From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22BC3458F4; Tue, 3 Sep 2024 12:32:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E73ED4042C; Tue, 3 Sep 2024 12:32:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 08095402D0 for ; Tue, 3 Sep 2024 12:32:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725359542; x=1756895542; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ypg+38eSz6KldVGeJzWc28EnpS+Wnxd8a3iL9CcfWC8=; b=n6x8nE2DRlSGBrkjFes7F2+hgxPqm0w0PBD1WzS8A6R15Ia1UyR52fbO NIA8Vu4GFTREbR+6yuKBha3fZ/j4piRgqwVYDtOh8L4xbO5MEY45QkrRG W6lIOHe61hdvXQWvtjKgE8auqRovG8gfSt/nOKrT8qXtDXXe7HysM8okq 3a+ReCgX2PqRSDbW9Ipfkko+0fvxCEskLb4iFrcKUnPFSDtAje4CbFL69 VWSzr5VteLspi/nLq88hOVDDqSvEflF0AWKWyQB5oqMiYLkFR15GBeReX CcXGvHR2WPQQJc2E89H/oxu/J+z7u49rG4V95C38q23oDwU6PwQ1Pw4MX w==; X-CSE-ConnectionGUID: x0prBmwfRJKvlOoHbXym0g== X-CSE-MsgGUID: hqpdR9icSY2sG6s/bDPPRQ== X-IronPort-AV: E=McAfee;i="6700,10204,11183"; a="34604902" X-IronPort-AV: E=Sophos;i="6.10,198,1719903600"; d="scan'208";a="34604902" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2024 03:32:21 -0700 X-CSE-ConnectionGUID: WEa3S2f8RDK6v2VejCndCQ== X-CSE-MsgGUID: QbeVLKMSStGDbG2A/zu4MA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,198,1719903600"; d="scan'208";a="65368734" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Sep 2024 03:32:21 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 3 Sep 2024 03:32:20 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 3 Sep 2024 03:32:19 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 3 Sep 2024 03:32:19 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 3 Sep 2024 03:32:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TNVL7i8UUV+d2NJ3EiVSRrVqEJAUWmwuRWk+FZpvozUr64jy/Wgfkd1cVopaVjD7E8XVfp4Rp7yYx5HGjdVUery0Pz0dfTT5oMgXRSpkjiwVXOM8H7IWqbuylHd3AzX/eIFO6JWldZF+yhLjrg8NLoHGdJJLSeS170LScgOpWZt7cNZvHKvjmci8GBE9wbhlAEdi8BCfagSzJ0+zeABtKl9yGOyF2BM8hJOfedZ7Za8kBW9BkF1uu+EvKxtAdS2oJB87r5bN1A22iheKMEKvDnuKc8BMmRibdaGS2QLGpiw1gi+XRzEyoPspRFCMrgMefi2M92A7Cv+28oc4MLeVCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z92QYCDkZVwOn8n57wKRlNC0vA2D2B7AngcF1JbtQ1E=; b=jy8VZiyN9FirE2MSLDDgdP01Cx49c3A/CZ9G/bgibhDwas7z9CLFJotgA2BYNWWbj1iaSj0rLyI99e7vkVl7YxIirbWhavPG8+04j6mGLPlJCDp/anlxegEw1INpXKFPCnI4bAvADwlF016J1mBTe57azWI/Z+2J/3l4J2C/OydOPSfpJYiOMYud1PRKgz3zzy24nJxuVVIV6wF7xt/ZRv6or4vwXGUa1EPhB3szHtMl6Pkp0luK93+b8MUsALY7+Zb4fdy8A7mNMYIaowv2Oe/bvjnju3L2llE6Ojnw789t57t6WMU023lgJ3TnkyXRuBfnUnUgtX2T/99bVwPQyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.27; Tue, 3 Sep 2024 10:32:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7918.024; Tue, 3 Sep 2024 10:32:17 +0000 Date: Tue, 3 Sep 2024 11:32:12 +0100 From: Bruce Richardson To: Anatoly Burakov CC: Subject: Re: [PATCH v1 02/15] net/ixgbe/base: add missing ACI definitions Message-ID: References: <15a202bbc980f323ee6c8b83482ad3ad7393a95c.1724921977.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <15a202bbc980f323ee6c8b83482ad3ad7393a95c.1724921977.git.anatoly.burakov@intel.com> X-ClientProxiedBy: DU2P251CA0018.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5013:EE_ X-MS-Office365-Filtering-Correlation-Id: 693ead7d-787c-441e-a1a9-08dccc03aed1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7zUVDKzTFynaaY0tk9yGi4EqFJlHYVekQBsWZQ98bXb78j8iPTMW2ED5H7/A?= =?us-ascii?Q?AEp6P/KoqVMX6em7KKws613fTiILsgWSEU93p0At7538wsvUrOw5EDcKYpCF?= =?us-ascii?Q?PYgj34J6Oq9leODxO8HJYUcBVFvnmrv0T4J3YCukLS+ovVzLJ5aoSM78tKSY?= =?us-ascii?Q?yh6JdUAbWWtE7gjHQZ5KH5HOoQcf49r+Z8tY46LYv4/gBfgB4ev3XI/Ggi7U?= =?us-ascii?Q?Jzg9dvftXc6OYrh4Hog8o5siZafNtEZchcgqT5OSamsNfH1blVoldDG1Fc9X?= =?us-ascii?Q?ZwalbEp1BSoiggKyF2y1SG0gKYAaY6mLAskeF2ffJLdbVQo85+TyZaauDkRB?= =?us-ascii?Q?a1r2XqZf+HCx1j/5/HEoaaVtAM9kvhR7qm2KuJrhT8CZ5vIMWy8Oko34I8bm?= =?us-ascii?Q?sfMte5Fp6coSYwpEW4DISLPnNANVhmgv87+o4OkicPqQD3wV0YiLdhCv6Mk4?= =?us-ascii?Q?umF7Ruqyt6Ax4/SaXYR9/RjPQ0mUZPzeSUcwG+ixlqat1rCdTPKusUo71sqM?= =?us-ascii?Q?gIknywd8OuZoe2B0greq8eprTibPhOy1oN/5PJPxLZlDiXHO4Yejziic2m+/?= =?us-ascii?Q?4or0IenR0kDdZEyiOmALa9FssA69kVTtMeEgDSw4JoZZXW6sBuDtGrkWcQH8?= =?us-ascii?Q?SffLmp881WGs2lw5Qrs1+ZDtwcwEBeawsDzD1GZu11IAaOcIgCmfqCczEtkb?= =?us-ascii?Q?4lnz4ahPiZHgaztvEqqnrAWLrd4vYVtsbWBqdic+dNqGT/C3ZLdhUgUYS2nZ?= =?us-ascii?Q?K1MukqQc8aHyld+LgMx+hS7IpqjX92EJJ8hcPN4G9yOJq9wFvBnCgk10MjSc?= =?us-ascii?Q?92Cyir2ozJl0re4QB5eYxnv9UybF2lvPbMtjxJr6+pHTqAGxrJlxCNAm22ad?= =?us-ascii?Q?bgMvgj76bV+5+H+FBzAUVw/CVo8rDIaX1cZdcBmHJCXzff//LhfFEdeKihte?= =?us-ascii?Q?Pnp7DzvVh3IQA15udKAB7ZzKh4a8M71kk+QGcpr1BN1/qt9sIOW4tVHsfXj9?= =?us-ascii?Q?aO78iIBY2y+ddGMr/KDSjSgXYHBwagxRKOgxwA94JAMCGsWjQ8GJI2D0x9b3?= =?us-ascii?Q?8vGhJtg3N7apdYz9/lTtK5hnf6VdnnBjNLGPwWh5Zs9VixrlaKTZwjGEOeYx?= =?us-ascii?Q?nFJfTWVwe5l82wKxCy04atG0WjkDvQmFwqaRGYFJlPfn+4AmgGG2OnQj01E8?= =?us-ascii?Q?gF6/FUzo+bwOiZ6N6xTBLwSQcDJBZ/+yohgGNVoaFsKGSFRxhTo3NkJ9DMHk?= =?us-ascii?Q?SKQgC6Ty8jy3NVhDCTFsEs4SZMPdVyXJ+cauCS1z/aMPKI6QS986qkJoH1lU?= =?us-ascii?Q?AP8ucFKfXXzODW5GenPdsfcGKFtNxuE8iNSGk3yzKZDI3A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A6l6kylXm9xfR37VwGLuDUDflT2AdNR4gFeaAdfE5yfsB/0a7IsCm5hnhPIz?= =?us-ascii?Q?bGoPP+Rmng4aJm7qx2sfDib0+vr/akj7A77M/AZQ63VOUxpWBbDvlPNCzk76?= =?us-ascii?Q?sd7mAx++7j9waNlc4veqrhkQWSprjkRizDxiTdUqpOGWmjXuSf42A0fX9/tu?= =?us-ascii?Q?k9S0fssphOdj1rVn2EtOPHd6hfPuwb515pDt9JAUnYcz3T2Tmg6+XZYrjeCT?= =?us-ascii?Q?Q7ZRWG9pSVezfCpB+00ah/0QF9fRecfuIDAlLpZFj/nkwZtq4cspBMfTRWn8?= =?us-ascii?Q?Y6yICRDBh8NLD8aH4MwAwrs0p5ZJSuITdBDfYaaFtJEFmP7JQA6XDQD+2hO7?= =?us-ascii?Q?iS1IwfbgXbz9ywepv4exv5UDXFjye0H2YQKoSA8rZLBrk/l4h00GdiE3T93O?= =?us-ascii?Q?s5Eoq2PTxycscvh3epBCprrGJmjzIL8fVK1NpxB9Se0VaPZ1f7VRvc5XbIpN?= =?us-ascii?Q?FF2t0E01RDHdynhOXWbxrainOWzPbOIizzyfg87H+41jPA7DWKwfDxGhP+n3?= =?us-ascii?Q?2qiueYNWzZkZ7G8geD1amHUzxgJLFxLRuW60K/f4TUCHgZ7yQGRUUdMJEv86?= =?us-ascii?Q?oXvoczarv3fL4DfA5keCFKVRvvNMnd1Py0u024fHAcRJ8t4UyF63tMJZPxzb?= =?us-ascii?Q?AOac4OifeDu+7MoRVkRgd1EqHxgostI+ZAI5wlAgTzJ5L3DG/ZqfgysZqiZK?= =?us-ascii?Q?mCVvF2TPDBbVFUllLAKYkLB+zUFoCeag+NeYgOZMiULHYH94uX1M0kTtkFSJ?= =?us-ascii?Q?4AiNrHVvNZ/DMuesOwoTDEWksBNKeCoe1tgtryAyE5av5MP19YPXgaYyYUDc?= =?us-ascii?Q?h2Z6uVZSryns4YjSWVJ2xEAjM0F01eI2gi0VJFAkJIVtdx61RZghemD6S780?= =?us-ascii?Q?Yd1QTF+UJH799wRJV6U2xsBQIyoQCMyYjWgJPIZvELIR37bi+fNtoTuN56v3?= =?us-ascii?Q?DYfIngpjxXJmuPga+OzoEhT0Mon1TTjHsmZnTNgf7Wye7qDQhYruKbtvDQzM?= =?us-ascii?Q?bpIAM0F5UorQvzUTc980mR3SMwAGumKrTYyUtleUneN807pB7BO+GRO3KIb8?= =?us-ascii?Q?uNEw4ElbwAim/lqdBuvu5hm1VZwTYINjkICH3WdJQjWbmkDna3YrJm7kKY5n?= =?us-ascii?Q?r4TQtnfO0TmS6bfgkvPufOBSAdfp1D2RxPgFLZBUDHcKZx1P6dwwiRDBLfzC?= =?us-ascii?Q?+qT7at4ylviJOkDBkmDgzsbScfFd67zu7rNQis5hX5w/iV7rDeOEBJ9NnJ4R?= =?us-ascii?Q?6WUKKl/ZmwcOhIw+YYyn95/ht4WM/KcJsm7ojBek1pnGSyCvr+v26WftsX6B?= =?us-ascii?Q?bZcXLEMy0M7xpeFIj4HMm0syi749Y9KjFuVy2DQHoBEsI/nK47JyIiNSjyHL?= =?us-ascii?Q?XUi3MtYsjA1+2UI+AN0jbHhjGilNJx3TNV9SPD/XjEN8SzXUwur8sGvz1uMW?= =?us-ascii?Q?IfLirYxhrAWi7eKvxH6bP+YVcM6wIQpuZ12NV+oLQClLxy9AOpP/XHyUSV+N?= =?us-ascii?Q?H2Q7zfaCWMQktqb3z/w5T3fT4mtPNaSwl0nHtb7fMYDtBPsOwxPjVZgBwgSu?= =?us-ascii?Q?7ykqDN+dbH2ZYZ74Ejr6MjQv+UT2qv2eR1ZSmn6RhCFWgecfoSIKA5I0lMxt?= =?us-ascii?Q?9A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 693ead7d-787c-441e-a1a9-08dccc03aed1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2024 10:32:17.0994 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YfYNQFSbxhn5sRZjHfVBwV075jPO9Q2Gb2n2uxHl20venXxjvdxQm7Y2DS8KzNA2FqBT1TtgGCkuwqKYPq9leNwD32mqKpRAtuwIQWosXI4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5013 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 29, 2024 at 10:00:07AM +0100, Anatoly Burakov wrote: > When adding Admin Command Interface and E610 device support, some ACI > capabilities definition code was missed due to the way shared driver code > snapshot was generated. Add missing code paths. > > Fixes: 25b48e569f2f ("net/ixgbe/base: add E610 Admin Command Interface") > Fixes: 7c3bfffda43d ("net/ixgbe/base: detect E610 device capabilities") > > Signed-off-by: Anatoly Burakov > --- > drivers/net/ixgbe/base/ixgbe_e610.c | 49 ++++++++++++++++++++++++ > drivers/net/ixgbe/base/ixgbe_type_e610.h | 4 ++ > 2 files changed, 53 insertions(+) > Patch-by-patch builds are failing here. I believe patch 3 is needed before patch 2 in the series. Assuming no other issues, I'll just reorder these on apply to fix. /Bruce