From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7047F459E0; Fri, 20 Sep 2024 11:04:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13C48432C6; Fri, 20 Sep 2024 11:04:20 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id E57B840275 for ; Fri, 20 Sep 2024 11:04:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726823058; x=1758359058; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=vrS6/Rje621a8iLhisy4YWHjlDYZlwmf9LAKogPGxWg=; b=alkNMqYZ+quy951JspgOxpPkELCw3kMJu5V5lR46DqLVhpC4jUZyk6fC 4l8W/rr58HWQ5g52mIycfiLfKtlGTJ+a566BxypOQFQHAXIYeN8En1VWg SlmYP8U3Q9maZQExRNu0eCkU1nLKV1N1kit/YK5TwHjB/Bli0jQ1EhzN2 mp/ETXtr6ElzdOsOIYuYXLKsfv+r1Y9CL0kkdYA2WOTyKgf7eMwhsPcHD c7kQlreZI4n/ZNyGLjJw0Y4fD5vdLkwrV0A5i3u+u5pbwn2iveAyXP+NI Q5KA+uaX0cDkpVUvgnPHSOT2k/ckIKMh/chvpAJ91rMvjNIMsArPEEBG5 Q==; X-CSE-ConnectionGUID: 5KPux3ABTVGWHfvOA+FPIw== X-CSE-MsgGUID: j5qRI9LuSmmRbNpDz76new== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="43341412" X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="43341412" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2024 02:04:17 -0700 X-CSE-ConnectionGUID: 6+/A0LVNT+ypSvxh5y9AzQ== X-CSE-MsgGUID: pWrnODqZTYiQf46juKvzwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="75191196" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Sep 2024 02:04:16 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 20 Sep 2024 02:04:15 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 20 Sep 2024 02:04:15 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 20 Sep 2024 02:04:15 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 20 Sep 2024 02:04:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xXNwjXKkQrTO+bsoxiUeuWgd9KG/Sp1/bgmA/mvqUrhcQjpV9biSC2zVbkKvc1HPMuuriuRSr3yc74nHWLRjPFur+6bLKYCxIFeim//3HJ4dhdO4aR+CgAf/w6JAIAP+TXyA6H8cD+ezB9jrsQ/L8Cq/KL4a7v12cJevIOLc9D5DbCfU9m93NdO64bCsNvv1kZM1eOSpf8neTQoyfNdfo4nHGZq/KeE7vmZa5DowtFvaUjr/exk2u3Poy/VnZdmQDJ3AWkFqQhTBagsavIlvtXHHYDzBcqkIamHKVOLdCjwuzf8J4COHII/52Rp3M0Ie7hktSAKTK2dOfn+IQ+uqlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2OvmROWYgop2SW8XKpxsjM/7ou5M9CvuA5VbxgDtNQc=; b=USj2NSKcr4wL8IAdj5XpYjXhVambm9OHM0Ks9o4S6dzq4DCYaHvIsyMIYxCjDw35jBfP8dpThCzlD4KIDgc/Sfl01/acktPqwaG97Iz0MbxaWS9o/oDvArWnpl74PPgTnInbUuFbPjrkvIKPHXpCqPIHZn7+17cjYCmkVhoEY137OSAkNdTg06QVZ9DkTvHBrDc9I9ycHszntwJ1TtYSPbxqCAMOSLMteNQJpOMuV+a04uKkXbJ6M3HrTPPMVFfQEaGv1p7UG02eCHhWx9TRqPVWmtHFYbjZSeUewAP14VpuwrxLa7Sf6cw4Q31k21RoQ+rAotsgNjRTwdrHToOldA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB7156.namprd11.prod.outlook.com (2603:10b6:a03:48d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.21; Fri, 20 Sep 2024 09:04:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7982.012; Fri, 20 Sep 2024 09:04:05 +0000 Date: Fri, 20 Sep 2024 10:04:01 +0100 From: Bruce Richardson To: "Zeng, ZhichaoX" CC: "dev@dpdk.org" Subject: Re: [PATCH v5] net/ice: support customized search path for DDP package Message-ID: References: <20240913061537.2077253-1-zhichaox.zeng@intel.com> <20240919032934.800979-1-zhichaox.zeng@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZPR01CA0302.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB7156:EE_ X-MS-Office365-Filtering-Correlation-Id: ed34402b-7ade-4141-f1a6-08dcd9532dc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7b73vU8ACanQ/UBnjuwnP+S2qvHh7+TN73YvdW9IbbWCulDU0d6S5gwhVRBc?= =?us-ascii?Q?rjtEatwaJsjd6m47zoEuDLN97V5HYiXGstEAMSHy+/B8/1hz+eLr2nz2s/dS?= =?us-ascii?Q?YNOyQadgFgsRdOilfkvdOvPlC7GcAQ1XWrR30dci5sYsi+v96R556E8ZhX2b?= =?us-ascii?Q?dtGSnYq4TeBpN5X1pkeXd47Xi4rNaQW/VCrTVfFim9wO3SMkJZnznvPHMgkg?= =?us-ascii?Q?QXtdtsW22bYydSoVR3nApbj/g56MoLRRSiNq1obKCl3Maq6c11jXVf7LDBPX?= =?us-ascii?Q?r7GMw66QQSJLHKXSmZ2GiibB7YywBs73Nl9ziGkopXQaonjf2QHu2c0zdbot?= =?us-ascii?Q?KMeO4B5mECLaUTdsyIiohqGYZSANoeGcHJVnQKKYD/EcR7gh9S8aLsdkT4rW?= =?us-ascii?Q?72CVQelVgE49TeDGmAUu2Gd5QPkdecXvxNebubpExNydmUB4dCMJ46TADQmS?= =?us-ascii?Q?iekxQo2Hgy65UlHHXpkUP6ror9DjIit9KGGcGIVbLt1wwekT7NLBemT/tKZl?= =?us-ascii?Q?ngGDRIUX+IHFAzFMhJzhj2fCgmEJs3nSnQfdWhTjx2qn+OYOz31YVEZJtkiT?= =?us-ascii?Q?J/PhACoJcJ2ncZ3lXD6qJ7fe9PlVjf/igbBc2aemTWxXmt/E/kL1SiM+UpGe?= =?us-ascii?Q?dTBIt32yGDO0fzE4YxCpAo3I1TZU0BxnUFPNDIMADbDWkwOF2/815D2kaofM?= =?us-ascii?Q?M1/kDSn47RC6hxHO2N99Kv96cqZj6rKu3xF24eZPig4CZ9PW0YmmysTEA06j?= =?us-ascii?Q?yVp/ZVsFhprpjNHDp8yPB9nEC4X4i4CQo80/0nBJxvE6AqxAdgU18QAKK6RG?= =?us-ascii?Q?rnZa//8XwDKX/pOwjuMcA0e+FKkvLk8+9IuS0KG0KDonvBym+RJht+Da+KJE?= =?us-ascii?Q?IhTYaON7Mqia7tHAzfsHh0wSF5jopl70F5UQcz55z+vuZRKjC9pDw/gBrqiE?= =?us-ascii?Q?2E7R67N0HHV/C+yIn8TB41+HyMhRtPBji941FQlupW94wsoT/y/dVADTHwwE?= =?us-ascii?Q?RFqX/ydeLQL9rP03E8126WhDZs8wEK2g4GtMmCcyemM/JK3ogtJI2KQZz2re?= =?us-ascii?Q?W4/Z1OwKchB34pj6N6ru7/siew942PPf4ldjP7QHCi++YLGfQE7m65+wVaob?= =?us-ascii?Q?Z2tycBuw6bxPHf5GYgSf/D9LOKWvbDm377s8BGE24dif4vbrICRXS1sGEHlS?= =?us-ascii?Q?JNQgLd5DDRiqvhY2/ewdi4nh8KUO7+18l1Gb86VAI2bpBpKohUwoUQ3JsxW4?= =?us-ascii?Q?ojyQuHrCEr0280ty9OqbGdc33bVRRvRTaFbfpLYwvO0LM0++cu1jro/0GJ7O?= =?us-ascii?Q?T6Afv+VouD4h1DcMj7o337XWeC1b/rDJSjPzA7d46C0iVQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+1rFhegnRUx2iFmb4yqpSfSTx16uZ9siS3MG1atma1ouuR1z9vVy4vMP71ht?= =?us-ascii?Q?fZJNNl15trNnaz6rDgC0PiUG80Py7A5cJirkZfUnXlgwD949sAgyt0vK7I8u?= =?us-ascii?Q?YeU1Iay8k+oAt5lhwS7BkhlQzorhFA3YQrwrrK81tP6IMFCHXRgOqmKZOJRl?= =?us-ascii?Q?cLEb1YsPNOslke8uOGo6uTMc3UwMxmUnRzoNXZINKxnBcX5+ok3JEsNJb4TV?= =?us-ascii?Q?4mmdwyoz4HhPabn3j/Hmy6mj0Bswtx4IuYGntBAOF1nxPROLzeZPGSIxIwRc?= =?us-ascii?Q?kjueGnVr6jGOp+0M5tskfm4wK8JjtZLKe5KK0bZjPOGQfCnOtKwpzbIryiKy?= =?us-ascii?Q?Ocmb5XZCjKUHyONSxNyCuNb0Ri/dkS7Mgu5elvRMpsK46+pDFaE/VECxPCxa?= =?us-ascii?Q?FpnTRc7yGvHOxpaylDTZTmqBQvlRYJUByFSdagKJ8K1NZXBYkLGuKFWdWH1Z?= =?us-ascii?Q?L6G0FdUw4GbFZlXzJB9PAa8EL+yFMvrv5l01VVQHinIK1RkrWnlPC/DxmVzj?= =?us-ascii?Q?eSfloRSjhvNkK0Yi3pHurPUvrRmACxwobykcMz7MEIR1YuEZv5p/R0+llplR?= =?us-ascii?Q?yPBi8sEtKU6NZ2H9mOxwfbCIvRlJcnJEDzeTBuZtsracSI0CEywiEPW4c3bZ?= =?us-ascii?Q?ffCxgJ51EeD4GNd1qoaw9pDTiJ0k6VOz6f4YvOHatdC7hcUQ/1wn31ifiwrv?= =?us-ascii?Q?WSoCz4FnQrJHdbSxoPpU2wDw8T2e7fFPN6vFxesR/agVlH22iPdyMYiP/hft?= =?us-ascii?Q?cbXsqa6JAhpJjBeIzPNy041jRQhaYCeVAYzv+K2tisrkzta/kMuByYA5WhgO?= =?us-ascii?Q?WwMe9l35NeZ74dg4M1Y8IKJQTNVtGJ5qJFcHM1acbTNBAOCS9vxDyqYsFtYt?= =?us-ascii?Q?eYDJINzqwJSzQgbPMgDUadb7SLen063RqROXnPz4BMVhq7s/nkpl6c4wZ2rE?= =?us-ascii?Q?rXISfFdK2y//4cmyqnIpbT57eYkNWOJROkWKNgNJZEPuTpzmPNBXp71mVrdK?= =?us-ascii?Q?fdv6FkZP6WbTF4BxWoJAaIhbXzD+ucZUj7M/xtkX20h9gwqRZVYHZ31cbz1D?= =?us-ascii?Q?1nm+gVbErfXoh5dM5ja7SOj2ice2XlB3CyXoONiNwF8tQUPuAkG13RA/Mevx?= =?us-ascii?Q?Jafi+pk6O6uFxDlcUhiuidsQ0oFxmd6B/uK/JEH9a6HsO5rt0jSvHl0fLWlh?= =?us-ascii?Q?j9YuXzxufB6XVa6amgX8alP1QOBtHLz1FK9dNd2cs0DVdPlMJenyCZ5f8s9Y?= =?us-ascii?Q?beGo4gMGfjXHC3ydxLEWCswDMd5GB2ekY1R6patG6pZwFhaP5Xut//SLp6Ng?= =?us-ascii?Q?qgejVO0LBwYYSXxUnH1JG4yqcoDUo7UN+k19iPaQ5pB3+3Oeg+bPqe+po6Pv?= =?us-ascii?Q?boo9G0ECU3z636GaNDTJe2FjU+2VjnS4zc6QXCqD3NftnyPqTGG1AUUhY5hA?= =?us-ascii?Q?vaE689b3/hRaOC3cO4AdZkDWsuwl0m4hbYi2/gwNmBrNcYk2GO9+OEgHFBlR?= =?us-ascii?Q?4rrXra98xfBabS+hVz2FV4v5Y1EMiD8GwoDr0X5tfqpVZtpNAezbEE4GIPIy?= =?us-ascii?Q?Lh1VhWXqz+fVCCXAMMf17MBM9a7WRAeiSDwwptKqa4tcX4aLHK2lOqYrUB4s?= =?us-ascii?Q?gQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ed34402b-7ade-4141-f1a6-08dcd9532dc0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2024 09:04:05.5170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xkKh/cElXaJ1tpL1B6nVG1xcili7DufBIYD77246CFlB01JqYq/Fh0Vo9v4WqLlPS9suhekxCKCMBcZzJ24rsVqVUshS5xLCKaSlVDecPJU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB7156 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 20, 2024 at 09:34:55AM +0100, Zeng, ZhichaoX wrote: > Hi Bruce, thanks for your reply. > > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Thursday, September 19, 2024 3:50 PM > > To: Zeng, ZhichaoX > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v5] net/ice: support customized search path for DDP > > package > > > > On Thu, Sep 19, 2024 at 11:29:34AM +0800, Zhichao Zeng wrote: > > > This patch adds support for customizing firmware search path for DDP > > > package like the kernel behavior, it will read the search path from > > > "/sys/module/firmware_class/parameters/path", and try to load DDP > > > package. > > > > > > Also, updates documentation for loading the DDP package in ice.rst. > > > > > > Signed-off-by: Zhichao Zeng > > > > > > --- > > > v5: update documentation, fix code logic > > > v4: fix CI error > > > v3: update doc, fix code error > > > v2: separate the patch and rewrite the log > > > --- > > > > diff --git a/drivers/net/ice/ice_ethdev.c > > > b/drivers/net/ice/ice_ethdev.c index 304f959b7e..f0389cc4ee 100644 > > > --- a/drivers/net/ice/ice_ethdev.c > > > +++ b/drivers/net/ice/ice_ethdev.c > > > @@ -1873,21 +1873,61 @@ ice_load_pkg_type(struct ice_hw *hw) > > > return package_type; > > > } > > > > > > +static int ice_read_customized_path(char *pkg_file, uint16_t > > > +buff_len) { > > > + FILE *fp = fopen(ICE_PKG_FILE_CUSTOMIZED_PATH, "r"); > > > + int ret = 0; > > > + > > > + if (fp == NULL) { > > > + PMD_INIT_LOG(INFO, "Failed to read CUSTOMIZED_PATH"); > > > + return -EIO; > > > + } > > > + > > > + if (fgets(pkg_file, buff_len, fp) == NULL) { > > > + ret = -EIO; > > > + goto exit; > > > + } > > > + > > > + if (strlen(pkg_file) <= 1) > > > + goto exit; > > > + > > > + pkg_file[strlen(pkg_file) - 1] = '\0'; > > > > This line is unnecessary and, if it were necessary, also incorrect: > > * fgets already guarantees to null-terminate > > * if it didn't null terminate, then strlen wouldn't even work so this > > statement would be completely broken. > > > > Also, as this line is unnecessary, the lines above it, and the label below are > > unnecessary too. > > The string read by fgets ends with "\n", my intention was to remove the newline. > Ah, apologies, my bad. That makes sense now. However, I think it would be clearer for future readers if this was more explicitly called out. At minimum use a comment, but even better is an explicit check for a '\n' before you strip it. > > > +exit: > > > + fclose(fp); > > > + return ret; > > > +} > > > + > > > int ice_load_pkg(struct ice_adapter *adapter, bool use_dsn, uint64_t > > > dsn) { > > > struct ice_hw *hw = &adapter->hw; > > > char pkg_file[ICE_MAX_PKG_FILENAME_SIZE]; > > > + char customized_path[ICE_MAX_PKG_FILENAME_SIZE]; > > > char opt_ddp_filename[ICE_MAX_PKG_FILENAME_SIZE]; > > > void *buf; > > > size_t bufsz; > > > int err; > > > > > > - if (!use_dsn) > > > - goto no_dsn; > > > + ice_read_customized_path(customized_path, > > > +ICE_MAX_PKG_FILENAME_SIZE); > > > > > > memset(opt_ddp_filename, 0, ICE_MAX_PKG_FILENAME_SIZE); > > > snprintf(opt_ddp_filename, ICE_MAX_PKG_FILENAME_SIZE, > > > "ice-%016" PRIx64 ".pkg", dsn); > > > + > > > + if (strlen(customized_path) > 1) { > > > > Is this really the best way to check for validity of the search path? > > I would tend to ignore length and use the return value from the function > > "ice_read_customized_path". Again, maybe check the logic used in the kernel > > for validating the path read. > > Will use the return value instead of string length and check the logic in kernel. > > > > > > + if (use_dsn) { > > > + snprintf(pkg_file, RTE_DIM(pkg_file), > > > + "%s/%s", customized_path, > > opt_ddp_filename); > > > + if (rte_firmware_read(pkg_file, &buf, &bufsz) == 0) > > > + goto load_fw; > > > + } > > > + snprintf(pkg_file, RTE_DIM(pkg_file), "%s/%s", > > customized_path, "ice.pkg"); > > > + if (rte_firmware_read(pkg_file, &buf, &bufsz) == 0) > > > + goto load_fw; > > > + } > > > + > > > + if (!use_dsn) > > > + goto no_dsn; > > > + > > > > This is changing the search path logic compared to v4. Does it match what the > > kernel does in finding a package? > > > > The kernel searches for DDP packages in the CUSTOMIZED_PATH first, then the default path. > Thanks for confirming.