From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 811F2459BF; Tue, 17 Sep 2024 16:31:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47472402D8; Tue, 17 Sep 2024 16:31:42 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 93E1740261; Tue, 17 Sep 2024 16:31:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726583501; x=1758119501; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=FdLE+zzPxtex62gwJoebM8BIw7YNHKVCAuzVHR2CqZ4=; b=m4W+brrrqHIsFxg2oYMKd1k5gcZ46flPjYLtPfUfU0MMq9T/5/12oQL3 UOXfYh4wnTPbl/7ZMWgDi52R+Y0BZRYBxldZSHXDeEk1nWZZTmKU/ExwH NrwnqlPdQzFEcLLaFQMYZ+zJQbghydrNPIQ2pBBw//3A0nuz1XFIP4G2k UeaOHvYp7Rfb8xP3JrXLAniBKScbvsbwZoPXg1BmhaCz2qKvcRuAsSWEo X5EumCTgmmvKT68H5dQcCQZYe8b3KyysJJUcR6eMN+YKBMZYVev0KLJoT sgpA0P14Jk6ZuQ4aDfDNYK4asJYFHiZqB2BScfyVUBuF75GNs/AIKU6Mi g==; X-CSE-ConnectionGUID: Hqwh2AawTqqW+Z574I+96A== X-CSE-MsgGUID: dtDc6aGdSjCL8EN6y3SArg== X-IronPort-AV: E=McAfee;i="6700,10204,11198"; a="36023785" X-IronPort-AV: E=Sophos;i="6.10,235,1719903600"; d="scan'208";a="36023785" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2024 07:31:37 -0700 X-CSE-ConnectionGUID: PTTCl7kjTZezVKTxp3mQ/w== X-CSE-MsgGUID: rYONsRSBQo2/Y7eV8NVUCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,235,1719903600"; d="scan'208";a="69173653" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Sep 2024 07:31:36 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 17 Sep 2024 07:31:36 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 17 Sep 2024 07:31:36 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 17 Sep 2024 07:31:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YwVEqhemFIqEHYGbDK5oeaE5apWa00Xs7A8rdxt5kONlQTyR5J8DL6BmKsK0tEm72KulPI+Rztfif/mOJL6eLOglpZcBRjIOnbd0DLAeuwps6QRAbZWBaBJiQuoL5mbXre1YQJJBw0ZqkYNKwK+TGtHiqM2V5uWXNCOfxiDBvl0dvOZW7IHuiNf4JdvC6OR3u3bh+AzcRfePCD+UetaCybOZd4fG0f8jfpnVCrr+V+FHmjWrGXdPSgeyldQgkJoOGvw8Uqyw1/9GULN6Px+61zhx0z4sGeNvsVvv/rdJNVPEA5MYFeDh/dscVyw6gcVLl6TLSJ8/OBLDeL/2G6ELAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TBBSaDPLNT5+PBEoo5LVg+lzxnhJ8ICJnAExnT+LH7A=; b=qmTBUDUHftcgA7L69FqXpIAk9dnW+dple88Ai9WphzxiGAHjpgOLhD2rrSmcdE7EeeinfaBsK9fOSWOeUvUsRK+10iZYWLLS5fC+UyMhrVUa7HQg8snT9Boh6Py892soaqyT45baV/++LJE9I6LKSeh+Ya7nNe1Vsuu1EgkL2nxusueyjf5Px36DN3fJWRPlfscoUuYC95EY7SDSX1ZedTmtiXevdku6dGq0DPpnhcNhA3dec4uzFp98iH5Bye85bZiMzpwrG1zD0KiG0WBPk0fVVFwF0ExbWfOg11LTJF53DsDSVOWe94phyUjvDVn8+qwAVpXbwdqLjNVnFaFZoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB6569.namprd11.prod.outlook.com (2603:10b6:303:1e1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.17; Tue, 17 Sep 2024 14:31:33 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7982.012; Tue, 17 Sep 2024 14:31:33 +0000 Date: Tue, 17 Sep 2024 15:31:27 +0100 From: Bruce Richardson To: CC: , , Subject: Re: [PATCH] net/iavf: delay VF reset command Message-ID: References: <20240909110356.23757-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240909110356.23757-1-bruce.richardson@intel.com> X-ClientProxiedBy: DBBPR09CA0037.eurprd09.prod.outlook.com (2603:10a6:10:d4::25) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB6569:EE_ X-MS-Office365-Filtering-Correlation-Id: 72b18f0c-17b7-473b-21f2-08dcd7256d5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QwKdB5Ak4YPca+mD4+akOXsTFypGTk4AmKSw0CRLJxxjlRykqyImQWWxj22z?= =?us-ascii?Q?8wOo06jSYgUUcbQIYYFllX0UMWmy2PN5dBMIRWeL+vfJM10q7NiMpqOKL75e?= =?us-ascii?Q?5gc/mJU7Mp68SwaAyORAUh+VLLwQK1fpv9ZqBHOQlwWomU8t1FJaNpIFgGdm?= =?us-ascii?Q?D6RW+IbTmNCEg2HMBOQ+zvW00q9Imz865uKkadCSaSYFUV1h7Djegmj91YCl?= =?us-ascii?Q?oQbySAAx5d5DYhhGYZOgTyXDE/LhNVRJ3bgZBnQmcQDFFULtEGqIuAxH3KaD?= =?us-ascii?Q?NVI/DE/U05sd6gI8SmOZl8GBokpoTlehiZvJlnqbzajwRmkVVkopnFiQIjHP?= =?us-ascii?Q?F8rCK3M9sp0KgK/iOOVi14f80/tzXGaYq70ThTr7umqxf3aiuRVKN1xRQO3z?= =?us-ascii?Q?v19XcWTM4tuPbDnjEyOglw/9bUrJBAgG/B2RznvoYRbp3CIsDLiDt1VJ5qRR?= =?us-ascii?Q?HBNAcArrBTwJcOg7eDOheoF3YyjQ5mvIdgKn9QSPKdTpsJgWe6DnCISGAX0Q?= =?us-ascii?Q?7y3+o62WX+P+c9yxnXLLPpBLR30fozJRLyCL3kau5byS4a8+tX2z6LGiIKdu?= =?us-ascii?Q?+V4Rnh9g3n17G1jDSWlyZRRbPKrpWw/xepnxzB4BdA6bFC7H2IDrDkgw/BCK?= =?us-ascii?Q?nzGEbP9RP73jehOqd4UQpKXlyjq4BueuYD7sVOuUs7klVyeGhSji3rW76XGC?= =?us-ascii?Q?wtP2FBBc/mloDZO8fBCeCtOnLgmgY+SJeeivexqF38d9pqy73Im4318ZeD0w?= =?us-ascii?Q?CR26llwDoHrwWRFZb+bA2xnjskOcEa/9ucYu3Zs7pH3sjkHGBya+Hnol3QXQ?= =?us-ascii?Q?ubf0AowuIRjKnDPgmWQFTnJtVHAygOyWrQsN8gyOFoOY7Wt+YRYnZZ7kYvCl?= =?us-ascii?Q?DX6wKBeRFim9dvvey6Dci1H9xdx3u+nj2RIfpwRJ80ptzjXan4l/qZRlDjzs?= =?us-ascii?Q?35NzQqHPgOL+C6Ni9G7putHdk1hr9/X6dLAZikS9QKq/gndQU6z2AYKuC7BF?= =?us-ascii?Q?o67Nhe4b5+ayXZNQJYmjGAqk1MCTy+ipa9ToqF49QySu0u+XenoXcuwKPWSK?= =?us-ascii?Q?7HfR+zCKqgWWixcULfd3EMJEI589wX6Hw7NnF6Tg6KI5T9AmJ/ow3Bu38Tyh?= =?us-ascii?Q?o25jnNzAVS50arnOmalEbBgD1ReYmu50ex6PnpsKDo2Kg/XS2zB4p7U7nrx4?= =?us-ascii?Q?Wil0s8lIpkIaadjbGM12P0r/E5m2Prd59O6gCmhcBiQmqjyTp1P/bCbS46dP?= =?us-ascii?Q?dDXtl5pJi+wukZ97wIiU1M8wWifssuhs+6D0WypMlFIqsSyjqzpolVbVRYkN?= =?us-ascii?Q?ovoICPVh1zQkEkKqKXMSdYe6N5aUog5klA5af0i7zowWxQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nNYEF9Lmo4xiduLav2cx+dq6Hx7odgW+/r7OdRUVBXQSCWUWSUUJy4umpa8P?= =?us-ascii?Q?cY5NlCxhgiAzKZ12kuUnga30MPdUnQ9FU90a/KAwWWeVmvjtes3HAi+gsInB?= =?us-ascii?Q?lKASVJ5zuxoUo0C6PRJc/PwmrO1K22lCZqYxpam80AS1MYaRkiBle7TBGb1J?= =?us-ascii?Q?WLchLhJ9EVfoS63eiCIeFQGIkOVwowO9T+w87WDYyNYV3wQnVs4KnfzkwnWu?= =?us-ascii?Q?xCCNpFSAANcIvO1ERb+G3rgYCLUfDPsVBLMyMP2lgUEHCmPzJcjlA79NvzxN?= =?us-ascii?Q?qaRPylzdCUHIyKBnYWusFw7uGLaYYUMoihohihNIeBmotJcsRAQzpwn1xkZV?= =?us-ascii?Q?ZNN+4h7ylkPN39paXTA7hrl6HB69nc2zNXVm6ieJrp1pn6mhdBkRB3ORzxFK?= =?us-ascii?Q?/3Gz8cyu0hrY3TbstnDRpjBdnfwdSd48XBex8uOesDsSHyOQWruvmrVDNjQQ?= =?us-ascii?Q?5XZ5+/+hdKRpjkZ/ildsltAyXsXiqQ1GxpamA3p2vA0+GWVGS0vq4ia34Jti?= =?us-ascii?Q?8FswmoMfQIPQkkxXMjeCrtWUUPptjRd9T+U6DRxgHSdn7F3RANXTqHe8J1ZZ?= =?us-ascii?Q?QG+ZDuzRvHkXDBfmJYIPY5G5/jtt98n3TtQ+w5kMmm4ctYtUoyknniRcqz04?= =?us-ascii?Q?Lf4M2iGomR0Tetpy0ewte62yYloxxDFMs4g9XYZaIeNBXWiuGkGtzLM22Xt2?= =?us-ascii?Q?t57O5bQOK7oAkBvaVU7o9u1xig/13ovsrRLDCwnXmCtcSj9nnQevJqxzUIev?= =?us-ascii?Q?1PTiLaoHkNxIowinihrs/rPYegnMWdVTS3j3hqV6aq+AKOgzFrXugBZRBdAB?= =?us-ascii?Q?lt64ddMrg3QoByMOI3CYm17oIlntExS4se50Uh4PJeq7fW1TbbFRqbGE5e9u?= =?us-ascii?Q?dKA2q/kTGDmarDLx0i8E21d1fu85FT0tEKxnrmGWiEmRm83liASnxOneH1Cy?= =?us-ascii?Q?h0x6aL+A5oxkJn3cduf9lLvi+22MlNxic/H1gFu/Dcf9tss+f2hNQT7JPyNC?= =?us-ascii?Q?yWdCvksfHeLgyZmkGK87HtMzL6A2lra5/iEDbGhaofcOMOvCJFDrhf8IQN6c?= =?us-ascii?Q?hGhV7s+n1veGiMjO1ODXnBbwjGJo8A7dQ1SOI9JGbLeGH7VuPKlL9CETzRYb?= =?us-ascii?Q?CusX42J+jMXxKfKevzVp+TzKvmcVc4bUs0EENcJLFyth+TqI1olRj1+2er3y?= =?us-ascii?Q?Rq++k8PyTBl9KCFRtVOEtbAtAhUwMcr3phky5fu1wc1G7kw7WSO01+S8peaa?= =?us-ascii?Q?ARwIIwlgJv9kai59fsbN35H3ElwPWxTjv23OYw540pO43+7Fplfnfrq8NBZa?= =?us-ascii?Q?0zfPszn9MuaixBtA75A8izopxnzqyglzPtVUrlHIIWB2c1crmi9hmfSGgy/V?= =?us-ascii?Q?Hf3Yq/reCBBwgQ8fVNgI3o2qd6J4oGMZxq50K0Igb46gxJNHEAfUTCXw7MP9?= =?us-ascii?Q?C8eQA/sJsIRvV4cs74MXzzXMoO5RFI0y8cFoOC2kI8l1mYba+G7DXP623k6U?= =?us-ascii?Q?LPG/ON7F+ukkEvFj1/OE5mh0AULleKrnQBQ9ND3VtWT8I5ufi/53eV23a5Rq?= =?us-ascii?Q?RI3F64GkqteJpKjwiBaXCyl8JCfbcwPUICXEXv+UFueoClhK8OGtBeGcNQw6?= =?us-ascii?Q?Xg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 72b18f0c-17b7-473b-21f2-08dcd7256d5f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2024 14:31:32.9741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zp3MOi/nhlcyVNHBxc/Tyd5t9fJ+BQgUten5Cj1eplLwuYRRe2gbTIrCojgMvtOdKAo3X0I1YtjodhBolc7MfdVLofG3kYVWECY8mmGtFcM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6569 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 09, 2024 at 12:03:56PM +0100, Bruce Richardson wrote: > Commit 0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF"), > introduced a VF-reset adminq call into the reset sequence for iavf. > However, that call was very early in the sequence before other adminq > commands had been sent. > > To delay the VF reset, we can put the message sending in the "dev_close" > function, right before the adminq is shut down, and thereby guaranteeing > that we won't have any subsequent issues with adminq messages. > > In the process of making this change, we can also use the iavf_vf_reset > function from common/iavf, rather than hard-coding the message sending > lower-level calls in the net driver. > > Fixes: e74e1bb6280d ("net/iavf: enable port reset") > Fixes: 0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF") > Cc: kaiwenx.deng@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- Tested-by: Hongbo Li Applied to dpdk-next-net-intel.