From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00322459CC; Wed, 18 Sep 2024 14:47:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C367E40693; Wed, 18 Sep 2024 14:47:18 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id 4992740395 for ; Wed, 18 Sep 2024 14:47:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726663637; x=1758199637; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ZcRYAYaoFMsNQt7MMPROPJhWcaY/ZtltiPKN4hoSEKQ=; b=lZcflzgK0CsWpFuEbmcgtM3mxmyrJgFb0YtzHjYnBimuRAHpjoPn69WE WMZKruOREKqqOmiHMV4pjl0guIVmdqlF7+PuEEoO0j+0V6c19TOttPzNm 6cHTr597ofkePH5OJPe8g2QM/3LsWoqNXqgqiz/B1QH7Tph6UkZWjBUmX SlQamrnA2PK4+3q/4MgUXmXk4itKbfEH1nj72+Bcck5wiKNL2U30iNDQJ GMWM6SNZjnwY91nNgPtT5bHYQ1jQR0pscoc9JktqbUcSHhrCoSKxTOu58 FMkNbRayieIZaxTHEcGrSsrpvql2p6YkizH60BzN9bbM4l1Hac/sqqnDI w==; X-CSE-ConnectionGUID: m1UGRjgeRNi7FIfTfUstYQ== X-CSE-MsgGUID: vTc7gQKVQImp7dQKDWh9Ag== X-IronPort-AV: E=McAfee;i="6700,10204,11199"; a="25511142" X-IronPort-AV: E=Sophos;i="6.10,238,1719903600"; d="scan'208";a="25511142" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2024 05:47:15 -0700 X-CSE-ConnectionGUID: 0OGoKiNHQySzsonwxDW05A== X-CSE-MsgGUID: jf2Ju87CQHeLkxXz1wcUOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,238,1719903600"; d="scan'208";a="69785957" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Sep 2024 05:47:15 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 18 Sep 2024 05:47:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 18 Sep 2024 05:47:14 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 18 Sep 2024 05:47:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZH7fT45cyzBb5TKTuU/IKiteWZnZXiku1l1czz0QHWFUh8F7KvKQk60CzqA8yRn37bFV6Nr2OncHjYQjE8YEaK0TQRTU05si2v0dg0AbGWClNz1bu6kB39jtF8XW6XWAJLfLvohBDhdVNOtISaYqZMIqIHuQUbfnDd0PtAQ+f87Kj225+DRfHe0j+egdme9SNsWlwia/y6xUhH67XEXY7DxnhWBPvvax+yRxgUm7flbSN7+pdPUlQoPIwIoVvs+BGu87kdYRWHs7bncyZfJneD6qCsNxJ1jJmRAd5T/sM5imNT1ZL8Sy0Jm75mwLDo17/RuOx1KOE2AaYWkoXqOr4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mnzNsDWaFB8Ir9tY2x3QMjYI8brp8KOoKZsyg2iPzgI=; b=KnVBE30Nt8BPajsNzHHi1Hg0ikpn5yn+kZMIB+1QjCjdWbYiIilmZ+pWiDU27nejLtoVeCBmlQDiEcdcxWue/g/gYOTLozFzInPcsLnTbPcWyg423uiZvFizK04EGMUunBQN5+7n9IYvtT4Y5JuZW4dbJvbdCt9fhDUAleVq7y63IoT5J4KSPcfrs2ulvotcQm3QozR+bLxsOeUgxDANo15P+y7w6Sx5y2JWb+KDDlSHIgx+yBg8moSxQZ73c62i9kt8ueHNyq8+BhplfcF65owQIb49kZ6k8KRebuN/0Hhbc+JhMzSR+jQfR7uk8ApRX8m5tr3T5NTk57w/39dQcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA0PR11MB4701.namprd11.prod.outlook.com (2603:10b6:806:9a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.27; Wed, 18 Sep 2024 12:47:05 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7982.012; Wed, 18 Sep 2024 12:47:05 +0000 Date: Wed, 18 Sep 2024 13:46:59 +0100 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: David Marchand , Tyler Retzlaff , Mattias =?iso-8859-1?Q?R=F6nnblom?= , , Heng Wang , Stephen Hemminger , Morten =?iso-8859-1?Q?Br=F8rup?= , "Jack Bond-Preston" , Chengwen Feng Subject: Re: [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies Message-ID: References: <20240910062051.699096-2-mattias.ronnblom@ericsson.com> <20240910083139.699291-1-mattias.ronnblom@ericsson.com> <20240910083139.699291-2-mattias.ronnblom@ericsson.com> <8a06d4ce-0058-4a16-b89e-4a8b2bed77f3@lysator.liu.se> <6730daa9-bbd5-471a-8161-b7d4ecb98196@lysator.liu.se> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6730daa9-bbd5-471a-8161-b7d4ecb98196@lysator.liu.se> X-ClientProxiedBy: DUZPR01CA0125.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA0PR11MB4701:EE_ X-MS-Office365-Filtering-Correlation-Id: 263ef305-8a72-4d7e-8b6e-08dcd7dfffbb X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MEpqT1BiOE4wRHJIUDhuY2FBYS9ja1FoR2xHNHVsalZQMDlkZEk4dkd3RnEx?= =?utf-8?B?NVl4REtGK1BIUURFTGpGc1d5YmRENUkrMlBhUHFKQkl1ZVhrSkcyL1pEWjUx?= =?utf-8?B?eXBoVnliMWl1bmtsWHJ4MkNMKzBIRVBHZXBOT0pQeTU3U0NFWG80ZHkwTnMx?= =?utf-8?B?NiticmVobEViNXFQTUdkUW5TRGdsK1hTQ05MQUxOaG93bUJIdUg4LzZtc1hl?= =?utf-8?B?NE1tSy9yNG1HWldRZDJMU0NJTnVmRXdFalNSWXlpekJENnVqWGF2UWRwTC82?= =?utf-8?B?ZUd5RVFHQ2ZKVmxodTYrdmhrcGR6WU9Nenh2WFN0dHVHdWxiU0c5a1dQRHc4?= =?utf-8?B?R2FJN0lCVmt3OTNEM2JCNlVLS01pZVBpQ3ZtUFVlaVhyaFZ5V2tRTk1MSkFh?= =?utf-8?B?Y0JUSTNlajRmUjhlVXh2U3p0VjFNTm1SazNDa0NVZUZjNUxidkFhWlM0VnNI?= =?utf-8?B?UWtFRlR3d0JXS2pCNTdneURGZ1Y1ZkZNN0NpYUtXY0FkU2NMSndDUldxQ25j?= =?utf-8?B?dHhMQ3J4UUdOeEQxMWhPOFJqZ2dmWEdhS20xdzFoQlo2ZFhGdVdwekhrcGk5?= =?utf-8?B?WG50S2hxL01IMnpuMVBmQzRwWVBONVNSaktIc0Fkam9JMlF4WEY0K0RYYmt1?= =?utf-8?B?bFBHeHMxOE85V1F5d0FQRXpkdnZXVHIwZyt0dC9EbUZFOTFuaE11NElSaXZJ?= =?utf-8?B?UUNmM2FGVzhrMld5NTBpM0dLUHN3SkJIK2VaWXBhRUw2akdhTWNRSWI0TnlU?= =?utf-8?B?a2ZPOE5GZHpndVJlWGxxQUNrbGx3bHRCVVAybWFwd2dGaTBkK2JmNUcrcEVI?= =?utf-8?B?VWZHUFlJWCtaK2c2UVdlcyszZ1d2MHhhYWdhTmNPV0YxS3N2NWp6WGNXWDNu?= =?utf-8?B?UUN4bGpyTElDOXYvWk15c3N0RWlXZkVlYlEyUC9LTktHY29HbHBMMjREWkt4?= =?utf-8?B?T2JHVW9xRGprNGsxQ0VvVDY0ZDZrWThOb2h6THZNeHB6QTVnQU9iVG0xVVpz?= =?utf-8?B?dDZRQTBudUUrS1pySitnaU5zL2ZVcFBWVzFwUEI3MXRuYnBORkUyYXQ2K0gz?= =?utf-8?B?WTJYNlV3YmdtT2g1UERGNjh6N1lJYVVUSi9vV2E1RE9zeFpIelhCb0dMOHVU?= =?utf-8?B?V0ExUlBCMzlxNmo5UHg1WTNmdVRscXFncllidlE2dGFGUDQrT2dhUVlHeWR4?= =?utf-8?B?RUNKejllOXFqalRjMmZSNUUzNXRnUkFlR2NWc1VEREFMbTBpSEVHNERSdjkx?= =?utf-8?B?aGVnaEIxNDVLcU1yV2NNYWNTYVFNNGREN2EyT2FMRjdCeGNkSTRIS2VDbWd6?= =?utf-8?B?ZHQ4UEJwNWRMUnJhQTNjTll2TUNBY3NEUFJaT0tTNCtmM29XbnIyRkVBY3Ja?= =?utf-8?B?bzBnTEFYekhHZnNQVG96TWsyU3B5eHRlSmdpLzFRM1o5U3EyM2lwdUx6UE1x?= =?utf-8?B?T3RGZWhWci9Ta012QmRkK2lLVVlqeGJLUENHT2FzbFF2cFRGQkg0YU1LNFZI?= =?utf-8?B?QXpGbE5KZ0h6L29aRlZDdUg3Mk9hWjdZeVIrZnNsVG9rclhLVis2L04zZ1Uw?= =?utf-8?B?cGhBRUhTZmllUndGOGRqSzhFbDRIRkdqd2EwUldKblQzbDVFZDY4SS8rNjVn?= =?utf-8?B?ZFRSSlcxZ0dXZXZWNUZ3aVJXK3Jwdi9uVkl4OHVjeXpWbnNxaC9pK2wxMzZO?= =?utf-8?B?ZmFPdHdJczY5aUhmaG9Qb2gyd3B2MkVSbjd3UmhvTDNkRE1xQW16WndxMThu?= =?utf-8?B?ZUdhMHJKZ3VpbENrU0poQUhBc3FBZFJHNHE0UUtuMkEvVU4xVUYyUXkwTFRy?= =?utf-8?B?NzlpbVRkTVo1WW81U1ZDUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDJ6b2M1UnJkaFk1YUhyVFRkaTJobGtOSVE4ek9LNmxIOUF1M2tmdTM1UTR5?= =?utf-8?B?UE5XRWh3Njg0YUFKbHRZTUNMeURkKzJmTi9ZL2kvUGNtNnNrdmVkLzA5MEFo?= =?utf-8?B?bkd4Y2tES0YvUnBaU3d5VW55NnBCMkE1MnE0S2VVMWhyektUcDdRMlBFZ1Fu?= =?utf-8?B?S0F1R2sxQTFGVDV1Q1k5N2FIdngwRFQ4dEJlcm1MYTlHTmYrOGludENHMnFx?= =?utf-8?B?WHVwb2hWN3JSWTRCNUhTSFpDdUNrY0pDWlNiSnp1OVZ3S3ErdjU3c2dqUU1E?= =?utf-8?B?bEY1dThkNG04UTgxaDc3M0QvUVUrZHZHV2NiTkdKQ2pxNGdIblZ1S1pFWGla?= =?utf-8?B?MTZubWk0QVRQbnkrRE5HRi9WcWlrWEdnUFZncjg4dUkvS094MWdncEpLZUd2?= =?utf-8?B?TkpFbTRIMnZBcTVvZTRJNXBOSDFXTUp5Nmoxdk9XbW1ubzVDbjZzcHpqWUlR?= =?utf-8?B?VkcwcEFnQ3FuL1FqRUNmM3AwY3hpSjZBVk90VVc0V2gvMExDU1BUNmxxa0RX?= =?utf-8?B?VjF5TFJNMm9QSFpnbTNaZHRFNkZRQmRiaWlKNCt4Ukt1a3RseExXdTEzQTlw?= =?utf-8?B?dEtIREcwTUZpa3IyT0Y5UnY2MXB6RXBEeWJBWStTWXBGUXk5cnR4MTh1M1lD?= =?utf-8?B?c09udElBbGJoYjdzbWVYN2tZQjh5Snp3TEhjTVRzakJJOG1xcUNMU2dMaDg5?= =?utf-8?B?QW5LSEhzellHT094NHM3bkJKbmdTeUFRQk1sMjByUGp2ZlBYQm1oYmdidzMx?= =?utf-8?B?Tk5PeWRZTGJmeXdmSUxVMFJsT1FZNnV5b0UweGNDT3hiamF0WmQ0Zml6QVNq?= =?utf-8?B?Q2RubksyaHFyYW5LdjRlSUdLWEdJN243aitUMmhrNFphTnZEYjVBNllHMEpr?= =?utf-8?B?WTQvNHoySCtOMzYwNnNPbENhdE5JVVNQWEFuUVVDaWF5MTFMeVNIS1Y0a0NG?= =?utf-8?B?d0hYK3lUU0g5aHp2QkI1d3lscXBMcTZ6aUtBWU5KU1I1OHFnNGtEMUxaQkpK?= =?utf-8?B?d1l0SnM0S3I2NVpORVhrNWN6eGVLOGNLMWtvem1UZmFNQ3o2S2JJb2RjS1Iv?= =?utf-8?B?elRKTDJGekE5Y25NQVY5TFlwbmlINW9ZMFd0b3ZZN1RkWW5Ic0NWeGc0NGRi?= =?utf-8?B?UGlCc084Y04yUW1IVTE3Ym5rMktDbktoeXJPOTFEZlNlSEcxWkF1U3dJVUF5?= =?utf-8?B?SU5YelRlVzlkUWRtaFluWGJncGVvbVFCVUkrZG1LUTFFRDkyYXBDVHJCT2Mz?= =?utf-8?B?VWVGdng2NEdIdVVIUSsxRE8rOHo3eUxGOVNyK3ljcHNlTjBkbCtmZHY3dHhF?= =?utf-8?B?S2hwMXFVWnN5ZUM5dkFkTFhtQzMzTXlMdk9QY1VrSVAxeGV2eXZha1pQcmMv?= =?utf-8?B?eHVSODJHTUlRWFJVVUFWQ1E1OUdGSDd5OEJEQTVsN1VEck0zMFJjM2U2a0tW?= =?utf-8?B?SmROaUhvUk45eXd0Z3Z3UG1HcUdzYmVQUUVzTjlNdi9yUjBwV2I2aC9ydU1m?= =?utf-8?B?Y0ZqVTBwOWExYmVwQmlPQkl3REl3RzRuSE1mbHRJV3ZhUEpUU2M4QXFVRldV?= =?utf-8?B?UDAvblc3TmZqTXFPZ3hYZFhSUER1UFd3bnVsUW9lMHEvaWgzakdjQkdUbCsw?= =?utf-8?B?OVJicjI4dzdZYWY5RytsbjVsSklWZWt2dk9GaXhGcE9uSkJ4RDduRmlPUEw2?= =?utf-8?B?NmRHOW0zUVVwTmZMRVM2RmhWQXFTRWVVVkFRcWJIWU80ek14dFpTamVoYUF6?= =?utf-8?B?TlFIenRUdWJUd3lUYVc1UHA5R2pkSklpSzUvZU8zQXlYRU13TFZVVERjM2VR?= =?utf-8?B?blFYTDBKT0YxbmtVN1lnM0VDemtDRWtnaC96N1dPUzFlRjVyY2RZM2hFMG5p?= =?utf-8?B?N0RzdHQ5eEFSUmJNanhvQXdkK2RZbkl6U2o4VGZZYmQ3S1ZkT2VWRlc5Uk5o?= =?utf-8?B?UWRtZzBWL21XelhTcloySUpFUnNuOEhWdUcvc01sdGhkZ2o3KzZ5ckgyVXFT?= =?utf-8?B?cjFtbUlEeGdnWmplSVRPTGRUR2k4MW9GenBHUHVIYzhlTUVxZFZWRG5jNnBn?= =?utf-8?B?eEFBTDJ2YVpXZXl0TUtxR1oxOFFpSU8rT0Zua0FCdVZIbmJad2p6N2FiS1kx?= =?utf-8?B?S2luSlI5djNYZkRlUWlLWUtYTTZPWlZyVGJpUWg0bFlCdHY1S1hjYkRJQjFE?= =?utf-8?B?d0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 263ef305-8a72-4d7e-8b6e-08dcd7dfffbb X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2024 12:47:05.0178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ljRzXze2xpLawZeFeJzJ6VhdfnkK6TX/PRRa1XrKwqrueR+Y20rWrOsAnokbcxl4FZeI7X83WWf5mRFUKVOOmCYK7ltnoDD2MpfsM9RY2mg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4701 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 18, 2024 at 02:09:26PM +0200, Mattias Rönnblom wrote: > On 2024-09-18 13:15, David Marchand wrote: > > On Tue, Sep 17, 2024 at 11:30 AM Mattias Rönnblom wrote: > > > > > > On 2024-09-16 14:05, David Marchand wrote: > > > > Hello, > > > > > > > > On Tue, Sep 10, 2024 at 10:41 AM Mattias Rönnblom > > > > wrote: > > > > > diff --git a/lib/acl/rte_acl_osdep.h b/lib/acl/rte_acl_osdep.h > > > > > index 3c1dc402ca..e4c7d07c69 100644 > > > > > --- a/lib/acl/rte_acl_osdep.h > > > > > +++ b/lib/acl/rte_acl_osdep.h > > > > > @@ -5,10 +5,6 @@ > > > > > #ifndef _RTE_ACL_OSDEP_H_ > > > > > #define _RTE_ACL_OSDEP_H_ > > > > > > > > > > -#ifdef __cplusplus > > > > > -extern "C" { > > > > > -#endif > > > > > - > > > > > /** > > > > > * @file > > > > > * > > > > > @@ -49,6 +45,10 @@ extern "C" { > > > > > #include > > > > > #include > > > > > > > > > > +#ifdef __cplusplus > > > > > +extern "C" { > > > > > +#endif > > > > > + > > > > > #ifdef __cplusplus > > > > > } > > > > > #endif > > > > > > > > This part is a NOOP, so we can just drop it. > > > > > > > > > > I did try to drop such NOOPs, but then something called > > > sanitycheckcpp.exe failed the build because it required 'extern "C"' in > > > those header files. > > > > > > Isn't that check superfluous? A missing 'extern "C"' would be detected > > > at a later stage, when the dummy C++ programs are compiled against the > > > public header files. > > > > > > If we agree santifycheckcpp.exe should be fixed, is that a separate > > > patch or need it be a part of this patch set? > > > > This check was added with 1ee492bdc4ff ("buildtools/chkincs: check > > missing C++ guards"). > > The check is too naive, and I am not sure we can actually make a better one... > > > > I would remove this check, if no better option. > > > > Just to be clear: what you are suggesting is removing the check as a part of > this patch set? > > I think I was wrong saying the dummy C++ programs already detect omissions > of C linkage. > > I'll leave for Bruce to comment on this before I do anything. > I agree that the existing check is very naive. Maybe we can go with a simple fix like adding an allowlist of files which we ignore for 'extern C' checking? I don't remember the details of the original patch unfortunately, but from the commit log I think I found that just compiling C++ with the C headers didn't throw any errors for the missing extern. I think the functions need to be actually called and then attempted linked for us to see the errors, and that is not something that is easily implemented. /Bruce