From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D05A445AAA; Fri, 4 Oct 2024 09:55:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B696E4027F; Fri, 4 Oct 2024 09:55:04 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 172E740268 for ; Fri, 4 Oct 2024 09:55:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728028503; x=1759564503; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=jRMkpVt62Gn4c+2XojRpp0MbQr5q4SHb7Nn6Efuh9nA=; b=ag3UygLyFM0fh4b+Ddpmz+QB3f0GtTgZJ46pyc6YNxRIZGQx/YIuAV38 bljeUQvVxkP+9ArXrEhO8QqssHxXfJYj6vhbi3mgIZ5glvsgrOPoQepe1 iP6CmttM/ALzvxIGr1h6R8jghlqVSjzmHyCFZczJiIY3C4KNpZwidwV1D LomXiGzA+UPKAVWdfNPXDhlvtsuO9x/Xm21bAgJCBMIQ4wt49Xc8RX3aJ JEVD63JD2mjTqrLxFxRUcXV9u1ic80TKTOJW2F7XYkO+8ID7mF01zZPsv 2dPDGNu1fjriKBFKPSx0G02h/tLJM3P13F4pEfRWvYXPgoQ4Fcq0R/FyM Q==; X-CSE-ConnectionGUID: jwVtMrwwR1SsJUWJeLGlQQ== X-CSE-MsgGUID: ZCxwobGUSUOvIwo2gWJRdA== X-IronPort-AV: E=McAfee;i="6700,10204,11214"; a="26710780" X-IronPort-AV: E=Sophos;i="6.11,177,1725346800"; d="scan'208";a="26710780" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2024 00:55:02 -0700 X-CSE-ConnectionGUID: v4iZ+YPURSmDUOqLw9tMDQ== X-CSE-MsgGUID: Lnuiqh39SKiPDfe7Qi7E0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,177,1725346800"; d="scan'208";a="79393575" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Oct 2024 00:54:58 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 4 Oct 2024 00:54:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 4 Oct 2024 00:54:57 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 4 Oct 2024 00:54:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fYwg4nhHnzcigUl1Ep3LbKlq6Z8zIrSH+lukBcttgtxBbqbQZcVRDbUh/0uvBYY6L4WvXwJdXZE+FaVsF5CmQg1uB8G2neLPxawVaxhbHsKnki2Eh/jlKzIWYw1+DKmctLZEzzweJfpjjvEv0G2mETeUJyfuihR1PQcm2RnGSaTPXJA6dLSjcdcPLM/W9TCFR7RUJkyfvKIocAb9FZQU6K1dYc8zZTMZhUHfloJglElNrDHhEmkfywI4UZrb5+Z4ZYNQTuXiivgg+NIkEkZwpaxg+qLvPGmxWZc37q7np1wn8ogXECt34qnu7+sFlqQo716bwmo8B7gwDE8pmZ4OkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jSdY062nysaHQSyk6mD/9Cr/BzdyiLrWRA+r9LX4bbw=; b=t4UbWZ4Mb35PoyQvDZwsYyikrtHPbzxFjPsT015zQjvr7EN6fB6fXv36dcahBLaWaCq+qv+3XHz+pVkHlFPfjLmKwgX0oLA3MUnBoKG1IRgYRz6FSwYFHekSmmLVlFF1spZL8mRWHQmEYrN0YEU6HpAurYl93cfAjyu5DMvmTOpyVopg+o0kAij6XGGoDG/Y2V6h4dKgJHta/P6UoHGrvll2GOFU7KRBj4wCxIzWYRtURXWg4jr9fJn2TKON6wowHCtH9bH/wEEVUAtQJ4BPFBhxecL5aMkjkn3fD+BfTyob1tzj2cOdelGbDrmnpyVcYCwRfYsguDvW6MEiDOW+bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8528.namprd11.prod.outlook.com (2603:10b6:510:2fd::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.19; Fri, 4 Oct 2024 07:54:55 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8026.017; Fri, 4 Oct 2024 07:54:47 +0000 Date: Fri, 4 Oct 2024 08:54:43 +0100 From: Bruce Richardson To: Ferruh Yigit CC: Stephen Hemminger , dev Subject: Re: [PATCH] doc: update TAP device features Message-ID: References: <20240904154206.13438-1-stephen@networkplumber.org> <31c8133f-fb10-4e2a-9b25-8a6f7557d87f@amd.com> <20241003192612.3c5055dd@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZP191CA0017.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8528:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d56d107-6b36-46ed-558b-08dce449d15c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?oSzCM125LKNaQ1wMx+xQIRnWigi0dh3vcznHUtYr4+XHM+KavOls9ysR3UAy?= =?us-ascii?Q?SUv0krVKK+9jOOR7fb4Gs3vpus47fGMljvzab48ZnRjP7JMQfoz3tU2g91G9?= =?us-ascii?Q?65Q0ANspuLuS+S32ov5WtxS22ldToPnm3GVLrIoNbY+XvwroNILtB0ykL+8b?= =?us-ascii?Q?nVKdyeKrO9CR/hHNtolQIPxV5LWbXCMQK39cxtaKBRZd9keBHEoFKUBaIjrM?= =?us-ascii?Q?QQeJ7YIGeu6iBa+SqRk/wOAUMDCIi4iK6a0NzyBF72Gb67rAj3XtFKIsqdW1?= =?us-ascii?Q?I7vA2lEzJxoGyzlv1i+RA35KucUhh0osdTmzUBeh7nvBlE6wf3g0CUxQqfEF?= =?us-ascii?Q?Ib9Svut1bohhF2F1F9LysKwmb6+YWwqhbB4O80a9zTfABvqkC11PT5Zr4moX?= =?us-ascii?Q?VM/8FgL1q4G+ZuW7QbSg5AYsAAafQ17BrqnwyG8ET2sBD61aNmEGldmHVEUg?= =?us-ascii?Q?Ocaw7uLR/iU2DAicNryIrcvgpOYTuM5Js2LmhsQJZXThkytLIr9j2J4Aypyu?= =?us-ascii?Q?No482tdDhmkTnLrr0+dOPvxBC5gTGQ0iAYBOtD9iLIxqQUWx5wpqE55RsJLs?= =?us-ascii?Q?8xx/4Dm8vZxb4robUvtv7HXYbHwUkA8Obqy3hjU3ycIm91n3FOQNK2a6eOMp?= =?us-ascii?Q?G+tzL3efIo8CX+OtLJzhd6JAOvkf0AhyVPo3uXYirnUNvfW8KOnqoZB6pFgT?= =?us-ascii?Q?W7MGKWuTd4AzHZRqiOetm9hJBXNfIJq0DwTALA29BqVUMnQIPIiDG2om1dOA?= =?us-ascii?Q?t+/0oJLKQPYKBdHecJf0c+uLDLwGMpB90zmELjUqEm+Vtvdg++lBaYsJnAQ7?= =?us-ascii?Q?pX9kzbKpy+8AU1LRnM3Ox8U1IfpotB9ToL51wjlq1FqHECSzHWY586Q2GEw0?= =?us-ascii?Q?0013J9ciVd0JDNwaSrM0f6w6e+xxpNH3vrfZSObZaUCx1rh3YHHVw3tIzpOI?= =?us-ascii?Q?2dkTp1+gkVclUtj6HFKGhO8LI2ZDtc7TzLMkB/kmxgeJRPMyt9x1473UcjfE?= =?us-ascii?Q?VMpJ2d2tbQbF+Slvmw4AVU0/VziUumtzXcqMIwXJPdqhymImebcUw0xSXi0W?= =?us-ascii?Q?i/TwFSHnwNY/O2wP7h78Qejacjw8pGQV/mpNm/lx5hah6tcRBvVwYHPBAHTB?= =?us-ascii?Q?DySOMTE9eKsARLSsNJxcTLc3id+k6izq2hn3Sa4tBYVZwurIKLT0+uIYB6rY?= =?us-ascii?Q?yGJFVYpvvYcEUun2R+sw83QGWC5MQhOpY5lbxsHPAgqyJtKReaZEohIYbKfu?= =?us-ascii?Q?5VFSvCzzk2fAks7e5a+3ZWbFAzb+8a7IZJRrF/Bgmg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A1fkgmYnTgub+fNPt8yTZ836IKlMK18xX3Bnm/7i7OPx1HAAf5iEL+1WhrvZ?= =?us-ascii?Q?K1T3LiSpSn7uE8EAgNqrQrKm50eHfpbD6DSvxJH4evbbimkS5ToHb/BwLq/o?= =?us-ascii?Q?QRe1mSy2TQVRR8vUyvTXQlv56JbLixoqMPFyb0SZexGxi8QpMuPJkzDpXYVk?= =?us-ascii?Q?vc81+3Uq1LGYwT2GBiSEXJswkoGG+GHG17PLX8Xu7YKa0zh2cohzPA9nkmps?= =?us-ascii?Q?46eo1MNmgtbTbbVpT3XN8NnsPqjI56Q4dPfGGBNv5UpDojrSfA9VnXPCGZsF?= =?us-ascii?Q?cABXlzcL2g2hV+XkOwlpANwKz0o1uCrEn+vAH1YrAzH92y3nEi9CtQ01k3V1?= =?us-ascii?Q?JOscNLo0NsSo1YghAYeQjtHWIwA/DMocdRJrPhB4bActva6/xuNtH1Ly/fND?= =?us-ascii?Q?SrB/CiO2b6YYRd7GwleCATKY8+m4v9kwSbPuQPCm10U68qrn/2R1qOzJeATE?= =?us-ascii?Q?kyUPxwSjJgshEJlnmHuI2h9E7FtXUExk7kJ1ti6hrRN/RemrXWeWCAWJoMZp?= =?us-ascii?Q?5I9dWRM5HTDgbSh7MUFocgNA1PbYWMttvGwXqgbmJGyQyt7n8TyYoWX0eOcB?= =?us-ascii?Q?pXxoSy8wmCHHYhAfDmDL70EvRKjZonLhsX3ojuB6i9qWGgWPgPDzafzOUAcQ?= =?us-ascii?Q?QOMtjAmNNRCQa1//mFkbKa/TRvy2JX4HIYWw76I3YCR2/VOVcmCBNMZnaRVM?= =?us-ascii?Q?7MZGG/9j6VEUvUJh8hgxT372cATMa4cUMKs18s3gyv0mz+zlAxbmVUi65KgV?= =?us-ascii?Q?kLhThCFJu9+Lf5AL/KryGAIFlMpfFUdRz/W3mo7lXiRmzv5kOQbBCDIzPtNI?= =?us-ascii?Q?yDcENSCF8u3fXaVB78H8oYFy5oI5Alwa5G+QZn89szvfQ5QI94qBWCSXza3X?= =?us-ascii?Q?yftLhjBZuWUS9uUKJa0jvUG25+NOzIaNPsuvzQ3kvcV5CGS1ZbmpSk7ZHZue?= =?us-ascii?Q?rfToAEXaT3S9sMKezc/MaTa3JqF+hLQ/NPnKdFL3wSt0Hsa2qt4DsQrVdjIs?= =?us-ascii?Q?wIzyFxjDb+drews0kdTYD/HQNDUxrIiTZAIYyAg7ch14JiRNrWZ0denOjCOe?= =?us-ascii?Q?Wzb+oFOJ+1zfpLpkm04y/FWM6T4yEbEbtSoFQoaDLoR1piy1I9L3AGoNIadl?= =?us-ascii?Q?cBval5K/7XL+0g404hfxK4hNGenevPVDgWwHnCHD+m558AkwDI91drMay8xe?= =?us-ascii?Q?iSRQZqgoa6HR7SILCEjMCetvT2FndSKag7dnzN5uT8YBQmW+QoO6X7zrzYIf?= =?us-ascii?Q?Su9enFmbBvdGzIf+LpxyFLpMgT1tvmclcnz7uiKqeGnl0A/JmsP2RIGSxCFR?= =?us-ascii?Q?sWnTZYRUd0H314oOC74KTSSoCBmpWFE+VHOtUSr24KGAl2eAVHQRrxxU0trL?= =?us-ascii?Q?aW5/rM9HJ2ZpaX0DDdHCl1Yo82bcax+PSGxqLNHgVRBRE6D0HMFe0bLNsBlK?= =?us-ascii?Q?jaVYjAdt2itFSVqzwEI2hXB/GVHMxqaXPsHYku87hIC/fBADDRdExRv8scT7?= =?us-ascii?Q?k/EPRzB1pQ3HGvyPwuSqBO2RD4812Wh4nDSuU9dhg550VmLDg5i89YsyaixR?= =?us-ascii?Q?tJnRiSwXiT8qIWg3YzU25fqX9ijZJeZ/p3rGAZXWsuxgCxoVy5XZ+lhjtRYT?= =?us-ascii?Q?5g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3d56d107-6b36-46ed-558b-08dce449d15c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2024 07:54:47.8074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FsMgkqWQzbA/tsZwND/EfX/PUbLSwlWBjCupWTsjbbIFjXLjPIob4Dy/cx5C6WfgQoboIQGZlSMaR/Pt//yuVBONIPrHcCwl8W5Ra1EgIXM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8528 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 04, 2024 at 05:09:21AM +0100, Ferruh Yigit wrote: > On 10/4/2024 3:26 AM, Stephen Hemminger wrote: > > On Fri, 4 Oct 2024 02:48:21 +0100 > > Ferruh Yigit wrote: > > > >> On 9/4/2024 4:42 PM, Stephen Hemminger wrote: > >>> The TAP device does have per-queue stats and handles multi-process. > >>> > >>> Signed-off-by: Stephen Hemminger > >>> --- > >>> doc/guides/nics/features/tap.ini | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini > >>> index f26355e57f..f2ea5cd833 100644 > >>> --- a/doc/guides/nics/features/tap.ini > >>> +++ b/doc/guides/nics/features/tap.ini > >>> @@ -14,10 +14,12 @@ Basic stats = Y > >>> L3 checksum offload = Y > >>> L4 checksum offload = Y > >>> MTU update = Y > >>> +Multiprocess aware = Y > >>> > >> > >> ack > >> > >>> Multicast MAC filter = Y > >>> Unicast MAC filter = Y > >>> Packet type parsing = Y > >>> Flow control = Y > >>> +Stats per queue = Y > >>> > >> > >> This feature name is misleading, > >> it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is > >> indeed for covering limitation for some drivers. > >> Tap does support getting stats per queue, but doesn't support above > >> documented feature. > > > > The stats queue mapping was a feature that was hinted at being removed. > > It only exists because of HW limitations on Intel ixgbe NIC and SW > > limitations from RTE_ETHDEV_QUEUE_STAT_CNTRS. > > > > > We have a plan to remove 'RTE_ETHDEV_QUEUE_STAT_CNTRS', by moving queue > stats to xstats. > > But ixgbe limitation is there. > > > Perhaps there should be a generic SW emulation for this the mapping? > > > > Ack, cc'ed Bruce. > But I am not sure ROI of the effort at this stage. Not sure what the specific ask for me is here. :-) Overall, I think moving queue stats to xstats is the best way to go. /Bruce