Re: [PATCH 2/5] net/ice: improve Tx scheduler graph output

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Oct 09, 2024 at 10:45:43AM -0700, Stephen Hemminger wrote:
> On Wed,  9 Oct 2024 18:08:19 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
> 
> > The function to dump the TX scheduler topology only adds to the chart
> > nodes connected to TX queues or for the flow director VSI. Change the
> > function to work recursively from the root node and thereby include all
> > scheduler nodes, whether in use or not, in the dump.
> > 
> > Also, improve the output of the Tx scheduler graphing function:
> > 
> > * Add VSI details to each node in graph
> > * When number of children is >16, skip middle nodes to reduce size of
> >   the graph, otherwise dot output is unviewable for large hierarchies
> > * For VSIs other than zero, use dot's clustering method to put those
> >   VSIs into subgraphs with borders
> > * For leaf nodes, display queue numbers for the any nodes assigned to
> >   ethdev NIC Tx queues
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> 
> Fixes: ab4eaf9a8a31 ("net/ice: dump Tx scheduling tree")

This is not really so much a fix as expanding the scope of what is
displayed. Therefore not including the fixes line and Cc of stable in v2.

> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> 
Thanks.