From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C85F45B42; Tue, 15 Oct 2024 16:32:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 691C7400D7; Tue, 15 Oct 2024 16:32:53 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id F20EF400D6 for ; Tue, 15 Oct 2024 16:32:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729002772; x=1760538772; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=II8Ahc75a32KmhXxaiX5HLWmwKsTJw7lPBEhm/VANvE=; b=BQjzqr2eGSd0im1xf5EPk8v94dANrZcGQq+mQnKdOP4erzpEP/cDFoZ7 A5ejbSHFTdb6nbXoT1z3zIy7ev2USfmfDQvHQHECjilwA117nAhKj4KVN 7dicJTors2sbGIXj1+2Oupw7ieHy0eWu+odOVgGxfMM/PmgJ8TXX4JG/Q 8sLZFjZn98xjaCo9wQVJmtQsZUPFVZLkTgqj87vaPEZP09BQ0hc4+6YAn K8VEgUQDirBoepg9mWwytQmMwQTF7a7Tfn2ebAYGjVAbyh0i/16G7hy9S MAQzt6lDfffJtOGUZe3vgh3qqduJTxuUHRiC10CoL05fZspTy4Vi2OseR g==; X-CSE-ConnectionGUID: YlmfgncfQT2j2B9OHCDbww== X-CSE-MsgGUID: yPCJvvd0T5eergbd65CJ6w== X-IronPort-AV: E=McAfee;i="6700,10204,11225"; a="27845233" X-IronPort-AV: E=Sophos;i="6.11,205,1725346800"; d="scan'208";a="27845233" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2024 07:32:50 -0700 X-CSE-ConnectionGUID: 26/PSAWoSdWcvhPuNPpF7w== X-CSE-MsgGUID: RvGizodOQGuRZlaNmkC16Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,205,1725346800"; d="scan'208";a="82984707" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Oct 2024 07:32:50 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 15 Oct 2024 07:32:49 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 15 Oct 2024 07:32:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 15 Oct 2024 07:32:49 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 15 Oct 2024 07:32:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r9bxHjeLzNPmgYDyi7rlWqFHDg04dT9LY6CUswXidkDd75win90YomA+bCw18761IeBf+f816S2zI4+DGU4IkN2hYHoVlaf8eSI6g959eeUZ99TTg+5nojyPUH7dfzzzGG1j7tp2wbQLSNhsbMRlPTyUOn08MxBXdNepKLTACIXs4st2L0QM48OveIa+1mfhdihSVHmBI9IT6asxgupmBIUkDOe2MNumc8YTuRRPyIk2WVsUpZWCx3dV3rfFJdr5aY3UtHJMmLTrxUxNS278LCZqlxs4eSIX4rSfR2AD7JRfhqI5gen4DzaCMPi2cTI/X+o+/1WpgwtTxgSpfipL5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2YqDMdZUkeTxTs5EJfK9e47dRCNff7soZF5cocNtwzw=; b=qFAjamPVByEkwngj+cIeKlKfIY6CrGN5DsAnpBvZuMFThiFJzf2y94FKEp++1JG7wK9xI0gaSXr0x45O3ZvL4qO0LzanWW5XWfOI0LhC7nkJp6Z+LmIpScFayxnllH2loJ5ewobd7zhS1JnGoqw5jkW1KGcp8k9U28OkEWGoNtsYbjzrW4+K6r60JPYfT3m2odgIA8pShTAnWthLCwUSjAAVOsAJefw4KMC0IsdJ7SGrb56naybTpAgQFhErFL8ju6/tE4t7gI8gjL7b9XhOMQulSA/PzNx1hT1ekyZiKlu21rxtrD++NxKLx30/xB431X/EnbEvMRaR5I8Ex+muqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7372.namprd11.prod.outlook.com (2603:10b6:610:145::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.17; Tue, 15 Oct 2024 14:32:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8069.016; Tue, 15 Oct 2024 14:32:42 +0000 Date: Tue, 15 Oct 2024 15:32:38 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Subject: Re: [PATCH 2/5] net/ice: improve Tx scheduler graph output Message-ID: References: <20241009170822.344716-1-bruce.richardson@intel.com> <20241009170822.344716-3-bruce.richardson@intel.com> <20241009104543.026ddd29@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241009104543.026ddd29@hermes.local> X-ClientProxiedBy: DU2PR04CA0068.eurprd04.prod.outlook.com (2603:10a6:10:232::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7372:EE_ X-MS-Office365-Filtering-Correlation-Id: bbd17d4f-9ac4-420a-817d-08dced263a4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7wZl9xWsh57ViUUlk0lno6AXCdjvmE/lBVUcALb5nOUlHSsjlm98oUndBpWH?= =?us-ascii?Q?/XFmNOpK7XHsTW+I1f6GvQKohUG9RFpD9qq73o5+G4C7zOsjuvgv/8Ant31Y?= =?us-ascii?Q?/lx/DGpGonR1CMwkleN2LLW4GaL5KflCCNacDlZv2Iu46LZJ/1WNhCk1Rqpw?= =?us-ascii?Q?n6ApOsHcTgc0KF+NgqRn6MqBdRqc9T2jyKZ/s7WmR2Zm5kNapT8c5cQDAynv?= =?us-ascii?Q?f18zGnhgojNgXFgK/aJ0Qlok0UYGmLy9g70kG4jJ+0FXZuvU2RqG9Pij51lP?= =?us-ascii?Q?b+Sz9jHbSs+OMw0uaiBGa/V3LZJx3N/2P6r1XuLoG44dnkrUPkk9PpS3T4Z4?= =?us-ascii?Q?P2mV5VHeH1A4h1G9ZysrZsS8/7KQs5VArI3iXeohH/yPRaSlcUXhvNZjHudG?= =?us-ascii?Q?FuWP0OqNkBoqOqepWmHTpupC2qcwoMt38xTFxm931xvta8Ko0WG1/o/tKCOT?= =?us-ascii?Q?Vd5+cTRoENekvgcUqDVE9pgU5BI5idlTuNsPREu9v6TtSxjuisxmbh1dpIUK?= =?us-ascii?Q?/KJtR/3Z+dlpLBqOhTb81jq/+1SRwz8VLlDIH8OKeyxMIplIiGkUJR9GGApC?= =?us-ascii?Q?OND8SI98L44sqQ4IhunF+kUPgqpLvi3Ab81//BJKf/9TlisEbcH4d+HqVEAA?= =?us-ascii?Q?yVT4/WAR1IcyTIM8g2bmSTqu4YnnISTahCf+U+RUxIaLExcbEtkaYVbDIeLb?= =?us-ascii?Q?M/nX3nJn70FFkGC6i0CBDuxv7NWFBqr/kgI+4IYutwlJc7vlTvPVk0BwpjlF?= =?us-ascii?Q?RHZ5elOE2md1L2m3dim1mQEhfRNEDQtVmTAZL1V3NJTf7eNQvaqB0xxMq+WL?= =?us-ascii?Q?3jh8WzSnzdrlfn3/m9cigNEdEd88NtKk2r08FLrYV4srB7GwQxvACvc51t+r?= =?us-ascii?Q?D7g43ZeMwI8PHE+FVUyiZdArQ1pdSYX1JGbU6ceSpP9T7vx5qEtNqHjpI5ml?= =?us-ascii?Q?mdIuTqnnwGIiP0xXneV5qhunAbwFWe35kql641BDDApjYlMm0rVAowzDT1ly?= =?us-ascii?Q?PjU4HOza4qfLytr4yf9wPRR+hQNml95q1Z5JfgdnHxhPxy08k/nmYxERF0DF?= =?us-ascii?Q?lmvXXWegcxHdIRozi36WR6GAa/5u6XpAgAN962zWa6YdNBe+en8MPdJ3yDyI?= =?us-ascii?Q?pGq+qbrsOm3fxxDlvq7rkLRyYqRefLQ3sAOI0kKcHbfd42+yxvPxH/XK21oO?= =?us-ascii?Q?A6LJMeAvlJ1ulLpSj2LmhhE5PtvNgPK6wCd9VvvN6XJazbgSRRwzTalQ9LU5?= =?us-ascii?Q?4olAXYYS1Gd7MPAzK5taoCpz5p7XKuBTj1w2wJN1wA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UUrfVlZzZLx2rBvmzBkk4H8CV3ACDRwEattOM18QZD7U3wx88TfuY0SHUFF0?= =?us-ascii?Q?dQ+5UeESAflcNw9dfzQyza0Jte9/AQwHRgCiN4gpjJzJXlOhS99CWtrwRrE2?= =?us-ascii?Q?G+0tPWaHbRSl+TCz75vjTwnCOoLv05Q8u/q0sHdrtWJZ8Ue5s6ZE76INxEeK?= =?us-ascii?Q?GyLFCEtwRVJ/WXF6iMRESoqNFWL/x00jmgMiaeF6bzW4ubimTiIHUXIgfbO8?= =?us-ascii?Q?/lQyG0o0HDbxG8dHunC3OujJfqf1HS1OK+RgUVa3r+TBtmt5ZuMGH9hXoTXd?= =?us-ascii?Q?LncSqXVbDmrsZ6E513Zgdvm7+xhAo1ws6XgdaD5MqiOmLwEib0ndQWvmmp4Z?= =?us-ascii?Q?d0vyfO0b1sp5aCIchEHW0oNDUOhBWFDkamkkZaQF08g48nAOCjFPb1G9AMLV?= =?us-ascii?Q?5XXtDYYFaLOL/vfqde+D6a3tafbeMmKMX7/E6BE660W6ru00hpXMY5/xL+rY?= =?us-ascii?Q?uaTvyYGWuh+wpm9TOrZt82c8tJbkR6ZjRvjDlH9O7fwwKPfgZsuLeYoJCRyN?= =?us-ascii?Q?MgCzjotFGA9b4T/9ajnMnitm+/3kAs5tfSLA0EGv9SxpwCzYV7IYL/+dz/Gb?= =?us-ascii?Q?GIaaJrGdQtEsaqbK5DNAzB7NNtZKfNa5HG8YDuPXAtW8eRIzaRDPnRJAtY1F?= =?us-ascii?Q?o2ZnYcc4QCU2k5taIa36aCLaY3Z4wmCk0XCgAnZ1BQDSxtfU7fxphktiEKKp?= =?us-ascii?Q?og4f/XjJHJm57yod5mR0520yZ5ahSRLqynMI5myobLp1cUlsvQ01kvsqoV23?= =?us-ascii?Q?S063KsHiFgCK834jfyUemlvdm3rofroeqLHuiFs+JqJaSDZWMj46U+N2rMz9?= =?us-ascii?Q?J79FXwPM99um+wYO2JoztoLhMjcXTeMpP6VO14LT22lo+/+ZNADyjUoe2ZFW?= =?us-ascii?Q?h4di7s9PzsWkER0R0KYbVnbDTCtY4k7RkZU+yzc/ZCLJuQE7cvEHYsFQS9EL?= =?us-ascii?Q?x60PiH4C7JHaYA6kmJL1E7+98R7vFdIeN3TtIm2mZfOHYGyVKAUUtf2C7I1H?= =?us-ascii?Q?fUjq2VQrcvFT47lL3E4qAxm1xEAmumU4XZtNIzG7KZWeceN8mHHH7DiRCNl6?= =?us-ascii?Q?qZOaPxfDpifM1eWyIXAjqJavjCMPRUW/4afhtSsM28WfmPrBvX7UnKvjR91Y?= =?us-ascii?Q?229kPEGcp1iNGPqAhlrFAooL3X4gEUfnCmkVfVsOJo9GvPrtcBK9w/7strjZ?= =?us-ascii?Q?2LlRMCuDq6zqjCWTkvHNkhhtbOQYXovwqJGZo6yZ84d0tEC9nyZ+bdtgB1LE?= =?us-ascii?Q?aqRhFMI6X5sHyx/0sdbeon9imKb0P6tixpee7CfKr3b8ht+u6L+5XxaefOUB?= =?us-ascii?Q?h8jd/MVrE4AcLkYz/U0gooTnLxTbUqKc6yYF2kKcNj4iO/aZ8SnkR/C4Koxy?= =?us-ascii?Q?rDkFtHJnISiz9g8d4lHbr6mA5UAuKGYFTuLJc/5v82TAhSHFJ4Ju7lP/N0LK?= =?us-ascii?Q?arGgpEeQXaEdc5R8iEjvCY4nYXUvpSCCy2L22MC2RTZvWRtStxvr2zRjya8e?= =?us-ascii?Q?niUX+Td0QWSilLROElrVyUvQBC6Y6YO932gASx6fPqMGUippqlcTO04ATy6w?= =?us-ascii?Q?/d39Wr27r7SuKg66SKMbiHQAMmKrpDXHf0rxwv3LUT4B6K+UNaEnsYtNo+fK?= =?us-ascii?Q?Og=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bbd17d4f-9ac4-420a-817d-08dced263a4b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 14:32:42.4292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X4fg6ohvhvHBAMLgsYLZ0iv4sErWtyY1NwsgoPtkG0xwTBNgtmvEDqRFImQt9nK+rADI74sj7k+ClFMFhBoLeB8IOCE8WHkjZMg5Gce/5Io= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7372 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 09, 2024 at 10:45:43AM -0700, Stephen Hemminger wrote: > On Wed, 9 Oct 2024 18:08:19 +0100 > Bruce Richardson wrote: > > > The function to dump the TX scheduler topology only adds to the chart > > nodes connected to TX queues or for the flow director VSI. Change the > > function to work recursively from the root node and thereby include all > > scheduler nodes, whether in use or not, in the dump. > > > > Also, improve the output of the Tx scheduler graphing function: > > > > * Add VSI details to each node in graph > > * When number of children is >16, skip middle nodes to reduce size of > > the graph, otherwise dot output is unviewable for large hierarchies > > * For VSIs other than zero, use dot's clustering method to put those > > VSIs into subgraphs with borders > > * For leaf nodes, display queue numbers for the any nodes assigned to > > ethdev NIC Tx queues > > > > Signed-off-by: Bruce Richardson > > > Fixes: ab4eaf9a8a31 ("net/ice: dump Tx scheduling tree") This is not really so much a fix as expanding the scope of what is displayed. Therefore not including the fixes line and Cc of stable in v2. > Acked-by: Stephen Hemminger > > Thanks.