From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B664745A78; Tue, 15 Oct 2024 19:03:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5212A4021F; Tue, 15 Oct 2024 19:03:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 55ABB400D7; Tue, 15 Oct 2024 19:03:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729011829; x=1760547829; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9MkoAvmSfd58m/psDasu/eMIybUcTi06VkuO9rAv3Nc=; b=UWJy/rx8xbEX7/LlBXuaKNpQocyz7kbfmCSNvEk9NlbtzFEvFPZvSoOG UV+N4WR4EVBfJNWc7h0HTQPq8v+0PJ4c4Iw7O1mWanyCP1MusYlKwKUZb Q+qwnTC7432SMbfWdhXeiVZdDzJgqXEqgi6PZ1JkAjGSLn87fU4x5s9p+ wzpSc73eLvh1BiTFLBjTC3MzvZ/PxaWRkazsBc5aN1l8+kikyrZ8vsZ3q NPzSGFnvw68W3etqZA5Zw07AEGDrz7KSW9LYxQkk4wHwMBv4Dv6u+W6FP vJNsIQLFOfTxBkzpoRUCWeOaoPQlWKJkX3Eu9StlSTg6PAwqMY6/CaE4r Q==; X-CSE-ConnectionGUID: LeuL6GUKRLmqr5zJxL0WPw== X-CSE-MsgGUID: SA/d5OdAQu+nWUuCSkItIw== X-IronPort-AV: E=McAfee;i="6700,10204,11225"; a="27899967" X-IronPort-AV: E=Sophos;i="6.11,205,1725346800"; d="scan'208";a="27899967" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2024 10:03:15 -0700 X-CSE-ConnectionGUID: m/nvpEKkQCiARfrXI1wkNw== X-CSE-MsgGUID: kWr8I5GsRzGUDS4Byj7Pbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,205,1725346800"; d="scan'208";a="115403324" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Oct 2024 10:03:14 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 15 Oct 2024 10:03:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 15 Oct 2024 10:03:14 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 15 Oct 2024 10:03:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j3zwlnxkwZnk7VXMaeOYAU3E5iaSV2ZoHYDiatUEyQtScnz4gjwnYEiw8T+Qh90VexlJgJLkry/HOHiuqrcapZqbCGGKMt06WwVxtNTZ5FmV0Yv/yAMO6DT0mlgt65pKsImt/Lrx5f5/gB3cbvt0mxJYUWj0valkc7NotrncEL1KJtR5M0Iha9nT8EziuQgeVgA3lvWgliWhmbsM7vSnDOiK2O36y+Bk0Qeqi4IE+1WUfxsbGV9/B10dWLwrpVfjIDo9fvu2cdgLIog9eFCjMukKC2ldVVjAio7LZ1vkY/O3VqPUTAx1DUqZvhF+7iKfiqT46b/ilx+JWtQNU9w9Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3v3Fqshl6DLnoahSPp1cLciIw4u8T2ejXX0GfqunBxk=; b=s4L8UNRJ3bk/DiCqbZxt+uXVxu/LO3xEwYqk84uXJ8qYFVbGNZUIpfSupeNKsVWLeJ72sjd6V/+obHZ4yYhpIdDl1n6eK/3OgkA71rl7zCgSNDYGocJ9A9hC+e855Zq6JZhhBtUhqkib/vr96BAvjw4gngZLlEMfRra844zD3OR7ZEJo8/6suB6BF4aDbSRviHHHIDpv1pTE3Euo47vkgTa25TRbReo9OiKULpirP/tyy/yJYZ3PBqoQY7O2xj60uxgMTaTmBGr1H7nm6RjjJ1sW8ma5Hu0CZ1q+kVS86OrksW1PunBQwU236QCC2qwtFI4Jgmx0zYnbg//4jObeYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB4981.namprd11.prod.outlook.com (2603:10b6:510:39::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Tue, 15 Oct 2024 17:03:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8069.016; Tue, 15 Oct 2024 17:03:09 +0000 Date: Tue, 15 Oct 2024 18:03:04 +0100 From: Bruce Richardson To: David Marchand CC: , , Jingjing Wu Subject: Re: [PATCH v2] net/iavf: preserve MAC address with i40e PF Linux driver Message-ID: References: <20240919120039.4097053-1-david.marchand@redhat.com> <20241001091254.98540-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZPR01CA0028.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB4981:EE_ X-MS-Office365-Filtering-Correlation-Id: bc966265-ee98-404f-6f1c-08dced3b3e9c X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6KSfauENQjJjkPlJ5bQROMp6K9149IdiQ2rOD7oOiNzCdIM8FawoBNQKjZMH?= =?us-ascii?Q?mqepSE/m3VnbjsojTK5LHnQWqCoFWx3/QERM/h4ssz/K11KJTeIr73xDJtW2?= =?us-ascii?Q?WU7z2zVI38QOsl6cl9yFO5O8/2+Tui57mBck0lGG7a/9d6J0g1+KApwiFVqx?= =?us-ascii?Q?r3nUql/SwhYABVCsrXGKcaq7GEoKm5wLPSuQroQtbNsR1c/YLDxfNI1JQTLZ?= =?us-ascii?Q?UJSqXv6LiTDujjXJuDqjNDa+toIYQtbRwg1LfqCiBTZN4GGE3p9l3C7XmA6G?= =?us-ascii?Q?D2dv+bVtOmza4N8lANYSlKiwjP/+RtFZsZFrjVLmPPsKkF392h8EvCWdpDHt?= =?us-ascii?Q?2OmffCStsse8HM7imgEBT5T9D73MU4qYdMPl5kHAo8yqW9UAJEVs+nO5KDby?= =?us-ascii?Q?tQQ6itU1FWDpjeGEPg5VyXMkdBKwtXbo9vXNQNgvNm7gwq4i+t2bdVWkPwtu?= =?us-ascii?Q?W+v4oBdyKNfdInvJVWDZsQ2wS8u5QSJNLnS0uh2XmPsbvCQ9tmINVIRIoi1+?= =?us-ascii?Q?rFi/AYzbxe6EC5XqQbT2A2W0y0fC+GeEIEZXbEHE7nQUEy+ri4YEn8VP2lJv?= =?us-ascii?Q?qMUcoGKHzxjdCzofCbMF1unMetcdZYTdABea+3aGsE60AnGyjZD0ChwZ28vy?= =?us-ascii?Q?BG4SUHUqSknwx4XCAcCjzufuZ6Ski/vxHhvKvO3zogmZ+E0rmgB4Y+G4aHeA?= =?us-ascii?Q?tl6Wkfnj3Ixcs7AseOT35+6Mn+q4V4u+pczEoteaEmb29cktCVRQvWSw8sZj?= =?us-ascii?Q?7FiJmKeoYfdQq1QHXCBs3ZvLCZUXvkkVKct1DnummnS/gYilDCK7TaPlDaIo?= =?us-ascii?Q?U+AnwNLIm8iOD3PSrqa01L8hOiwbQUj9kIE2/egNUn9qSnFBU9Zm///dGBFe?= =?us-ascii?Q?gat0NP9CZNkn/zOCvgLfX2tRfIyNrH8fIRYGAXq3WR1stHqR54toFyZfbp34?= =?us-ascii?Q?XnGMPKIYTSjmTqnKhMyLaxvyMMNo9bEcqLYTsmUOY/4Ot5Lza8rqoMGM8gaT?= =?us-ascii?Q?cJ0sYho+hyL8r3P+BqnSmHiW95AoOCNa1Diwc/P39cusfGolbt02PD9I44HP?= =?us-ascii?Q?vTximtVWDwdr4bG/J7tQkjI09WPslCXYTRmLMkNwaYAz2APCkWs14FYLrbOl?= =?us-ascii?Q?/QZ8B82Ech0fppChYoux1HTs96mj6EyL3HtqCU7nYB/Y3hrapAaL86Fe8DM2?= =?us-ascii?Q?S5K5w0boIYC2pPIUgfG5EI0LVPziGAw/goSzxscnCq3j+NGr5zYnos5pQHJv?= =?us-ascii?Q?BZt0bN5zVrqYTO4ECaB5XXy8xt0PoOmqZlBrxCa5R0MZB1+hpDeINS/LLuMB?= =?us-ascii?Q?ljk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dTc3SSjGTs6S7xqnis40RPtKEvDtqCLgGqfuWl5rDKaWclyLytBGssc0Biy7?= =?us-ascii?Q?Slqn5CK311+LWDUR+TasuYVB0XsW2Gu+Hft4hM3D9910kmeU5fMipEvuT5oR?= =?us-ascii?Q?ND6j2TqWMUzTtNy5OC4WzyFXuC8QIPetLCA1AVSL+4H8bvU7fjLghsgh1mq7?= =?us-ascii?Q?b61dDCmIRLwvutJunHbQwOpMCLhB6S4ena8WntFDnN/NNYZ6zoYSf7MCja9w?= =?us-ascii?Q?ptZRW3q4JoAqE686jTfB97ql7Mjbk2QT6CqQVG7/O/Lbxwyf4POIJo74eOj2?= =?us-ascii?Q?lfMqjPgci0DOvQMF492BBkdKbZuoQycByGI3lNUYuIE/uswtW/bFR2ZpiSnf?= =?us-ascii?Q?jn3E/6AxUh2wDjdFU1VybRmAHUkxP3t3B5kliM3uDy5fh93P/RDMGnprwc0r?= =?us-ascii?Q?6Uv01GDHqI6P1Rf0FUDYCnCUYflcQb1+pWX2QRa3R2kdz7oPRJFibio5QaBg?= =?us-ascii?Q?HXlxX5yLngrQwmNnXf+YlHtDSLtQVzHczU1VgsD02OIW2egVcPQDtfYYGOX4?= =?us-ascii?Q?m1JoO71Rkxp+YgRoN4wmu47xnWoGXAdbhxq92nxqOFoEgebThaRoiCWVk04V?= =?us-ascii?Q?Fv8Fz49Jw/HxPmlPFui/Yy8ljqCUnI4nT0nUdY6xQL0kW4ysWdRX4LJdAlNR?= =?us-ascii?Q?2nke/alNAtaaMuwgI73DUOqVUfEo/AVt4WjQ/z0QL3InHEE52Z/shQlHq1Nh?= =?us-ascii?Q?K3ovMbsWTJv7qBLUOXSzXlkEn1R1vVaqpUdiZgWRHMQynpT+AgKGpMfNqzWg?= =?us-ascii?Q?lsT9k+s/PbOtjzJUICjDuo20rfURg9O8oJv9e5OwOOV0pw/ppx2vFYNOq9CQ?= =?us-ascii?Q?vqv++k7Ipo7wjoFvJ9Dai3a+XoCXhsoRNAIZNaLR4P+aAqrSJh4bkIsuBcBl?= =?us-ascii?Q?fOVbY/8cwFpU11lkosIWGFZvMvpBwPPkIvcAlmhFglpI8cZr3JrU49vCm2gr?= =?us-ascii?Q?mdWuS062XAjMlwd4T2vqzjh2iokp5/FTA7EmBPJqa2Silmpahy63mCj13UR2?= =?us-ascii?Q?Fc9F9Q6blcBCVHK3ezcFZpMaoboojiOqx2sn7P5voK86oOQl3i8WIG7kd/BP?= =?us-ascii?Q?8pREZRSAW+edFf7WsdX1ZBl7krCZLUEfM7b8zHhpicNOq/O6eG6vCJ8haaud?= =?us-ascii?Q?Hbb0uTP301kkILR29aDPytyn4r9Lb/F6ynl+Rxl5hTCMaE7jAOP1lvlyOpe4?= =?us-ascii?Q?vBWg3BkndTnvqfBLsO0ifT7nIpuQld4HZ3GHfufkfiPBDsYbADV/OQufChaD?= =?us-ascii?Q?G5t2Uc4bzJvzSv5j4DM6lS97USrP/dnOT3SHspjyFwEiIfxXJ7DGwqdX6158?= =?us-ascii?Q?YwAHZw6WdUnTkIglNpNsjeht0sWmYei5zTsHtUOKP7/lT8UJzwIDQ5OeeuZr?= =?us-ascii?Q?C1E0bl9lj2QlZCsh+kcZ97kctlcEXM0caW6DD+Un8Se0fkJTjNALiOLjLHww?= =?us-ascii?Q?5RO/5rpx1D2BvVenKLfR8mfjCDCysweYN3glq4TqsaBdjpoYalPYoREFD8OA?= =?us-ascii?Q?cJYPc9wu1ZHw8FQhUrJbpX0VHhrO9Jwa7LwDkP8slMz8GOL+v0APA3j1/lkw?= =?us-ascii?Q?OtdsTqzjgV7ppw95CD3EoVNghLR5+U6Kth69xBFUUbd2MDshkltPUqoASvaD?= =?us-ascii?Q?bg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bc966265-ee98-404f-6f1c-08dced3b3e9c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 17:03:09.1610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LA2KPImA+dJnph4llrPv/0vF/dns+SQ7wHaCbMqf8CYXYGrm17AiaqpEELosPCReKvVaOvgNvOq4Q0bRea7+YtzU/i+RsjsS6iZ6jAyKGn8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4981 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 01, 2024 at 02:14:36PM +0100, Bruce Richardson wrote: > On Tue, Oct 01, 2024 at 11:12:54AM +0200, David Marchand wrote: > > Following two upstream Linux kernel changes (see links), the mac address > > of a iavf port, serviced by a i40e PF driver, is lost when the DPDK iavf > > driver probes the port again (which may be triggered at any point of a > > DPDK application life, like when a reset event is triggered by the PF). > > > > A first change results in the mac address of the VF port being reset to 0 > > during the VIRTCHNL_OP_GET_VF_RESOURCES query. > > The i40e PF driver change is pretty obscure but the iavf Linux driver does > > set VIRTCHNL_VF_OFFLOAD_USO. > > Announcing such a capability in the DPDK driver does not seem to be an > > issue, so do the same in DPDK to keep the legacy behavior of a fixed mac. > > > > Then a second change in the kernel results in the VF mac address being > > cleared when the VF driver remove its default mac address. > > Removing (unicast or multicast) mac addresses is not done by the kernel VF > > driver in general. > > The reason why the DPDK driver behaves like this is undocumented > > (and lost because the authors are not active anymore). > > Aligning DPDK behavior to the upstream kernel driver is safer in any > > case. > > > > Cc: stable@dpdk.org > > > > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fed0d9f13266 > > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ceb29474bbbc > > Signed-off-by: David Marchand > > --- > > Seems reasonable to me. > > Acked-by: Bruce Richardson Applied to dpdk-next-net-intel. Thanks, /Bruce