DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Robin Jarry <rjarry@redhat.com>
Subject: Re: [PATCH v2 0/4] simplify doing 32-bit DPDK builds
Date: Tue, 8 Oct 2024 10:05:02 +0100	[thread overview]
Message-ID: <ZwT1viK-06rMnWy-@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8wRzK-ni8u9TT=ZjogEi=ezGjr0d2yGeo3YOgN-1X9kwA@mail.gmail.com>

On Tue, Oct 08, 2024 at 10:38:12AM +0200, David Marchand wrote:
> On Thu, Sep 19, 2024 at 10:02 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > > I was then surprised to read the result:
> > > ...
> > > 2024-09-19T07:22:12.6485260Z Checking for size of "void *" : 8
> > > 2024-09-19T07:22:12.6485592Z Checking for size of "void *" : 8
> > > ...
> > >
> > >
> > > *scratch* *scratch*
> > > So I retested the series locally on my f39 (the series seemed ok so
> > > far) but I downgraded meson to 0.53.2 (which is the version forced in
> > > GHA) and now I observe the same issue.
> > >
> > > I suspect something changed in the cross file handling in more recent
> > > meson versions.
> > > Likely, the c_args= or [build-in options] part is not read.
> > >
> > > Am I doing something wrong?
> > >
> > From the docs on cross-files [1], it appears that significant changes to
> > the cross-file handling was done in 0.56 release. That may be the cause.
> > I'll have to try some testing myself.
> >
> > Overall, I think we haven't increased our minimum meson version in some
> > time. Maybe it's time to consider doing so in this release or the next one?
> > Need to look through release notes to see how far forward to jump to see
> > what extra features might be useful for us to leverage.
> 
> Just a note that I think it is safer to wait for the upgrade to meson
> 0.57 before merging this series.
> If this upgrade does not happen in this release, I'll merge at least
> the first patches but keep the old way of testing 32 bits in the
> devtools script.
> 
> Ok for you?
>
Yes, that makes sense 

  reply	other threads:[~2024-10-08  9:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 13:57 [PATCH] config: add 32-bit cross-compilation x86 target Bruce Richardson
2024-09-06 15:34 ` Medvedkin, Vladimir
2024-09-06 16:12 ` [PATCH v2 0/4] simplify doing 32-bit DPDK builds Bruce Richardson
2024-09-06 16:12   ` [PATCH v2 1/4] config: add 32-bit x86 debian cross-compilation file Bruce Richardson
2024-09-06 16:12   ` [PATCH v2 2/4] config: add fedora 32-bit x86 cross-compile file Bruce Richardson
2024-09-06 16:12   ` [PATCH v2 3/4] config: add arch 32-bit cross-compilation file Bruce Richardson
2024-09-06 16:12   ` [PATCH v2 4/4] devtools/test-meson-builds: use cross files for 32bit build Bruce Richardson
2024-09-19  7:44   ` [PATCH v2 0/4] simplify doing 32-bit DPDK builds David Marchand
2024-09-19  7:52     ` Bruce Richardson
2024-09-19  8:02     ` Bruce Richardson
2024-09-19  8:08       ` David Marchand
2024-09-19 11:15         ` Bruce Richardson
2024-09-19 11:32           ` David Marchand
2024-09-19 12:09             ` Robin Jarry
2024-09-19 12:57               ` Bruce Richardson
2024-10-08  8:38       ` David Marchand
2024-10-08  9:05         ` Bruce Richardson [this message]
2024-10-17  7:58   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwT1viK-06rMnWy-@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=rjarry@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).