From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A03E645ADE; Tue, 8 Oct 2024 12:02:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30D0D4025C; Tue, 8 Oct 2024 12:02:56 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 595E44021F for ; Tue, 8 Oct 2024 12:02:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728381775; x=1759917775; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=3Ina9ZNbcCNeugk/0gy4iOB3MOYfOVfQZu3mdxmQROI=; b=FFL1U7CDAEcn7ekZxHlQU16QcBZBqBZGyV8SKYK+c1rhTfGK1tSq21+D jBMzU83YDv+yWKc8nv2x5Nfd8nMjTbYKsZh7TD6ZvbLXQbxTKUlAEVvM0 mUmWajJEIw54nRg+w6kAJiojayiEijKo5XtMCClj/5DVWIQcZsXbMv+XS rUYaULN/emfWvgeXZ+ysTShgVVOWljcKiigzqdGVEzJs1QcMXz76kymps 1QBV57B3SaG62P8iufa9vfyNNwJZaxicTkW3Rj/fjkj7jQu0oOSEHFiE0 UGE4RAR5knJzvMUADqsZMQvFQdh8vR+xF36MUB8saLdcA0a4oXZStVDsx w==; X-CSE-ConnectionGUID: bVCegdrBT/mEhhRlzpXwNg== X-CSE-MsgGUID: osnnGywyRsKuZbNrIFWpHw== X-IronPort-AV: E=McAfee;i="6700,10204,11218"; a="27450074" X-IronPort-AV: E=Sophos;i="6.11,186,1725346800"; d="scan'208";a="27450074" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 03:02:34 -0700 X-CSE-ConnectionGUID: y/TrQOCGQ12fY9Pd3n8YUg== X-CSE-MsgGUID: qOf9Xcw2QIq2s0aT7rP67g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,186,1725346800"; d="scan'208";a="80571159" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Oct 2024 03:02:30 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 8 Oct 2024 03:02:29 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 8 Oct 2024 03:02:29 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 8 Oct 2024 03:02:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gedNGpNOpk1QA8bCD8SthJ+lCHOuqeOSzgDryw7Y+24l4Vi8WjwZwA1sd5i4gkHWptyYT6VNDScfasPGuB9edd8bcLXQKK+DPcsp03/7oamwYb8sTAPHZZaywwHzXHSUiluDF5v0GegsjHyhdhHxpbGsHaFHD8p6hUjUjbya3BAytcltj895inxRZSAo1zWeKcPPKVXvZkGYkb1isK7Iggbx2ReI3V0hHsrzGovsD6vAgLjqzm1OYB4zpG/PosE1noAzcf/Ln1Fzwje+6zWeQDYKyH0nULchTF3yocdRCl3oUgZCxDqYjjCfqHsWDZiWsqElF1JolfolPNrTvs4s+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fAgeo2iRp8UHdptGApAsVSrhKrCeb1Vmmas3j2jj1QQ=; b=kVpQ0Cd30KxtIe5WUEAlKglK0xwGs9em6VvUDs1TJ+CtysPSUOd2F+3A5AL3ECQ/xd1Pmqtl5DhaGmnavrVIlgcQaO6/w01vrnRckJ7vOl0vK4cJ7Nq6G8Zw4h5HZB2bB2JwqNy11DYC4UiCtZsKXzbxyZmWgSnNGZgfLWP46ZybVOpW6TBk4FOmIQjFryctaWdCByX3qM1X8VAq3T+ClQrImHgfes+iGKoDNVJhWfaABcQuDMACiBo+29A32N4SG/s+ld9BUckCbEZcLxz7HltMlW6573gknPU/Q47xm5gbvA1r5bM2YqpNpxDfCT+jA5GMcRxyIWjA4Os8qFnh9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by CY8PR11MB7845.namprd11.prod.outlook.com (2603:10b6:930:72::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Tue, 8 Oct 2024 10:02:25 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::2fa:a105:f81e:5971]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::2fa:a105:f81e:5971%5]) with mapi id 15.20.8026.020; Tue, 8 Oct 2024 10:02:25 +0000 Date: Tue, 8 Oct 2024 11:02:19 +0100 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH v2 0/8] centralize AVX-512 feature detection Message-ID: References: <20240930175033.2283861-1-bruce.richardson@intel.com> <20241001111802.2728765-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB3PR06CA0011.eurprd06.prod.outlook.com (2603:10a6:8:1::24) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|CY8PR11MB7845:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bc35f28-e1f0-4b96-b65c-08dce7804f17 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SHV4Q1dBekxtK3RvWVg3TDdPYlBxZXZCMzRZZFJUUThyMWpxckJqTFdNb0pR?= =?utf-8?B?a1l6dFcyUXJSU3MvZ0h2NVlJY0w4NllWL3BDZ2k5YXpPRkxnTVRTclJobStx?= =?utf-8?B?MEdYVHZJOWE4aTh0UTJReWMvSVQ2Rnk4ajI4R1lMK0FxL0VOa0hKZGVCc2FQ?= =?utf-8?B?ZWMvRXZUczdrSlhKWnUxVEhFR2dFUEhFalZ2eUlCbGJ4SHA5dHNHZnJGQWJY?= =?utf-8?B?bkFZV3B3ckhaZnJUVlM2ZDdjWW5HaU1jaS85Mm85NE9hTzl4SlpDWjVxdEZX?= =?utf-8?B?RzB4cVNXQkVvREkwQW9Na2taMGk1NldKSUdnN1dudkxqWXNKdkhVeDJGbXVQ?= =?utf-8?B?MU8yVFl6WEtMLzV6bmF2NGVRR01CbDdIY1lyYnU3eUNXTlpDSXdTcDNqMmt5?= =?utf-8?B?Q21jT0RkUnlWSW0vS2JpSnVwTjIwK0puSEx6cDJOeTRackVPL1dxWmxzQURQ?= =?utf-8?B?aDdqLzZPcFZsL0piK2oxWUdVcG5NK3VMYUx6YXpIMVVPLzJtU2JVUWlrY2N5?= =?utf-8?B?YjJaZ2U0Tzg1eFZPUlFXMFBYSjhuUXR5elpJaDVuUU41R2NoS0hwUmFkTHh4?= =?utf-8?B?d0kzSkhGZEJsS25VdytleXFGT0hzRTRVSFdFN1g1R3ZzNWdrem9JUjh1Qmtr?= =?utf-8?B?a2VZTnRrMVhBWUU3YzZVRXBUa2RBb2ZEYkZLTmVFZXJHU1lWOXNxQnFXZHQ4?= =?utf-8?B?eFdjQ0hrZVNyQnJ6VjFpeHdoSEFVMXExY3M2M21OV25UQi94WkZVVDlLNzZz?= =?utf-8?B?a2tpUW0yVXU5VWxodC8ycW5OWHVNVVRUVWVGN2I5WEVFczc5amRUbURQTER0?= =?utf-8?B?TU1RVWpDUEFEOHJlanJpRVQzdkxvOXFyektCUjFLS28xTUkxaFcwQk1zaFBs?= =?utf-8?B?OVdXMGtMOGp1MWQxbEI4djYrcGtqbkxrQWRtbEE4VTR6Mll0TWRwRFJoMnov?= =?utf-8?B?VkV0cmhrcENRalZ1Z2ZLbWk2aHVZY2ZGRkkveFl2eURHRFVzZ2tRQ08vbzJi?= =?utf-8?B?UisvMHhwTjVWVGQzYytualFpam5iZks5dU1WWG91Mk5vaFFuL1Z1elJNNDdM?= =?utf-8?B?RThvNGE3cURPbUgzZHJrbFBPUE1Nc2hQckJCOVFoY0FVU242YXpwUm9BYlZw?= =?utf-8?B?d044L3NmNXZlS0cvNEhQczJ1UVQxVlMyYXRNZEVKVDhFWjd5eFFuMUJyT1hh?= =?utf-8?B?dTFOUGIyMzdPZWg4ZXR0c1l1VGlORHRqSkhxMzBjbUdtempLaFZkc3Q0bTk5?= =?utf-8?B?WTVYemFPQWRjSGM3MmdXa3pXSzMyWXVNR3oxc2FqS0RNSTdjdk92NWRHbUV6?= =?utf-8?B?T3kyMHh4dlZLTUVocEt4UEJDVmZhZzJWdkNDc3FlSEYrZGh1ak9VNFRsb25F?= =?utf-8?B?SXlzYjRxUmhjaWxOcDVqWFB1YlpYc1RzK0RXcDI3QUZIbWNXaWMwWXQwTUkz?= =?utf-8?B?U1IwdWVQOEVJRDlVbGFGbGZwTDhIRVdHSEhRNDNlR0liZlJWbzNUeGZwcjJO?= =?utf-8?B?NVVjTVRPVi85VkVEK0FuSzJLak1xUnVyN2Q5a3VTVU5YalFIL2NTenJNNWc5?= =?utf-8?B?aDRKMk9xSFI0SkN1d1Rvc0M3cjRiQi92OEZNdUhWWFo4QVZjdUcxbEJqeFEr?= =?utf-8?B?ZkpsVm0yYnMrZTRLRDhDN1Y1Z1dlT2dCbGtxQVpIOUxhdVZoblMxUURpc1E0?= =?utf-8?B?bFFLREdUQjUzWEVrSkhSTFdkYWwwejRhNUgyQkI2Q3pkQlJHSWtSRWNzU05m?= =?utf-8?Q?7Vf7pOWEi1JIafBbgg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEw3ZmtmYWNsem5ybTFZREVyK3loaTRFN2xVWmZNeEQxWTlwSEVLcHl5YkNM?= =?utf-8?B?N1hJS0ZzaFEwbHJqZUZRR3Z4YXloUklTTDhVK1hhei9iUjlHcFlHUkNGZVRp?= =?utf-8?B?ZlM3RENiby85eDA0b29IVENsVCtEazBvQ1FtVjVDTkQxa1kyQ2hBdy91SEla?= =?utf-8?B?a3lxbUNmSE1wd1F0UDJvU00vUkEySjBqWXhsc3hKSk0ySHh5S0pRV0JlaFVu?= =?utf-8?B?b3V6YXpVcGJnWlFjakpmc0ltMytSaW02TXdZd1ZTaHJGcG1ub3hJNkY5YXZG?= =?utf-8?B?ZHl4dTExbHBBWE00cWtZSC9PVFJZU3ZYNkdaUWlUbFhGTmhva1ZnRFdpVzZU?= =?utf-8?B?bENzREhKeFJvTmpIbDRPN3FMU01yaEpIeXlFWUZXQ2YrSW94NGp5UmwzUnlm?= =?utf-8?B?d0Urc0RneTdvWCt6NVd0OFp6ZHB6enhaTUZMZWxuZ0FHSlhHYWw0dExUenpo?= =?utf-8?B?emd1YnVtZUJZSkd2dEF4YmJ4RFZYZVlOdmhzcndTUEMyQmZpNjBrZ2IvSGNp?= =?utf-8?B?Y3BEQzVwWUZoMWM4b0NsUjl5T3hxclQ1b0xzQUVWclBQTGxMUCtydU5kb1NS?= =?utf-8?B?eXlob1k1NzJYUlBFY0RiTCtUZ3o1Mkd3U0VwOVM0a1pWMXRhbTAyZVRoOUx5?= =?utf-8?B?Tk1GMkxEdFVyRysvVEdIZHdrR1Y5dUN2SzdMc0s0dmJJOUJ4MmZTSUtpRktY?= =?utf-8?B?NVRlT3dUVHIwdjVQZ1ZSVFRtWkFMNUF3TW1uWkFFU2c1LzgxNENBT3dYOHBE?= =?utf-8?B?eDVtTTE4RDE4RDZidG1yQ0RDWnJ0QVEvaHBFZDRWV2ptbmN6bTlSTy9NU29z?= =?utf-8?B?aUdHYlltMFBLZEoya1pMaHZKM0VrdzIyL2xFdHdJYUFGU0wyT2tOZnNraVlP?= =?utf-8?B?UWxWc1gxZEhWbTJZOSsvZWs2dFY1QWc1SDNDYjJlNEQrS1RjaG9IWUZqZjk5?= =?utf-8?B?ZTRrQjdhRkVNWTgwK3haNzJ2V1ErOUt2UVNhQ1F2WHVaenlZZE9RbkdzMTdm?= =?utf-8?B?WDcxRWd2bDdkbjRINHFSaWlNcEVWWkNCK0poTGIyWVhudFhsOERvSXJKZGhZ?= =?utf-8?B?Ull0eHRyY21UdXN2UktDeUpZRzdmRmNjMnIrU2U5N0trYVp0MmdFNW1wL2Fi?= =?utf-8?B?YllRRzRpSnhJVk9KTXlJa2xDOFdDWU44OFZzZ1hqNGlldEJrV3N5dTA2TG0x?= =?utf-8?B?UFN0ayttUERCM1dsYVN1SDVpUTZnQTg4bUtVZmhXWUFsUm5QeDZmTGM0V3B2?= =?utf-8?B?NDRSdVRwZXN3R3Vjamp0M1pBSUhrbThnWUxaKzJVaCtleWVsWHc2VWlPZFdl?= =?utf-8?B?cEN2WER5ZHFJYVZFTlh6RWlZRGFIM1YrSjNkbTdMYTIzYlZTaExBaTR1WkV4?= =?utf-8?B?b2pLTGtWNXBlQXFDUkZla3BXTGJUVGpPd0VJTkwvS2dEa295a2FMaEhpcGow?= =?utf-8?B?M0tBdVQ3Qng4QmJNYzVXRlR4UXluQXFOYmhmMUFaR3dGbVZtNHZNVGROQkc1?= =?utf-8?B?ek82MXIxYU52V0gxSFdGQnVJNWVnZzFpdnAvZUVWMSs3SGk1OXZtZUlhSlVL?= =?utf-8?B?Qmh4WnBWa3NXMTVKUUFoY1NPRG8zd0w5dnNNTTVUa0pJZHA2VGNjK3ZtbFBa?= =?utf-8?B?NERtZERRVGpudnpia1UvUUNLYk9sV2NoVXdRSDFLejl0dENaclZUMUVZWkln?= =?utf-8?B?MGp5MzVZcEZVS1hzMmxiM0ZUeFh4dy8vdjhiUkFWQkxzZXR2TnVZazM1QnJL?= =?utf-8?B?VFg1S0hpdnFaY0VkM21ROWRIczc1Qzl2T1ZHR3NFRjIrTkFOMHJYdWh4QzVa?= =?utf-8?B?K1ZzdGV5UlBkV1hmUUowb1FlL0UrdmR3cHEySktkR3lFdFlXZGExTzZhbjlI?= =?utf-8?B?VlFTcDBKZjFFdGlMb09wWGtITG1WYlU4bTNTMVdaZ1VPYXdHOXAyZ1FLMFlW?= =?utf-8?B?MHBEdnFhN3k3YVFVT3ZSNFpmTXZ6cUR6cVlzN2Nab01MK0ZSL1NVSnpEK0tm?= =?utf-8?B?L01paUh1WlIyV1dyUldLY3R3Vkd5V1A0dTJtamlwTWN5M01XOEtQajdEZzBx?= =?utf-8?B?MVc5N25MNDRjdW9QVTNUZkh4c2ZaOHNad2pmZmxEZGM4RjE0M2w2NElNbnl0?= =?utf-8?B?cUVnTnR1N1B0N0cwNHkvQ0Iyb1gwWitJVkQvc3l2WU1uSUs5ZDlzOGU4c3pq?= =?utf-8?B?dXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2bc35f28-e1f0-4b96-b65c-08dce7804f17 X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 10:02:24.9536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: glu2D18XFU4chNi4VWDx0ZfzCWqgoIiRjgxMOWBHGnL3AdPc9jPKvS934/36SPPP3uPlnV5BN6ehK+Rmtn5YekVYPvL9oAI5jhL6/BkAjo0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7845 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 08, 2024 at 10:49:39AM +0200, David Marchand wrote: > On Tue, Oct 1, 2024 at 1:19 PM Bruce Richardson > wrote: > > > > The meson code to detect CPU and compiler support for AVX512 was duplicated > > across multiple drivers. Do all detection in just a single place to simplify > > the code. > > > > v2: ensure that target_has_avx512 is always defined on x86 to fix build errors > > > > Bruce Richardson (8): > > config/x86: add global defines for checking AVX-512 > > event/dlb2: use global AVX-512 variables > > common/idpf: use global AVX-512 variables > > net/cpfl: use global AVX-512 variables > > net/i40e: use global AVX-512 variables > > net/iavf: use global AVX-512 variables > > net/ice: use global AVX-512 variables > > net/idpf: use global AVX-512 variables > > > > config/x86/meson.build | 19 +++++++++++---- > > drivers/common/idpf/meson.build | 17 ++----------- > > drivers/event/dlb2/meson.build | 42 +++++++-------------------------- > > drivers/net/cpfl/meson.build | 19 ++------------- > > drivers/net/i40e/meson.build | 13 ++-------- > > drivers/net/iavf/meson.build | 13 ++-------- > > drivers/net/ice/meson.build | 15 ++---------- > > drivers/net/idpf/meson.build | 19 ++------------- > > 8 files changed, 36 insertions(+), 121 deletions(-) > > Thanks for this cleanup, I have two comments. > > - Some drivers were going into great lenghts to check that individiual > avx512 features were available. > With this series, we end up requiring support for all features to > announce avx512 availability. > Are we perhaps disabling AVX512 support with some toolchains, out > there, supporting only part of the set? > The various AVX-512 feature sets checked for (F, BW, VL, DQ) were all introduced in the same hardware generation - all are available in gcc when using -march=skylake-avx512 or later, or -march=znver4. On the toolchain side, gcc introduced all these flags simultaneously in gcc-6 [1]. For clang/llvm, testing with godbolt for compiler errors/warnings indicates that all these 4 avx512 flags are available from clang 3.6 - the minimum we support in DPDK [2] [1] https://gcc.gnu.org/gcc-6/changes.html [2] https://doc.dpdk.org/guides/linux_gsg/sys_reqs.html#compilation-of-the-dpdk > - Some drivers were checking for presence of -mno-avx512f in > machine_args as a way to disable building any AVX512 stuff. > This gets discarded with this series. > Yes, because it should no longer be necessary. The places in the build system where we set the no-avx512f flag are reworked so that we don't have cc_has_avx512 set. Regards, /Bruce