From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D52045AF0; Wed, 9 Oct 2024 10:08:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 913DF40653; Wed, 9 Oct 2024 10:08:14 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id 17B6D402BC for ; Wed, 9 Oct 2024 10:08:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728461293; x=1759997293; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=72X1ieVKSuYhYG7fwYlszR7xc8FQ1twJOnq9tjUcwog=; b=I7zXufo0rF/wAvLgIUnM6t0xENAbDnyTqVrocjLeVjGUoiF3jvycDC1b g9B+fgqyTwEnnMVenDxE3fLDk9JszXHXsXd7csgSAbn8P6icBjDy4pvpP lpkzccFVna9uZIHeNL6tsnQr/D1k9t855SkwCbL9ZHlgCtM+vEDNvacJz ODgw+ptjhf9Xy/NTBCF8DQ5sx/JuaMvizo18VP6rjZMNUNvRIUW1YMGD2 z5/W659x0YOc8297L7EOPvLefFj4GNir4xiAdWd9yL8/esv5xIxf97R3f 0pN05xbxrPYD0CNXC9pgGg7cB9GLJn6ud0T73jA1MHJtvBZFFsqDn3WYp w==; X-CSE-ConnectionGUID: CoWQn2YKSEihxh6IhF5HYw== X-CSE-MsgGUID: XD/aYxIzQ/2GeO3SMtuacg== X-IronPort-AV: E=McAfee;i="6700,10204,11219"; a="27829404" X-IronPort-AV: E=Sophos;i="6.11,189,1725346800"; d="scan'208";a="27829404" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2024 01:08:11 -0700 X-CSE-ConnectionGUID: oJ1ORphHTAKweBdOPny8eQ== X-CSE-MsgGUID: iQYyH3v0QDi/779KFY+iWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,189,1725346800"; d="scan'208";a="80746808" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Oct 2024 01:08:06 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 9 Oct 2024 01:08:05 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 9 Oct 2024 01:08:05 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 9 Oct 2024 01:08:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bfnpbL2LK1Ca5l4/jXZojmhDj918LArewNF/BJMQMDBxGtf0u7abSMBEQ94YsyFBX//HvKb3IwSVNGUxIENiPyKV8OvvLs8yd1naxiXCf0S9ui3egZbu7YeE80c0lIDg6KitcOw/QMPCJNGAkPshts2dLkPgPwP+XcdBfUauwMo+xtclfqEQvJzt+j2fRrCwDlf79QNF6IDslW6z2o7cj8FCsfdIICLs1O21LXsT0Q5ck+hZcf+OgKKlniro+Ypre5M6P/KWVhWPBoIq1HIrz5uHT0p4+Ui35JKM19Tz41UQWEkzWppRMiB7tCp3pu+YRRG8ehAeBbyCFJjNBMIZkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D8MP2PUB4YJzqoDDeukrOhwl/r/ukydb1JEwAECkTJs=; b=K6icoSRganMSjgBeInMakrmsSivc0zscpv5NVbzhsB0jQnrcQUaC3JNCdwoIeWB51hVJpk4LSaDesNCKX9h6c1GG0stPyC23LX7IaYNdHBQSt6V3NG8T22nIy2O0TXv/1jYJrISFW7IgrgNadDMkmGeNVVhcVUR1oFJWAv0cBmnn9uB5B/4the4HUcxS5qMjibXX28SAc8fyu0gB6/ps1ycvsWlsURLQ3zSdAsMNznPyKlSf6LzWp38j7rdMhDrc+kv2PXPcVWKL2CsVLKY1Lq5X4xlOE8uEFypZkE2+UvZJO6XbzjGhN9THfY6koKbU/Mpe4fm0IIEi3CQq/Hu4gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB6653.namprd11.prod.outlook.com (2603:10b6:806:26f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Wed, 9 Oct 2024 08:08:03 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.013; Wed, 9 Oct 2024 08:08:02 +0000 Date: Wed, 9 Oct 2024 09:07:58 +0100 From: Bruce Richardson To: fengchengwen CC: , Subject: Re: [PATCH v2 1/3] ethdev: add traffic manager query function Message-ID: References: <20241008105350.1396216-1-bruce.richardson@intel.com> <20241008144320.1632138-1-bruce.richardson@intel.com> <20241008144320.1632138-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR06CA0065.eurprd06.prod.outlook.com (2603:10a6:10:120::39) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB6653:EE_ X-MS-Office365-Filtering-Correlation-Id: 05597d48-5492-4439-a66c-08dce8397f56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hGXWr1452lknZu56pWDFl4/4jrmydN6PDRIEs/L0YP5It6VNOnZHIEC0xbIk?= =?us-ascii?Q?rnwuPCLHOBUdItzigsbWwX8DxABVw2WKahSmlFv0Np59sGBicFI7XFwTWf/e?= =?us-ascii?Q?W6a59Wmm1lZxUIehEEB5+PQQ1c2qp4CkxIZL3nUyF6Lf2kKe3M9CfhKrzG8Z?= =?us-ascii?Q?W0douDr7ky73O/GM5fgh7WxJkOndVmkvJM7BLr1TJ3hr0/0IpWM9Jq7OrM3E?= =?us-ascii?Q?nFgK6mZSL6ckMDRxXvGiOcXPmYnZH0cvwFZwOFcLj0IBMwGJxunpd1oqLQCD?= =?us-ascii?Q?rr1+p9We+KChHrGXJK+d2lQajCluRH6aN/0l5RN/09ZJosm4mQmFWgHAH0Dw?= =?us-ascii?Q?7P5rNr0fx9Yv37ceo1NDGYR2n45r2/F/jNA15sxuLVQYbazTyTdGmXAmWU0r?= =?us-ascii?Q?WDDVtkUvHqHTka5YuFMnFbx1HeSQkdHhwh+9UCqwBO0c0ZQfmX7En4Zn77WI?= =?us-ascii?Q?vVsayLS7Jj9rOJW+4UJK2u48AqEfs4dNCRnyS6zYIxKzu0ugND0bwJiFheO1?= =?us-ascii?Q?unL7LSzt8vojRoez7pZu+EkPX4zSGXau4DY/CguNdThNFqthLmiYJnE420V3?= =?us-ascii?Q?FY5jeUn9oDrGL32rGwING5BHGvYpHa86kReMj3o9l1B6G2WqcdZvoPpmGHkp?= =?us-ascii?Q?Kta8YSuJNh7/TFD4qcr1y0ucr8LXXwkjbFj+Ro29b19NWsyUV7LjH7/SBXqC?= =?us-ascii?Q?4a61QZ0IrjkRqPgEajlrMQo7sGXlgVvouuHBnuulngHusnUYAyINJBVe2ncM?= =?us-ascii?Q?NIp0BszcuSQsvM9Bk6i9LF9l6L4MtYw5u9P/2/g9bMboEdNPVYUP+b4yeSEi?= =?us-ascii?Q?M9BvqmtzDYZVRNGw5xDcTHesLzWSIp2yukgkMaylgVKZIQTmE9ar+uqxh2f4?= =?us-ascii?Q?Y5/i9RLMzaZtXQ1yGcI1dO81Q83LbNRS+TMHUsePurW0d1K6ndaTZZUHl3OM?= =?us-ascii?Q?Z+02nL0Lq/JWCEFypRX3DZtS3g+z7ZhzH4/MVcOg6WFgnMg2FoFLxmgJyVom?= =?us-ascii?Q?ejVA0tuSE/2awjAtdcS7TKbN4JURBpwel7T8kzupjEdR1eYQNNm3dcSv/jC1?= =?us-ascii?Q?N2wR+tq17x/lvu/dPLY+Fxr5hK8zVCm3WfzyHLU02a/Np4VTMu3JraBraers?= =?us-ascii?Q?l0yYOh9UjRTIgLMgLMHkRNy+m0/Q0/mIo5gVA7e66+tEk0XQ09itBJ0hu+Z7?= =?us-ascii?Q?FHltRS/SxN9C7rKv7Ug3OVWfVkXFQDWm5pETrQ9m6R9Nuu4MWgE/RM+RIEQz?= =?us-ascii?Q?iWpfolbhgPukDdzNTvCCdD7A4rEXieF1NRbQlqKxSg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jxuRTPBEa677pQsdvDeBETTGV9uVWLFz5PbCj2vM8ZFaQSowjZsmOHJr4HRh?= =?us-ascii?Q?naRW+4+Esyc668YoWFEOPV5WxoVcw5K7o8eGmZ8l1wUx1UsKGkleCmAZnJEy?= =?us-ascii?Q?ritIkwr7IIdDRVuJie8mfk1Eri2wsjXTshQUqUxJZsPQdyKwU6PsmbpXilRw?= =?us-ascii?Q?fus9fKNPdX5Ya11rwpjH0aAwltetr6oLDQAO57aB+u/VW1lNCu73sFRfRBx9?= =?us-ascii?Q?ng0WnsHZP0qFPvIV+1HH2J80KPV4hhjynUz+59X3MdjAyyGFd2mNxJC2VnW8?= =?us-ascii?Q?YVIAm7Ya9loKLWtyAht5/Imy+uomVbEmyTfRGak5oSfciSbo4sOhA5aIVlzX?= =?us-ascii?Q?QGGuQZYfK0uWJqPxZ5DLbM912JzclDHQ/Tx58IGgNn360FWFin/7fxfN2Emd?= =?us-ascii?Q?bGYhF/yYJOQJTvleAwlCQqcwKq6tA+pf5n4PWLQRarlBcVx+RTx2Spc47e3h?= =?us-ascii?Q?sng6zeeKu2Jg6h+BG9yGkDhNHzQiRGPujJr5+glPsNDEJbxWNVC1AZrrl3Y3?= =?us-ascii?Q?hTCP5VOodJBkKdqPC98lL3TExZHbH4PjyI/lU7K8yYgANchlcfxpBWTZodyd?= =?us-ascii?Q?iAnjoHX3xmxA++Ppsq73EgqaTv/uvOJOGjMU1ny36IsS4AgKC/6hd5dYpC3+?= =?us-ascii?Q?IgBmtB2O7MSVv89HwQLrfPldTgm6ck5ozrvXwSVurpf55ZjU7wQNfiS15fWx?= =?us-ascii?Q?bYoWg04u99e4YCyKc1ttT5jyfQoPZJzQM59MsgKIT1DXtKfUa+GuQ7SAQLzF?= =?us-ascii?Q?J27dDTjXPTpR7pWzyp3ItqxGw51Wzj4Kw6hmJ57fNOcp7NX7Y51X4/n9Pqon?= =?us-ascii?Q?7PPObzJLPhgr2ku2hnmZdboq4rs9q7PWTY2MW6PYQNbTu3coMKtRTiWoNt4/?= =?us-ascii?Q?sKu/u1oxU1KdmfhhDSiauAfoxT2dx3Ix5tYtJBRyZ8hFVE0wWHlezWmsX1J5?= =?us-ascii?Q?ooJX/zSaZD7BC3vRA5sS4xeEA0rG5l4DvrZ6QUGk8UpQ2c6a2w6hI27FlMoJ?= =?us-ascii?Q?1mWeBOryJtJRpH4NN8JplItqTFyBlvXECHWTvHSsc+ZGWvF9CMuIIPwDD604?= =?us-ascii?Q?pQUAzgGajwDzenW5nYoRqfnfnXDicB+Mb9AalSeadkXNoUA9w3jOEhfiBo9L?= =?us-ascii?Q?49q65UNBxVKarJ8NoahwStopGrjRjUSIkkgLOvsvRk3iA7xQYLxCPvXPoCh2?= =?us-ascii?Q?kq3lQYjqrqJm6cyXHAEqNUbAyEc4OG9ExVHqdWSmPc7Xhx2+JqgX//WL9gwC?= =?us-ascii?Q?DyLlKb10tS1aOn9DB1S9GzkfZC10wgUv/Tnv0sqjLBKYkKFqH2qqwynwH3q8?= =?us-ascii?Q?epRPew+3W1owMl+j5dSszA+B3ECYwkRzxArFYp+/mQ8RPJlUxEQI3FYJJYZs?= =?us-ascii?Q?wg9eA3NXrcBeCI9GQ7VLA7GT4LCf3f7cNejvKsq1Syk1pl/DtuQ0OrhxCrl4?= =?us-ascii?Q?M3i90PL2Z3moAKtaB8qiFFmq7YIKgNVPIu/6Vp8RUX15FFWPaeUuSrQ8C0dz?= =?us-ascii?Q?zseUlNFcWEyhgO3ViXbhd/uWA5hjofdPNBs4oa3hHXpe0qCCEzuujOW3Cv8Y?= =?us-ascii?Q?M5Ua0KCJt2Do7jt2dgB66qwEGfvy/tttCV2AAU22NObtBn9YcX/bNUOCYgAM?= =?us-ascii?Q?6g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 05597d48-5492-4439-a66c-08dce8397f56 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2024 08:08:02.8828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: clzrINUvgFy7YzAWWRS+BQqGzjq7SMTy3maKzCIJesX8+VLjMCyw+ktBBGeB4eFargF0FJ7DDikil5wuZEnVGBsOqrHZzS2+LvONHcXEJu8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6653 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 09, 2024 at 08:57:41AM +0800, fengchengwen wrote: > On 2024/10/8 22:43, Bruce Richardson wrote: > > Add function to allow querying a node in the scheduler tree. Returns > > the parameters as were given to the add function. Adding this function > > allows apps to just query the hierarchy rather than having to maintain > > their own copies of it internally. > > > > Signed-off-by: Bruce Richardson > > --- Hi, thanks for the detailed review. Most comments are fine and will fix. One reply below for just one of them though. /Bruce > > + */ > > +__rte_experimental > > +int > > +rte_tm_node_query(uint16_t port_id, > > + uint32_t node_id, > > + uint32_t *parent_node_id, > > + uint32_t *priority, > > + uint32_t *weight, > > + uint32_t *level_id, > > + struct rte_tm_node_params *params, > > + struct rte_tm_error *error); > > + > > Suggest this new function place after node_resume in header/impl.c(e.g. source or trace), keep them consistency Why do you think it should go after node resume? I deliberately placed it after node_add function since the parameters are matching each other, whatever parameters you provided on add, you get returned to you on query.