From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A010345B03; Thu, 10 Oct 2024 13:39:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F0A84029C; Thu, 10 Oct 2024 13:39:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 1411F4029C for ; Thu, 10 Oct 2024 13:39:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728560389; x=1760096389; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=fb3y85xIlmK0cCFF97wL3j/WYNkG/lP0EyZWxHBNQLc=; b=i81HFEWq+hwyHMFqckHQTxgNoUuMBGjupaShIz14Qiht132f2bkhE4TP 7D0M+RvJQa8o7SfPPVglt0THMBy01jg8ZnTYQ/H4Qy7M3KRDdBRI6vUoc hOWA6lu0n7b5CF6BLTDOVHJPb6KmeY+Aij3svvnxh6mv994su6yoSVRr2 QfnZkCt3FnQKRi81fHv6qMKUZGIbY7pbVdrRhBOq7lbyC9/C2fad9E8mC uAdh6YZub60KuK9fdm4vk9GWWvkYxG3IaBeCP8XpAwj/8yFgwer5h5XoF QQj7dTkMR+j8adJf0s2JHp/w9ozp8jaA5YRqbunejziea+WGxSS4gEhFb A==; X-CSE-ConnectionGUID: mhqXLks5TZCGSMR+uZBhww== X-CSE-MsgGUID: rq6hmU83SeWvja6I2ECiug== X-IronPort-AV: E=McAfee;i="6700,10204,11220"; a="31806768" X-IronPort-AV: E=Sophos;i="6.11,192,1725346800"; d="scan'208";a="31806768" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2024 04:39:47 -0700 X-CSE-ConnectionGUID: GqZ79KcYSWe1QP7FBhO8AQ== X-CSE-MsgGUID: MgH/B6toTjqYJGzNFvrb8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,192,1725346800"; d="scan'208";a="81130613" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Oct 2024 04:39:43 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 04:39:42 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 10 Oct 2024 04:39:42 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 10 Oct 2024 04:39:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sECGSUZrCD0rXte88wrDE0ljSasfQiduKYW4F/ExA8hj3RmbfigxtZLeOqOSRaCViW6qVbH/tpNetaLunryZWav7EIvqysReH+7Qdl0cLOB8scf4B4n1OkITS4cMQV8fnLtpbj9NxORUDopoqZ2KHvIcVPBvrs9wcdaWzWOELdpKaoNOaXp7U7NCDtLwixhcjUWgqXrSM6pM/x0b7W4mZijoAhgcU/BrwB4xP/7KDrjle9BbZUuus+HF+4fLvtmrV6WVfs65mDl50QWo7xSADyzH6QTTmAriHo1leAnpI5El/h66Do/zRxAbT0eHo7hLs8l7DZVJyGM2cRVBz/KzVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1P8sbPXMJELcKZ+6An5zssOOcuzERK6rPSzb4s90AOs=; b=O0WZC8au5UROfurtgxAxXhCg8ZwP9daoYuusiKYqF+uW3X2ug09Evj6bgkGQaNvO851bf0zpoMO2LfPDH1Er7oz1BPzI5CngkYpCot/6C7CZGViA90co2lflg/TUM32YxEiqGVobs2vOhYoj2EJ0GVm0wGbHVawuODYdjIvTaiFT1ZkeG6ohh4PJ6kjUsx1oIq1HEiH9UrOvJrloHmZfbHMLopsT9ywwTkriaFHHyfE5UoqMtS3RNBXWDY8/9YNxtNHDpZj0+I7mBAzTYRB/73UKfSft8cA7Ri3MCrlUgt3DAt1gZlQHx1vYsAjT/8eJ9BhZEt81AkEs11DGd3nmmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB6147.namprd11.prod.outlook.com (2603:10b6:208:3ed::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Thu, 10 Oct 2024 11:39:39 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.013; Thu, 10 Oct 2024 11:39:39 +0000 Date: Thu, 10 Oct 2024 12:39:34 +0100 From: Bruce Richardson To: Dmitry Kozlyuk CC: , , , , Tyler Retzlaff , "Pallavi Kadam" Subject: Re: [PATCH] eal/windows: define standard file numbers Message-ID: References: <20241010095434.358810-1-bruce.richardson@intel.com> <20241010134341.142453cf@sovereign> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241010134341.142453cf@sovereign> X-ClientProxiedBy: DUZPR01CA0171.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB6147:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ed069af-0392-4258-fd4a-08dce920398e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2wQ2JHKWxnaP4tZkcAajbVovs2ZN/JZpkoxWXaktNxK/WW5sWpu58UBTsAPf?= =?us-ascii?Q?mDMtnwmHsWHzTZnPTsQNMRbalT/2ZecPrwt1GuRirAQ6rr6ggF8d5jU/CB91?= =?us-ascii?Q?em+AGarMCJH+XWYHuzAnETuid83NFTWZor0wVrJ39iYMlsI+ody6geeVvs2b?= =?us-ascii?Q?lIKu4cWMtEypXlBeJqMUG6/PySRC8uwNLuoDEhEOVQqMjYl3ofWrt23ft0Q+?= =?us-ascii?Q?w2fLjM542u0+auVF1MnFEs/6EngYL42u3aY2ygqdhveV2N5B+Tq3uLIDOH68?= =?us-ascii?Q?OSKUyNQqCoW+VOYAwRVe15lPcqLOSQDSJwuf5HnFpC5heQ9gq3+Kcr3OR6YR?= =?us-ascii?Q?0opHjsnLLdVvxl9AdxgNoVXxheHeYPpOrBJQgxfx/JOYwSxajIqPpSr1rQgA?= =?us-ascii?Q?1zJriXj/i7lyrKDHC2Bl89stjaEOoZbvuJiPQOjggSvsLQvesEw+APuh2EOc?= =?us-ascii?Q?NFsfi2Gls4+n2mjmZaCTIW9rti1zIeiCNNGh41hQ+QrjRtU4hZ7K8Ad/t4Ju?= =?us-ascii?Q?417PF7rPJOu6UEYQLr1Shs4uSBx5QOUOjD1BTe12Hc44Q3gHTFBC/Juk1qwn?= =?us-ascii?Q?dzqAW45gLNDsJ9ts7twTxa5LyWInhiKP1LzOoSNAywOKiVHdd05PxdeAvK1b?= =?us-ascii?Q?i9qXSxFtMHWDhXKIUK83PEESPePUFkHYvnj2wLDEh0a2YXJiQNTOVBUeB+2j?= =?us-ascii?Q?bP+rZI0K3Tmd579wDzd4YRcXQDcmXI1Q+eQvArNBwgyf1QLOL/bfrArZ9Ir/?= =?us-ascii?Q?FuHclXjgA/9VqtXEiA20dui5ZfNGOincRzEmRpYDlp7YSbJYUO7+6qcOfEI8?= =?us-ascii?Q?SXfleUAhjYYlUoFvQxCgsT+91y37e6kNDw7vzOP3TUSW3XPasxpoZ4U+4KYT?= =?us-ascii?Q?8b0MdvhNXhoqs+t4kF1yQkVSSI5zhGTZuekV44u8SVSgzrpNki1sJ+k87hJi?= =?us-ascii?Q?Caoez1ef1JmWah/WGx7z3o8dg8IrZ5bisUs9ziSXtgUvYHzUxl8vKEceNdFo?= =?us-ascii?Q?OG5hNSEImkLfdL/P/l8n4Hs6WI8VVaPm4HKuImk41TUblWhEM6XSjDj9mlJz?= =?us-ascii?Q?9UvlckqfqvtbUB2Fcda+ugDmH5rd0+yIs1ZdeN8mWrUhlX5etMR4gH4AsN7e?= =?us-ascii?Q?6Z4K6kdEPQFaQxK9jBystw0E7UQk4WBEoRkm5FUMYUUKqxu6oJpslrA2GTUV?= =?us-ascii?Q?wYMIWRn8y9m6YEKd7i39M7/qsoAnzThJEqZpuK5av7IwhSsYV+pVbPtQEhU?= =?us-ascii?Q?=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BlKyJdGsBSMeQ3re1ptW/gQ4K8gz+XX8LUsYXOWJnBiNUk4cY0JdCHN/VIut?= =?us-ascii?Q?jDu7sLIEUrQhlTMxBzhjrP2YAXlHkt/pEfRnAu+k9JtMUTJ3bRH6JfspZqv5?= =?us-ascii?Q?bqEZnWAHAhee6iyNo00oubvwGFhd4uWPxxUmTSAh0dFEz4LL30ukKk7PX3BI?= =?us-ascii?Q?XHGr6vQL1ZMSQqEBnbS6IbWHVm6X0Zig5GZj/ahodwNHTlEoLYswEXtOyhje?= =?us-ascii?Q?WVYHA2AUUTtRogE0CCQA3hDR6xT3gFz+qPUAOoGso+xIcQ2EnoXQC65H+Rr2?= =?us-ascii?Q?kCNyho26GvsNjagstjDIcOvCqYvD5k4iYDDaUbFow3HAUkF106c5xMNGwN4H?= =?us-ascii?Q?/ADqAqdB6I0BpEcckurZL0SzZ+eko5m5YGS4ulqde4UWHGGtDq1wnB1P37al?= =?us-ascii?Q?CNF6GrqNLv4+XhHynJo3P47YvG3kp0E0dGiT/teqSt0y2/Kk1SRfhOaBFXzk?= =?us-ascii?Q?t1xCabEbMx5cjFojOV+7Xcjtuni9qp2uD8SbkGrYAYlzvGdl0+gw1Wb9lVI5?= =?us-ascii?Q?6U34579RXhl4pbRFpZjyXlrxNH7SRyJCnDc4v+63ujzePwfuzPsCDwsSUs7K?= =?us-ascii?Q?mTfeuy6QGTz4Hlw5+SqCxIf0TJ2nQVRd+CTuZ71XOT4GC9WMlYDHBm8grezj?= =?us-ascii?Q?TJm/g7Mb1XP2hN7ZHLKRmvWSnqO2hxA/D+CmFARIpvYMei+831ohRUTR1nbR?= =?us-ascii?Q?wEL0/eIvYuZ079klsxDHtMTNtlSwNiHA+obJWhDTmmB9E64DA69ltybydrDw?= =?us-ascii?Q?Sb73rfQYXfncqNrHb9AJjxWriLau776ErA/By3+W5G3rJWir6HJNrtF/1qjk?= =?us-ascii?Q?QzDntC73oGvw3OFgwVg7Vzkq7/cFInYYT9TcV2A3krl+l3T9oUAXv0VPSrUy?= =?us-ascii?Q?wYaJrJTrsFqquExvmm9rWqFDlE0m1FRN0tny+Lxcxg1VW8wPvAuPGd/dXTkW?= =?us-ascii?Q?Rp0gyoAOy3u1py31Zc2SBZPSsl6e6AqFo59G9mbIaFJ37QJmdPJ0k8ckBbv7?= =?us-ascii?Q?HNp0I6maSBznXwdt8XPo+6+xzz2GJOTKZsZrDQn5voVNqAVogVZ8JoyDSvPt?= =?us-ascii?Q?6uEtB20feKDqJTDl/wkj4BoUpJBIIOAmTfU5sIJymOZ8SrjhZcMhpCBpRmpS?= =?us-ascii?Q?zjGPMYGVH39+2r/wRbfJeAgeoTU4j4WYTgaBX7MBSfVj9FjWRegL7xqIiriW?= =?us-ascii?Q?4sfH8UpDjxpdln7M06gbjf55YaCl28efPXmCo36aPvrPIJlS66sW+Lh7Ha+d?= =?us-ascii?Q?pZx0aW4nvfB9mpKI0OfV/wVWvpyp8U3nQA1u5eF6Q5FKfO4GQadKgwus1uMi?= =?us-ascii?Q?u6b+79odu3At8xrYKmypcMhr6F19ZfT2GIrOqJxzhLEoyW+mY3qwE5keUt/v?= =?us-ascii?Q?PVonex1Xnc5+uXmNMDHR0ZtxEkmFwU08xoNPZiRI0U3VogVTQRG1+1+eePIT?= =?us-ascii?Q?S4RDuSaIzz+UFe4r9XbD9hFvqqHa6CvRyn4DYpRFhhNCa8DV25n+9eHeMAy7?= =?us-ascii?Q?+PRzeMvBbWQUn1GWfms9qoL3KHMDmsM/vXl9thnmHXISWA/q1EJvzKhYMsCn?= =?us-ascii?Q?CrL4wZsLLIT3pcAxqNiKS8efyPnBDiESE343gwp2iKhypY4/03KtYGHhoclm?= =?us-ascii?Q?7Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7ed069af-0392-4258-fd4a-08dce920398e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 11:39:39.5931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wNu6Lj1m/ucA1YadXfiotoY3vZz5FTsFrFJeINjw/S5hpte3nSVaPLsdDol/xcPgDKKeCbibv4Vguf3i2vVXa/ZnnJHaDjjkP687d5NQHdY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6147 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 10, 2024 at 01:43:41PM +0300, Dmitry Kozlyuk wrote: > 2024-10-10 10:54 (UTC+0100), Bruce Richardson: > > The macros for STD*_FILENO are missing on windows. Add defines for them > > to the DPDK-local unistd.h file. > > > > Signed-off-by: Bruce Richardson > > --- > > lib/eal/windows/include/unistd.h | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/lib/eal/windows/include/unistd.h b/lib/eal/windows/include/unistd.h > > index 6b33005b24..78150c6480 100644 > > --- a/lib/eal/windows/include/unistd.h > > +++ b/lib/eal/windows/include/unistd.h > > @@ -12,4 +12,15 @@ > > > > #include > > > > +/* > > + * Windows appears to be missing STD*_FILENO macros, so define here. > > + * For simplicity, assume that if STDIN_FILENO is missing, all are, > > + * rather than checking each individually. > > + */ > > +#ifndef STDIN_FILENO > > +#define STDIN_FILENO _fileno(stdin) > > +#define STDOUT_FILENO _fileno(stdout) > > +#define STDERR_FILENO _fileno(stderr) > > +#endif > > + > > #endif /* _UNISTD_H_ */ > > Why is this needed? > There are 3 users of STD*_FILENO within DPDK: > * lib/eal/unix/eal_debug.c - not for Windows, obviously > * app/dumpcap - not for Windows, requires multi-process > * app/proc-info - not for Windows, requires multi-process > * examples/l2fwd-cat - not for Windows, requires https://patches.dpdk.org/project/dpdk/patch/20240822104109.116208-2-bruce.richardson@intel.com/ This merged patch is now throwing errors about the missing defines on Windows. /Bruce