From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 206D445B03; Thu, 10 Oct 2024 12:39:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E180840279; Thu, 10 Oct 2024 12:39:44 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 061C14025E for ; Thu, 10 Oct 2024 12:39:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728556784; x=1760092784; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=cRj7HvWRswrPtvSyHevVIg3nfcTRvlCYjpswwm3Azcs=; b=NS6t8lpOg7HYsvTcit7uwpUJJ87n7wWOlmabsZdWvFmjWB2DBQ9KZY8d 0sxEw1H+HhBoTxlFtwULfS2MQp+3VIQgAGR24DWWyRYhVD0bGIfNqa9sd O+v9OmyZrlIJkamM8FwES7PXtiUfiNGQJsxbP4cKcMrukjMQtHUAgK2DA CTW54yVfQzaNSDTd2IBnT4Il05DwausYazkUgUJbIHPSufJwPprTPvQO2 x1cTgXIrf2fHD5yb8MDBeyz9jgIoKGMfGwpW/F4uL0+GKInTKZzIizQA5 H6t517isoSgj3XBvwrBpxb/eZHL9VVX0+40l4rwxSJvckWUPdthRUQY6E g==; X-CSE-ConnectionGUID: 17v2oGM1SCaJJc+0DOW6jg== X-CSE-MsgGUID: 3PKl4pz6QomARkvODpdZbg== X-IronPort-AV: E=McAfee;i="6700,10204,11220"; a="39295869" X-IronPort-AV: E=Sophos;i="6.11,192,1725346800"; d="scan'208";a="39295869" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2024 03:39:30 -0700 X-CSE-ConnectionGUID: uCR7QH/sQQKo1iGkl/biEA== X-CSE-MsgGUID: 2XaNXgi+QN+BcI02VANAlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,192,1725346800"; d="scan'208";a="81080856" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Oct 2024 03:39:29 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 03:39:29 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 03:39:29 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 03:39:28 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 10 Oct 2024 03:39:28 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 10 Oct 2024 03:39:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sgUs3kZiu91pi9KvxcJDU6TQALf8yaayoKpWRMV8TgChS28eqrNiSWHsOg5c58SWbpMRkHYYkaTBQlTtUBnDFKfYpBU5j+5mfcIAIIUhvKgzAaTPi8+evqyvdit6CPH0b0/w2oiKNgj4Aw2ovSdusVtjnaDLAlCO5xaYNrRStlPy8od0KzDF/GX51f9McvKCp/lRyTT60F5Z47QdcrSgqWjzYFpXS3zuEnKc60ry1NREFW21JLLewgSD7uGGoC/GenfmcftG0bvQhJvv8z6GJuLmun9bK49y5d1FVAXLsVbOnfmOaH1iW6jKQU6iJppSyeVaSJYF/TnM29G9EeyXlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KhC7qnQQcjEYq/LKyvbYd8+zxBccvS69zT424VED6ag=; b=YqwK5f3bGwZ1Hd/fwraKIEySGz0EYjzpi/iSRb4QFJduCK51sKKQpq5GYQvRaa6hydh+9oZdk2nMOO3ytcRTnYeM88C+BK3Oe5rPSRkDpL0KeLV1gj1AGeU6qTivSNgMPopVCw/pbIVd1iiVs1tnBlfupKmhW0/s6zA+R0DAQJuZ5fB/BKBGCftFGnOiSMS8pBcBrUzHBmj+AXr18sRzvp9U+nNKfSdRwCuZTmZsI6CDqAUX+gQWUWeE5+AYk59sDJxFAVenNAuVUsjG5hHOFPX09NDppe89d05SBgNqLKl7Bi0OudXLxwZL4NHnZ5zGJum/Y/Ch35Qk1s4ehvzYlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7851.namprd11.prod.outlook.com (2603:10b6:8:fb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Thu, 10 Oct 2024 10:39:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.013; Thu, 10 Oct 2024 10:39:20 +0000 Date: Thu, 10 Oct 2024 11:39:15 +0100 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: Robin Jarry , Mattias =?iso-8859-1?Q?R=F6nnblom?= , , Heng Wang , Stephen Hemminger , Tyler Retzlaff , Morten =?iso-8859-1?Q?Br=F8rup?= , Jack Bond-Preston , David Marchand , Chengwen Feng Subject: Re: [PATCH v12 1/7] buildtools/chkincs: relax C linkage requirement Message-ID: References: <74e86a66-4341-465d-bcba-d76db66035cd@lysator.liu.se> <722ddf9d-29ed-4d3b-bc54-ac2aafefd2bb@lysator.liu.se> <6fd9040d-d923-42e2-8eab-b7ad5e48e28c@lysator.liu.se> <2ee279b5-910f-4428-84e0-6a14dd4dfd5c@lysator.liu.se> <0f81b9f3-8724-4bfb-bcd4-8d5c7c035d15@lysator.liu.se> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f81b9f3-8724-4bfb-bcd4-8d5c7c035d15@lysator.liu.se> X-ClientProxiedBy: DUZP191CA0004.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7851:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c78c149-45c6-4ff7-afe2-08dce917ccad X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?CyCUrMm8aC4vTtCQgltK7DpHZCurXzV6jkXYXTinBSvweb7zhXDJ0UJzcO?= =?iso-8859-1?Q?8+PJqqpXRpm2yigAlZZgIVVFWbEBsrtmsKVDyP1QupK5eR9LjWjbOkEAZp?= =?iso-8859-1?Q?zCnPYB8/9oCARgyX4r+L7dlX++4KJYIOo4DJuc1J19UGn/nDC4fjmwmyGe?= =?iso-8859-1?Q?sLyG/iXn6ybp+ujpTntGx4SmzGhc528/ucr7uyPaTQ2Z5olmaIslLOu1nH?= =?iso-8859-1?Q?jKtJBaMMYx1+cNWGidKPKlaJ+Laa93JSW7pS2vNM63G1s1cKqqFmS/io/W?= =?iso-8859-1?Q?Ce5qalzVB6T14NQidK0Q0uaCOBrjcI89Xddoj7WnQtLnRsFrxp8IQBstWn?= =?iso-8859-1?Q?XwsKOeOVY4QWmY+j90LkXiVQ4jbB4Jp3WOD0+WoWxQXgOpKSPorRzoG+16?= =?iso-8859-1?Q?LKPH1X+bWB+Oyv9nPrnxDrcqZn4H4G/YqMIAMTeYsrGqW+XJ5jA9NhI2jg?= =?iso-8859-1?Q?qHe2kHjrdXjN4WHicxlc5B43DcVaKoxS50YrG4vr8nQsZQYRBCEBRUtQCj?= =?iso-8859-1?Q?j6trY59+Oy/i4Bo/ZgBrQMwQNeCMVjoNdmnT1V5/1Ci6+nC12m8inswObJ?= =?iso-8859-1?Q?WsKWrqCw3gfV4spLZCoefu1C9ft29UVKZkXLdm3mAOKNXwP0GiR/fFrRhr?= =?iso-8859-1?Q?V2u6wD5/vtAmvhZf4YM/ZDP+kbz+kdYPKaLCteW2fxRkscmO+vTIj9An51?= =?iso-8859-1?Q?luwAlmgtNjQTVbs8+L+QlQ6p+Jb3KL7i2GWD+lMGJFNNUPSnYRs1a55rb4?= =?iso-8859-1?Q?hPrePGGgIVuoU4yhYIxORz8e4mRIRd07RFqQJqn0bKSHMgBgm96ib0EbES?= =?iso-8859-1?Q?wHx0dMAK8jssHTxdXJofr91dLcE/QPz1omZvkOiOY564DXUlS0mBPWnxbi?= =?iso-8859-1?Q?/F6l/PW7k7ZK7Du8YoliRnNtojJtUL8mxF5FSBN12xMQ4sXcp321FEgGf8?= =?iso-8859-1?Q?jDITjA/0BMwSmHjkKdliGe2Fpt3v3CrN8FwaP5a2Fb8WvKuHAwv1FZMoc9?= =?iso-8859-1?Q?sc8Q3lg1e4AV0zt0/GqCpkyI75qFG0JwUxpb4/jtr/Y+6yfr7ZydMdpsDn?= =?iso-8859-1?Q?4fbY/iJhjO1VRTmfaB5SMf1t3YWrE6er0WxI1NhmpC2LJDd1rgR0povaIa?= =?iso-8859-1?Q?RrxUEAOxa7qcUTYQyvLMKYZoFtpWj2oW5pM+TWgkLQFTT8EUWlmSvT57h+?= =?iso-8859-1?Q?NW6rRSt0T0SSg6C7e+ZN8DoB9ozxhr2tH+18RWNZkU5a7+v8H46zTFtiX+?= =?iso-8859-1?Q?ndoc+71Grhx2nrG563cnKUkHkQtcZ6jVqi2eMqQArXwB5W1XpZslrP8Ib3?= =?iso-8859-1?Q?kBQWFgasYb9n8SdEu2heW4Gs3Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7416014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?m5SwqL3RHDVcdr8Xsi2/L0AKFFeIpL9GZK5bI43EIebnwz3eTUgawh87Dm?= =?iso-8859-1?Q?n0z/KPKA3oT+M80l9eq6kdF9MQm01wZM+jywErki4CZRAstwGSe7+96DL0?= =?iso-8859-1?Q?2v9dFOEvQfjkK3DM9XJi0RSLwJ1KsMr/AyWDpQ7HRwHflUaBwDtfLUcnFN?= =?iso-8859-1?Q?31ip7DuD+qsEnAZDiRx1zGeinsD5yKh/fAWNiPTTpuZHJ5XjtG9TMqXd/B?= =?iso-8859-1?Q?mICSsoWLhom9WYERLxZ1UtIoLsClF6cz+bvtL9C0PN93U98Z4Mw3XG3vGT?= =?iso-8859-1?Q?rQdcjMJUCBHvxwiK6NSlIT86X5dVqgpZKiyXZcNnRVwW/asUiJmPJNpAAy?= =?iso-8859-1?Q?/BLsXUN5Y1sjGv01qpwYY3aBZMWN6x5cDRP2bgmKLJmoaMtgd6fd4xUtaR?= =?iso-8859-1?Q?VhU0c3p2yixmjaMgi6g+39r4zWTdKa6T5AWh5h5QOBVGzvdXjIr50csZRn?= =?iso-8859-1?Q?rCOVMaTs70egdxvsjaULidBT0n1M2kJEEgwv6KlErnX52AQyYiDnWnzMIe?= =?iso-8859-1?Q?gMONB7X8cvv6mRgxXVCZjZ8rtUvQAAIjd6cHnltVkgt0pIT2whuWGI/9Hi?= =?iso-8859-1?Q?gjFUa86Wk1Zh7JEMKFVdf9eqmhpjSz4rpr67X8tWgpD05oihSyJha8cClh?= =?iso-8859-1?Q?Hkymt/ooTwjDGOkfe8df6/T3PwzOudGbfpWKTnwQoKFR4oOeewVLccikDm?= =?iso-8859-1?Q?ggeDn/gVRlUSq1p9DGYDg83xYKz1XGzzCyMH0nJqaHW9Q7za6Ms8flWlhA?= =?iso-8859-1?Q?0CD/cybuHn1vXOSJY62KWYqYodjzbqAWgLkyNHIvFSjWZNvX3+6Xfg0JXf?= =?iso-8859-1?Q?d0QGDUM4GKMHHpOk6TJcyS5bI9ioRn3UwSOerJIRBXxJsS30/w5abjsthY?= =?iso-8859-1?Q?RlQegsoy33jNDpEc0fxFxm5DrX98brbBQlKOigjWQFcHMQNHIM33NguqJG?= =?iso-8859-1?Q?ucsCVQqPcxQG/emOj9TseWwlLZC6lQ1z7FndF6DmyYrglJqm85LT8nFvQ1?= =?iso-8859-1?Q?7v9C6QUxQttVHOkoyURp3sPnCMSQFFtrGOaY6EUMIDdZUFMoKPQJ5y/4z5?= =?iso-8859-1?Q?KRSposwZttS1IDXWwRFCkGk2XRZYtSc9J4/LDtn0MnquZa7dGlexLqihhZ?= =?iso-8859-1?Q?5kxfDZetpTPRtzZndEZfQC3GxL+6dGxbZ2OOa1jA9x44kkLAXpBEPNKOcg?= =?iso-8859-1?Q?hx416qPdrVtq5Y9oEtXKTwz+g7qwHe0ZtBezGwOn530wTeDoI/e8KOBAVV?= =?iso-8859-1?Q?pTELzhPJaFF232Nh4GnIHKfyhkCL+y/eVOXVpDrvrczjlk/cnxMWamK5eI?= =?iso-8859-1?Q?BpQRRWJkKwtGC8PHjYa/6YnJxHopD6g2RKUHjfTTKGjOQImeDxFfgrcLm4?= =?iso-8859-1?Q?9S89BbunXYCmHLuK7Ij4WH+Xdq5yhPbPOr3kFvk6jj6wCMAefLxLlhodGo?= =?iso-8859-1?Q?NZ7hg1EuyJ78LYmkUiVEISbsvLdqTUcY1P0t94fmmiOddmzT8QmXMsuaig?= =?iso-8859-1?Q?S33YCVGgJUC5HP9U/+5dFwHFeYa0OzpP2KaxeNJ/GJvAJElAiZrb/qZVwV?= =?iso-8859-1?Q?7vEwfMOWroq2TjU2Ui2Vk2DbEounRcevHXDCrBiq+K5mU0xPWmyOe6lTZV?= =?iso-8859-1?Q?cRPbERB885BPW4C4QJqmIbcIH5QB3/dAGu9rM1S5/Yp9FxPeALwZi6eg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7c78c149-45c6-4ff7-afe2-08dce917ccad X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 10:39:20.9049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AAu2ZVtsW2aZtsyJpf+CwAzjtIoyYeqF9Aof+PysPNBMMtkuaPaAN+neTfbS+i9TWFo1aU0lG9Bw2W1yDzTjNe3VnHnx8FyBuuMfhPpXsqw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7851 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 10, 2024 at 12:24:25PM +0200, Mattias Rönnblom wrote: > On 2024-10-06 17:58, Robin Jarry wrote: > > Mattias Rönnblom, Oct 06, 2024 at 16:17: > > > > I think you need to change run_command() to custom_target(). I > > > > was thinking of this patch to be much simpler as follows: > > > > > > I started off with a shell script, but I switched to Python when I > > > wanted to strip off comments. (Not that that can't be done in bourne > > > shell.) > > > > > > The below script doesn't strip off comments, and provides no usage > > > information. Earlier I got the impression you wanted to improve > > > command-line usage. > > > > > > I think we need to decide if this thing is an integral part of the > > > build system, custom-made for its needs, or if its something that > > > should also be friendly to a command-line human user. > > > > > > I could go either way on that. > > > > We don't have to choose. Being part of the build system does not mean > > If it's an integral part of the build system, and the only user is another > program (e.g., meson.build), the script can be made simpler. For example, > you need not bother with usage information, since a computer program will > not have any use of it. > > It would be helpful if Bruce could comment on this. How should we think > about small tools like this? That are more-or-less just an artifact of the > lack of expressiveness in meson. > > I'm leaning toward having them as proper human-usable CLI tools, provided it > doesn't cause too much fuzz on the meson.build side of things. > I don't have a strong opinion either way. Meson indeed (like make before it) has a limited set of basic things it can do, and requires scripting to augment that. Whether those script are only for meson use or should be usable outside the build I think we can determine on a case-by-case basis. Initially, I would myself tend toward having them build-system-only for simplicity, and only later generalise if there is a case for it (YAGNI principle). However, if you think that a script may be better usable both as part of a build and as a standalone tool, I see no issues with early generalization - especially if the added complexity is minimal! /Bruce