From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CFBD45B04; Thu, 10 Oct 2024 15:57:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E56A402A3; Thu, 10 Oct 2024 15:57:52 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id 79B7140298 for ; Thu, 10 Oct 2024 15:57:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728568671; x=1760104671; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=s61yQq7lBCvBwmKfyfqZ9788bF/c0A2q+EwKGMnP7OE=; b=L9N8rZhG44cAmnO7kOjRmWX2ApcOvk+rwvL9dfmvYkR2hF4bI4vwLTe0 8yzwdvYzkihA9Z2TPYVDharF7CyNqaSXYRAIwLJE0ydl8Gz2dyth7uVih E+exn6EB2mkzQqyglks+F6apcsOGK9Fc1PUerRTIKhUaE26gtn4nva7Ad Pd8Dol/JlqiUOMHEZelvKLRZZuF4SKdUk3eQ7tzULZBXAKf6vz2jLaodx 2LYl4b/olH546Ukdc7A3heI+SE1/Ty5Y49hSV0GKhQBvAlzEuw0VTwe7Q ZuzusbkGc6ModsIaCTSt3Z07fVYL8sgRRwmShHklXQB2R1yz73iQUaZ8P g==; X-CSE-ConnectionGUID: EGV0dtNdRbi40jld1rMyHw== X-CSE-MsgGUID: br9BoXqOQiWqkYxrvn9FTw== X-IronPort-AV: E=McAfee;i="6700,10204,11220"; a="28062538" X-IronPort-AV: E=Sophos;i="6.11,193,1725346800"; d="scan'208";a="28062538" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2024 06:57:49 -0700 X-CSE-ConnectionGUID: 3VkLUbZrTqKa+u8evqmuww== X-CSE-MsgGUID: VOTGTL+0RneM0BwDS4T8Bg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,193,1725346800"; d="scan'208";a="81608733" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Oct 2024 06:57:41 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 06:57:40 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 06:57:39 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 10 Oct 2024 06:57:39 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 10 Oct 2024 06:57:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W+IEZZGsecCPHJBhXM/JOp0p48qYCnDH/rHTSoiZbOvrihP5BgOthJFfTrKHCyY+4qowdrrECHVyf4GBxgKWXqKQzVNKyRova+FaNuVCFeyO3N9gPfDkvS4xi3EUwhwfcn24hcjZMS1mknmc3Crz7IGsWTngMw0VFcGUXsMciN+vWBi8YINQMlszrl9anyacpvwBSRdjsOgtMgZJqHC13nhwwi+yM/7CvsyLKRiooitva/HrzDxPuL3rQ+7QibEzbkGrsQCP0R1ajrvQOL817tCkAxPvPY2QddBeNTgLKs0ScUXJusnaPk2uPTDszJzDp67HuGRC8uS1ygOP2/AczA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yokZrgFFJoYYT9+292kkUFmux8MB2vDZmpt1N9/GWmQ=; b=bqs77yQSb85XDwdrKhZBz6VhFFaZuJhJfailhfxXjNBIFET0jMLvV1MYx0xINJ8ymdlkSrGxgpYufBstX1aaFJMsZB6eVP+rCwSrv8rW9BhABUKA9KzHjtpFdvol+Xr8GdTx5hFWOdzzK73Lm7IOeSQXDJx6rP/38eEaAr68CHmZBs4a6zMvlxOQP0JjlS/L24R0mp/ufiUogVk0nrSe3fj/DOhebajjMPjhBtDaGXGzQQiULGHRriHEHGLm7kxJ8gSRPEeSx6WSkKqJL8HqJF+dJhfinSByUe0+bHJu4W32njH/dOZzRPJ4lWK9KhfmpVoOkP3Nq5OVzeXENCBSwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB4921.namprd11.prod.outlook.com (2603:10b6:806:115::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Thu, 10 Oct 2024 13:57:36 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.013; Thu, 10 Oct 2024 13:57:36 +0000 Date: Thu, 10 Oct 2024 14:57:30 +0100 From: Bruce Richardson To: Srikanth Yalavarthi CC: , , , Subject: Re: [PATCH 1/1] buildtools: remove absolute paths from pc file Message-ID: References: <20240107154137.4909-1-syalavarthi@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240107154137.4909-1-syalavarthi@marvell.com> X-ClientProxiedBy: DUZPR01CA0066.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c2::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB4921:EE_ X-MS-Office365-Filtering-Correlation-Id: e0a6ac32-4ebe-4c56-e2b4-08dce9337eca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vCOvaA6LG2qSWfrB1Mh8sQgzAezCYGHoGAxtUbxQJ5xtg9+/9XrjRdFGei2E?= =?us-ascii?Q?3ssiCcUQPZVBjxIIUcgnZjiSw8x73DnlbIxhgsu9o2B0e/P4G/Xn0NA+qXmp?= =?us-ascii?Q?OMok87l8yojODGxP2lNcNX2f/fsSSDAHObo2HQQnlwfmLqCa8i7jngDAPHr4?= =?us-ascii?Q?CCuQenDh/4JpLuSOlrSVp6bRSY8yqIPTckdRMCCQqM9it4gjpPqK8u2t87mo?= =?us-ascii?Q?9Z96XVC4hKJB8s4HrlrOnN68ucDyORg2djzleH8VThooVSeYni0UXoR5kU5P?= =?us-ascii?Q?6iq+0d/cv4XlZ0UGAzTc7cOavrvxP4V+w12GvFeltZ9/tcHvSoi6RYFYl+1R?= =?us-ascii?Q?K0KGJx5m3q7zwOStPwR2KvPHo19qBr9m3solS4wXqrx1STRnG5uVdpdRyubX?= =?us-ascii?Q?eZ+UEXD9kPs4QJ3mqPEeOWeSZBr+NVq0m5NummCp4Fc8AIpvkP3lPMu4AB6q?= =?us-ascii?Q?sdpeU5Ve/KfKyTb52kpQmnyBhotESK7Lu/4OHjZRItBIrD/iIRSfMmYRm5RM?= =?us-ascii?Q?b6e58wKrB+UkFNGi4+rd3K4kdUnJp9lNLbnXsfOMQfPaoG5VFA7zsFIUDvzH?= =?us-ascii?Q?r0EMIOwgF1u38hFA3Uee9J/yn5cJLexUO6wH0xCXCdoseV9AcUQt4eAd/cvG?= =?us-ascii?Q?BLpWrjNYl40JX810HoMcrR3p3Vd0r9yxar0XlAY5tqaueYx6xOS4rcTs4THO?= =?us-ascii?Q?7kZdzJttgjRdAFwqxuWy7V5fLkt1hCTMHrZaex/dI+hrT66x/c+6v7lEP+GC?= =?us-ascii?Q?wMDykzOo/pAkoQ1V9ytydEeJ/asdaVW3Z06EWor26i4Do9gqAq1ttvHQeHa9?= =?us-ascii?Q?vLGpqRd9kxC2YZwVGMx8kSKozSdlmHlFMyf061nEy6i104Wu0CQW9dQWKYiP?= =?us-ascii?Q?KSK2Az/+vaqVkQAa7FUUph4XT8BoKxoyppQG76/EAxtblMsBx7+UknuyB8H6?= =?us-ascii?Q?SvRrPGGGFPB1U7WYlQ3VXiXjPUKUNdfunBjctI3h8sSusQSvJpan8yIBzWFC?= =?us-ascii?Q?xY7tcULnGZoG09mTN3Q6rfkMlTaJEOMWicxfEgG/rtpP03TQ95jI43tFnOmG?= =?us-ascii?Q?X+PRmPJT/krJKk36FXNJtSwYbnwrvZups2O1gtSrZstDmYU/Ix0fSTdheRXU?= =?us-ascii?Q?XOZB7hvxtlsi2jHQdN+aLSVAFl2GLG7Z/AGW7ygpIkqJngV5xdlH5WDX8JH2?= =?us-ascii?Q?c0Gsxc5rkiJ9Jjs7KPUUKCNfS4ANNO+k7vSamXvBY0FMpSEDSViFwie6dZXR?= =?us-ascii?Q?7pjKPyL/TMZWIrO3bZ5uVFQ4xGzsQKiiyzJDhn3c0A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xxJla33+zDEyeHsTOY6AHeTPeXh6kyuEADC4/dwVbnYCC7oXe9xzEBL9zejt?= =?us-ascii?Q?JHvJPmmOePF74vnppUJoFad4ZQzsEsjnaLkS2lt5v2YyZdRwr6RHFKLtPjJ3?= =?us-ascii?Q?HNLg8p18YTHhF5ewR6wK2e8gBIfABdKzhc5KG/S2fI++dZQa5QZbPKNUq9Zv?= =?us-ascii?Q?dY4/mEUEeEI+UX0j/pkdBcajdon+ItNOOTd8J6FM80uwlNlTAjM66bJoRppF?= =?us-ascii?Q?9E5cnhotwe9wg1P6t0+gQQBH4r2+2RNWAwj6FHU9ccCXrOngtvYFmw944Mac?= =?us-ascii?Q?Qrhug10TZr97ZQc941JltEizqxSaIZoHW4EqGYAcH7GGQFamei6bAzPsKFKK?= =?us-ascii?Q?j/fkjCaUx7cMdN7DWlpCudpQLKDH4z0kbY9GD3ZCsxIHbiV7P77FPbTjfi/T?= =?us-ascii?Q?QdS6SaNVJ6T34aIoksOGoiK1kXkF8IbppqkdVhRLGYKvE88fI82Ggh5srPZ0?= =?us-ascii?Q?0Yrdb8LFIhYhlZMUaIrjI2eYgXFBXlM6snsi9cYgo2TJGFQQV90RRjnpL5MY?= =?us-ascii?Q?h0U8xroZMheY27UYzXKz4RFtozxlde+mgy0vUckBWWMQuQAlLZIQaUE5uuZn?= =?us-ascii?Q?X96vnwYzT1zXwgXbbhY2DHIvqVeX+uRg4wjVDr1K5fZdSuYgkUmsPoXGs78K?= =?us-ascii?Q?9yMqZttzeFMfOz0VPlvpUXjTkKgceNu8u8Z8tXdMNIfiYakS+Gndby9CpQcQ?= =?us-ascii?Q?Ic7AM4tG9xxdIJKE2vumAUufyajdILCb+vP0lMVtT+N+QcDZA9ugL1M9h/RM?= =?us-ascii?Q?KwQxEkB6d+5USgAkb7CGEqZkZqDeaRUdYc/o1n4ydt4cO2df2iGRa8rZgik7?= =?us-ascii?Q?r2WOzYnsZcr6J8SE/oxacub1oURtNob8gBta9P9yf0DeIUiv50kzeoicCKKZ?= =?us-ascii?Q?a0PKSvUptr+eYAFM21fKzqVADmwjF6FYu+9NAHM2ZUXb1f7BkphIvuKE1Ts2?= =?us-ascii?Q?7W2eLcEVdbUvJb+WOyWr9l6fO5+uiD4239xzWCCoZJ6EIxl3iQnfXUMmCRiR?= =?us-ascii?Q?5frJydDMPNSzVuZNr1P7eWHoALtlftAFVt9BQYuDcZlrl6uodzf/gRzTe7J+?= =?us-ascii?Q?Ii+Zj2lhGmLh+ibULEsjmyJCybRzzQWPgekWzNennjZjsBUgKieBUrJJYO8a?= =?us-ascii?Q?1kSMLzWuUpKywrRUxAZzTHsytjGHabGvHHUdvx2af4l3X5OcoAOzDEXw3+Fo?= =?us-ascii?Q?VMVZEEXGshMsgUDJi/PVyJdjQXawDVYXTiFDevFUBh49yH2GbSXRiTpkL6yN?= =?us-ascii?Q?5yyoYsVl2Gxc8v50ap8vCIwinPAnsEP3dRsCJk608DImZipViJZutmztily5?= =?us-ascii?Q?TQVEazOuZ7HLYTDMTvVFuy7uEeSD3xs0VciIGiBTe6RVdJioD3+d145eCm1x?= =?us-ascii?Q?PogF9A+QOb91+zyL2n/M0QaeZGDW0O0meEpkoaeQEMobnmsUajGHzmJob/gC?= =?us-ascii?Q?B7aFMHFfe6gVWRip5o+VwgPG+KeY1gl6qjHup9diX4CPul35Ur0SUwT1xECB?= =?us-ascii?Q?psS+2uxpBva2i6RToJwIc1vqnTd5Y6MhsiyLYSKi4aHNP4sYXR6LXbB+9rUZ?= =?us-ascii?Q?Oo5znqP7VeHhttBlgzSy+RSvrpbNQWP+4N6iED/SWYlDcpNs0kkLMd3oLbp8?= =?us-ascii?Q?Ww=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e0a6ac32-4ebe-4c56-e2b4-08dce9337eca X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 13:57:36.2108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rVpFsitK4mMT94VH2l7Zl1Z0jeln8rN4Xmsg8euIXHZWyRyZfpmDasyqin+xZRStz07evYmHdhBVIbzzZLWgjmqcz7/BYa3sxZl/nhuPWik= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4921 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Jan 07, 2024 at 07:41:36AM -0800, Srikanth Yalavarthi wrote: > When linking with non-versioned libraries, absolute paths > of the libraries are added to libdpdk.pc. This patch replaces > the absolute path with correct linker flags, -l. > > https://github.com/mesonbuild/meson/issues/7766 > > Signed-off-by: Srikanth Yalavarthi > --- > buildtools/pkg-config/set-static-linker-flags.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/buildtools/pkg-config/set-static-linker-flags.py b/buildtools/pkg-config/set-static-linker-flags.py > index 2745db34c29..e8804353383 100644 > --- a/buildtools/pkg-config/set-static-linker-flags.py > +++ b/buildtools/pkg-config/set-static-linker-flags.py > @@ -9,6 +9,8 @@ > > > def fix_ldflag(f): > + if (f.startswith('/') and (f.endswith('.so') or f.endswith('.a'))): > + return f.split('/', -1)[-1].split('.', -1)[0].replace('lib', '-l', 1) > if not f.startswith('-lrte_'): > return f > return '-l:lib' + f[2:] + '.a' > -- On initial reading this change looks harmless, however, I'm not exactly clear where it is needed. What libraries are getting added to the PC files with full paths? Also, does this only apply to all versions of meson or has it been fixed in later ones? Thanks, /Bruce