From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5233F45B08; Thu, 10 Oct 2024 18:33:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4104A402D4; Thu, 10 Oct 2024 18:33:05 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mails.dpdk.org (Postfix) with ESMTP id C661D4026B for ; Thu, 10 Oct 2024 18:33:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728577983; x=1760113983; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=YKkPgaPaC5SuHDK0CNbomlQTkOp2PH/g+Am8aKP8kHA=; b=BKHkJH934hovX2pAgKAtb7N5lUc27yuU5dzBfpYEMbfaWm1yZlm8yRgG aSaWTX6wLhJDcNifwwd5QJ8c5AugTQ00kuwTSztbfZWWPQbH14NOgyOFA kl+wA2lIFUYjQcnr50idyYoEUlen0e2rHPyZvVunBBvlwLC+3aZxEWpAl URHt1kjaMmd5NNP8p6NehVanR7ESSJv9ru56K49kBxHMc1Rh1jW2vDlJM yqgSQ4L/o1j7xIgNCDxlOJzA4R2GXEHX6Xi0LfoS3De6G7DKs0vqOPe17 mb0lSMTn6OBcnOAVzU9HZ/huToEB0MqgzPmRlXSS1b44vHBrbLzG1nGZI Q==; X-CSE-ConnectionGUID: yCBag59fQOm97lZ63K0dmQ== X-CSE-MsgGUID: 4QrTEw1XSR+yEm7zogn6kA== X-IronPort-AV: E=McAfee;i="6700,10204,11220"; a="28107032" X-IronPort-AV: E=Sophos;i="6.11,193,1725346800"; d="scan'208";a="28107032" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2024 09:33:02 -0700 X-CSE-ConnectionGUID: flA7PnyiS9egtDK4sbxPWQ== X-CSE-MsgGUID: w/D5LvbPTA+vXjtTMctfFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,193,1725346800"; d="scan'208";a="76262197" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Oct 2024 09:33:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 09:32:58 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 10 Oct 2024 09:32:58 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 10 Oct 2024 09:32:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PUYs0SKUSKfUrI2cfw+HxZXt8Lf9CvP8BZzbNdyIwUP7C9tizBI3FeoZrX5bD8zwCehxjhjDoXZ9Zpv4damPqdF1u+K1rXX4z5xTwzPbZ3icf0SKgFiJdyr964pvvKRZCQ0cTz8EswzmOO5f58XXGqcCMoWNOQvJBroK3ADq2r1uJdbeUYncWQzWH1NvBP3GxsrJFtxHEU3jLO6BT8dmjcTaMhlMxeN8+bH9ZTNayABxILhi25fJBxOdBkWMxJdaUuWyMWVZs99OvxrgjWLJGI5Tns4jfaiphyp2LyFzpnbz8e++5D0lIqkABI+QSB5C0qZjx/Ft7Kp7VrbnZ2sV8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z0gsiXo6cKYxG147nOiJHFidOIY1ORNo71qHwbYFo1s=; b=Nu5XK1q1DULrbQFDyt6pXxs0M0lXmMuYJGpdhzo81wkAYk3//b6ugsi6/9KQOcc5EM3jgCPu6xde5p1enh8LVrw3EVz/rF6qC/nvzvMHogw5NjhQ1WN5F747uB8rvYw8rT7FzY2eVjCBOXbJuBD8BXv8PoxkmaK+jurdqPsBaqDCHuTE7fctDtJhDfdeqGShaP/R57W7yLQ1opZjDiCRWT6aubYZEKAcEnAJv4av+li7mIFqa9jQI1Gden28soE3ym4OSJNXISjKHyKsFOYQpVfOYf3iyQlgBVm7A1W0YWNPlwBy0HrorjVWDCGOCNlJbkQxQEGXD10E5Q9hrCT27w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB5170.namprd11.prod.outlook.com (2603:10b6:303:91::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Thu, 10 Oct 2024 16:32:55 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.013; Thu, 10 Oct 2024 16:32:55 +0000 Date: Thu, 10 Oct 2024 17:32:51 +0100 From: Bruce Richardson To: Stephen Hemminger CC: fengchengwen , , , , Subject: Re: [PATCH v3 04/26] config: add separate defines for max Rx and Tx queues Message-ID: References: <20240812132910.162252-1-bruce.richardson@intel.com> <20240814104933.14062-1-bruce.richardson@intel.com> <20240814104933.14062-5-bruce.richardson@intel.com> <20241010092727.5204a9f8@hermes.local> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241010092727.5204a9f8@hermes.local> X-ClientProxiedBy: DUZPR01CA0099.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB5170:EE_ X-MS-Office365-Filtering-Correlation-Id: d0ca1787-7b4a-4ea7-1e56-08dce949319c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?GGEf3OnAa5RMmSv0TPwTq4raCOk6TiLgT+snu7UdQRoGKHWyoREAjdPULG?= =?iso-8859-1?Q?63W3QcnfBVrnMEK+GfNz6Bjd91G7yMCPi0xsyC0HUIgmh3GSHbZkkxXQwi?= =?iso-8859-1?Q?X6yif7G4vMvAZi+WKfIJfprdJoxkxoMHNG8Z4N20Uu9ApihYOEppQJbEWJ?= =?iso-8859-1?Q?oacAbqswaIf5cJtWBp5RuF14ina7FJ+ltzBigFul8xsXTfrZVI+76Fu3Dg?= =?iso-8859-1?Q?Z1641vm/+dpbx5ABMFYwFzQB/a0C3ZCJQzftZ7pf7qB9ldTbGox41leix5?= =?iso-8859-1?Q?V9H094r8G9DzPoyv3y6SbFhU2+/kbzWLbLR01ZuMEs0njr7ft4nNBstReG?= =?iso-8859-1?Q?1wV+y3h9jNwX5ZPIH1e2OP8GwwDjvgxP+BSxl1Bj74nr9QbNNHYoJAxpv3?= =?iso-8859-1?Q?kM67+Hs+fIU0SOY3EURbBQzJHhftUK0uaJt96JJRtDVX8KE6ZE2ACDiLg+?= =?iso-8859-1?Q?BfuABL1xUW62LbDVJmRKuLJahLFU6Q3LVB2nVAIKXeeEwjuAH4ZUnWI+jt?= =?iso-8859-1?Q?N//Jh4cJmytwNDMhEy9w7gbEqvlt1sE7S1dghNzP0oF2FW0F/dMMFRd5CS?= =?iso-8859-1?Q?LfEKb+r90zduxNIzwaVvRvVWBwJSRkw+o4KvKeuN4unpBuAcZ+rJkdTJxq?= =?iso-8859-1?Q?4wThqit924UGFFiskwHy/UGM60XoSAvifXMhDmlhhvXHYdRWMO3mjAtEyQ?= =?iso-8859-1?Q?WQgP94YKC/T6/CnSZCIWycx8HlTfR/VQ5KGeh3IRYNXuOmNPCwaSi4kHVV?= =?iso-8859-1?Q?cHuvrjkeGxLX6V44YpdPt+5rzrsbsDzWL8u3PtRlnKQKhvnTLXhS17GG3v?= =?iso-8859-1?Q?xm/FXKI5kas53iNQERu3RfFnR4pKIKahCkCeLDe3kRt7xXnu0QB2l3AVeM?= =?iso-8859-1?Q?h+R2W1NsWluV2LT/2doO9wOBgwbj5tbxWsfHyaLwx5yadf74aMJERZVyeC?= =?iso-8859-1?Q?7KHwEtXI8s8Q/4zaf0Tq7hJTiaAerw+4VseUMjwiINeGpAhZ01gzylOkxs?= =?iso-8859-1?Q?ta0RRHl4feSKeqTdpR61DGeo2oDekehjgRJ9oRL9IzhsdAynN8oJlbsMYF?= =?iso-8859-1?Q?vZf5oaffZr8A1N4Ef1zMd5/9egTO9I67/ZN6R52C0VcxqhSS7E+/ryrZ8r?= =?iso-8859-1?Q?OXxCXv7uM4AspBTuwXhkeHM71yAwiLJKEFj9Gejw/6Q9aNeczfknJhnJhC?= =?iso-8859-1?Q?cUgyZb0PVxOdkwa2ybWEv4yNa20X6svHKJumTJ6Y5227vb8l6iDP1H+OWN?= =?iso-8859-1?Q?e4isRnblk1aFjkTR0ebPzMJoGhZkgjYgjPUjvqOlpykS4PbFDTVvPn3Rks?= =?iso-8859-1?Q?E/k5yj0jUDOKCJSAGiPianLUYg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?xKXLAnKBDa3H3/rBD+bO9eqfnlmZQ06xxfc2on9TQOPy2IE/dtXQ/lv5/7?= =?iso-8859-1?Q?A318Z3bqbm76zA4GxGgtep7j4MEoStWESdPDBsRqndgdqn55J2UbM4LkBq?= =?iso-8859-1?Q?gVP7fv5SnN1q4K0VqdH20UKvOEX27ihINH53AfAaQ6QFN0IX+jVjjNgLFp?= =?iso-8859-1?Q?IRKCfkcfSymtI+HE7cbPVL+Fa+TqjShQCHKvj7jLztTJO2eFh1s50T5wvB?= =?iso-8859-1?Q?+HAbkC+V0gx3teKetNroG1y6aLIrJ1B8qzg5AKzcnIb+xFFpKRYF3z3CFU?= =?iso-8859-1?Q?ByhXxX9oIX397c22+8CUemQDRqNN3msHQPWumgUkWUiRVaBJ3JnaVT4x1Q?= =?iso-8859-1?Q?GviFsk9llL5r52y93WAxUJTE0vkr/KrzTMqAkVznJPN6gr8tv7KoYBsMw3?= =?iso-8859-1?Q?ovVtObf2eVt+wGh4UeQ180hkZpCbUFrXQHAbHtdNVNuQGgUl9laigay8r9?= =?iso-8859-1?Q?nEXPZlNKVZcpfB5oQ+TmZEzVXiQRkYuTrIPSxWi+bHsMz+rqQa5icfAA3E?= =?iso-8859-1?Q?AEdPZKDH1k7Gc9x1Jr1sIrX/g91heUHcRAVtcG+glkCAqd6fVSdX6Ledes?= =?iso-8859-1?Q?valNVcQPz+1Yt/K2xREpka3C/NC535alcBbgyJUC4SyZnhD/YqLpoq1794?= =?iso-8859-1?Q?07LELAFkjKbWYesQKJvPrzNLWcDrIU5xgR81Jk6KjuH4VcLOwScmpYGdQe?= =?iso-8859-1?Q?/g3w9n75EQdUSEDTDddzzfJYaFnJTuqenGX1ejDH8pWvzjnptsEizfTxgG?= =?iso-8859-1?Q?+Q/s0n5KaIJ9+aPi+Dza+sa4lwid/gfS0ogYhkgEBH1usYHWYfEniiNdWx?= =?iso-8859-1?Q?NZWhH1D3HIvjtpeLRNpd50B9kLkSUqDKKJ9Qow47oPg21VIPtkkt/pGjnH?= =?iso-8859-1?Q?827PirlFuds1kjgFlWlcDHlu7kF9LUTc4+L1RoTTso7LHELtkBBFu6TMRU?= =?iso-8859-1?Q?KX2xGoUjeePVe3Ahu4EgNcE2TQE05g45gr83sO+vMVT1DOCdBjaP+jocWN?= =?iso-8859-1?Q?KHkQi2tck5Awm1KE1wF6EB1Y/HIl+frCKbrA5sNzghXhiVRbY354r3cg96?= =?iso-8859-1?Q?Lx2ABZvaoKcHZ+59mJtVWgkNdYK2KuyIbmDFi0eT446LRCxO1/VoJX7Kkj?= =?iso-8859-1?Q?CSwZQUez1f7/VqsdCb1jtGy0Nuke/3KPgtGjXBIkgMA/ImauQ+uSqSwMQf?= =?iso-8859-1?Q?UMmN3WHLQW9lGK5zxM+PZUQJ9EpVmUf67SxKCRQvMkuaaqPIYhblZ6w1AU?= =?iso-8859-1?Q?jDXu6BpkQd4HUuNLRLgP505hjL1ulH1BROgqF05NNlq78TGk4NgE1niQqA?= =?iso-8859-1?Q?l8smBX9RVYliqHlzmMYYzowDSqFV6dsODusOmdh/ViW8Kf0x9Q73kwwmCJ?= =?iso-8859-1?Q?ZIz9hR9KvCPtDAY7wSCFvaPx6fYbwIkFuJgo0/zZbMgH5KfLQYmOji17FI?= =?iso-8859-1?Q?/ikZYRnoRgVHwR2qn1VUIUaOrNZAqH/rp7u8ifE8lVP3h6tVoH7qHxOHhk?= =?iso-8859-1?Q?gOH4/bgGWMqub0fIf5feYuC/6YeyZ5IQTE3WBULXsOhC4ePMfXnfa7uFsn?= =?iso-8859-1?Q?8MDZeQqGMq4ihT/96iy26e1mh/VLZqW9EEk9bO6zZWUR49h7ky2j8gtWQK?= =?iso-8859-1?Q?FqrLspvQeQMtz66yXCwqIl4a5uD2cmdYuLoo5FBzQFIa9b4+mg8MDBnQ?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0ca1787-7b4a-4ea7-1e56-08dce949319c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 16:32:55.6510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jUFKupJSy6Qv0xF/tzvPiytBN7SDCFaVwHuvM6K58lhcleBrFkMdOcmfLll8SSHsdrcnvA/vFV8Gb37uGz3WcuVVII7qCi/v5ldMNHSax6o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5170 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 10, 2024 at 09:27:27AM -0700, Stephen Hemminger wrote: > On Tue, 10 Sep 2024 10:54:37 +0800 > fengchengwen wrote: > > > On 2024/8/14 18:49, Bruce Richardson wrote: > > > Rather than having a single define for maximum queues per ethernet port, > > > we can set the max values for Rx queues and Tx queue independently. This > > > allows future memory saving for apps which only need large numbers of Rx > > > queues or only large numbers of Tx queues. > > > > > > Signed-off-by: Bruce Richardson > > > Acked-by: Morten Brørup > > > --- > > > config/rte_config.h | 2 ++ > > > doc/guides/rel_notes/release_24_11.rst | 6 ++++++ > > > 2 files changed, 8 insertions(+) > > > > > > diff --git a/config/rte_config.h b/config/rte_config.h > > > index d67ff77c71..2c11b4eeec 100644 > > > --- a/config/rte_config.h > > > +++ b/config/rte_config.h > > > @@ -65,6 +65,8 @@ > > > > > > /* ether defines */ > > > #define RTE_MAX_QUEUES_PER_PORT 1024 > > > +#define RTE_MAX_ETHPORT_RX_QUEUES 1024 > > > +#define RTE_MAX_ETHPORT_TX_QUEUES 1024 > > > > The Rx Queues != Tx Queues is not a mainstream scenario (at least from most of DPDK user as I know), > > rename it (not separate Rx/Tx) with eth meaning and make it as a compile option is enough. > > > Agree, allowing max Tx != Rx creates more test cases and other things. > Lets not open up that can of worms. I fail to see why it would be that problematic requiring additional test cases. I also think it's reasonable to give that level of control - thinking particularly of cases where one side may require thousands of queues e.g. the rte_tm cases with thousands of TX queues - you'll pay a large penalty for the other side's (RX) data-structures unnecessarily. /Bruce