From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E18E45B12; Fri, 11 Oct 2024 10:02:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 199B040279; Fri, 11 Oct 2024 10:02:45 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 7F8DD400D5 for ; Fri, 11 Oct 2024 10:02:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728633764; x=1760169764; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6SZbqBhtkHjkyGXWtUWsD7TXEmh0bejdaojwEG+ffq0=; b=PDi1ajztKVTbOyW02ZCUxtqKuDpjv6OT3ogi/jD8qWXpEQlPD27vv9Cj IWAWf2J+WgkVN0Sb4t2T00K9hBGhtVOnzyxibvGxKvK9UXc1y4QejOciO gtukgTWSbRtahNUp78T4BCI4DC8Ng2tfIazTBtj4jVfa9l7qCX9RZiwxd h8qL9SbBbZdkn4uylXXlXCr/dhBAGWH+siMnLtiCaUvxVnGHb+wpyCqU0 0jM151N5tbBgyVCeoVXWN67dhIOv1TJy4iurGL9lB1PhxeWGMCNDdPzjQ t8kSuCEGHG/s7/noRJYdnLsDScGzKyO5AMp5egssdAIXm5rW+0AwCSPlU g==; X-CSE-ConnectionGUID: gc+CAO+NRX+nkCd4b7WY8w== X-CSE-MsgGUID: V+eSSFY9SqevXyUtNn6TiA== X-IronPort-AV: E=McAfee;i="6700,10204,11221"; a="31933064" X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="31933064" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 01:02:42 -0700 X-CSE-ConnectionGUID: 5GYuGeWyQw2LxqD/YDZOHw== X-CSE-MsgGUID: mVN426iWQXab0deKQAeOHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="107571246" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Oct 2024 01:02:42 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 11 Oct 2024 01:02:41 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 11 Oct 2024 01:02:41 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 11 Oct 2024 01:02:41 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 11 Oct 2024 01:02:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RjgUiKVogsvCOAGslf2pw6MwlLHuve2T9LV6BuCbQsYoqVlxvzD24AMx3chDUJhcXuWhVjjLxKy1PxQizJ5/ftWfXMm87mBFKdvmEi2rlbvBflQ0o1Z1XygeJ2zK9YCtVfSqSKxLYWUovKXxrB/WstHkvk99k2zjgxrEF8pM4KlslzsZHKhj1b//gUFptRhAyqUT7jlkjQJ/iuLE0Q6HHBI4/uns3hGCTsIpar6dxV1kR1zUX8yDk0KE55h6NME++GvUbAsL8CxyAHYAMCn1vE8LgXm7QcYDh0YqEhnj6dmAeENfNcxTZwT/kpcc39Sct9OUWZQ5QVXDIVasaVT/Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tbl/lYblpZfeQ6ENI4JXdGqBCUzFQO8dz6zUsfpVCNo=; b=sYVOKPFA+24CYdxqZVIk2D56gSLPTm2CgbX/Ez7VzsShxi3JjV4XaQSCd8uDL9NznZWyXUrddiUftIDGbNONs/XzNJHXR3jhEaknQn5zK7SlfSGl0dTcM9U2iqWZ9OKeKrfspDZd4z1sU447Vr/hXoh0RscI6gkGdyBO6QpxsLS6iOLjS5tCs4RWnFB+z9kXFGp2Bpkxi6vPXzFK6j+wn7YRvfxo2cPVXw2CkcT0o/GC5vjnU3i1d2uVU0hJ5IUVdkcxLoamdAjkgLnOA6Mc+NKFeKohDypZpTT4g7awsYM//1Oem0JMcOcN5a+vLp/8NyfmL1X7AVP8XafNQW7b1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB4878.namprd11.prod.outlook.com (2603:10b6:a03:2d8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.20; Fri, 11 Oct 2024 08:02:39 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.017; Fri, 11 Oct 2024 08:02:39 +0000 Date: Fri, 11 Oct 2024 09:02:35 +0100 From: Bruce Richardson To: Mingjin Ye CC: , Simei Su Subject: Re: [PATCH v6 2/3] net/ice: add frequency adjustment support for PTP Message-ID: References: <20241011025332.1423395-1-mingjinx.ye@intel.com> <20241011063407.1427421-1-mingjinx.ye@intel.com> <20241011063407.1427421-3-mingjinx.ye@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241011063407.1427421-3-mingjinx.ye@intel.com> X-ClientProxiedBy: DB8PR06CA0064.eurprd06.prod.outlook.com (2603:10a6:10:120::38) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB4878:EE_ X-MS-Office365-Filtering-Correlation-Id: e8cbbcce-c81a-4b08-31e0-08dce9cb1376 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?i3q7nhbBnc/fDx//7fyhVGTgdUGmAwQ/gk8Zuw7NokXqAkyML2GFk5WT+G4j?= =?us-ascii?Q?jfCZcJ68HbcVDrCHpViNOhiaIlIvKzgqlRLU0StwqX9ghEX2l26eBRDgoul4?= =?us-ascii?Q?pmrWvB2rTVufA1q8YkYQqWsANYKwEwUlp9Vx1sHVl6NT97E5lqqFN2jWhTe2?= =?us-ascii?Q?bdxg3j3hk+6WGkgN9BM85eIaivEJbcsYeI7r/gD1LMCO7GcHlB3BqRDJS08B?= =?us-ascii?Q?OBILU9IzA9G9r7E8rm2XHE+fFmV5vjR0XzP1EqpYoO5CkZyYRvyYoj7NnBlt?= =?us-ascii?Q?VkYDsU2Mt93kqM69EhgDna8Op40CdnA+UXqMf0Ns682Qfts4FXUC5D9Gx7+X?= =?us-ascii?Q?culJA0qZTWvB1puvbgypfoD6LrdEGPfdcl3aEv8Ipzidoyzt104DEKAlGIwd?= =?us-ascii?Q?2XgKjiHn6dSaWlpDO1EA5h3Ddvciwr5TrFzV+RoSz+iC6bD5nRJno9TDA5Ib?= =?us-ascii?Q?Ujm/W44yGFAEu6IWDLU+QcLLA8yVblOcgPVtKMHAgYgH1jjoXtijwiKSimFB?= =?us-ascii?Q?eu+jNd830L1WK5tEDXZ0O5An+r6DVLNbg5rKUUcItFjTwWwNaI8bDWKGfnOY?= =?us-ascii?Q?hcsQWnnzPHljlRj+WOH4VFbfYjaVjeUyd7/7VcifXdm6ZgoCMkGoug1MXWNw?= =?us-ascii?Q?e6x5E1ptiClty7zyB13tp2Te6H1xXfSM2+be1PK1D2fBEFLyiVbwSYxNW/dB?= =?us-ascii?Q?lNuNbC8yqC8MiiO6r8jGOL4tD6RPNJsNkQThuq4rnF/pQOJ6ykeztDkUIlHC?= =?us-ascii?Q?/BQKNMpascG+Rg2A03oTE/zrA4oE9/XEwqX/koNFEzLwvjTomzLOrjIbMQHM?= =?us-ascii?Q?rUZaeURxF2YsH3Wx1g4DxvEu6qYvwzxpyU9dFUZpYFNfy0YTijB2I5z3/6YZ?= =?us-ascii?Q?2q9nBPZvXk5wavHA4a41vx69sugDMG2MYT9+SrTEFmbNVUEfRPlZlktwDKxc?= =?us-ascii?Q?F6X0vXCPf9jZwRxw1FhCkabt9YUM6Gp2tseEIL64jeCz3LsdUEw1OvN9Y0N7?= =?us-ascii?Q?VNuE2pY/XLCAx2h9khvxTDogXnXuKpw8KBCencNT6X8Elh++CHqenmhVO7hn?= =?us-ascii?Q?VQdYcrlq28/iNJZ+ewWxB29HpmyI2WD4jkVzr0W4pLLGOj+0JOrclWwE+3Ls?= =?us-ascii?Q?vCOv91idTnKVYvKVTv69Sx3FJ10Y1e0mGlsPNv8COjnx8TZgL9b9piLk7f4h?= =?us-ascii?Q?opONua8e+rHLdGdrJZn6Q3+jJz/XETYhj2RqS5JzJ/XfefVmq6ED6apct6S7?= =?us-ascii?Q?ExKqXIEjWhH/FykusUqtflMUjcCcsGDb12FfL0c4jw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?358Js8kbaCdvqwucwHpLvOUamFwBsns/IXH30hRlhhWqsd4STOl/OPQsSZiF?= =?us-ascii?Q?uTg+VJXjekFAHVULjjtc9eBMn8GuWGs7N6Rg1BuAE0E0dzK74PjUvBPKsdE8?= =?us-ascii?Q?V1t2CwR5NwKZrnIRASI09TP4sHdeJ9vk9LSaZvrPm/4d2isYgu97oV+HsdlG?= =?us-ascii?Q?EBsMXthXqJyHIl+RIFp816QR9sJFogwbozK8bVKWsfa9fmPMOBGIrMr6mHMh?= =?us-ascii?Q?eYhcltEEJ/n+zVSsl+QzvOuyUWxNX+UXQxb1MIjJM07SrWTEjIzwi13cxwFK?= =?us-ascii?Q?vDKF7D+PhpPxwAT5yZc8+la4Gw7E3VvF9MC46N/Aq0jqBvMJHlxVA72GrHuL?= =?us-ascii?Q?pm2OQGsfRjeT0vayVWu/YFTJWgmO5omrHdvbdRNsZ+I3vCnx7jUbuzdPR2cT?= =?us-ascii?Q?sLlvlFdlJPqCIw5Vtzd4QlJrdxuZgOglE8Gpo0uN1r2C79kJC8Iphy+gilh7?= =?us-ascii?Q?DtIriWsek5GBtRE2r3lLvxm+qBWF0gBXVvDvmcd/hMfn16EqCsaWaGMIrPbG?= =?us-ascii?Q?3GiBdIhDfclPf13mpNKvbo4STxzwMUA8cMjk+a0B4ZKP6WpR8V2ckUDqXZHs?= =?us-ascii?Q?XitUZeUNYWuX9CSKM+2XrIcuim/LZQZoEeW+DyGk9QRzONJIiiYu3TYtM3kF?= =?us-ascii?Q?0FmFKdKcuFsrF196mTedw6PUo3heApreSPM/Qg4qVIDhANlMq2V+ji72baM0?= =?us-ascii?Q?AYfNGO1TleS8TXunosRVNR5CaCqGSoj3O4sBETUY1IkMWUph3QlrL4ZqRxkC?= =?us-ascii?Q?6gX9UKdeDk1kthzk6JfVqYmSpjFUYN99E3HYn9n27AIujnsLu7PkNz0DPstu?= =?us-ascii?Q?l4uXPj/J9Czj5mT+TqNbgKSYgAAK1oAuFEkGRhY0nPnR8m4f9NPfW5xgCLga?= =?us-ascii?Q?cOBOQp/ym3u6Zovql57KSaC1YBkscimU97CQFNYnVf66m7OrYANCrGmfouFk?= =?us-ascii?Q?OUE64qRjEr31ZhKVwy4SQ7OpJiwF+0N9rD18ufu6rQcJX8bROlgFbQ3lbtjf?= =?us-ascii?Q?s/ixZX0Exnt4pRuaVrOtw+Xe+evQ8EAf82+Z/8F1unJr9n61AI1OruiLqk85?= =?us-ascii?Q?Bmhdr49cKugpWkjA63H+N3fc1vUNrPY+BonTEVrEmE0xD/7iFxKriZvaj+zV?= =?us-ascii?Q?oLdvjR9ixw9mb7DvirM9FwwEgyDe1aD3H5ESnwp115ChUJOGzwJ1SusMWR3D?= =?us-ascii?Q?1qM5NE7xPvYSFD6daz6Ow213w2Yb8HYGW7quzONJT1RWQwNUeAzPZoIHoWOq?= =?us-ascii?Q?tjt4M5KSmXt8CZIoOGJIS0pBhjUFYT42rYi6c0QUKxq4Kus5Jfkc481aK4Vi?= =?us-ascii?Q?FrH+0izk7zJqNizzlI7i6fka8ZezQ4f11040+kSF7DsP1c9Z19qknIhJl+O6?= =?us-ascii?Q?8tQI+FP5t8P/d8ixWnuJ4ZLPrIE0y00gtgriLYte1jUndCpe0yM+HELRMe0o?= =?us-ascii?Q?OUBhM0w7oSI7F6FAQR8G10VSL7O0GSKTEKWgwZ0Tci4B1LcY7XeJaurzdM41?= =?us-ascii?Q?RvkOO+VGQedTKmJtyH8K3CMPAUjlAsJjjH3XhmjH55RnGr0X8POK0xQdk35E?= =?us-ascii?Q?mmlFzm/FkABQ1EGcXyEHop/ceYOPCEalGh9a9O4AdN8ANqwE/A9oHbz5muEz?= =?us-ascii?Q?ZA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e8cbbcce-c81a-4b08-31e0-08dce9cb1376 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2024 08:02:39.5760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5fmMPRGNutN95rObW2fk7saa8lGIkmDB5FSm9jYnDlo4ZfOdCRecvHqf6qaIjIOL8mPGlGTLR4UKbp+pavTThicRTOCWC5MpapOnht5RHJw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4878 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 11, 2024 at 06:34:06AM +0000, Mingjin Ye wrote: > Add ice support for new ethdev API to adjust frequency for IEEE1588 > PTP. Also, this patch reworks code for converting software update > to hardware update. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye > --- > doc/guides/nics/ice.rst | 16 ++++ > drivers/net/ice/ice_ethdev.c | 176 ++++++++++++++++++++++++++--------- > drivers/net/ice/ice_ethdev.h | 5 +- > drivers/net/ice/ice_rxtx.c | 4 +- > 4 files changed, 153 insertions(+), 48 deletions(-) > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst > index ae975d19ad..061c8c7a20 100644 > --- a/doc/guides/nics/ice.rst > +++ b/doc/guides/nics/ice.rst > @@ -328,6 +328,22 @@ Forward Error Correction (FEC) > > Supports get/set FEC mode and get FEC capability. > > +Time Synchronisation > +~~~~~~~~~~~~~~~~~~~~ > + > +The system operator can run a PTP (Precision Time Protocol) client application > +to synchronise the time on the network card (and optionally the time on the > +system) to the PTP master. > + > +ICE PMD supports PTP client applications that use the DPDK IEEE1588 API to > +communicate with the PTP master clock. Note that PTP client application needs > +to run on PF and add the ``--force-max-simd-bitwidth=64`` startup parameter to > +disable vector mode. > + > +.. code-block:: console > + > + examples/dpdk-ptpclient -c f -n 3 -a 0000:ec:00.1 --force-max-simd-bitwidth=64 -- -T 1 -p 0x1 -c 1 > + It's a pity that the vector disabling doesn't happen automatically somewhere and that we have to ask the user to pass in the flag. Maybe see if that can be improved for RC2 or next release? Anyway, for this patch: Acked-by: Bruce Richardson