From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF8CD45B34; Mon, 14 Oct 2024 09:57:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D84F540273; Mon, 14 Oct 2024 09:57:57 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id 221BA40151 for ; Mon, 14 Oct 2024 09:57:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728892676; x=1760428676; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=a6bFHfLrjNTj13WmlQ3iyJY8PuWSk+I6Jkth7RF5Ryk=; b=YyvNXgD75HpC86V/I0CWPQyTFZNFTDZbDeVmNQyjlZ4BDxD7jMutDLrj lGPdvc1SoBgqpBozGyZZPwxN5kjlPLpsDnMI392/ACivRGIVimHUULcVX tLgK0YETSWvOFGVpqXNyCtMCe9z0ibFxzMu3UGRC7kj8TXUUDEXem9RqW Pcne1iJEyk3GKcqr2ikFS3V89z+BK/OeSZb8PLVAp9b+RTZlwH1YJCYqr CJYm/lpnAUYL2JwCFLSfYaPspXNtGk99pHYv2OWoO/VRtNH/niWaArZq3 EpQl7j2BO6E/t++3HhDEwYDVQlLBAuhfcMrMYtldTVaskDU86gmq8G9tq Q==; X-CSE-ConnectionGUID: C8HLV29CQyC9kLENlDmPtw== X-CSE-MsgGUID: mi7MHsp1RCmACC+CizSxEQ== X-IronPort-AV: E=McAfee;i="6700,10204,11224"; a="15858538" X-IronPort-AV: E=Sophos;i="6.11,202,1725346800"; d="scan'208";a="15858538" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2024 00:57:55 -0700 X-CSE-ConnectionGUID: R1222hm1Tz+qQkGaZCXxaw== X-CSE-MsgGUID: SNgw04B5Tu2dc/o0BBUcZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,202,1725346800"; d="scan'208";a="114948917" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Oct 2024 00:57:55 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 14 Oct 2024 00:57:54 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 14 Oct 2024 00:57:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 14 Oct 2024 00:57:53 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 00:57:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k6iJ2Ft8z0ss+1MAJqDgnPQre2y6xlUftmXaMZdqnyR7k6FPFJcFGwlMTJtHUEktAypOeWzEzPUY0u8FGDOqht/+Rjmsay19808kSudnknIbnOQmGUVFGF4BtRCmyl1mt6NG/WaowLEIXC9lGqkZHzUxGFNEbjRLANS7Y22pb9HVsdUT6y2ZLU2iuhzQnubfOAa21EVmIPeWC+Nl9JygRFqSaH2lHExXHvj/GD9v/1M+aHvFd5Ht0MjmkypciJhTzUAgswbOZWDd+YF6WPCRM2yOZoYcU+3DY+FE9btSGy0hFiLrVS7kRwG8ybKv/D4Ow7IPSaO2RTPYKjTYu11zkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ltc/ps6ZhL05v/HBK+/j787xnl8hlw/hO1y8jjAFlu4=; b=r7TVPoL8gyQab1OC1MS8234vrMG+FRHyh4Y05lGX6YSa4OXvqyuoFUqtuuNfUWxZLMeje0w/nvAgm7Ud2ENAbn0QPlNqs/ufQHCuAVTMmeYUajZRA7M/WBLe3rCja4cp8eEPImlVl2kHAIqdBbOziezfilvH8VYz9uGqKT82IyZ0/VpdGOWgifeaiEg71/Ms/UwoxQz0FXxYlwM0Xr1Pjgz3DnhkiTUnzZMuy403/sBTHMUNxYLa7lxJBkVpO2qlGU1yNeYC4gkMkIhPqy9pbL9GIGqkKG7lcWtQFaXIpl9f5Wq9B3lS4vMzJz/m0ZCwWE+EmXToK6u1QpmiDYW6Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB7352.namprd11.prod.outlook.com (2603:10b6:8:103::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.26; Mon, 14 Oct 2024 07:57:46 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.020; Mon, 14 Oct 2024 07:57:46 +0000 Date: Mon, 14 Oct 2024 08:57:40 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Stephen Hemminger , Ferruh Yigit , Robin Jarry , , Wathsala Vithanage , Min Zhou , David Christensen , "Stanislaw Kardach" , , Vipin Varghese , , Jerin Jacob Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix build for clang 4 Message-ID: References: <20170417143559.11701-1-ferruh.yigit@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F7C6@smartserver.smartshare.dk> <20241011104817.3cabcbe4@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F7C7@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F7C7@smartserver.smartshare.dk> X-ClientProxiedBy: DUZPR01CA0011.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB7352:EE_ X-MS-Office365-Filtering-Correlation-Id: 13720dca-59d4-4d44-0c4d-08dcec25e42b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?IKkP8BGPmgadoEeoS0Gb+sQ0MJPdKyFDODFKqMZp6qUkXW52H+8t9+Y2e2?= =?iso-8859-1?Q?l44m5o5aZfORf518uf8LxD9jM8LJfksfM3Urp6UKZTqBHDhbaGExxulEAW?= =?iso-8859-1?Q?JV031JTceBLck8m/Kq/46I4KAmG8/wS8qK7tnq0UxMQ/3GZ96lVo21bHvF?= =?iso-8859-1?Q?evLr5cJecr3P2l6tQGOwCVGZxDm08ybTUn3LMlKZsCi6zT8M5QT/srXhIZ?= =?iso-8859-1?Q?zUQyYxPpabQFQHgU0KRXZXhAbcRldFRY7Ie3s+P2+py3j1l3apnTQQYlgy?= =?iso-8859-1?Q?vYvtNSLF19LNRKUi2KC0Oap1O4ugBLCjOXa2i6mXWJmmq/S3acuWDnoQZl?= =?iso-8859-1?Q?wjYmkASi1HHWzD5CZ9sGcuXhBP82AMuzpk60KIo5KNhq+7CN0Jdx6iMgaX?= =?iso-8859-1?Q?f7UtXevFh4nI0yyJQiy8tBRrLPecJlfkgAsda4JqzDSwVpYumStjN1zAKj?= =?iso-8859-1?Q?BkkbqRjR5Jy93+rrjYSbpb82SjQMgZaccliITZyvs0RIE5WJTFAWAVkmwO?= =?iso-8859-1?Q?0K4nSQZtObnZdCP5PcHjSe7Cjmo2FIXo84NV7ecz6CCoyh7UJe3SoAcheB?= =?iso-8859-1?Q?C8vVdo9EqGMCLQPo6pgRGE3Ci/OTF7afrVBGBo69OLOWGqvdqBiMtQ2tP2?= =?iso-8859-1?Q?q1lhsOVanaaVQfGrb7ffjWYpgl+wxmx6yCvY0U1vtKsDLM9PXhUqSErR6i?= =?iso-8859-1?Q?Pm07d+9a4vk52DXOrF9BhL+w4cPKTge+FYeyRbX2fuSDa8A8V5wiEaKzx/?= =?iso-8859-1?Q?8aKtcavkvzyoGfe88cTIGShHk0+Y5ueAb3Or935m2hbcxK5YmLesLK1hul?= =?iso-8859-1?Q?gfGKap5KoPneJ7hxShGybmV1e4c9qpKSWBV+HwQz/cS7PIZeO14WaUCjNt?= =?iso-8859-1?Q?g8Xh+B43Fs8PNSUGXSZZBaomiXfW7pLU3+UlHNU+X4uoOa7KbteI6yZ4ti?= =?iso-8859-1?Q?q8Wm2X2079DULhpOzq9fpQBgAooRF4TlVjwNCSRolCfDwueu5CAYkT6+6y?= =?iso-8859-1?Q?iZBMWT5pZ2uEW5hup0lOLhxsM88BdmO48SZpMYZWnmL9NTCEMYJxiFEM9J?= =?iso-8859-1?Q?sRwe8quy5wCpV4pU0vNmBIkb19dlAX0V3D2Jylq6d1wbZ2a3/XGnunwvOK?= =?iso-8859-1?Q?w+p9HGXDGEfqyv5t5zNlJXAAdMdEoLObjMu3/BRpiHfrF7tGROHFHdUY5D?= =?iso-8859-1?Q?WcOUu77sDQ/jethhWb0q1AOAA0C50EwwZRLX1JGn29nmeIYp+3Tbn2cRhO?= =?iso-8859-1?Q?yWxoleMwUOFRX4JhvhF7l5R1pgq9WmwBbgSllh+whPEBq6YYUuLCIwHuEg?= =?iso-8859-1?Q?lC+084IDbzGBMMFItw7rBlwYLQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(7416014)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?RB10v8NTR7tIFMN0vJoUv2m2NAcGl7YmkI+gMDFgm/BkEHxgnpT7VJf1+w?= =?iso-8859-1?Q?TDoIOpDoPY5xgtjIxoenCi43ZzZbJfwx17MvfbqBC0vU1M2WrTSzTXt2bc?= =?iso-8859-1?Q?B3+R9ljissfkuae6w96EG3b/Z9ntkpZT8R3AQXZxfLViwwrZpEGuQvm5vN?= =?iso-8859-1?Q?RaM6GhErIMedZf4BhYB2ro3xdEsMehwAtFKKjEAcOxPcHJMtKTAX4LitWk?= =?iso-8859-1?Q?VXsK3FyI1+bSUv3D1YkDvzVbQWuYn58fslBab82dfHkKXa1q73TXBhwv9f?= =?iso-8859-1?Q?auZ+R4BGaCqzIp+gTAcdX6o5esIIDz+cLYZc/rzog2F0TDwE2fzJTuwgGb?= =?iso-8859-1?Q?bmKxB3/n21/rZQqBBCbXBvAAVelGdkM8YnvQuF5+unkFeaWBw6mJSr4sng?= =?iso-8859-1?Q?a1kpgkLHdWQjyoW1+4jqM+nhgMhKv1wSMYr3F09b83M3cd/UEl7WE/DHCJ?= =?iso-8859-1?Q?iNu6FZlnAGe5U6wgSoqGmuGIO4+oSUlP8sOz0eCJMR6AkRrRBO7Qg7mIIL?= =?iso-8859-1?Q?DqqPD/yUPpWqiaRRbXTnlI7LnvKTUOhra002MDS+JKSpEV3tgGoo/AriQt?= =?iso-8859-1?Q?6Lk3ZidpMGppgGl7ZN4W3+qGSWNT8N/7Q5DJku0yqkajB6zCzoEIeFXiJN?= =?iso-8859-1?Q?ZLKqs2ORDUoEVMmqzQpVkDbnvf0Jv4/P7Sw5hZF1c9JCFgXHOR3vI1OQam?= =?iso-8859-1?Q?G1Ax2H+T41tY6Vh+ghAtgNHXXmwobtGkXLz69MgObcrYhVmyW4xgBk5uE5?= =?iso-8859-1?Q?rYz69ZlCF4gT800rw6BAt+L6KhNmw+r/j0OGQQyPGt16omHZ9aFzkpJ2B7?= =?iso-8859-1?Q?O47UFqf5zwv+1NaHKyVmmIIMN8zUhz/AauJJoS7y3d6I4IQyp7Lhb26QCH?= =?iso-8859-1?Q?QDalHBvEX88pz5Ab6xV9AZWmZfgiE3B+Gu/GZaC+X2Yklm7md3HYI+GxL0?= =?iso-8859-1?Q?lvaGlbstJU3F1vPgvxoR9FZkBItgRBQqHw1W4mt7QFbPjX43dJ0S7LrN0d?= =?iso-8859-1?Q?RSwmrN8NM0IYwkk/kgUcdxK6PtVz/ULN8AKo0B5rN51a0lrBr73IKZOQKS?= =?iso-8859-1?Q?JBnZt8ubuYYbMluPawehrvrON/9+8y1qF/UqoVMppRUmT35+Znj9KVejRe?= =?iso-8859-1?Q?2rrXXWJFqwJ1Ps/cU1iiQ2i+dqQd/J+7St8iz1m0lyTikEYFZs3ypxfnG8?= =?iso-8859-1?Q?uNSN0A20d/ma4USGmgdTVIo1JNnktiRNVsjyimzTDnaoa5u5p9ZrqBIJvP?= =?iso-8859-1?Q?buw5teyqE/E8N23rO8deGI0vaFidzVJhn8+t03I+71xYZXZQ9zNMaq3YyN?= =?iso-8859-1?Q?WMIAK0um7S6EwEHlzitYuVgRsWzgA4hiwxjwVb/YDN35XEJ7U6kC47I6Sk?= =?iso-8859-1?Q?3Yr9nJkHrHHqoWmqyJpoLSQSLPyvjKhQPmX7iLPR6iaqqkeUmrBNAX7+0I?= =?iso-8859-1?Q?SHWiuE+K0jciC9Narj289iSUSbWDjye4yEgFn5SIZlcfRe8AahdFoP0Nb/?= =?iso-8859-1?Q?dYoCPR17stUVWlL5uUXZaUf1A6eo0+mvxcl7TzgHqay22xcLdvqRlEQ9lh?= =?iso-8859-1?Q?DO4bOpJa743gO9WprX/MAWEfmFQjZcMFi9ZWZaWhDo0XPe06ZwE91VFEA1?= =?iso-8859-1?Q?Rcew6gbkZMUdBc57AYMD1v6f4aLZclyv4ZBuhUqMWd+F2biqt2L9ZVUw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 13720dca-59d4-4d44-0c4d-08dcec25e42b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2024 07:57:46.6970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yZQvLtWLhbGjm7raoBmKD0aDl4FnvA+OEg73hxTZ2TbEXGFH9OqbnXN19Lyqi88w4z8w9fA82esW2QfEuXrYnhL9CtMRAoQ7G+ddGLI9tCs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7352 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 11, 2024 at 08:20:12PM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Friday, 11 October 2024 19.48 > > > > On Fri, 11 Oct 2024 19:36:08 +0200 > > Morten Brørup wrote: > > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > > > > Sent: Monday, 17 April 2017 16.36 > > > > > > > > clang 4 gives "taking address of packed member may result in an > > > > unaligned pointer value" warnings in a few locations [1]. > > > > > > > > Disabled "-Waddress-of-packed-member" warning for clang >= 4 > > > > > > > > [1] build errors: > > > > .../lib/librte_eal/common/eal_common_memzone.c:275:25: > > > > error: taking address of packed member 'mlock' of class or > > structure > > > > 'rte_mem_config' may result in an unaligned pointer value > > > > [-Werror,-Waddress-of-packed-member] > > > > rte_rwlock_write_lock(&mcfg->mlock); > > > > ^~~~~~~~~~~ > > > > > > > > .../lib/librte_ip_frag/rte_ipv4_reassembly.c:139:31: > > > > error: taking address of packed member 'src_addr' of class or > > structure > > > > 'ipv4_hdr' may result in an unaligned pointer value > > > > [-Werror,-Waddress-of-packed-member] > > > > psd = (unaligned_uint64_t *)&ip_hdr->src_addr; > > > > ^~~~~~~~~~~~~~~~ > > > > > > > > .../lib/librte_vhost/vhost_user.c:1037:34: > > > > error: taking address of packed member 'payload' of class or > > structure > > > > 'VhostUserMsg' may result in an unaligned pointer value > > > > [-Werror,-Waddress-of-packed-member] > > > > vhost_user_set_vring_num(dev, &msg.payload.state); > > > > ^~~~~~~~~~~~~~~~~ > > > > > > > > Signed-off-by: Ferruh Yigit > > > > --- > > > > mk/toolchain/clang/rte.vars.mk | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/mk/toolchain/clang/rte.vars.mk > > > > b/mk/toolchain/clang/rte.vars.mk > > > > index 7749b99..af34c10 100644 > > > > --- a/mk/toolchain/clang/rte.vars.mk > > > > +++ b/mk/toolchain/clang/rte.vars.mk > > > > @@ -79,5 +79,10 @@ include > > > > $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk > > > > # workaround clang bug with warning "missing field initializer" > > for "= > > > > {0}" > > > > WERROR_FLAGS += -Wno-missing-field-initializers > > > > > > > > +# disable packed member unalign warnings > > > > +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 4 && echo 1), 1) > > > > +WERROR_FLAGS += -Wno-address-of-packed-member > > > > +endif > > > > + > > > > export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF > > > > export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS > > > > -- > > > > 2.9.3 > > > > > > > > > > Revisiting an old patch... > > > > > > Maybe the code causing the warnings should have been fixed instead of > > disabling the compiler warning? > > > > > > We would probably handle this differently today... I wonder how many > > warnings it spews out with the warning enabled? > > > > > > -Morten > > > > > > > With gcc-14 and re-enable packed-member and no-zero-length-bounds, lots > > and lots of warnings. > > Thanks for testing this, Stephen. > > It seems to confirm my suspicion... > > Random sampling: > - The warning in lib/ip_frag/rte_ipv4_reassembly.c is caused by using a temporary variable instead of mempcy(). > - The warning in drivers/bus/ifpga/ifpga_bus.c is caused by a struct being packed for no good reason. > > It reminds me of compiling the kernel in the good old days... spewed out lots of new warnings when using a new compiler version. > > This really should be fixed. Disabling compiler warnings because it requires too much work fixing the bugs is not a valid reason. > > > > > The ones related to locks are particularly concerning. Since many cpu's > > can't do locked operation > > on unaligned fields. > > It certainly does raise the level of concern! > > > Mlx5 driver seems particularly bad. > > More sampling - zooming in on the mlx5 driver - makes me wonder why struct mlx5_mr_share_cache is packed. > > Perhaps most of these warnings - generally, not limited to the mlx5 driver - will go away if we review if the involved structures really need to be packed. > > > Is a first step on this to change the flag to fix any easy warnings, and then change the flag to be per-component only for those that need more work to fix? That should at least stop more issues from appearing in the codebase over time. /Bruce