From: Bruce Richardson <bruce.richardson@intel.com>
To: <dev@dpdk.org>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH 4/6] pipeline: remove packed attribute
Date: Thu, 17 Oct 2024 15:24:13 +0100 [thread overview]
Message-ID: <ZxEeDQz7GoKPWLOS@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20241017142214.1669370-5-bruce.richardson@intel.com>
On Thu, Oct 17, 2024 at 03:22:11PM +0100, Bruce Richardson wrote:
> The rte_trtcm_data structure, and its substructures, only consist of
> uint64_t types. This makes packing unnecessary to remove the packed
s/to/, so/
> attribute from the structure.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/pipeline/rte_table_action.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/pipeline/rte_table_action.c b/lib/pipeline/rte_table_action.c
> index 87c3e0e2c9..b3c77dbf66 100644
> --- a/lib/pipeline/rte_table_action.c
> +++ b/lib/pipeline/rte_table_action.c
> @@ -109,7 +109,7 @@ mtr_cfg_check(struct rte_table_action_mtr_config *mtr)
> struct mtr_trtcm_data {
> struct rte_meter_trtcm trtcm;
> uint64_t stats[RTE_COLORS];
> -} __rte_packed;
> +};
>
> #define MTR_TRTCM_DATA_METER_PROFILE_ID_GET(data) \
> (((data)->stats[RTE_COLOR_GREEN] & 0xF8LLU) >> 3)
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-10-17 14:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 14:22 [PATCH 0/6] Reduce scope address-of-packed-member warning Bruce Richardson
2024-10-17 14:22 ` [PATCH 1/6] ip_frag: remove use of unaligned variable Bruce Richardson
2024-10-17 16:26 ` Stephen Hemminger
2024-10-17 16:42 ` Konstantin Ananyev
2024-10-17 14:22 ` [PATCH 2/6] efd: remove unnecessary packed attributes Bruce Richardson
2024-10-17 16:22 ` Stephen Hemminger
2024-10-17 14:22 ` [PATCH 3/6] bus/ifpga: remove packed attribute Bruce Richardson
2024-10-17 14:52 ` Xu, Rosen
2024-10-17 16:25 ` Stephen Hemminger
2024-10-17 14:22 ` [PATCH 4/6] pipeline: " Bruce Richardson
2024-10-17 14:24 ` Bruce Richardson [this message]
2024-10-17 16:25 ` Stephen Hemminger
2024-10-17 14:22 ` [PATCH 5/6] net: add smaller IPv4 cksum function for simple cases Bruce Richardson
2024-10-17 16:24 ` Stephen Hemminger
2024-10-17 17:01 ` Bruce Richardson
2024-10-17 17:15 ` Morten Brørup
2024-10-17 19:03 ` Bruce Richardson
2024-10-17 19:34 ` Stephen Hemminger
2024-10-18 0:32 ` Morten Brørup
2024-10-17 14:22 ` [PATCH 6/6] build: limit scope of packed member warning disabling Bruce Richardson
2024-10-17 16:21 ` [PATCH 0/6] Reduce scope address-of-packed-member warning Stephen Hemminger
2024-10-17 17:02 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxEeDQz7GoKPWLOS@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).