From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CD5B45B60; Thu, 17 Oct 2024 19:03:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8959A4025F; Thu, 17 Oct 2024 19:03:13 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 4C51B4021E for ; Thu, 17 Oct 2024 19:03:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729184591; x=1760720591; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Bpa/iMJuS9Ezivdux9ujB36R2p7sZHkH7CNq0jAobSo=; b=G7I47IpozNtkCZkPu82sMLptIlevA77B0qK45YErt7LxhkTNefh6CLMj OcUAA+eZs3kiCthuteH2STPJLLEidqEf5Rxcov9kNpw0QEPGi5hOCcBID +r35a3Tz/0S2O3ho1df3oMYDhXRutnKClG0CvA8opBq7yDSbALtsysqWB HoGfwwKbsVpt3spZ9dRL9ww+Fi0HpVVzesS+JbaahtdGZB7ylXx2FLS/3 yL/3Vo5DBZZkEWVUoBZ7930pgv9MRr4x2EP0Ru/C7xNZ4XTzPU1E5gD6r qzRmCyo+6EylNLIyp3Dt9+L9uHeMPICSHca7Pqw3EU15Xije7rRuYYMeP w==; X-CSE-ConnectionGUID: JB5aTja9Q5iTv0ak1YHCSQ== X-CSE-MsgGUID: YeKRVlgMSWWKqojDw/q7pQ== X-IronPort-AV: E=McAfee;i="6700,10204,11228"; a="46180927" X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="46180927" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2024 10:03:10 -0700 X-CSE-ConnectionGUID: 61SSOWfGT9CB3ie9EClCYg== X-CSE-MsgGUID: e6DU2167SM+1qx3QNJiMKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="116058486" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Oct 2024 10:03:10 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 17 Oct 2024 10:03:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 17 Oct 2024 10:03:09 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 17 Oct 2024 10:03:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UM0la/4Si9qi0T3pzfZWdwEEZ3f3RRcBkJU/7oDvLtMV5AED8+60+Nuegusm/fBXOtTcPYU9DvDa6iHql0PGMZRWln0zRRFM2iKvzH1kdrer4iIGsKUqY9ndkiUvVVMceIMzt5OF+8IPeUhIRW55r+QGg7hbn4SYy4TSLUgtC/EkYt6LCmPR1QS2diHLM/Vk3wNFqU4bVmAkXD0FQxHyT2PbrQa8dNpCz39rwH9CRZUM85ufpYMskygbOTplKdKt+h988zS2PQxb0XltCkiCbO1dMLdTQq8UdTplvkq8EQYqlxCiAdJeESwdvf7mADjotcG51k3TY99m4oJVz/vcSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IgOfdzgl83jzL3hMAL25sg02ULTOKOA2O59ry8nSWA4=; b=ulel3S3HYqirl4TQmPmU26aoB6rukavDxPQowgz+O+LIRN+cJFGlX06c0hTHyRbjvJACHN18u79y/wWHnAOPCmFAOxeJ7hR9RzguqyhLHsg2xPAXUfer+Jv+WPGcoT/z2m8qnEs885wKY3mNJo7h64Pv5vkVSJoYBMqBnWKwyAdzVSX8br+7llv04ay+YZ5bWO7yVAgCCCCc92hpurCVvmZBjNs8q9BVlJ9qtSxnZNhU86hk7XL67nHuyOVuNFa+Cb8SG3bg9vzX6Hqrq2T4OfJVpd2QECRRgeBVFEkdkfTGA0izLpRAbF5moRn3+4BEY6w3NRvj406HBtJCDbUb+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by SJ0PR11MB4815.namprd11.prod.outlook.com (2603:10b6:a03:2dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.20; Thu, 17 Oct 2024 17:03:04 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::2fa:a105:f81e:5971]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::2fa:a105:f81e:5971%5]) with mapi id 15.20.8069.018; Thu, 17 Oct 2024 17:03:02 +0000 Date: Thu, 17 Oct 2024 18:02:57 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Subject: Re: [PATCH 0/6] Reduce scope address-of-packed-member warning Message-ID: References: <20241017142214.1669370-1-bruce.richardson@intel.com> <20241017092148.60429247@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241017092148.60429247@hermes.local> X-ClientProxiedBy: DB8PR04CA0010.eurprd04.prod.outlook.com (2603:10a6:10:110::20) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|SJ0PR11MB4815:EE_ X-MS-Office365-Filtering-Correlation-Id: f78c28bf-33dc-4490-ef28-08dceecd8f5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nC10rjFKVK+XojOQooDh6tyZF/ZxLU7oCYN3KVwynETN5w2JJ+DU4l6n2mxu?= =?us-ascii?Q?l0lSSCQKtuzYldXivJ0EzRs+Qy80QfKmpSfdaltMpC7BFAfj3OYLxqu7rH75?= =?us-ascii?Q?ezVOssBSFonhqIapNman84po6ERLR+XPoiOSWWTWguoCrkiUO1pjvyqVB+Vb?= =?us-ascii?Q?Xnoz1DX0P8cTDHKJrdvVz5c4J0YN2GjDcdihxx8GFh88mnkvd6mX0ulz9Hdq?= =?us-ascii?Q?9XbPROWXPz7r1lgUoRn58ZcysHiS8x5W6KpUEEo62hULn6YPmrfum7DJM+XS?= =?us-ascii?Q?9tV9cbfl84KP9NMkm/L8PJ+S/Zc3cTc+MqhQ6vBNx6RX87mlR/it/9gEHx98?= =?us-ascii?Q?S3ot0kyblz8eLhX9FBEeu+fiRHyEu0cKBsuQ4/F4MHboev+TIuEWaATOIjg+?= =?us-ascii?Q?O8ULU0brm8Mn8fkmJ0VDQrgx0gak/ApUDo63MinwyyXPipTNO6QMtg+OOv1u?= =?us-ascii?Q?UBP++hRqmLtdkOPoK6CS+n2/1LPtvnjBKq8vlpHyndA+3IZkyImDWeoE/B4u?= =?us-ascii?Q?Y+HdunqpNDme+i31QrIrmWpjkmkbesdxXjq7iPqcVFWEWAhJirScU0tShnqe?= =?us-ascii?Q?UrqAH6kmzqTqBcz3A+flW/dzwyf7M63LznUiSHVbnVE88B4aLT8ajz1nzXL2?= =?us-ascii?Q?kzaaygrxnr2xmRF2abm0fmIaYljRctkB8JokuSCgTHHiRpZjUIbngR+k17VN?= =?us-ascii?Q?wuPDITqV/kZUKtAPt31nPKN6E+5eDoMP21Kj2pI1DLsbZlXDq1QrFdHcsgmN?= =?us-ascii?Q?EI+fj8VGO+MrhNjGv9cRECvBUW257/BXZ1Jfy9IcyyI4L3mcAYrlk7SX1T93?= =?us-ascii?Q?yLUIeSgZLosJ1tn1fhZ3K23e6Spl3JArWSGTpAmpPpLvKPt/zr0M8At2m/lG?= =?us-ascii?Q?yCQjsCEgf3fatwKmsE/BBu1HeEqntxUNu6suQejyJmgyWq8ZpCEoU0a5bHj+?= =?us-ascii?Q?6MknQAh7OSead+jnqy+7euyIrIn8pw3pDQKyGHC7JRJq+HNpb6TlF0A39Pfr?= =?us-ascii?Q?qzVtgxmSShzqSiZC51jfyqPbso9koYX7jzaxLsgRCNIbT1NIFqvizPitDzmg?= =?us-ascii?Q?r6uNUmRBV+F48bdyHDbLyWIHHP4ijtSpSvLLAPa7+Rjm4rOGS++dbfJ74tvc?= =?us-ascii?Q?gT3XwFYBWD094cNTJNe1MLeUSceZiNIQtClsyfYYQh17wNAp9BkIKKiWu+G9?= =?us-ascii?Q?5cyimjOQxqmXlq5jhNVsF57ApykAaIRHQ8Uhq8z/VNjR45AHe8wp7KKtejgb?= =?us-ascii?Q?cQ9v00eKia9nf1w3ZK69BOviwaLGHU+l5j6OThRUwjibNz/WpmQLEdELPQiN?= =?us-ascii?Q?umQcY1P2VfKjwicmGs+WC2Ky?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aA08HSltLoQ4a/heHdi4EU28/q6OkBzS7mfx4yNgxonM1Qnn62izXFRzjlRX?= =?us-ascii?Q?oiU8MBnpP139szpDWrKz6eIT50Na4fCsTvckWfDZILs/l0zasQRA/gr4aODR?= =?us-ascii?Q?A+YxU1W6IGtSoWi6aIUfvkXsKu9RkPqzzJc2mq//3usZiOmd2W+bXHCzplFF?= =?us-ascii?Q?RtpcTqJb9tvBONElDHfw9mr3dNM6BWqhxXfi0VJxR9bqI3AkMqU2UqrxyJRO?= =?us-ascii?Q?CkxPSHT3zWQrA/n5yKMr0pscYCCOg8lqemb8K40xbjXxOYfY1vMmxmE5w736?= =?us-ascii?Q?mIF6moTr1rbKyQCXBzAmaKhlCrCLpP9W0vXXNGH29GDuGkiGhPhnjttyrb43?= =?us-ascii?Q?cz6DENqDlFo2wLIdENUJepFASlyVHsNDvdzPAlW+aRURloX88tSRta8tlHsH?= =?us-ascii?Q?gkWlbHCRxjCVMlY7zTf3IdZiyZgNleQkGWZDI8FSKL4Jkjp6QxsnMM8ANLTI?= =?us-ascii?Q?Q3cI3PNizCOb0aTG6x7N8G55Q/sw1ObCIhVIphXHec2AefEFMYlgoqVwwEIm?= =?us-ascii?Q?RdLCGRA+kGtlT5kYBFBtA8y6aJI6QOSMJFud5s7Ee0bj3TRJ8T/tE5kezQWv?= =?us-ascii?Q?CfhsnHC40NfFCSHwQ78jk9wctNy6u/zxyTBYIDJkGqb6KrUvLb5T1lSq9L64?= =?us-ascii?Q?LIBdG9SDU1U+nU1ZZZRah+V71plKzKmokmEe1imZ2P5NEQuIZW1FL5Acd+wH?= =?us-ascii?Q?dgoQzLITsMPP2swJSZkKqHNI9iA0VbGpnvakK8lbG38BAdJ8iwxBEQ3HN6Mt?= =?us-ascii?Q?wRNA9PE9YMRbDRq2j65gkQ/Xq7inGxkn5segD/Nt6H5l3a4UthfAJdqeSARV?= =?us-ascii?Q?twqtacoEqYWVTWK8NPVnZpm8QPcLcnGn1jZ6ZUJjIVkw9Ae++utBSeTiakgY?= =?us-ascii?Q?pj84wpVo4JJh8vBEnUiA4uFI1Smql6AY52Urxvz6PBciJdHup8E8c5ACf1NF?= =?us-ascii?Q?zMsOrg6HPxw32I9hD2Z8anRfmYw9SD7ilp+S/vq8xExqbqhz3tiQWBxTU6Z9?= =?us-ascii?Q?GRy241DGrVv/WhT1s3KoJjANMVhrYhFU/ayeb7WI3muHGkAF8EufV6WdY6To?= =?us-ascii?Q?6k/V3n1EKkZfs/cNsGgeTopTIef2HyQjoSlKrtYEcNcBlnpcfTWEbI02TsSV?= =?us-ascii?Q?o0XlsU8kl8q//lX1sd2zCTbOhbUzn9+HD0lZfJgG3hnsi2LVuLyqGx8n5VTf?= =?us-ascii?Q?y9mCoP3k5jWeX2HYBNozgxJ10+eixsOe4Vd7opx2P6AiUj2xcXiPWAoWTjSd?= =?us-ascii?Q?ZcpTWWkoWEtSs/pdmObF5aXc39+iE5oafGIuEzl+xBKQBYEFNj30BDmPkNUa?= =?us-ascii?Q?RDN4kRHKTPEtNynucP4ykp9s25DXELkVzNHcqx/OsPrhjQsZMsDz4YFJZbPS?= =?us-ascii?Q?SWsH8qVAK1De0hvMz35rsFlw+OZ8wGF5tuxlM1jkHVwTzwqmltbvmrkCy3TU?= =?us-ascii?Q?eD2GOA2RjmwxSs+Qpu6tYUt3UdfQEf/ZPueimzN3Rge85Y3y5cA3tG6zPwt2?= =?us-ascii?Q?MXihJUEZtdl+/k7wJaPfvgkrhdm2CfBA2W1R2UvUaPBDcx2Xs2N5Z6jYfnTd?= =?us-ascii?Q?Wh2TATESvjq/hWjjFcs9W3Cl5d1UJG7KDbiFXXqtt/us18afdQVmpKwhyg0n?= =?us-ascii?Q?kA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f78c28bf-33dc-4490-ef28-08dceecd8f5f X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2024 17:03:02.3369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n7tfOwk8cSotNh2IbA2eN1ekEuPXxWDlLWA4WsCQidjf36p5pjLjcNeV/cDcMxNoXlA7mXO/T5kyn37WXABaPwabLVFU9Bg6RNLru9L2/9M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4815 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 17, 2024 at 09:21:48AM -0700, Stephen Hemminger wrote: > On Thu, 17 Oct 2024 15:22:07 +0100 > Bruce Richardson wrote: > > > The warning for address-of-packed-member was being disabled globally in > > DPDK. While for drivers which need to access hardware-defined > > data-structures the use of packed may make sense, for normal libs and > > applications the use of packed data should be generally avoided. > > > > This patchset initially applies some fixes for cases where we are > > unnecessarily causing the warning to trigger. Thereafter the 6th patch > > removes the global enabling of the warning and replaces it with more > > selective disabling for drivers and for a couple of other components > > which have not yet been fixed. > > > > Bruce Richardson (6): > > ip_frag: remove use of unaligned variable > > efd: remove unnecessary packed attributes > > bus/ifpga: remove packed attribute > > pipeline: remove packed attribute > > net: add smaller IPv4 cksum function for simple cases > > build: limit scope of packed member warning disabling > > > > app/test-eventdev/test_pipeline_common.c | 25 +----------- > > app/test-pmd/icmpecho.c | 23 +---------- > > app/test-pmd/txonly.c | 22 +---------- > > app/test/packet_burst_generator.c | 49 +----------------------- > > app/test/test_reassembly_perf.c | 29 +------------- > > config/meson.build | 1 - > > drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- > > drivers/meson.build | 9 +++-- > > examples/ipsec-secgw/meson.build | 6 +++ > > lib/efd/rte_efd.c | 4 +- > > lib/ip_frag/rte_ipv4_reassembly.c | 4 +- > > lib/net/rte_ip.h | 33 ++++++++++++++++ > > lib/pipeline/rte_table_action.c | 2 +- > > lib/vhost/meson.build | 5 ++- > > 14 files changed, 60 insertions(+), 154 deletions(-) > > > Any chance to just fix all the places and have it enabled globally? Not any time soon (at least for me). There are a huge number of drivers with lots of errors if we turn back on the warning. We should look at all our common structures first to ensure none of them are unnecessarily packed. /Bruce