Re: [PATCH dpdk v5 08/17] cmdline: use IPv6 address structure

[Bruce Richardson <bruce.richardson@intel.com>]

On Fri, Oct 18, 2024 at 04:05:44PM +0200, Robin Jarry wrote:
> The previous commits introduced a new rte_ipv6_addr structure without
> any alignment requirements. It is not compatible with the in6_addr POSIX
> type available in netinet/in.h.
> 
> The main issue is that in6_addr is not uniform on all platforms which
> causes unaligned access warnings when compiling without
> -Wno-address-of-packed-member (set in dpdk by default).
> 
> In order to have a consistent code base, replace in6_addr with
> rte_ipv6_addr in the cmdline library. Update all code accordingly.
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
>  app/graph/ethdev.c                     |  4 +--
>  app/graph/ip6_route.c                  |  6 ++--
>  app/graph/neigh.c                      |  2 +-
>  app/test-pmd/cmdline.c                 |  4 +--
>  app/test-pmd/cmdline_flow.c            | 14 +++-----
>  app/test-pmd/testpmd.h                 | 16 ++++-----
>  app/test/test_cmdline_ipaddr.c         | 49 ++++----------------------
>  doc/guides/rel_notes/release_24_11.rst |  2 ++
>  examples/cmdline/commands.c            | 30 +++-------------
>  lib/cmdline/cmdline_parse_ipaddr.h     |  3 +-
>  10 files changed, 34 insertions(+), 96 deletions(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>