From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C277C45B69; Fri, 18 Oct 2024 16:25:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F5754025F; Fri, 18 Oct 2024 16:25:07 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id C3D444025C for ; Fri, 18 Oct 2024 16:25:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729261506; x=1760797506; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6qjgPLpYNEiRbQmeCRtB1opRgp9N305EBH17X4b78PQ=; b=QtJ9/2MDXXknndKWEC0oFgp+8QVHjnTOrL6C+LY30t/CxrC/C+iCRxEt c9Uss5cFfJoRaFrEe7hQgTR37wYRzJ4v0RxulavHHV66Tzkyyox6cKTu4 J7XGtggJeLVPyGLD8Jhbfps4ypbNurGl4sccj5N8txGtD5JHspaphiGM+ wmd4CQ9HGdQtMRTH8/RmtxQWX5R/kh9E7F68x3OJvF1hqcpeUhlhhzNZ0 +t3+GbBRK+0me/C9+pflGCAjAuIqu/9rRblbyUFDu4SmO91oyl0vfKcDP /ZZTybMg+RMhdPjAKBbw9ypVq+n4MLt9coiAf/Cq4sBhHIWC04IK0LifV g==; X-CSE-ConnectionGUID: 9jfaDLYfSYadK6Db+uwg0g== X-CSE-MsgGUID: O1ExTaMoQxGq+PTuSi3MCg== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="28754668" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="28754668" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2024 07:25:05 -0700 X-CSE-ConnectionGUID: AZRrUmbWR3STxiCVKoVuxA== X-CSE-MsgGUID: +XJeQ/sCRNirqQWNSiEEnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="78839351" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Oct 2024 07:25:05 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 18 Oct 2024 07:25:04 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 18 Oct 2024 07:25:04 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 18 Oct 2024 07:25:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ym7MmwIQ7U/Rf7ueG6GMCvIfrqDckm2g9shwdfvTqYb6/9J0rnpUIOsKd3AnrvgKMNi1HDzm3tCUtPGtHUdB+g3llOopf0+e7afsv2Dt4c4eFcNSUy6WsPf/o5Y791xY4mPQl6dfbd3VhF4P1qx267/Ondzf+0Q6Kw2UZQ6WX9KTvgpf0ZsjqXAg5Uc9oGWe3m5dn6Nw/7kY4Qk7YwAciy/n2t1v7XK7SK462sBf7bEjD3W4sbMF0P8ROuBoQeaczuhlIFrEc9NC9hF4bWgXRwYQ79HHh8R4kJksIEW1rzEs/bYwY9EbUb4vKP/V2r8qveJiCpPKgB7Jx0Vo0Bw9BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gl51SDQWWuqgegsjYVscM+FFgpEGxHosCGcTvE73xSw=; b=aBv3HfZT95EGE0FAJo1iR4XoqVfmmIhUrl3WngUOCRoSrRaeAf1wJhkoZAQ4VrGNOkh72cQy/ZR2dSD5hv7LkUH/leEc83xB6kcw4QXhVHu3LUFb3F5yAoz+s1CTW+HJnV5U8A2aQkYNtit2bEYwNtyPrJk/drBhsM9z6FZq+7ob6DZKxEepml7iPWo5An6Y0+GKH15ewLeT7zoI6B9Cm1EFiVIn8UxowfQamVwIcEnT0gJh3P+wkkkgm68GnbBKQjG/sWOP1uoVkg58qAXUpmE7eTqVHMMQeaXku7JLlh1MZVqQEIvbdwASlC982R8in50nMOHDGfNSi4j4e0su+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7848.namprd11.prod.outlook.com (2603:10b6:930:6c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Fri, 18 Oct 2024 14:24:58 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8069.020; Fri, 18 Oct 2024 14:24:58 +0000 Date: Fri, 18 Oct 2024 15:24:53 +0100 From: Bruce Richardson To: Robin Jarry CC: , Sunil Kumar Kori , Rakesh Kudurumalla , Aman Singh , Ori Kam Subject: Re: [PATCH dpdk v5 08/17] cmdline: use IPv6 address structure Message-ID: References: <20240821162516.610624-17-rjarry@redhat.com> <20241018140553.79789-1-rjarry@redhat.com> <20241018140553.79789-9-rjarry@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241018140553.79789-9-rjarry@redhat.com> X-ClientProxiedBy: DUZPR01CA0056.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7848:EE_ X-MS-Office365-Filtering-Correlation-Id: 5da6e6b2-9c0c-47c1-f9cc-08dcef80a4e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CbEp852MOx+pdOj43Oh2wJHd1qWrsj+UBq23fxL+/xLWnFHPbqqeqCbcwh5E?= =?us-ascii?Q?mixw4UBwlqQgxgf88SRYfmgQAu3rNWHOC+m47gh27MXB2bvgDN5q5/VgMrN7?= =?us-ascii?Q?zPoU8J9Zxd9Q7TasDpo3TeJG10JCay5z8H2IMX5O8aeVJugSMBcdVIc7waO8?= =?us-ascii?Q?rsAEDLzVgOuxRqPB5CH8i9L+j21lJ7A9ffF5FtQozyX2tg3qMib/kAvdt1j1?= =?us-ascii?Q?FeI1n3+zs81h/EtRaCo87F+zStVZt6dRMqAIk9qb3Is7bfmVDP1+pj/lyxa4?= =?us-ascii?Q?to/vE4q6aUHD6StTgV2jdjxQpCLM28xWaNTCmNfbXxebTFJWmmUbzNuD93xf?= =?us-ascii?Q?/Dx4UjhqUJsovj/U5+tqZKUUT2/eF1Xodj3wyR2HotpdpFeDQ4QAwwsJrtAH?= =?us-ascii?Q?gMmoZbA2OT0xIZHxyEPq8jcP/SPVTMXEaZ+XICI3U9MZwCE30sSLuiqJ0WPn?= =?us-ascii?Q?539B+boMpDcRC+LPPzn0EYN24BKLQp2JUmV9Aw0XJD7Q46YuTDvduQ9z/s5g?= =?us-ascii?Q?0Zk0qrvYIlwMbCfWliwGAHoTQsfw3RM5Fa8nVhjXwGIzVl+XIxig09XG8Y13?= =?us-ascii?Q?ecvQfVwIWNhfpX6pCH1FDDcIL7vaSPFtX6Yaa2txZzMoP7mV1iPYHCgI1m1h?= =?us-ascii?Q?Ck6Uwib2JiNTj3cQjppgVllfkTrkeNF4sB5nc6dvKGIeBpgU/ZBgRc+KzYsV?= =?us-ascii?Q?K2+8Hht/N0jAYsLPHGVVdRUBzngx37hXwcn0mL6OAfl/HWDP5fzTeUKZKzwq?= =?us-ascii?Q?fGx7HqXcMy7dilAU6ShoF/8MDZAURTmX8S8K9EJo9e7zb6X0Uku373BuvgD5?= =?us-ascii?Q?BgSepjmFxacuEL4VftPnA+ucjVkNBp0kwY2EYdjAj+d/musHkoTBOOYCYAmA?= =?us-ascii?Q?sUAbgGnd3HszcWsZwLt/PdIuWLZPlM//3epCNXwnRy8YTOkPTqmjA/UZthKs?= =?us-ascii?Q?BCrCwhVIJIT6LvY9ASuwHkUkLzQWwX3QvUEOnuF0KusnQgf5WVO4SnJzg4Vr?= =?us-ascii?Q?EJXnK1iPGUAJV68qIpSAa9R0vUL8Tr4ZJyVYLQJI4dK7nGzJ0hcrd21kc34v?= =?us-ascii?Q?JnMATxkbuIh3kFpc9/hqDNEsrtj/862rBIjUQcaugIbJ0/9reFmvDrXzwsRD?= =?us-ascii?Q?nKXmj/N7hPqlyvj1lgyhCxrZowLSQu6XBB0DPu86INP3DhlWCmAabcFOuxpA?= =?us-ascii?Q?3V1I3I+GdYFHL5YEYgiXqascNw2yPjJcJndDqWsS7gZZ3dLT2bmt9FUiv3x6?= =?us-ascii?Q?72Aqwm5O64Gm9dU9t3dz+Np47Ye2r5WyKzLiLMo4ZILJa2FPDWcd/3Eb2jq6?= =?us-ascii?Q?PfJ8iFfkJE2WWNzbJioZvQgQ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NvexWp6a0qMf25UaHIEshqkcxlIDoP4/Nau+4WeQcYgZlYxippKwQzHsc1uF?= =?us-ascii?Q?JFy4CS8lGGdP3FQNd7NsKZjRC/Bk5smeofCnLdoy1g0J5POgMKgV2pIxsov7?= =?us-ascii?Q?3aFjl1l8pzMpwNSMCNDggvTVhugQZX9Znv21WKAEvbazI6C3Y3ZE29RSLYqe?= =?us-ascii?Q?hNIUBf/B+5hta6mKybEqzS/d5zgr4tBJksDqzkbqKpI8mhB79Ns84q7PgCkW?= =?us-ascii?Q?IhEYmyAGfLKbEey3V/7j+KAUQ3WJ568qnofOAqBY0TugwQ+Xd3EzoGG3a2kg?= =?us-ascii?Q?bvwLpxlB/GR+GpOG5NOOEsWtq9+8zpmBGSc6L68oSuIDO0T+mjzLdhPAXXrV?= =?us-ascii?Q?0+zwf/GzdA1xggOgBXERfUnp42QQIKryDgsxAoOMDodV3bWmvtrYxZgStZ7s?= =?us-ascii?Q?g+03kg/zueQxfAF4u6bqnqckZ1gM3jgN+DBruPxUreiLQE50rjQcooGl08mT?= =?us-ascii?Q?IpCA5KzzcltM32dLqtk13uh60MMphlK1GIl6qNZG/3zd2i5fG/PNPW6e6nDT?= =?us-ascii?Q?fynkMvkljV6BvNCw1ez2C9i+tJVARLWdaIInCd+zcOLEh7RdKTvxU329ipFd?= =?us-ascii?Q?oOK7QmPl5b5vKrtTTx5W8Bzs8WSN31xI8DJtsqT02lKVD6FfGG6S52EkDfGd?= =?us-ascii?Q?bVXqkg7ga80fxg3x888U8NjHaxABXlP6QqVB4MCy/Mg3uzebp7tzSVwJzoF2?= =?us-ascii?Q?OYYmvzNfjMJ+6M24ZCiA+Zj5jjiweKiMLDo9XPIEoLRlmgeUIxS63/BsXU9X?= =?us-ascii?Q?79THXjgBrLfU7uUqI5WLbpuzTigRfThop5LGXo4JuAESHnTptdTqnl9m6Bsg?= =?us-ascii?Q?iEieWj1+8+x8vz7xTkKmGf5k2s+Zy1nHV6BT3lCElE00/QqlPp048IG4nmEJ?= =?us-ascii?Q?ktvjwVjVOk5CkmVi/BPmIKwZ5cf9udz15jHTM7HpTZ2qA7tTnFOLp3DPweXC?= =?us-ascii?Q?yBzPCTW4eODwuSMIjxaX1Aq9rly7NyRVEPdhDqR2bVtXqv2Kl/0FUmg3UIFN?= =?us-ascii?Q?pM7HrU+DYBRAMWQbrPcU5enCsNSbBmLguoc2IHvNMgv/s/QiZ+3Tw+1HRv/G?= =?us-ascii?Q?oYvxtnfqSUBs6ijX/LK6SzaBGocz2/C4EvelIcZSj2wSw3sobdfhgGoYqV7Q?= =?us-ascii?Q?7PQpsTqtmMoJMutzEuasEveKwntNgQiA/eYqB4CUj/vHwPEVlepHNB0AIiUu?= =?us-ascii?Q?ZWAjI9gk5OkD2oMumaRPzloXyyUjtClxFaVrbgzuUHMD6+d0reXloWfORfQT?= =?us-ascii?Q?r5Ksi2CqRFhf/ZJlyPQCK9aNeClbORpXBQ+knC/3ZqgcVO6+VS8sNt/5Iui0?= =?us-ascii?Q?XGeMDnuXxX1ZSU/jEUPRFR9i9kP3WXJVDFvx+lHOtOw3QU51/Qjd1j20W/Gt?= =?us-ascii?Q?QUJVx+j09Ivyfzl64r4aq7gStGVJxxY/EBhTFhwGi1TAZUrZ3k7ojA6XKzK+?= =?us-ascii?Q?1YCF5Y9jn0YfgSvpkKgLrOtnBS0bPhmdC06Rs3Sr1XA3bYMAyzjsizS+tdHb?= =?us-ascii?Q?dzrZ2rAzzeTezo5KVDZ8Ez+QEFUJOvO/p27J2eqSboW/I1H+w9DmOPO5eSUo?= =?us-ascii?Q?rYt2jv2JOqMHsvSr/6kq9uvoAIMk59siy2KvhUYePJK649X3ANdpIoJ9wqyy?= =?us-ascii?Q?AQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5da6e6b2-9c0c-47c1-f9cc-08dcef80a4e2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 14:24:58.3504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DqOr/sDQXumOo02dhA02wOOya2R+QQFwbeol3twLjU9we1LcPwJ0k4tCgCq9NkCQpJMvZ5ESjSKW62qxW6SvuN+ztmttICl16AX1sJUrhjo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7848 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 18, 2024 at 04:05:44PM +0200, Robin Jarry wrote: > The previous commits introduced a new rte_ipv6_addr structure without > any alignment requirements. It is not compatible with the in6_addr POSIX > type available in netinet/in.h. > > The main issue is that in6_addr is not uniform on all platforms which > causes unaligned access warnings when compiling without > -Wno-address-of-packed-member (set in dpdk by default). > > In order to have a consistent code base, replace in6_addr with > rte_ipv6_addr in the cmdline library. Update all code accordingly. > > Signed-off-by: Robin Jarry > --- > app/graph/ethdev.c | 4 +-- > app/graph/ip6_route.c | 6 ++-- > app/graph/neigh.c | 2 +- > app/test-pmd/cmdline.c | 4 +-- > app/test-pmd/cmdline_flow.c | 14 +++----- > app/test-pmd/testpmd.h | 16 ++++----- > app/test/test_cmdline_ipaddr.c | 49 ++++---------------------- > doc/guides/rel_notes/release_24_11.rst | 2 ++ > examples/cmdline/commands.c | 30 +++------------- > lib/cmdline/cmdline_parse_ipaddr.h | 3 +- > 10 files changed, 34 insertions(+), 96 deletions(-) > Acked-by: Bruce Richardson