From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64A4A45BA3; Tue, 22 Oct 2024 17:25:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22BFA4029B; Tue, 22 Oct 2024 17:25:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id D6A634029A for ; Tue, 22 Oct 2024 17:25:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729610749; x=1761146749; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=th5QFonfKwK+gbcwzmCH3lBKl5994IgJiYEZOq9wQjk=; b=L3gFWiW+J4xbM4KgtFqpcldaewPaRuXKH30Zosy6tcg59Ss9IC96/j0E w6JDYWXQIVyNsidMvXEAR4r0D8UamoLvrNV6iNm6kdt6UgY0JXYlw4mni A4gBz2hTTcP1hZ+yi1IbQZEBX5xDiSBBklOvqg3WqQrDGGyEpjVLnJKcX /eZVdRHBn4jUoQmy7BmACbyhEpZzUw85U/nYRCq8K4J1ybopTxg93WfgG JN3cixVW8Q4DVn8bLElD66Ajx6ownn9LeicakaQjMP5Z/Gr0xlHSC5z5Y BM2kJKvBkXzdwVZaQO4Q/e50N5Cim6g4URRbyS29x+R9Y8tD/LEOgI0DO A==; X-CSE-ConnectionGUID: xYTp15LbSqKZc8aDzuaZzg== X-CSE-MsgGUID: t32R50EbSyiiRB11SnuZEQ== X-IronPort-AV: E=McAfee;i="6700,10204,11233"; a="40529893" X-IronPort-AV: E=Sophos;i="6.11,223,1725346800"; d="scan'208";a="40529893" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2024 08:25:48 -0700 X-CSE-ConnectionGUID: hIK91Cl2R+e8yEzonxpiEQ== X-CSE-MsgGUID: aDGaz4S8StSHWMQ6Hjw83w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,223,1725346800"; d="scan'208";a="84978622" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Oct 2024 08:25:47 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 22 Oct 2024 08:25:47 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 22 Oct 2024 08:25:47 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 22 Oct 2024 08:25:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vg21aZ0ZQP8++sz/Oq8jPGgwjAXbP/JFBHhiugArg/wbyTYC9veinhY+PWn1Zo6OdNZPpo0sCqPiv+BpEYkIU8dgGN84iH7rHBaprgqU7vIAtgNe2I/pYyEsR6rQWS+KkES8+dchgZJaUXtVKmo2YxJoopyZopmp5Qa8EVv5+PV0dFailoEGSBBNH9LySNLszZqWxw5y5S1mRp3qEyHmyUF+mpRtK9gXV6p8mOvLcM0iLPtKLAsOj1QwoXyohw6MliO0u1dzon/F4zMPklIX2k1SBRRwBoi8hZCRV8T9oJVbPitE6nhTr2G8Y7PrwQzdbSUmpq5oq9umRUx29/AjSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FQrlyOL0H2M4EHozoJEfF0AfenLawJjVWaaBneOvoWs=; b=vO3a4f5HtWWWrsE9CU8uYyWoVmiwRMJ4nlMlzy97sD6RdKtCzk4KlRxYJ1ZZnt7HmnSo98eEvf3NbXz1g4jeDw/6mFEfSx511nnnzbLLeOn4K03dWuJTZInZwT+4ki5gyQgxw2LHmsNEJ9Q9Ntxx2Nz6haLjjkHRVEBbdYklrdTObKgikhjX0bih9oJ9pof/temBzxX16GJCQI57lA5lgHn4SuZ1NLto4vYV0HtFgQvqZKPp3eXX9mgQ4OWwXpDsrnGZjcbOFepj4XpwwzqeKuUdQH6X2jWoJAHvY/8J1Zir4ViUKCaIXAWWNrjnJ5ydSpHonxjHuQcqV3QK3Qdlsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8239.namprd11.prod.outlook.com (2603:10b6:610:156::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.16; Tue, 22 Oct 2024 15:25:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8069.027; Tue, 22 Oct 2024 15:25:43 +0000 Date: Tue, 22 Oct 2024 16:25:37 +0100 From: Bruce Richardson To: Robin Jarry CC: , Jeremy Spewock , Luca Vizzarro , Dean Marx , Thomas Monjalon , Juraj =?utf-8?Q?Linke=C5=A1?= Subject: Re: [PATCH dpdk] meson: properly disable docs Message-ID: References: <20241022151142.246535-2-rjarry@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241022151142.246535-2-rjarry@redhat.com> X-ClientProxiedBy: DB3PR06CA0030.eurprd06.prod.outlook.com (2603:10a6:8:1::43) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8239:EE_ X-MS-Office365-Filtering-Correlation-Id: a11b1d69-a097-4746-10d1-08dcf2adcb5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZDNUKN6MveLXWNnEGu5CoM2xVFYccscy+qzUMaIPkRFw3tKkXl84o3IFwLCR?= =?us-ascii?Q?iKugVnyFdXNzYhcfjoOPZiNjLwCgbyibew+n1axMGjrq/qvY89iUtrqqB3fr?= =?us-ascii?Q?+PQf411zsXcivHM1/bsq0dTzo6oCUyC4108VvkWjBE9wxUGNeWz/N+ZIffbB?= =?us-ascii?Q?7684EDScfsUSka2iXX7esOV7dYpI1Ru8Dva4RpstfF1T79qproEarldGfNPq?= =?us-ascii?Q?f13IIsGL+Jnl+SPBrk9sXCWnE0JpUKUnkwfEMjl9fModb53F2N5Dhcmttvun?= =?us-ascii?Q?Z8+NZySzxdGVHE8NCFsCEF1bz6W56y0XGQe54WSb+dOYk9q8W580IzMY4F9G?= =?us-ascii?Q?xA+Ds1DuerzxrVD44mFwajBMBAH/8/ydTtXIGSuWhJlxWLAszVACMJT1rRHW?= =?us-ascii?Q?Bnm/WYzTNKAWNq10pDMI9PwQSuhCdzylr/w5yM7MJml6Kr7U3nhNX66hdHi4?= =?us-ascii?Q?HFSHZ9hY4tLlqh0duxT1B6k8UNX1z7p5Cjb3ib74bUAxKROmw/lbIo3CvcL8?= =?us-ascii?Q?/s0gWrTBAndt2aEn4dU+HpqF+gYNV2tSnD6ZqMQ062eQzlvWuo3mVIfZ9KoZ?= =?us-ascii?Q?gRXOaeQEKuHP6hnCPQyYEOzrBarhhzxF6UvLPjN58ol7zi4BV+EjOYEKwKFE?= =?us-ascii?Q?JfoDsrfsasvoubODTJpLijEyeNcRe9yApi0jELOKtdFuadj0W0/HitPxiJox?= =?us-ascii?Q?pQAPnrbjYR+Xvq7a8hEJIJnxXusXCFaD2zzrHVr5UaAPc8ZvBBr3ZDWXRLnI?= =?us-ascii?Q?lw3SEF7ofQ2nOBjYKSbIlJVbvlCXpkVvgB3YgCR28ww2gndexQDv7NuxE5AH?= =?us-ascii?Q?0Ns/GfBunwp14XaJ2pKMrOBX/A7ocqp/v8efGN1l28BLddChpACZmOVyBhvT?= =?us-ascii?Q?2a/qLToAB/gyO8siTCSFYp4BdZpuAgQrksAUJrhU4gNpQfRK1aRl5+qmncna?= =?us-ascii?Q?aydAQkOd2z5f1nvCjnocDB0IHRfsIs0TXKm4hXrQ6d2pzr9NQvcEA4ebZmfp?= =?us-ascii?Q?hMoeCVw/ADgJzFc6glVO+pBAYUFzy5FEhe9Q9qkAIpRPYNunss4o5jZCBlE6?= =?us-ascii?Q?F3CfAZtRFStvyiaOhdRNZOKQdpNVl53pdrY8Ix/bulNFG7LR3fO4jrnjXYxz?= =?us-ascii?Q?Eb1odFSUIrY8/1q5hV+ePz7nymZKfqQLrwksH5jDklIWqDkr64NUMQX5Rt5R?= =?us-ascii?Q?MEjf0tMeJNlZnxE3YysIG+r+dsi60S8WzYo/A5nnAhTsr4qONQIiemKZAUZ8?= =?us-ascii?Q?1r+IXWNDThsKW3jPbgyzaxi87TS87n3xGzL2ISvcRT7yKooIIJxaGBQWqeU1?= =?us-ascii?Q?JKSK4ZSbI5e6v/6l7/CkraLA?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gjGT01xBHn8zWQLiMsqq0smCWmijZygvz63LID6FzAsrsQnYpuMotngp5h2T?= =?us-ascii?Q?J6w3nven1lzMUJqMgvP+43uOncpJUlyuSIPfz4GA9ojg5WHelrUWrGqlh91R?= =?us-ascii?Q?+Y1Bie0xi0xDgu5+I/oB4X9EFatk/G9X0UMhgjb4clSS6OsO6s57kgJelvRb?= =?us-ascii?Q?AQ6yn92ktShL19Xiw9qdEM45OvAwdVlH8euYg/8gmeqFQC0pTfpoWg/aAFEp?= =?us-ascii?Q?UQvJE5lJqf7ywYeAVi4/t06TGwQQ17DOhiH0os86AGoGrrTCl5le+b6MjE7P?= =?us-ascii?Q?hUxIY9hXq+snh1o1w/LKAGXB65raySNL1ck8zrUuzlFH9GrwvSVvPIU3r9by?= =?us-ascii?Q?JpzIeGeewDQwxQlR54lZ9VVehiE2yyYYHn0akYjGXulR2OswPmJbSTWJJ8mp?= =?us-ascii?Q?S7W4koIdSpTykZ2aYZvBGszDNk0D6oD9GLWNmSLN0TE++VbgJJuEvnQXlHxv?= =?us-ascii?Q?5PUTgkPXdIbM+COF5rVfAcq4nEZS1NSIadYnFTon74ACnvixR+znYNB0XbHK?= =?us-ascii?Q?kUeWiBTTVMLmWVIRQIuz9jw3wfFZ3PBMEEVIhMVVRy4ePZ+sbfDMIkkU4x8W?= =?us-ascii?Q?IfOxLhoHIO92zLPDuNeIHfQ91mX7Q/npkiYtc1D+8oefOak3DMlVX+VXImm/?= =?us-ascii?Q?BL1s40FzI4cHIQznVTRaEWjk+oZg9RJCKB1bQO0fDhej8FZRmG2MGa1fNRYb?= =?us-ascii?Q?Tip2PKOPIhzyaEJheqmZlipZNHn6Dh5nES4yaVMm5PKVBgqengAHO3+A+Xle?= =?us-ascii?Q?eH5tGNeaKnEpeMoN5GfXW6CEbtDFeT5Va9mck5/qXLHY40/AUShpGcb9dsn6?= =?us-ascii?Q?VDAus5azCnh988a5ejRCvL566yMjLqwgCv/Wgr698ozDOyT4abeXGoOVupxs?= =?us-ascii?Q?7o67VgX0cQCb0BkQmXRqzUbX5UPfNUtyZIjcqfwb6aIUHH4ovWhN/vt4d4Ty?= =?us-ascii?Q?XFMuNAI9ZjqhMWN4tQBhPtf/VwrZBaf/reLCz9KS5fPFcyuHUE5Dj68y7kE3?= =?us-ascii?Q?7bO/PyrpWg7pnfCHkV8jEqJvD31TkzlEK1HA7MQQTmIBSDZyqoMme+ujOBhB?= =?us-ascii?Q?nFOcj4q2osIoo20nOKx0+XmzL5oD+ibSNSVcPjcVxPWjzw0DZL6kh1nfaA3W?= =?us-ascii?Q?rMAu73oh/4S4q3R5PUzPu9HY23KrAygYfXIlqBiFTZGIR18DiUR1jFJ2p2Mr?= =?us-ascii?Q?NaREcqP/HBFVdgvqP6ZNqHbaRFTHTLNw1rN8TS8+DVhW+SEtD5HdFs7cp3av?= =?us-ascii?Q?fdnCQHn5QYhgLZPV6ikQYCYe6AX95dLx+oj4pPDs2JvVYLf0ND9VWRNmOHIC?= =?us-ascii?Q?JUKr64avBzG8pdExLpa6GNMWO7YqovsCnw0v+hnggYKWS49BJeGrkA2bImOv?= =?us-ascii?Q?np7xDKxQ2Ls0f+crGZ0YwFpdIAPLMSPt+j+/M1GlgbTgrEMcPw1G9Vu8k8FP?= =?us-ascii?Q?qb1LFGJChajvL+IFlWVXCY0dH7dypLqJNNlXtZ2SRIbZgIGSC0/NmJqqFHdA?= =?us-ascii?Q?ij93zZdvENZHjx+/nFWJLtts1ljQztRYNStFq2NitvzwDxGKwjqA0K4VUBlD?= =?us-ascii?Q?tiJIvI3ODw7BCaGqUzIuxAC/ADvJzH4R2x7WSU49+NDy7Cz3NbzbzpM0MM5Q?= =?us-ascii?Q?ng=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a11b1d69-a097-4746-10d1-08dcf2adcb5d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2024 15:25:43.8327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Of/UlEg3M74oXMcbl0tcL8Nqsu5C732PbyklWjxspKswRFp3z5+qfXuCkdFItjeNmvP6mUgoN7ZIQRmdzqo6fcQ562dbXac4l6HjPPc+bFk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8239 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 22, 2024 at 05:11:42PM +0200, Robin Jarry wrote: > Fix the following meson warning when -Denable_docs=false: > > $ meson setup build -Denable_docs=false -Denable_drivers=net/null \ > -Denable_libs=rib -Ddisable_apps=* --wipe --fatal-meson-warnings > ... > Program doxygen found: YES (/usr/bin/doxygen) > Configuring doxy-api-html.conf using configuration > doc/api/meson.build:54: WARNING: The variable(s) 'DTS_API_MAIN_PAGE' in > the input file 'doc/api/doxy-api.conf.in' are not present in the given > configuration data. > doc/api/meson.build:54:17: ERROR: Fatal warnings enabled, aborting > > When -Denable_docs=false, do not even enter the doc subdir. Replace all > occurrences of get_option('enable_docs') in the doc subdir with true. > > Fixes: 7f9326423a04 ("dts: add API doc generation") > Signed-off-by: Robin Jarry > --- > doc/api/dts/meson.build | 6 +++--- > doc/api/meson.build | 16 ++++++++-------- > doc/guides/meson.build | 6 +++--- > meson.build | 6 ++++-- > 4 files changed, 18 insertions(+), 16 deletions(-) > No strong objection to this. Just FYI, the reason it is currently done as it is in the build, is that even if you configure a build without the docs enabled, you can just build the docs explicitly by doing "ninja -C build doc". That is so that one can do a test build of the docs without a) having to reconfigure the whole project b) not have every build from then on rebuild e.g. the APIs doc if you change a header. Regards, /Bruce