From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9351245BC6; Thu, 24 Oct 2024 18:44:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EFFC434F5; Thu, 24 Oct 2024 18:44:30 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id B763A4025C for ; Thu, 24 Oct 2024 18:44:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729788269; x=1761324269; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6Znm76dOAbsGoYX6iLAbSksC1AKJ6rsGqexu4B0NFno=; b=aGSaXjFemAY39p/iQImK6Rau6avCUmiYSMfel4d8owXqUIc2Olql30+l OKDOEqI9iAsR0r4+ycPni8Wy6SjHU6OOmKwsAuGgzVQqh7jrUiL0yGOZk 48FKRf9/Hz/snHtofZo3nYbzGKgXRXNB8OLd0UAa1BcNAbODUb3pdbMlZ 17A1AwGt/C6YZore/jhZFn9Oyn/bnL8BuhThApO8jXYJVm7UnmHL9xAID ebEYBOCnKkljx1vhlffaaFW+cmyOkWZ7ZZRMTF/2gZvrSDqGgkO/vnP8b sOTRMGbimqX4yPk7Men1oNnR9B/kCWmtLBcqFmqw25tyRmTH3bTMKOR4n Q==; X-CSE-ConnectionGUID: 9PrlGDmNQd+IllyTTa1EZQ== X-CSE-MsgGUID: 92JeDlyrSTSgqFY+qXe2gg== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29295781" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29295781" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2024 09:44:28 -0700 X-CSE-ConnectionGUID: 4ruAwSPrSQmbD0v0VqtGUA== X-CSE-MsgGUID: 60GP6OB0RnuvPQmNWH8R4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,229,1725346800"; d="scan'208";a="80950111" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2024 09:44:28 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Oct 2024 09:44:27 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 24 Oct 2024 09:44:27 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 24 Oct 2024 09:44:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FmHvshvFy7zQkK2wo2US8q5Z/jrXpoLZI9p0+8Kj7cxMCFHrLseoKPKUf2KlW1smzHqylWTAZqwtCvsVhDMvHXVe82EAl0WGDV1AydIONb8BVlXRmXDxU2VcUkB8u4M+rFrqspMisPfjICfJuNNpXWcHkbEgwPcGYgBR8dz+TKECNUCTBWws3C0ROkwbcXXDadZq/uAZq8c+aeowfyFjdxyGd+zQXxKdlDmQKHUJSiyV5kPB5iV9J6T+ZiW5YgmGWIOEv+NygR0xE/28wft6PLXXKqxVsfGYogrprMFXNuiNML3qU2LrP2ClE2fw/pE5O28lFv+rbRsjFjVAiZKM7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=me505Z5lft749190yEU472razfeVlIS4/Dbq5Akn31o=; b=ppyj2b8ZIMLwyNl+OIbMRIqsDSn4THz7hxrSnCZfpaXwXyNTBBAHMpieoLfLzo9bw+CBNNM50NT03raD7W9WABEQqOkfVSzm664KdOW97gN3C5y86VRi4/eoG2Zj29TpTPqiQIbswlhuh1ZgRrYeJBe3qbhHC5WxSKudsvW3fBHyRw87Eeek9mTcCXqul724wWYxFO8m0nV/b5lA96u3XRfcL9W3X2cOeOPMGVBacfgG/8lAoMpafcyeVtUO69hZaXHQn3ENZKFFrsF/mBbeReUk0KRJ6gN34j5GtOh6N6frSpiIiilq4J9n4BXSV/dNdDhRZb55ljxQxk+LxeEmuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB6741.namprd11.prod.outlook.com (2603:10b6:a03:47a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.16; Thu, 24 Oct 2024 16:44:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Thu, 24 Oct 2024 16:44:24 +0000 Date: Thu, 24 Oct 2024 17:44:15 +0100 From: Bruce Richardson To: Shijith Thotton CC: Jerin Jacob , Jerin Jacob , Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , Wathsala Vithanage , "Nithin Kumar Dabilpuram" , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , "Satha Koteswara Rao Kottidi" , Harman Kalra , Thomas Monjalon , David Marchand Subject: Re: [EXTERNAL] Re: [PATCH] common/cnxk: allow enabling IOVA field in mbuf Message-ID: References: <20241014110608.2170844-1-sthotton@marvell.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: WA0P291CA0020.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB6741:EE_ X-MS-Office365-Filtering-Correlation-Id: 439249a1-ac35-46f6-3a36-08dcf44b1da1 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MDk3d0ZFbWF5VUxqMHFqQzF0L2V2dUR3ZERyWFpMVUxkUm4raVJsdmRyTzZs?= =?utf-8?B?WFA3dno1Z3pHeGltWmYzaVVMK1MzWTdybDZSb2RYKzVnSTB3N2FlVUNhdE1t?= =?utf-8?B?MXJya0psS2R1aDFkMldsRXBkT2g5eXhkMVdueDgyVC9JbjdhRk9zYXdjaVFz?= =?utf-8?B?dGpEMVpWQ1BRbUx0QzhSVVpFaXUxd01Qd1dTTzl0UHBCYkEwQjVYS3J0c3lz?= =?utf-8?B?TGdvQkorTmtJYk5wQTlWMDN5ZmJSRlhPeHRTZURrbE11NUFBTzJmSTMyUkxw?= =?utf-8?B?OS9xcHBKVFNoK05EU2xuK09rTGdWQkpoUFhNc2Q1elZXRnU4RWRkMVZxemlh?= =?utf-8?B?LzNoQVorY21pdk9kbzFZUysrUDk3elk4bmRFNDVYdDgyRkI1QlJ4UzNxTktH?= =?utf-8?B?cmkwMS9rQURELzVyci8zcHU1c2Y3amFUZ1Y3ZmhLeDVkcnRKRGRzVXhKNmhG?= =?utf-8?B?Wm1lckNHd0o0OWRZNTZDNXo0YTFJSXlPdjVQUnVDTFBNTFNFd0FQTGNHWER3?= =?utf-8?B?YnNKU2VjaFpiM3Urbm40SytwUkpvUUlMcy9mSGIwUGZNZkhtQm5WQTUvcHg2?= =?utf-8?B?NTd2dW9COE4zVWlNQkF4OFpPY2l3VnlxSVczMEhEWlg2eUJCc1hDN1JuWVpR?= =?utf-8?B?L3p2ZG1GRjBBMHJtZktyT2lSUG95cjR4WE9wUmhRU3YvbG4xc1hJWWdzT3VE?= =?utf-8?B?V2Y1eUF0Mm1mdytQcVZKNy9VSmxuNkpLZUJFRkJJdHFaRzRUTUpxRkE3SGtr?= =?utf-8?B?TFFienZMbTg3THJVL1FCeG4wYjRNZ1phRE1UL21qN0N4Uko2UU5NQUswNmxD?= =?utf-8?B?SmtINHAzcTFrSUFURFJoVWVqazBUS2pjS3ZCYjF0Q1FiSnhMcG9ac0h4QkJa?= =?utf-8?B?Q1VrY1BXVk1maGF0U1FMNjBVQ3BXblVRaXNCNDU0S3hTa2pxdU9tQUptUGg1?= =?utf-8?B?azdPUkdhWC9sWmxzR1p0dnM5YVQ5VGZ6SHlYRk1qWmRiZlM2YmN0Z3RlSDFy?= =?utf-8?B?N0RnMmk3WDBNUytCb1VXcmJ5clpSQkRkeVV5Z2NQY3JrbXVXcGYvaUlkWjdX?= =?utf-8?B?VzROOEh0QnRNbCtodVNUSStPREZnMGRoVTIyRmhoenpzeU8xdjJCeFh2WjNG?= =?utf-8?B?VTU0ZkpzNU9abEhYL0lJWE1kUjRQRE12MTc4UUE0UTdNRkVvdCtYY1ZJQWxk?= =?utf-8?B?S1JCS3NTeXFteEFQSjVPYnR6Yk43TERsOGJzNERxQ1FWMERHQlU3cWRMdzho?= =?utf-8?B?RGVpdGRiK0k2blFqT29QMXQ1OG9LK3RaK09wdXZ4RnpTQkkrVURDVjBzRmdu?= =?utf-8?B?UVR0UmJUb2NTdFJxRWlJdVNoa2NJcVZwRGc4aENoZWNkbyswU29EanhPUTlu?= =?utf-8?B?YkEweVBvR3N0NXhFbzVrKzNvT25Qems4R0M4bjkyRGVyYXV6TjZ0UGxqS2l2?= =?utf-8?B?MU1qL21LRGppamM3NEFFZUMwTnlxbi90OG1wRXRMZWE1NHJINXBXek5BQkUx?= =?utf-8?B?eTg3enFFZ2dob2txUHQ4TndiY2daNHhWSVI3NWROdnNFaXpZZk0xQ1pJeU5J?= =?utf-8?B?WVNiVVNrTElmZlFGYmpKQ1FqK1RDSlNSS09TeVdxM1kvZzc5YlEyaCtNWm9P?= =?utf-8?B?SEUwQUYzQjhDM1h4dzdHbk44ZkVualZqWWtTdGpCRUlBamhZTEE3MmpOTmha?= =?utf-8?B?N2hTOUlzbHVna0pzWUhPa0tBRTZUZ1NoMVh2MjB4bXkvekRZTEhDZllTTE5G?= =?utf-8?Q?Gby0j++5GOh+l7J0oQi+LxNmanfySLvrl+ls6EH?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7416014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2FSVm9IRUNoQUFFRnI5Q3F5SE5WeXhVR3RBakw2SmYyOXA3eGFZT2FzMjdi?= =?utf-8?B?Nk5CdTYyaTRsZ3VKckg0eWRWQTdiaTNRWXlhTHlWeWw5V1lhc1BjenduanZF?= =?utf-8?B?ZVh5Rk1za0xJMlI2Vis3Z2ZQWUU5QmVjUkNZKy9hUDRGdzFHYTY5bUE2Rjd4?= =?utf-8?B?VFN4YWJmRVZPRTdHUkhUd2MxUytOTzBPQzJLWkxZTnRXVTFYdzNFWk5veDY5?= =?utf-8?B?OWtVS1BMV3BxaVZFTHV1dnFKQnNWdmJiUHUrUU5lNEh2UEVkYnNxTXhoanBG?= =?utf-8?B?ZE5DRFU2bE5QVCt5N0V5NmNVYjV0OWNZdzhsTUFqWHdrcFp0aUdRZit1NUdm?= =?utf-8?B?Mzk3YytZRkRZWm40RGEvMThERzRWeFVzbnRiV2ZLOGp1VXRpVnEwQ3hnM1hn?= =?utf-8?B?RTFMNkJXQ0c4OW5ka242UWNSMk1UYkR0MW5OeHlad0huQmQwZUdSWVZmaEZw?= =?utf-8?B?K2VvN2Z3d3ZPcnU5bkdpU0dhWlpsRHV6c2xwN0FsRUNSYWxJRUpjQWY3YWM0?= =?utf-8?B?ZUFzRGUwcys5RUp0cmJ0R1B1U3hoUVVJS1JaaXEwQjhpdS9iUGt3Y0FoUFpM?= =?utf-8?B?SllLdjhTcnZsRFVpTWNnck9nMTh2bnhhTThqL2VZTzVCaEZLOWE0S2FtSzFU?= =?utf-8?B?ZTQvZmloMXBxTnEwVmVhejlIZnFTaE1jT0hyK0llUWFKRGpwOFBkYkNiaXdZ?= =?utf-8?B?N1BPczRwRWUxMHE1a28yMkRQREJRV2E3MCsxaEdqeENqcCtLUm9yRG9ySHFt?= =?utf-8?B?VjVwSVg2ZTFtU0lUS2tXMnE2QnVDa3VSSGJIV3RodWZFTjl3RkY2Tjd6MzlR?= =?utf-8?B?aDV3OGliajdzaUx0U2FZVEtQOFpRT1NXemliZ2FNTi92K2locFh4ejhVdUhz?= =?utf-8?B?dGpKSVlYaDJqOEdYMGZ1Um54MzgxZVQ1N0Nxc0lGSjBqVGhBME9EbitkNk90?= =?utf-8?B?d21MY2FWbUVSVFM4dmYwbGRpSGhtalpkTVlXakZ0MWdqMTBmQjl5TDdTelhU?= =?utf-8?B?Zjl3d0VQS2QzM0lBSFBSd2hZa3Jrbm5hTk11YlFlbWp0ZXhKODBCanpkK1pW?= =?utf-8?B?NkM3VFZ6Y0JIdHRCYmlFU3V2RnVZNkozMDA5SzkwRDFhbkJxd1YrT2tvdmJN?= =?utf-8?B?dFh3ZVZCNm5rbWhKTUZVUmxJYWNIR1RSdlZnZVg3ZnlGdjhJb082bTlxcUVa?= =?utf-8?B?bkVhaGVHelRsZWZXNzVwODlsTjArVXRySzhzMkhYNGVSVTVxYmMyai9LRGp0?= =?utf-8?B?T2dJWXpQZmcxQSs2OWpJOTNCRk52L1ZpaE5QdmtKUWNVWFh4NW5oMTMzeW1W?= =?utf-8?B?Y1hhOXdHMjFsV1FCV3VreHE0cWpxUWNvWHFFb1ZyNWdlVU1rem1zT1Z0QVBM?= =?utf-8?B?dkhNaU01aVBTT2pibWxiOVdadkw4MTMrZExZSkorNVNmblZMWm91ejFZTVVF?= =?utf-8?B?aTgwUXpwVXpiU1dpVVF6NHNaYWJsQVE3S2hiRmF6Uytoc1FGaWFHdEpXTS9x?= =?utf-8?B?UUw1b2pSbERPZmc1VDVLS0RXbS9BL1c0SlhlVlYzRmJGWFNiZkw1Y0trbVBX?= =?utf-8?B?Ymx6bzhTcG5SRTF2UFFZOEQrNUdXWG1ibkhXd0prcHJZVHNlR1NtemI5YlZp?= =?utf-8?B?Z0pab1dHdUdzSTZRYUhEcHNYcHNYZ2d0dGxNbEFYeFo3UGxYcjNnMGI5cjZQ?= =?utf-8?B?QTZNWTVIemFocTUwREpPRk43TlZZcDRZeFNpcDhCY1pZVXV6dWNYYzlZUUdB?= =?utf-8?B?dTBUL2Y4OHVEKytNVS9DWDRIK1ltVjFiYTNoYWNqeVdNWkNpSlZaSHVPNER1?= =?utf-8?B?VmxDdERhc09OVkxFZXpSNVBLbG9wSkNXTDRsTGIzdXVSWTBQQng1NFY4RE5o?= =?utf-8?B?a1M4dFczWUFLZTdtT2ZNbXV6VS8rNXVocjE4SWE0dTNzMlo1R0p3dldURkFZ?= =?utf-8?B?dnc3T2FJaXpEbHFnUklmekhScXVQajRlL3VORkhlZms2SVB0QU84YUY5UlZS?= =?utf-8?B?TFYrdFpydmR6ZW5yeXpZMktlUDN3VjYrSnpnNHpBSG9WU2huTFFIdWw4OG9Q?= =?utf-8?B?eFFoci9EcWdRbEkxMzhUMG8xS2lQeC9GM0FUWWx5NmRZTzVPTG00WTlWM1dJ?= =?utf-8?B?and3dXRLZTdPdWlpRmdqT2hDMldMUEFGM1g2dGE2clhFMFpPeHNIZTVMTUlz?= =?utf-8?B?bFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 439249a1-ac35-46f6-3a36-08dcf44b1da1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2024 16:44:24.0011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JE6N3BNHrUDsNJ5yagqTZlvgsO41xTUMJAqJ5uSsKXMrYjkaC2nYr9+y0KLQKG4f82Gfgc3zMwJcVy2cu/Tgqbj2OwGxhkP6P6YXKg1LZEQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6741 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 24, 2024 at 04:13:19PM +0000, Shijith Thotton wrote: > >On Thu, Oct 24, 2024 at 04:40:40PM +0530, Jerin Jacob wrote: > >> On Mon, Oct 14, 2024 at 4:37 PM Shijith Thotton > >wrote: > >> > > >> > Value of RTE_IOVA_IN_MBUF was always disabled on cnxk platforms, as > >IOVA > >> > in the mbuf is not required. This change modifies that behavior, > >> > allowing RTE_IOVA_IN_MBUF to be enabled if the build option > >> > -Denable_iova_as_pa=true is explicitly specified. > >> > > >> > Signed-off-by: Shijith Thotton > >> > --- > >> > > >> > diff --git a/config/arm/meson.build b/config/arm/meson.build > >> > index 012935d5d7..ca54524376 100644 > >> > --- a/config/arm/meson.build > >> > +++ b/config/arm/meson.build > >> > @@ -439,10 +439,7 @@ soc_cn9k = { > >> > 'description': 'Marvell OCTEON 9', > >> > 'implementer': '0x43', > >> > 'part_number': '0xb2', > >> > - 'numa': false, > >> > - 'flags': [ > >> > - ['RTE_IOVA_IN_MBUF', 0] > >> > - ] > >> > + 'numa': false > >> > } > >> > > >> > soc_cn10k = { > >> > @@ -451,8 +448,7 @@ soc_cn10k = { > >> > 'flags': [ > >> > ['RTE_MAX_LCORE', 24], > >> > ['RTE_MAX_NUMA_NODES', 1], > >> > - ['RTE_MEMPOOL_ALIGN', 128], > >> > - ['RTE_IOVA_IN_MBUF', 0] > >> > + ['RTE_MEMPOOL_ALIGN', 128] > >> > ], > >> > 'part_number': '0xd49', > >> > 'extra_march_features': ['crypto'], > >> > diff --git a/drivers/common/cnxk/meson.build > >b/drivers/common/cnxk/meson.build > >> > index dc2ddf1f20..bba780e750 100644 > >> > --- a/drivers/common/cnxk/meson.build > >> > +++ b/drivers/common/cnxk/meson.build > >> > @@ -108,4 +108,13 @@ deps += ['bus_pci', 'net', 'telemetry'] > >> > > >> > require_iova_in_mbuf = false > >> > > >> > +cnxk_socs = ['cn9k', 'cn10k', 'cn20k'] > >> > + > >> > +# Enable RTE_IOVA_IN_MBUF only if enable_iova_as_pa is set explicitly, > >else disable it > >> > +if meson.version().version_compare('>=1.1.0') > >> > + if '-Denable_iova_as_pa' not in meson.build_options() and soc_type in > >cnxk_socs > >> > + dpdk_conf.set10('RTE_IOVA_IN_MBUF', false) > >> > + endif > >> > +endif > >> > >> Since this is added in driver/common/cnxk, it will be late to decide. > >> For example, > >> > >> Following PMDs will have mis match: > >> common - cpt, dpaax, idpf, ionic > >> bus - cdx, dpaa, fslmc, ifpga, uacce > >> > >> I think, this check needs to move up in the chain. @Richardson, Bruce > >> Any thoughts on cleanly adding this kind of check in top-level meson > >> objects? > >> > >Can you explain what you mean by a mismatch? > > > >Can I assume that the common/cnxk is processed before any of these other > >drivers? If so, then whatever values or variables set by that meson.build > >file can be queried by all the others. > > > > The goal is to change the default value of enable_iova_as_pa to false on > CNXK platforms. > > Jerin pointed out the following issue with the current patch, which causes a > mismatch during the default build (enable_iova_as_pa not specified): > > 1. The configuration initially sets RTE_IOVA_IN_MBUF to 1. > 2. Meson proceeds through the lib and driver directories, enabling the > build of drivers that require IOVA. > 3. When Meson reaches the common/cnxk folder, it sets RTE_IOVA_IN_MBUF > to 0. > 4. The remaining configuration then disables the build of drivers that depend > on IOVA. > > The problem arises due to the extra PMDs being enabled during step 2. > > We could avoid this issue by moving the check added in this patch to a > top-level Meson file, such as config/arm/meson.build. > > We would like your feedback on this approach or suggestions for a better > alternative. > Two alternatives I see: 1. One, you document that for CNXK platforms that the value must be set to false in the build configuration. Then when processing common/cnxk folder, you error out the configuration if the value is set to true, giving the user a proper error message. 2. You see about changing the value as you suggest in a config meson.build file. Of the 2, option 1 would be by far the most preferred option. If an option is set by the user to X, the build system should not override it to Y. This is why meson does not provide a set_option() function, only a get_option() one. /Bruce