From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A87145BC6; Thu, 24 Oct 2024 19:00:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29AE14350B; Thu, 24 Oct 2024 19:00:59 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id A41D2434F5 for ; Thu, 24 Oct 2024 19:00:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729789258; x=1761325258; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=VqD0tmUNGf31A+hgM7p3/yUWA5Fe20YlH2yWPuTY3iI=; b=c9AuPNKU21XwGnrep6BJa4AqSezFpLUClj83lNsJ92SE7MlGf1EiTijZ nAvW45knm11YpCpMZ1wwEXqk8oc9m+wWICQuO52pMh8GT0bfTVSypyUMJ gUnVx0d6vIepBr4upIGqmqqyTuNjY39+aFeJZE1IAzr21urXleyaOPGDR ZYyvgJRkcYFCZMUxZVqkM85QqFew8vAcFR9IOl1H7RKnh5KlA2ZxbRFVu c/hv2156wo9aZKQ+JWfoCFHcb4ceknylIeI3m12GzXgJR5fHM6GF4889m diSirTiSDC/Kzipf5sAzHGtiKkVExlc1DVQP1z4kQx7SkQX2aiHhnkpAu w==; X-CSE-ConnectionGUID: 7JMIFBpVRSqDmtgysqzb1g== X-CSE-MsgGUID: +7jGhVvBT7GChdwgGZYDew== X-IronPort-AV: E=McAfee;i="6700,10204,11235"; a="40831916" X-IronPort-AV: E=Sophos;i="6.11,229,1725346800"; d="scan'208";a="40831916" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2024 10:00:57 -0700 X-CSE-ConnectionGUID: sR2CTB0/S/KBwOL+FJvi5g== X-CSE-MsgGUID: wSmTLu0xTQWI7+FukImkSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="85427107" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2024 10:00:57 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Oct 2024 10:00:56 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 24 Oct 2024 10:00:56 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 24 Oct 2024 10:00:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DeC1g7njseCpmq1EGiI9stwSf+k3rjLVeUfL9Jr9pMJVG2C4FCt3M7Geq0GX2bul7+dF9tcy+JI66U7uBVVeFXBRX0OaaaY1dxqKBuHmuWthtsbc+UujlE9EnW1APURpqgBQuLxqKsuPz2YFbCZIh7anZ4KtxZUswDMkedULnsGftb9Ej3SEQrBnx8+EPXzbeYCoQ/+ks+jaKzws6kRMmKDgFXC8Dd11Qrqem/V/dUetQ5mhrmVDqbDkqR8tnqRbZmdS8AL9b1WMYDfGukGOFsztAzMgXekwF3PvRYHz1dSgt6rRrQpaq9a2kQ5EwaNjS0txgWZ6DeRzJCwveFTeHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o8ACpJpegDhm+XXm1N5E2kCxvYZbjX6u9TgMsfgd5Fw=; b=SehQpNGYC7kKLGZJkflQaBdTkrZK8eHMfSOmVpBA6BvGf/HCZVxcg+orW73UAnJGB2VW8IruPtE2S1kp3kTB8Dpp/fMDJCa/RY819NJ5Xdio/o3glxYgpRsP9Vv77i1llJXFW7kI1S/Fko4Ia4jD+MUrkxfJxdevq8IcmaLGfDZBOu/7hzOUDc//m8UX94ziPfG1C6SdTa6dLZaDrcocYy7MZc4ZHOQKdWqyIfARIQe8asjV/ifyVLLqbdTbdmfu+7znr67jUoq+fUGAWzITXXHUyOH3g+dJsxDwmuRm8F7EU/YZ0Z8erJqwYvoweTjolfX2uTwc1s1EZ3g3x00qwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM6PR11MB4692.namprd11.prod.outlook.com (2603:10b6:5:2aa::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Thu, 24 Oct 2024 17:00:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Thu, 24 Oct 2024 17:00:53 +0000 Date: Thu, 24 Oct 2024 18:00:47 +0100 From: Bruce Richardson To: Stephen Hemminger CC: , Subject: Re: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share() Message-ID: References: <20241022144205.49664-1-lew@perftech.com> <20241022091655.543539b3@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241022091655.543539b3@hermes.local> X-ClientProxiedBy: WA2P291CA0011.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM6PR11MB4692:EE_ X-MS-Office365-Filtering-Correlation-Id: 2135ad3e-e911-45a2-1dbc-08dcf44d6b36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZjJEJvq6RbYJLOYgrC4O76t1vp2FN0mXjExhheT9m2J9v0QFDsWDqCLZmOsL?= =?us-ascii?Q?FhKVkfkzDRk4CX4re+H55zO2urbHs9Uw757Ods5m/sk2Ixn6kDHv9hcws57C?= =?us-ascii?Q?Uiw+HBb2mFhFTTgBte28dLX3EpYwS2eomnc0ILgvlMiJAV/v9bOSlHA+wWqa?= =?us-ascii?Q?xZFR8vS+J7eJIA16OWfquqkm5RQCXbFid3fawBjE4IiHENZknFTW3XRmDRlg?= =?us-ascii?Q?+P9pgwb0mtgzV7qxextlSkiWRkVLGHeaEovmP+4jmpVmgK0xVDcVtgKW55rd?= =?us-ascii?Q?7hVzDb+Y0Cj4O1yv5MSjZ7XTwnKyagsztxYLVi91L1P8nZeQDq0faN07g0Md?= =?us-ascii?Q?CrBr1quudnZr4QCxLmQxMfy815HOBv1ZfiWCTL4PhaB3lEgAKghijRaMwDr7?= =?us-ascii?Q?zTlKm2H9h86DsOqGnBonoMS9P8i4f93w5U45DLtEVw1yEYc1vAahtBmoxdnb?= =?us-ascii?Q?hS+OtWuAeLHnl3jXw/NDPATw0fryDufa+Gm5IZYIad2a0Ibbjk03l8/Dpm6k?= =?us-ascii?Q?JEC5CzZ8kH7UiBIiNxl/juLEtBzOq7k1o0BATvZJ8H+ZLO3B8PBtpoVVuEOu?= =?us-ascii?Q?n8sLZcqkB/awMv1S+KNr2xFlG+VrzYOBbTo6IrlDOt/6QZdxB9YimL5s1IQA?= =?us-ascii?Q?aruRAEAM+o/vJJfflJLUIWDjeOiruSu6nIROJt7e/NncDlwzhGvVB4GfCNGQ?= =?us-ascii?Q?QoFUu0wgCipHvwgCjy6mhdHLaDET/QGOYHw2AzQjWLB/krbojSSi8+j1wvLr?= =?us-ascii?Q?kNHZto2PVlY1gYKIRhcmqkww7BOeeUrjex2TW6a+A198LSehoqpQwGloRR3G?= =?us-ascii?Q?vOP7ST4yt8yB/EVBu+3J8JgvroMIOxg13yyT/ScxPD0gSPTXUwGhTrC9KMGz?= =?us-ascii?Q?TOeFAgVlt892pBwrMwEQlW72HICGw4NLk4Lqgw5ydDWqLzyXVILEzKX2Qykw?= =?us-ascii?Q?G3tvZyhQ2/QgMLc4HBPhgRKjh2v7ae8VVwBlCxojXZ2k2BB8zAHH1SdkFuOH?= =?us-ascii?Q?tHwQR3qz9M75227oXeop2S+kyU+F1RBs0X/2YNFedrNLMQpevqojY6L11L0Y?= =?us-ascii?Q?cdKEfp3fggEy0GEdew5or+P6S8QIg23uEa/t3RbopnGsG0yF65x9uqyF0Z1Q?= =?us-ascii?Q?JILRPeFxDTdureUGrdIMWWlH2ES13uUIzC+IlzikqQBb9LB+z9goFYXmW7J3?= =?us-ascii?Q?V0U5W/v8hbb7EmdkCkOySBvhy/0hpStwf1bn/iW2eKQy3jp35v3V8UNZ2QXD?= =?us-ascii?Q?bYv5bqSeFO4UwIc7MZ+q+mroxkE2Ms7KGaDJTzUgqwpkz7KGzi8mOfil+aID?= =?us-ascii?Q?qd0olME4pV74PGKln8j1nc78?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l014kK3vvHhA2LwcTIxgtvx1A8x596ib0SKfd1YopSky5Hak4Dy05FMJJavb?= =?us-ascii?Q?HiOwZsf4EhqVnpmXh1ZvwOWqMXQxza6V7bZJWWR7fzAQZwZFpXvoKCZZTsU3?= =?us-ascii?Q?NeK482RdqrHNOdm/f24A45m4mjL6l+AXSUXxmXpmuBAJpsKnkzRkSESZbLRY?= =?us-ascii?Q?bqaTPETYu1NbNZQq0pvBYxDtz5ZL7BhX1TmynNW9eb8eVFUSQah5h6HlqXf/?= =?us-ascii?Q?LbWoToixfZO0LWjkEBYQJyrdM7SianIZt+mn+jjFgaWgECXFzxe3v5eLXNZd?= =?us-ascii?Q?4COnX6HjgtJtTARTnjxt+uFYSKW5IZPPj0RLpCGjK+9Sdmzrzw5dZdWd13hR?= =?us-ascii?Q?n0oXMgiynUTnFahDsVWCn7RV3H1WHXNNzYTxfROLEHPdmn0fVcyZQZf5WtWl?= =?us-ascii?Q?ZXvDWb3GUJDY3rZNp89bMW2Lz8Jvw7CpDwfH0y+huzYTzKUmRkFj0EwaIGlc?= =?us-ascii?Q?nqWKN8uk7MCSGI3tC9QN4lPtTwrJNSNH8UBQHo7Li6JGB/LQQYo4VVq3A39Q?= =?us-ascii?Q?L9HYeYu8swKk0FB1QeVPLfZBcrp/YP0oKZR3lF0kIWLbhnq8WibWD+dWCjbT?= =?us-ascii?Q?mFKTWR111kgqaxBsiXOAd4yJtirbQFRibcfma5KlVBxNo8HrxATmm0iIuqod?= =?us-ascii?Q?Lq2Sbrt0vLG9dKzlhPT10sAVba7Tx184re3lZWStU8Sbf2PNmDZ86Bs1rvTs?= =?us-ascii?Q?pPi7ex03E3rpY/VmpcoCkYbdK9lgz8KbIvNR2T1MZNy5xKTpC0AEJa0WezzB?= =?us-ascii?Q?lM597ukrQJlLODEOqxSIy2mMQIcrfSFERvJhY1MZ/Pp4rUCTAgTqpWANLA8B?= =?us-ascii?Q?FKc2/KtG+7qxaA1TEkAebqRajW46AduoF9IcltC9MWYDuABa6Id4/QzyIpyu?= =?us-ascii?Q?OCEjC2lMVrS2OgZvq/jo1mWdKxQOYroqG96WxjUlKwANHPSWNao2+jz3CPJB?= =?us-ascii?Q?Zl5i3ovjVRfOdocUBI+Y+rs/JHf7KeOp5IKGkwYmOqXSVR1DB6kcVfuxE/yZ?= =?us-ascii?Q?wry9Ojt6fQ4dTLGCOLsWa1y5qMNmfg0985262KsqtzFvAqVuPGxNtLHHMcYg?= =?us-ascii?Q?XiUbC6v8bZCW3M37G4Z+ylNtGehMSiuomLLRl9w98wztGNhs3OlCh38S1sJw?= =?us-ascii?Q?YJqGLzng+I6KwoUwRS2P/d6dDPzZID8dIZtRvqkFK7u1HrRbNCUcNWffFT23?= =?us-ascii?Q?tD6RUfqzOX+5htxcZ+1jQ5mUjCQ4kJ62NL6Wo4HSVmXDRd+Kkg65ECoBimuC?= =?us-ascii?Q?pTSIRPr883ujzCBAeNALvkIkN1iJRSR5qwLJBcvLrZHrpMXxvOt9wkZArCIj?= =?us-ascii?Q?d6Q1xBThvdhYQ9IadggjYTm8MFE0lPTa+S8Wp9qPpEGvRfZvZDWiwtg0mvpf?= =?us-ascii?Q?5M49+miPa4qOEr5PN3NxnPCZ9vxajcqaSGZe4P7fXatXSKtYeLy4zMdIHVvj?= =?us-ascii?Q?CiirL+kbSNK88XQvmxtNPJSm+1/jYXJJ/8OWrPubout2foiS//ayaFw/pfED?= =?us-ascii?Q?Q78eQhgAU4tsra+i22MsKj2GLV7EYqD3Vct0FQyiwfG5Ig3kTV81m/5hlFd2?= =?us-ascii?Q?GQJnTW0lNyP0nB5PdAHCpR9trK8gipr1fdpUN6ymiqeNB4iB0pKj5G2tWOtj?= =?us-ascii?Q?xQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2135ad3e-e911-45a2-1dbc-08dcf44d6b36 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2024 17:00:52.9595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JPCYqgHggfbjsvTtkCQodlgrXAbAbQSjkpg+zlRVnX2hpqtpIIyHAfWJeQuq9jNDqldaSBmPpzcRf9AeJn2cfmDKo1gr9e7JP12dCw3reA4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4692 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 22, 2024 at 09:16:55AM -0700, Stephen Hemminger wrote: > On Tue, 22 Oct 2024 09:42:05 -0500 > lew@perftech.com wrote: > > > From: Lewis Donzis > > > > Forcing wait true prevents checking link status without delay, because the function will wait more than 10 seconds for link status to be true. > > > > Signed-off-by: Lewis Donzis > > Looks correct, driver seems to be trying to work around slow SFP link detection. > > Acked-by: Stephen Hemminger Applied to dpdk-next-net-intel Thanks, /Bruce