From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06BF945BC6; Thu, 24 Oct 2024 18:02:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8A4540265; Thu, 24 Oct 2024 18:02:32 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 6447E4025F for ; Thu, 24 Oct 2024 18:02:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729785751; x=1761321751; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=tRTA0AjGdWzo2zIlKEVkIAoLtwd2ity0InFwF6X2IZ8=; b=dvyjI2zmQFgxTGs69oLQEK2gJsx1uUsIRcOrmleppEY8WCvBZovOBfb6 XwigDnzBdWB+ePjOdjZNnCE/dYOZdOT2BwG+n48+QH+0n4Qx1513FZo9n 9Cb+JRzyB17kJMzxEShz9supf0SN8BQg+kFKrVD/F6brfFeO2sq0XpY2t n2+GJu0WMvAfk109uhXE5/EMrpnA4HtYMWzxvGPVQ6FxXO75UnU3VdvJK fUyhKDHL+5rwdgEf3IYVtXEVCz6HMUHEuAOOcOSW6eoSCdwUYf18ThOEu OubFdHYsoqSPwFhhWCyx7pQLDDyCOtRPcYorBBEHNV6xupUlu6U6V2rPP Q==; X-CSE-ConnectionGUID: Llflpp2BRY+9mQIxP8/uhQ== X-CSE-MsgGUID: gK8G8qRmRZiQYTrVnDGIDw== X-IronPort-AV: E=McAfee;i="6700,10204,11235"; a="33331718" X-IronPort-AV: E=Sophos;i="6.11,229,1725346800"; d="scan'208";a="33331718" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2024 09:02:29 -0700 X-CSE-ConnectionGUID: EZNEjk6PQWG0GGddsjMnug== X-CSE-MsgGUID: +dLtyug3Qq+Efs2Oqt9vhw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="85416694" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2024 09:02:29 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Oct 2024 09:02:28 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 24 Oct 2024 09:02:28 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 24 Oct 2024 09:02:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V8fpdxghUA88os/zXL3lrIemrEjkAca45RXAJjAKNMUI7I7jhHyUWcATDkMgEW0HatRPMfIq66vTszdOSi2wYdczLD3Yzr0IGyrL0ShqSpz2IuQgnCBRfSUdGBhBC9vQn5+v68ubtwKJXoZbnN45jphbhDe9eBaucAyMQ9sEwC9e0Axef9wmYb9wnF3O58EQh24LpLOclIhH2da/Eme+xD/vmagMySiQzKy/7M5/xYIxZ8ElunYrYqHMEzAOHhR2M2RmwmSTkJTMVbBNZd81bSNbcmhTiUUW4vFGiTJcZNiajsId2WdsQG+D7O67s0VyxrefPXtQqJ9WJltRkMEN9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ohe+OCNhGSLYPnsBVTNtzk2EqLCe0vda8knDgg+4U6Y=; b=Qegf6M/0BtU77DMVRjOYC4rA8o1WnLe2M4ajDLTlJFj/Eq4p7J8QRNzyhd/l9bknwWcfepDeEGZu7Dwgm1sS0tGXqDlrS7e+3NODfcz+A3hO0dtG3nkAJQYF4INVmFD0hhsApJfH1k9FlY361HrB+bBe+qdiOmF/QGt//4so8sLDIbvyT4onprl6hYMsKvkxh8XO3mHxuoYaLS8pSln5ebM6P/zfb6bWBx9uGXNpgVJRHJMvlUPISDR4hQ4BA95EgjPFPdkO4sG0NZqk+UuL3Oeo2TSyyjPZvH5hN/elR8P3zxD6/MSL1IhRTY7EY6pPRf6vZQP9bwGCep/KZdDmsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB8428.namprd11.prod.outlook.com (2603:10b6:806:38b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.32; Thu, 24 Oct 2024 16:02:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Thu, 24 Oct 2024 16:02:22 +0000 Date: Thu, 24 Oct 2024 17:02:17 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Anatoly Burakov , Vladimir Medvedkin , Subject: Re: [PATCH] net/ixgbe: fix per-queue stats for less queues Message-ID: References: <20241024111757.791634-1-mb@smartsharesystems.com> <98CBD80474FA8B44BF855DF32C47DC35E9F81C@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F81C@smartserver.smartshare.dk> X-ClientProxiedBy: DB7PR03CA0096.eurprd03.prod.outlook.com (2603:10a6:10:72::37) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB8428:EE_ X-MS-Office365-Filtering-Correlation-Id: ec1ad3c7-936e-4d8f-f3da-08dcf4453ef8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?sGO6CEKKP6leSfTwzlViirOQ9Q1BadxByVWOjqoo9ihSKn0gaKgk/BshJ1?= =?iso-8859-1?Q?LAKyV7uVUEGnzoWJPXeWF3Z5UR7nVmOMlp0HY4X4bjHjtu3/cewwA4iZRF?= =?iso-8859-1?Q?6o/8nge2MD+AWO6uw/QSnmBtXzGEDlk1vTeIghDIToxXcgOK9haEMi8RHZ?= =?iso-8859-1?Q?qeD1qbVUZsn0w+7nyaB3PJ8QVwb5yp0fD8Bi9IP+naebf+jkMg9c3Oq+JQ?= =?iso-8859-1?Q?9htUs2A7U7elPjJAH3wY63bAhtXifrIz0JpmbovlnCKrw89IkWsft500Zr?= =?iso-8859-1?Q?b8UqddE1WUkx/0DaUwpJhGD6K0C1X72/0iazqIqGl22XyFcr5zGs6fvd5m?= =?iso-8859-1?Q?BSzgyO97/vZj+bI0rSFyPKmKB4r34d3ztcA9hwdffG34Jk/P3e57Colp1d?= =?iso-8859-1?Q?Jzf2nG6U6EkltubGftPQlfvcdRh+eP7c85wl4pZClAlEJzdsscVmH41lAy?= =?iso-8859-1?Q?inqvmrxx4hTE1UOjglvF4FzEt5btZiQwgnpxXLcuMdkyLOmLbMGENBn+co?= =?iso-8859-1?Q?RhXqjiIMVDx9LNw+K+v9mlRe/82a4OfrzkvHihDC0D6jdgCQ3uZXESfHqp?= =?iso-8859-1?Q?1r/EZi+xHjVQBrKVEqwXHtvXpDWSL6/SWkdMF2AsU23D0u3O1zZmOjxV0q?= =?iso-8859-1?Q?2DKJ+OF2Me/GtlbgSyCv3xtOlyo94PtxM5TrSKagJjA53kB/B+Ghm9jYgP?= =?iso-8859-1?Q?Dm3aZ9DYSysHNmfOg1So9A55KL/d9hzREizzXdrxcEmDtk/hgnNylbAusa?= =?iso-8859-1?Q?ruokUUdaYFQtCbzWc+thGAMXpib8mmCGO5W2UsszQ6aLxmp5X/XijC6zQ3?= =?iso-8859-1?Q?WHGyVjrECRIaMjKDA+nl9qnDkZqkE2PBNPMX93xkJwHNj6TM0kVc01roYG?= =?iso-8859-1?Q?5R3ay64Q3coQuAONNN0+NPnd4ALl0QrLL9CdbTFtpo5DRTXJYClx8LEGGD?= =?iso-8859-1?Q?jIWKXGbgTAVPMMdHxhjMWurfbkdPyA+SQG0WJkiytpA/tiol3R/nasV+rZ?= =?iso-8859-1?Q?E5E0+UmGVbOGrCEYh6zijp9h5h6d8CH9M4X01yjAU7kqDkKgvsHSTsbIm6?= =?iso-8859-1?Q?A42uhv1uLNHLZXVWA2Rdb14u4yxRJEsy5Cd640pHGA0lSbLs2Pw4nquHC6?= =?iso-8859-1?Q?tfS8JU4FpQJWrTyhKQNT0lzCtVC1WIVuVstGB+26Kc5dHO23x9CsS2Zs+w?= =?iso-8859-1?Q?By09DFz8/opMNeaG6Sy6pVzl/I3NDcYvU5irgbr/9VDTkZzXUeAGjqRors?= =?iso-8859-1?Q?AezEgG4J+gU6RC4AJ4b3HnNevh680ax3n50sTsgrh6csScoWyr4U1kYIYM?= =?iso-8859-1?Q?r2aV1MGsOXArYC10tItIbzFSkA3XmtnqvFw0evjS8Oh3oZ/Fo2vvL5vmnd?= =?iso-8859-1?Q?ySaThxg8M5?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?XLf6ocz0cv0y+BVkZUUBRgDNaZ2LONZojBhZ9WEWrnz/Cti1FpMz+baQYC?= =?iso-8859-1?Q?VcXfihsl6YHamAMJerBlZpTTTdP05Bl4GdjDWp9ggUa7CeJM0jnUxOrbN8?= =?iso-8859-1?Q?orlq3SKLtriu6e+cRebNDEQ+4c4p5BMe9YQOQ1LJzqln+tRLidTLGp15Cr?= =?iso-8859-1?Q?8DI7OtWcfKbWoFOpzOSkuZ+fVvMTM4C/Q/NvC+RLatp1Kgz0uiJvAluOrb?= =?iso-8859-1?Q?wOlkRzb+/q/I62L4/IqU9P9d8FrZFjo9Sgm5eRpZ0emIT9o0t76Dt3bbCu?= =?iso-8859-1?Q?6NDeP4dsStiQ6uCE6mhpKxgR+3XolIgLyV48/bcnfOPd3p4Rc6dy/pDQS2?= =?iso-8859-1?Q?edarWzkdZZSDighiTSLKEewlPnVbjfffKNnj+N9x1KOSF4bUsVTMfujr/d?= =?iso-8859-1?Q?C+CzpXh7136iNO5f21ZVc8gMWCxxnASTtcRSo8dlcNE8In6GJTInDH14IJ?= =?iso-8859-1?Q?oRVHs87v27Lrl5rp7mIdSU5whGStcrq8M2o+rX3usHNbaittMI8fHYOg2o?= =?iso-8859-1?Q?zV5PJByuygfm0Ixfv1+3ylbyiSfiLKhVZ5vgQ9Pca64ApArVYYJ6TKVy8z?= =?iso-8859-1?Q?Rvzrhs29J09pe8chzItKeGTeOEWnL7NyW3sR8Czgxe6qqN/rN80OFqEfid?= =?iso-8859-1?Q?JSmRRaIJ89Me22wHkQfvVmOahLqu428HrlhAbFmyzNFZDBO3LxpxjjQMvD?= =?iso-8859-1?Q?6/qLxXodC2+TVYlykCZbguqAD+p9k7eaqeaXlWrOPa/x3YwoDJr9p0psiC?= =?iso-8859-1?Q?Ur1rOb9efaNqOJ5HjA0YsrcEDEKv4UesyMRqJMtJO/k8PU7AmEeYDUlHK7?= =?iso-8859-1?Q?Yq8rxbDbUb9eXc3dQ/PatlkpJwP7V83Zipb8M9RgN7dmhisTiBVflvf82d?= =?iso-8859-1?Q?JB7mOma9vzpyK6CnSQoxg6djgTladMeN4bP/Nl/Lbiqxv7tdvlniYAHP/m?= =?iso-8859-1?Q?ImPAnp/IpG2HlkY3OeTmI2YURoKkiVSYfbBTbuYxMSf4VbMzhKVqMSJSRo?= =?iso-8859-1?Q?EkJ1wcgFlXdS2n6YSzJ0gKEG9sYc2q3WYbPadAR17XqJCYxJc8MFn1DSSy?= =?iso-8859-1?Q?f321wpuJMdcIEFP2G+L7R9yc1UAwBDleAm+llqpFYfd1UuDEp7zLo6aoF5?= =?iso-8859-1?Q?cpXGWBbFW88OTdW1FzLN7t+Mjm3eIFdfg6Kh2pQbaBtI0Ujrzd47m+jQMS?= =?iso-8859-1?Q?FpB3mPTuFrXSeJAzWMXg8yT42FbaSVOop/fs0RPdJDDSxIh4D2Jffyp5JM?= =?iso-8859-1?Q?63Ip2Eni8fZYAn3/szMQ+tv5ICw7s1FMgZ9ueEuJKDOXtQJpBF4O5x1Mq3?= =?iso-8859-1?Q?BgrKKmI0IMG8y0VCLhp/cYT/ggyxEY0ughT/V5JCXXDYzrzINCAMmg7Avz?= =?iso-8859-1?Q?ksCVjN2HR+zHOHUz0cWX9Ta652vCrdKvJdlb865jnM9lTmDOLRxiOzjW9U?= =?iso-8859-1?Q?+W6hIPv8WnMXt9BHhLj1GOjBZs4seL7eE7VaRfRjh9cWkqOLPk+D4gDV7u?= =?iso-8859-1?Q?rQD9tuCmaB2t2kaWrAkMjGsrOBPvYbrFwQ+p4QvAAQT5yhQ5h0LnHMIYqc?= =?iso-8859-1?Q?NbDxoW46N4Bq7+X2c4aNO+gb9DKvJs/lnyVdurXj1+6+aGn0mAdRBhDrWE?= =?iso-8859-1?Q?xRxzYSKTLt/KERYZJeZTozqh1jEZHH3X9IL661/G+mmIGYS13y32OwuQ?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec1ad3c7-936e-4d8f-f3da-08dcf4453ef8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2024 16:02:22.8757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +/6BDTwIP9YopEiXNAMOAmS7tn4+zBNtH1ThLb117dFl3w+d0qIb/nN7eGOPZy/VAl64R5jRegaxCo6mTj9PQ6IFJVQqV55I/5WurQJeF4c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8428 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 24, 2024 at 05:15:10PM +0200, Morten Brørup wrote: > Forwarding to the now official maintainers for review. :-) > > Thank you for updating the MAINTAINERS file, Bruce. > > PS: Please correct "fix"->"support" in the subject when merging, it was a typo. > > > From: Morten Brørup [mailto:mb@smartsharesystems.com] > > Sent: Thursday, 24 October 2024 13.18 > > > > Remove the requirement that the configured number of queues to provide > > statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the > > driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS). > > > > Signed-off-by: Morten Brørup > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index ab37c37469..895d6e7169 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -3385,7 +3385,8 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, > > struct rte_eth_stats *stats) > > stats->opackets = hw_stats->gptc; > > stats->obytes = hw_stats->gotc; > > > > - for (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) { > > + for (i = 0; i < RTE_MIN(IXGBE_QUEUE_STAT_COUNTERS, > > + > > (typeof(IXGBE_QUEUE_STAT_COUNTERS))RTE_ETHDEV_QUEUE_STAT_CNTRS); > > i++) { The big cast using "typeof" is awkward-looking but is probably the best way to do this! Thanks. Acked-by: Bruce Richardson > > stats->q_ipackets[i] = hw_stats->qprc[i]; > > stats->q_opackets[i] = hw_stats->qptc[i]; > > stats->q_ibytes[i] = hw_stats->qbrc[i]; > > -- > > 2.43.0 >