From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FCBF45BD4; Fri, 25 Oct 2024 11:02:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F1FE4027E; Fri, 25 Oct 2024 11:02:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 3D62A4003C; Fri, 25 Oct 2024 11:02:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729846943; x=1761382943; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=2/xNM+YRL/YSQdCn8z2QEuQnvt28NxSHM/h5GXZEelA=; b=VTdRyxY8Yy5fgICblhDoLuQc6QbjlHmsm3L3czsuHk3WguZavS6iT49T gyXspSCKb+7Hv/Wf3JbZ6pphb5i7l4IedayP6Ql32BuJvGHBmKqp/ZiiV nGHGHhfcA35dOneoOn15+8cm3wkKGV6LFYDMlEYkQLEprXYV0yfyorQaF OCDllbbUoCOGW85YPgH34piRdI85hLH7POHRq3/66nkmP1DQN301SiKfE Jsdi8cYc4yk5UJ3DUpI69X3h/g50TP8uZET5jsUoX2UaG0W1+E2MnXjqu 38tnvmTWTgnLUrPFzGogtnOwnFfGNOtUbMho3E/p3DldJPKRLkD08eiA2 g==; X-CSE-ConnectionGUID: cajPneU1QsC2mJSQzAbceg== X-CSE-MsgGUID: 7uQOb/BwTaCwBBEbCBuJqQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="52064679" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="52064679" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2024 02:02:18 -0700 X-CSE-ConnectionGUID: L8ohrwvbQgCMqjr47YvT0g== X-CSE-MsgGUID: YU3hcCALRoer4hBL1BHoig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,231,1725346800"; d="scan'208";a="85650893" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2024 02:02:18 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Oct 2024 02:02:16 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 25 Oct 2024 02:02:16 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 25 Oct 2024 02:02:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mYsmlkX96fhALbkJP2y6eJH+FTiTpugl3FUTo97+B3TpyjNAt07l+QBfuMjPM14nHv+xdwuO3/msEHO5/KWRUBuk8lVyFbGAV337+LEx8JcCCnTH9UDhkfKY1LHnvk9HcbB3BNKVxH0GoSaybpbgwFq+97yw3SZH6Gv3wKLTvXSiiEq3HK/IEl9oKSrLxDYaTB83aGf0DQsVWLPi/Sy1wH+/ncb/whocA5QVg6bu4fp0aH4szJHOVQv/dhaEFLNNgG8B67PdjtDHXRVtH4SZQNetjSRJqgfR+wjm4tn8ZgLEk2aoqbRwSmyISWIfoQuC3SxD9Y2YO3XiUophShMx9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Yx0bLqZwrKV017gRhyKLDJEk6dElGkRKgeH90+nhtg=; b=GNiuAhfmo1JL3wex3iTf06/gBDyROKDfJ8OkCg7Q3mV/+9FEGBJgorD6QbZ9huHtn0L4fBvag6NIMkdLODKZCK3btbFEfHv/bgJIyhBF3B7icaASglqHFibw34UFbLBHg8J5twJ0Q5q698ag9Q9gbNmXMQf551oILYbHToNrcGqjZV33cEJeYBBvCF9U26EOjGUNZK7FDUvKSYi9OTz95q25n+TIxDodLo4oqP+ZoWAPZxhI23ciWhCbGROlaCehXku704AxzTgvvTrJ27DsqhZNhtBtU7T5iLs5D1DEb1/94E3v0cVQg+iZZwSnLZhuznizQLgq5iDLskiz1h9Xqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB7031.namprd11.prod.outlook.com (2603:10b6:303:22c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 09:02:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 25 Oct 2024 09:02:13 +0000 Date: Fri, 25 Oct 2024 10:02:07 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , , , Subject: Re: [PATCH v4] net/ice: fix incorrect reading of PHY timestamp Message-ID: References: <20241025051419.679693-1-soumyadeep.hore@intel.com> <20241025075025.682290-1-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241025075025.682290-1-soumyadeep.hore@intel.com> X-ClientProxiedBy: WA2P291CA0030.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB7031:EE_ X-MS-Office365-Filtering-Correlation-Id: 98c61644-6341-49d2-d710-08dcf4d3b76d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1kPhiwDa+9yZA6tB9KVmAlxrqdFVUNXHgclP6S7u2eL+0mOSHaeo27Afzfq8?= =?us-ascii?Q?/hBcvLoU38PFxgbpm09c2vNeS/wXGU9AilcWqfdLRicJe0M8ZV6hoPIrbGZH?= =?us-ascii?Q?eccoJT0u0wPdJSMwVcisBN6+BgiS+cLUuNX0mIowOcxKRLg9XW1aiC3NJa+F?= =?us-ascii?Q?LDM25o7EFdGHx+JNLUp8YB73G+mVFy5cUCL5PxF5oK99HUqDYEF1TzHLogrz?= =?us-ascii?Q?ktVFn6cTsaQuEqLLnilB3JZL8XUr2Ug/upcDWCC55oAtPVBZwos6hBHjqSXj?= =?us-ascii?Q?t4e3Wwy8TNq5VJ2k3eCj5FwykZsE8dpCDXitb/L7Di7QkFtAmWLQ8DpYsHzt?= =?us-ascii?Q?BwBOeTeK4TOoKbksWFHaGKJedunIGiRKybV/4ADZakU+2Tz6nOMUX0cCSork?= =?us-ascii?Q?3RnxNimV7SGf497OevaOy/r026UMFwIrXLb6G66gSV/MSLNLSC/66gxfqWiP?= =?us-ascii?Q?UBol337Ska7QQjaQ8NloiMCXfVPZf0BvXrlclRH/kSZERjM0M5IuWqRM+7Vn?= =?us-ascii?Q?Y1eY5skQ7GygyCfpd1DFrr08atMYrZlZ0HXJg952GjayT2ad1vzgMCtoa4mt?= =?us-ascii?Q?AYH+/22hnxEKDUNSHCcCmNEML0SgwcIaT7fl1vkE6AjcCseqNsiT1hMcthZ9?= =?us-ascii?Q?t6fAV1Tn809YnmQ2A4FLB33J+iVrvK/a7LcXS1/B40B1rWZW6pTpUC5phD3c?= =?us-ascii?Q?Kfa0+DFgE2mWZLvAyLjVBlTHlxpk4zZ4gYAtYzmxznvOZtO0yFSv+APSovMh?= =?us-ascii?Q?wsGfH0KG9dW450ouKmPTA2fvSjO2ICA6h3SJkrAoNuxgoZpvzHI9bSIF8oOZ?= =?us-ascii?Q?suh21PbcDx5sQiI0t/srRyvXsIKPDsHDdb91jAK70zQdHDnZ4KVGXHAfRzvu?= =?us-ascii?Q?vFOw7RzuEQXpiOqQOX+LGk0RKKv7+wt3K8dml8gqJPzvddd5TW2X1Bc3bujX?= =?us-ascii?Q?Tz8sVLFAkZJgwrty16YS3r/31qBCQ0FsvkRqdfW1ys+MaUSd6/q1CsPFwbrW?= =?us-ascii?Q?QmPkB3Lp2pn5f8FjU1li3oM/fMw9//WE4WrgaqNddQSW7aTz6CzSCx6yExUc?= =?us-ascii?Q?XjNIhNgbT4vh1k64C3WhHiRlg0oY1JgTCaSQIYay0LIsx+GNBuSjjYYR3keV?= =?us-ascii?Q?5ea62GRWs+gWNam9cGBjvOEurBjbwyF6YWjARnhZgpKBkwq5cryUa9THdFk0?= =?us-ascii?Q?hIO0ud09FH3i5bVgYAWRSV5S5QnGf+28mg9a8wcoUVZbTncnM1sdACbG4rGX?= =?us-ascii?Q?TZpxRi7h+Ubo71pgXstVlvAxvxofU32i8GioO0cDsxILBd8k+XncnbIPyYF/?= =?us-ascii?Q?+f4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nMPh2Aab+wa2EyMAuzmgE8E8T6KEhd3eAxuIcSV2t4E0YLLI2A+OUIAQaQ+r?= =?us-ascii?Q?L3BKQX14Oumg9qQ9ZEU+XWQD9q288Sz239TRq5s2N51AODVrSn+LcrAhgCoC?= =?us-ascii?Q?TQ5nwgc6Ebyy7E6unD2xRETV82ST5LQl27bP3vFtvxTwpyPRr532exos1FyU?= =?us-ascii?Q?aEbmsnFFkjP651mmyAisRmpH6XYDa2gDtqvuEuDugEkd0XIaCCXFFJLECe5e?= =?us-ascii?Q?BrNpVGbNMj5T65ACUvHHOlPnG3o436cCmK1BHCVOQXGILtXmokI6r7tfvt0N?= =?us-ascii?Q?tsUqQSUU6gZetA7+GI8NRMsdbQFtiHepfUf7SPzLtN89cGwT2l7BKs5qxO3R?= =?us-ascii?Q?lUP36bTr0bazRu2OQQx8Q7TTsL5potodThceN8oVdlrNDo6eugzz58bP/G3W?= =?us-ascii?Q?89CXj6hVY0MpUGWxu8zI+77uLjYKLeW7pyXGRfkznVriNaZqXo0Zvhm+N3sR?= =?us-ascii?Q?9UuDiwucaTUKGvcixm5hYVWBRvbUSjFDotALOLg8+6T9XnXVBLwsYzCu5cgf?= =?us-ascii?Q?C75/eVyNDeMWU4OaHu4YA4QuNfXfXqw8uml+o2j4o3P4Dwdjpl25uKndNHGj?= =?us-ascii?Q?I6ZsNzDUUnu/PmzWt6vpadRNKTVKP436hcvinKQmB1UI26m5jf42GtFUiv8j?= =?us-ascii?Q?k62hUFdZ/RxggELilQiaPAXL/iQjayEip2WVmkstxkLQOSEjBdL/qNPT1YsF?= =?us-ascii?Q?z7tjQSa5uvy5qOvu56oKWnQv1XtofbWkXpIfLwfsNJ+zFpnVvE9jMcUybPGS?= =?us-ascii?Q?9SOGrX5C6oapM3F4s0A5rQWSmUcefPd4tmuRaQLQZl2KGLDLx8SiAgGp/ZzH?= =?us-ascii?Q?6iT4QXAudoahptbujBrGhpAoKOJN2LTSUmb6f6jToPwI77hxN6dHKSd48IhP?= =?us-ascii?Q?NgSMeqbE3AhGupgKrPXoR/xr1nSSsabBFe7Q8Ryh1RtYHtGGgZMRQ58bGcGX?= =?us-ascii?Q?SbEWFKpuIo8xWQMn+K87H+Q5JnakTc1BiDWDXZ1upqCFhqhjT3bE8u+JWKNU?= =?us-ascii?Q?oQN8vd6ODk16TkLpa4kFzBdHnAcAWKuWUqjCNd7N++0bSEK8cli0V2uzu/FF?= =?us-ascii?Q?1RXUW3fkwx3tzej2Gv6PHsadqIaOTurEfOdbYB7RP01VjKDgLrUlIdWVNGZo?= =?us-ascii?Q?an7+ZG0536ybszLGBc12c7IXRhukq6dIKJcOTwyLIPt3k3OwYbfbk8A4xfEK?= =?us-ascii?Q?yqGf2UID1Y3wzfTpiupTR+/5QDHcLNnimqpO3RvVdzCWWkzzIuQwykCAXATA?= =?us-ascii?Q?KOtAsHJlx8RIIcaMBxF1hAqK1nKUgFVWQPpmf2crOMZUjnmvSSfUkOPlZPIg?= =?us-ascii?Q?31h5cdEgmd9PqWvuOCNkpbVym/Z9ApmHq7p2D47smCbljYy+1aPg5m2r6wS5?= =?us-ascii?Q?d5aS7btNftviF/agRjHwFpskOCDt6Ob4vsFBCtukWo4FIPXV0SmsonHB0Eje?= =?us-ascii?Q?2oaryZEhYyvhSX9vQ5qgMD3J2rr/obfqmCVQy9fuB3QRv63l1DVUhydG6EaD?= =?us-ascii?Q?OUh0cMRO1c3cQYG7XyLw8xwwzZ0HB5OGXor4d15t2Xj+bEFRG/nN2GDk5EQn?= =?us-ascii?Q?AdygPjThTxxQmUTxXaI+D4lDOvHRfvTwX0kstnvLNR7hyA3N8rysMwH6NwxU?= =?us-ascii?Q?Yg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 98c61644-6341-49d2-d710-08dcf4d3b76d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 09:02:13.4112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JI88QAhDiP3PputVMfXx0tKduxuKLDRHsSfINDlwziAZnLwemwRtqFRlHJGHJWLWXzLBrVySteEB33bfgmX5IRSwbi6U5LFLvIBnaRhSf4Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7031 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 07:50:25AM +0000, Soumyadeep Hore wrote: > In ICE PMD, previously the ready bitmap checking before reading > PHY timestamp was not present. This caused incorrect Tx > timestamping. > > The ready bitmap checking is enabled and PHY timestamp is read once > the ready bitmap gives positive value. > > Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830") > Cc: stable@dpdk.org > > Signed-off-by: Soumyadeep Hore > --- > drivers/net/ice/ice_ethdev.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > Hi Soumyadeep, see review I made on the previous version. Also, when sending new revisions - especially if there hasn't been previous on-list review, please include below the cutline a summary of what has changed from previous version. Thanks, /Bruce