From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6E5545BD5; Fri, 25 Oct 2024 12:06:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B83940156; Fri, 25 Oct 2024 12:06:38 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id C34D84003C for ; Fri, 25 Oct 2024 12:06:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729850797; x=1761386797; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=vsg4vRbDdyftPTEzSDu2TLBjVvNxWsAnWO9iMjkeJMw=; b=IS1vQ6rlXDMOXszPNOLDF3Ev0YIS76NRIVGLmj02yGhkVMnzPhBOmGKM 7Xk1YuVTQkRFkXLAGKcY3DtRP/UYdwS+PnErrE4/CoenJKe0ztxha4XY8 vvHoUiyxNNm2CJU+PcYOMl8XN/mS5sfgXRYnaLV4GPRUa46uZYxsf4ICx n0/i1mkue0bAQ98XFQFLX9bWqnJYtQlWYVi4JvrsN7qRhJptrQ3Wil1c7 zfw18uJ+7SbEEfI3K9FsnOhnxNb3X379OQlQ5HLkrdifPD3c58wlSZZ8x BCQD7O9XrvMXC/fTylrZO/hJaMv5yEzEFFqA5fmm72N/+IYCsiwJpk152 w==; X-CSE-ConnectionGUID: pxifTZkcT6ytIhXzAIWQtw== X-CSE-MsgGUID: quZ1ZWbDSq2YAmEDYOMl3A== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29295030" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29295030" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2024 03:06:36 -0700 X-CSE-ConnectionGUID: 8fr+Yh/CSweFp0WKTmqHUg== X-CSE-MsgGUID: Z3m0jDndSFy598CS3DnPeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="85637998" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2024 03:06:36 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Oct 2024 03:06:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 25 Oct 2024 03:06:35 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 25 Oct 2024 03:06:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WHv0NcNeB/eNbRUUO2D2C13/EN1uWMpkE2sG9GiDblV77/wyY+6MQ6UOQ2oZgsRxuFLDKs9vyxRj30yq4BrVjbjr2NwBMP8AXns1JalJeQ8az47S7r1QsGMbOJi8998/ooVJhxFLS8e/x7WqBdT2wHmgqqM1CNk/9gs/dDCKi2hJPppy0hq/l9AOD+JVFtkPZIBAJ4Qi7y7q+bhznKst3B71WZzzOlo4XXWyguMgOG5L259zwlpozZb8qrLcSWDgrl4BCyaOnLXn4HY8cnFitBr/TtHipPlkaHS4Zhl3cgF/2qFNSUfkabOG4EtRE99FJtVjousdv314Vq05nkxQkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+l49kCKJxR7H4lERjOL85X5Eq2A17UzZd7Q6y/Lftpc=; b=gG8zuT9pZYlytfqc3TZOUWIVaLaGGnVPg0bzWuvoQ6ZlanYo3myrvHrwsIvx+0PDfLDkiMv/Bz/Gsmfek8I9Lzy5mFH+HglOad7QcLDTBS+0MkImh9oyHTgk62xmep8nAjZCRZadZfbylvXOB4cz+1kizkLjwtsXSf6Wpb5ZAuUo99u3SHXDBxMbQQlf0CawQtFZ4Q9ZCdZ/XyZOk3iSqn3EpX3t7vHPNUpQy+K2tkRG1ZMU+ivM6jspfhAEj0GTgml1KD58UZnEx3qWd/yoJqxD9dSu3uhHnXczbakO/Cg/VWi5IMYej9r49TruAonxmTNo+mRIPIo1n+TmAOJ7CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB6767.namprd11.prod.outlook.com (2603:10b6:a03:47e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Fri, 25 Oct 2024 10:06:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 25 Oct 2024 10:06:30 +0000 Date: Fri, 25 Oct 2024 11:06:25 +0100 From: Bruce Richardson To: Shijith Thotton CC: , , , "Wathsala Vithanage" , Nithin Dabilpuram , Kiran Kumar K , "Sunil Kumar Kori" , Satha Rao , "Harman Kalra" Subject: Re: [PATCH v2] common/cnxk: allow enabling IOVA field in mbuf Message-ID: References: <20241014110608.2170844-1-sthotton@marvell.com> <20241025095040.2275978-1-sthotton@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241025095040.2275978-1-sthotton@marvell.com> X-ClientProxiedBy: DU7P191CA0010.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::35) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB6767:EE_ X-MS-Office365-Filtering-Correlation-Id: b833bf4d-8068-494b-45b1-08dcf4dcb284 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WdOfaj6S6NsKhQLUrI64GqyPteDNHR8kd/5KbL8O9+gjTzdK4Zh3xVrL5Mta?= =?us-ascii?Q?Jrhg+4TBPv7lr2e/F3LTc66Y03yNb2To+cVZaEoyf3+qCr2DrmMwxxSg5LzN?= =?us-ascii?Q?FUm73BSHa1KRi5q/9k1hEnEOheMOGnAhjyVkd9ck4rsNTyQ6m/aMeBFCuB5a?= =?us-ascii?Q?Y+zBlorpWS1s+bdcmdYA8eHk88X5kwcVZalAWFfeZlRHRUn7V+oIrXf2j7Py?= =?us-ascii?Q?af+XrfjqiW+EzI6bLECi776hL5DyASg8XaCDn/UTfTmaw5ns/uMod+nR0o8/?= =?us-ascii?Q?y0n/Vh+vDMw0tqNxNC7x/i1NDQDdNDb0TueNUnUu9/Bd1JovfwRYaVaxRk+M?= =?us-ascii?Q?/rV1Xcl7UVsnIbBn3j2Dy6ecn7k1HVjylWzwZDpUr2wKR9437PdYY/htvK7W?= =?us-ascii?Q?+pC8tAgFDaFKJsICi8vrwpqiobSrJ7EjPw2TeuV+BF/wF2ji97lqi4+CtJM/?= =?us-ascii?Q?Cb32ivA5genQzIbdIMi9OCo3QIwoo5ssc3zpm452Z78OmQ4EkwYJAEFCntRt?= =?us-ascii?Q?rMfMNzMRS6qOYXMnqkG7Bbm4y6KrKlem8/u1yyZVEdn9v3qVIDIZyC30aKVW?= =?us-ascii?Q?HVknhuPvRdLRWkamw1DZlAki7RL1/s5vnvCHyO2o1KxlQVtgqyqXjhflfQCG?= =?us-ascii?Q?g+HtVoMvUKICbOC1h7jH3UB65iCMyMSjwRccuuzCggn6A5AgrDUfUNZqcMWt?= =?us-ascii?Q?NN3Z8LJaGjwTsNO54U/QNdoOw6787H0DMb6ZLF0htdqJrQaCIp8WNjMwRjhG?= =?us-ascii?Q?6CU9zela5YtZSDBUlgk0UOmQDFCcjVDfUbWbs2pzVknPSMsY7ttaXi/mqgZs?= =?us-ascii?Q?z+KxZbRAS+9oUIXGfqcPSeYxpabDnQEshWs8sfLFTgzeboAkLOr5oyYZIber?= =?us-ascii?Q?lsn05qszv+6T+6y6KI66ICoW5ZyawRSeQG+vrCE/9uQOn3PG7kPWuv/neDFn?= =?us-ascii?Q?ov5b2MADrW/3gvocIFqGJR8jjmeQUSXP53Tvov35iP+yrZ0KzvkKjiuz1qwk?= =?us-ascii?Q?6kujZbfcBnk7ZAPszcyY60Sq0FWUg8lg2zyLwJp2YFmdg2oQaxsic3aCv+cM?= =?us-ascii?Q?hcmv9P7y31U/yfVOveSKxzdLWSX6eRocZGDdAdVbEVfH0FBEFPIPUhb9oGLz?= =?us-ascii?Q?e7gFCKLRz18mKNZg1GG2hI1W5EvccugEi3g/d4CpIeFBHWiq3xJaUbWBr4U0?= =?us-ascii?Q?JcI99BdOVaLKfoPFFNnvfdieVFLoLRURwlDk7NbLdcTKxkArOpgMrkFMqftT?= =?us-ascii?Q?aswjhZllt2DQUnVXNK7gAwvopeCfGj614RfkSTXWcUl5n9gD0veFHZp6jLMA?= =?us-ascii?Q?l3/UKPSwZH2a8jO+1d4u89pf?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4ZBTeAQprIvUjONJXpL5go8i6+z4/1eq8g/BHxhCYpwnekmhOACGCD7den6O?= =?us-ascii?Q?ktJlt2k5lJm72flBeCgImSSWY4FlGe9vxqhZiUF9zUyoyN2w9xfAbreb/j3d?= =?us-ascii?Q?UfhNCNVQX8jhXjZsl10f1+V7o3sfadrGE4aOc9zLDuUkqg9ceDRR1a4kZmeA?= =?us-ascii?Q?rKGElWE2HpB+fXz4i0y30DNLzg8+KVESbfMH/KtOITLCG8WhOOE7+RulIWZ9?= =?us-ascii?Q?cG0h+j+b3OLQaNqVoFV4nU6iOn2R9qQpXjSuXE+53aQBx2xzFoOYXY98FCgq?= =?us-ascii?Q?QmHc5ufMQzx8kaCU2rp8+Va7DzGjWelvFi8XldgMLcUIzeEqwy1jPO9S+Cmb?= =?us-ascii?Q?+d0OqWa2Ab9vSqmw7V2hZgvFoSaFc0x7rxApDyYYLpU5j1MuEK1USV2HcE4B?= =?us-ascii?Q?E5bKF+acA6C8kdvwD4pJAJilPmDDBbOY9AbE7H/aJTc5GXmLRMdZXUgTC9ot?= =?us-ascii?Q?dtCKqVZU0zcjlY2eBSxom2DI4ENKJwpOLPbQJ2/5j4xwlIwK9aeVWNwbIhqF?= =?us-ascii?Q?lz3FEYOHQ/HIrZMI5lRcTQ0ZPTZMfV4CTwfXBz9+sUiltN3+INJM7hnuOMiR?= =?us-ascii?Q?b/DEUcvJ5ozqYVv0ji2FpSP8CJh4L9Skg43T2/gX65NR+Ef6SSg5uo3AA7lV?= =?us-ascii?Q?bpzrv3fInKSVss3jYHDUR7x5EEM0HQSn0N0WguPmoiI+UKKT0mywx9Aih6Zq?= =?us-ascii?Q?4pvU5WTZQx0IaQF14aADbBk5BPB6uZszz9PUuIFuPIMMeIezuxF2qIVfvoes?= =?us-ascii?Q?/xIOERxjckHDjFnjULOV0ClmKBK16kCpjx9Ury2Sy3Va+qZUYe6iw5wo6/r0?= =?us-ascii?Q?YljxjBdzz10fNFD2QofqdxWqN87q/WqVkMRF1GSEoInLYD7krBwxdTjShjGB?= =?us-ascii?Q?X10LbBTEgJ85kWlXNzVyVtjhhzRuMD8aUmw5LO400xpmw9OZHHbb78sYhBcm?= =?us-ascii?Q?snga6FOs/CfYiZ/qxsOKgwCnmqaGq3QuNSK6uqxlR8zkj7tC8slBV38GCG0j?= =?us-ascii?Q?GyA6Av4n9a27NXnK5ogEJc5CF7iiaO0I6zEgT2/mGkUQycN2lBWC3bea+TCN?= =?us-ascii?Q?EcPNE7AhyMO5zN0rLooKLoYUyW51ufKwRs29dHyJhRCN/pxRjEzo95s6cdqG?= =?us-ascii?Q?G0E19rdHDZU8MLdFvlbP2xjSVTw69/IHKCB+X1QT+jowvYsa1oMEmdIFMZwH?= =?us-ascii?Q?46PWPvh8jmnrj3FagobPeVYROAqzI4KMvo0UBsns5rXXBwJqPO5cpA/XXu6+?= =?us-ascii?Q?MbctmO4Aa1IqrrBcxJdVdjbkpp0PoC+xXenx0ik70K0S9r/eAAyHumCU2vmO?= =?us-ascii?Q?p4jc6rgPsP9Jhk8HR1XM4Uq5ks34zBKlChHFLJjOAQ7ikHaTlXhZAlDOfAHw?= =?us-ascii?Q?C1tg4jur7cN3Z8L3BlsPoeqF33eKcgc3NGyCWZ2HWo4twXtUn13ZML0qCa3f?= =?us-ascii?Q?kEMGX4qQA+EExXQmRJBqIsY7fwhjX/4bPIIk4ux4itCUoqFS7OV7TPTCJFeP?= =?us-ascii?Q?6G3yUD3ZMztQdZISDMb5oALkWV/RTZQVgCApR9VjP+eXtdGp3VSQwJ7+uyFY?= =?us-ascii?Q?zq1D8eBhCfJCT5uaKhz8XINVDruZ7ggyJzopH3GwOMCR1kANC+BZuDgqS02v?= =?us-ascii?Q?sg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b833bf4d-8068-494b-45b1-08dcf4dcb284 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 10:06:30.6778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GweHSlaaqLIcS2b7vJzmONrO19zkwnKMvH5Z7rEb2Ln+PZ1vtGvKjZYNK0Up0rU5ZczO2myKq6RxAyJaM+IVJyRWDoMfbaWS8dkV9kSFCtw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6767 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 03:20:40PM +0530, Shijith Thotton wrote: > The value of RTE_IOVA_IN_MBUF has always been disabled on CNXK platforms, > as IOVA in the mbuf is unnecessary. This update changes that behavior to > respect the value set by the user. A warning message will be printed if > the build is configured to enable IOVA on the CNXK platform. > > Signed-off-by: Shijith Thotton --- v2: - Don't > override the default value of RTE_IOVA_IN_MBUF in CNXK platform. - Print > a warning message if IOVA in mbuf is enabled on CNXK platform. > > config/arm/meson.build | 8 ++------ > drivers/common/cnxk/meson.build | 6 ++++++ 2 files changed, 8 > insertions(+), 6 deletions(-) > I think you probably need some doc updates for this. The current doc (cnxk platform guide) says "Meson build option enable_iova_as_pa is disabled on CNXK platforms." This is no longer true. Instead, you probably need to put - in more than one place in the docs, I suggest - a note telling the user that the option should be disabled. /Bruce