From: Bruce Richardson <bruce.richardson@intel.com>
To: Shijith Thotton <sthotton@marvell.com>
Cc: <jerinj@marvell.com>, <pbhagavatula@marvell.com>, <dev@dpdk.org>,
"Wathsala Vithanage" <wathsala.vithanage@arm.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
"Sunil Kumar Kori" <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
"Harman Kalra" <hkalra@marvell.com>
Subject: Re: [PATCH v3] common/cnxk: allow enabling IOVA field in mbuf
Date: Fri, 25 Oct 2024 13:39:22 +0100 [thread overview]
Message-ID: <ZxuRem2sstuqwohk@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20241025115122.2378308-1-sthotton@marvell.com>
On Fri, Oct 25, 2024 at 05:21:22PM +0530, Shijith Thotton wrote:
> The value of RTE_IOVA_IN_MBUF has always been disabled on CNXK
> platforms, as IOVA in the mbuf is unnecessary. This update changes that
> behavior to respect the value set by the user. A warning message will be
> printed if the build is configured to enable IOVA on the CNXK platform.
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> ---
> v3:
> - Updated documentation.
>
> v2:
> - Don't override the default value of RTE_IOVA_IN_MBUF in CNXK platform.
> - Print a warning message if IOVA in mbuf is enabled on CNXK platform.
>
> config/arm/meson.build | 8 ++------
> doc/guides/platform/cnxk.rst | 13 +++++++------
> drivers/common/cnxk/meson.build | 7 +++++++
> 3 files changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 55be7c8711..20f7f6508c 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -459,10 +459,7 @@ soc_cn9k = {
> 'description': 'Marvell OCTEON 9',
> 'implementer': '0x43',
> 'part_number': '0xb2',
> - 'numa': false,
> - 'flags': [
> - ['RTE_IOVA_IN_MBUF', 0]
> - ]
> + 'numa': false
> }
>
> soc_cn10k = {
> @@ -471,8 +468,7 @@ soc_cn10k = {
> 'flags': [
> ['RTE_MAX_LCORE', 24],
> ['RTE_MAX_NUMA_NODES', 1],
> - ['RTE_MEMPOOL_ALIGN', 128],
> - ['RTE_IOVA_IN_MBUF', 0]
> + ['RTE_MEMPOOL_ALIGN', 128]
FYI, meson is ok with trailing commas [1], so you don't need to modify this
line at all, just leave the comma at the end.
/Bruce
[1] https://mesonbuild.com/Style-guide.html#trailing-commas
prev parent reply other threads:[~2024-10-25 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 11:06 [PATCH] " Shijith Thotton
2024-10-24 11:10 ` Jerin Jacob
2024-10-24 12:09 ` Bruce Richardson
2024-10-24 16:13 ` [EXTERNAL] " Shijith Thotton
2024-10-24 16:44 ` Bruce Richardson
2024-10-25 9:41 ` Shijith Thotton
2024-10-25 9:50 ` [PATCH v2] " Shijith Thotton
2024-10-25 10:06 ` Bruce Richardson
2024-10-25 10:12 ` Shijith Thotton
2024-10-25 11:51 ` [PATCH v3] " Shijith Thotton
2024-10-25 12:39 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxuRem2sstuqwohk@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=sthotton@marvell.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).