From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6750745BD6; Fri, 25 Oct 2024 14:39:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00127402C2; Fri, 25 Oct 2024 14:39:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 1D0DB40156 for ; Fri, 25 Oct 2024 14:39:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729859974; x=1761395974; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=823pQNhbg/2nAjYut3y3GN62RVsFst/7pBIy5nG+14M=; b=G6LYMFSQm+HfNZOUmuHX19CjgYb7hAOK8zHArZYgsohe3qCfjlJJvs7W KaYm6bT574a0qg07IJs4iAG8KyK6aXbWciMa4Migwrf8W1TsZJrP4h9RU XoEcEZBPr3VfWhLhgB6olMIsw1hPgr3fgSmeZh00jDcKR6h/kA+H8sG1Z Nh1hehpq0Lg1mZlCMXY48J2KdqLOxeFgZ0wpM8W2AP7GTeYuxnKO0tBJW uHNtUM4USooiYJQlYYHJOklDv891YB1HBRhspizZe/B8pypxUcfYxFm4q 0/Q2g6FyzfvLWyX44nzvnMcoFiqiUBr2lnDnm1uBu2tgKfuNGKMcbl/SV w==; X-CSE-ConnectionGUID: 44u8a9QUTQaA/5IONQxR+g== X-CSE-MsgGUID: saWlQhcjSySi8hxawlO+3g== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29696117" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29696117" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2024 05:39:33 -0700 X-CSE-ConnectionGUID: /1SGKQG3T7m29qz1cE4VCw== X-CSE-MsgGUID: OOp11MEdR76/aFc1CjDMhA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,231,1725346800"; d="scan'208";a="104214995" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2024 05:39:33 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Oct 2024 05:39:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 25 Oct 2024 05:39:32 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 25 Oct 2024 05:39:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p0mxGmJf9VvLHA4zVIeRJXDlYYVoycOjg3Nq6kWhb+E9jLDcGw6kEQvzKilRs3f4dQIT9vmb+zrYBeLDiaCt1suHRlavtO27q5mNEMxTo31kbA41veTBTZQilb27RKs+OhEbtrq3gKQ+Y0C2C28h8adakVRD8dVFBqhKbF+bi5d0P2XHbfs8JqrSdNtz383jQHg5PbDvcb35Yg3JQTNYMIMHH0cz/Afe6K1CeRL1134jC96qFBMQDfrciTSwSf/F8snbqQryKVqTci8inJKCwIjEpgoUGgzE6TM1RyJjGlYiZg+rOUvPftFJvMa0WABnuuzArVJyGHuulPPSAL+k/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QT2pEvxx6By8sJqUHi4jeduazTv3XFtuEcnZZNxayRQ=; b=LrJ4WiSCLyUXEjQ7xnzhG17IXOCFpWj1dFMUObjTSjUfpw4U6UZA5rZLTgs7aGTGcH9QQ6i/uYBtQZiVMB4L3FDd3AoqYRVLkogffTtSrqwIUcJVSE0aQWK9pVCsnuxM5LwxXF6afsxcKTs0lG1N7LQdoEWwX6IA3IOIFKgEiI4H+ckbZMDXFvdh9+rnxA9A7LUNqhbn7keWluew5rqmyWIewiEJw+1eGN5K0OBFOP1HWORKTo9mXbCLGIkSXBOA6scRFVFkJB4MZK87HB59KcVaaAM5x38dGVmvWoUJeVv9Jgwl7svexjWd3k4qe8cGIFRZ3JvvBCbwYPxjv2i1Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB6788.namprd11.prod.outlook.com (2603:10b6:303:208::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.18; Fri, 25 Oct 2024 12:39:29 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 25 Oct 2024 12:39:29 +0000 Date: Fri, 25 Oct 2024 13:39:22 +0100 From: Bruce Richardson To: Shijith Thotton CC: , , , "Wathsala Vithanage" , Nithin Dabilpuram , Kiran Kumar K , "Sunil Kumar Kori" , Satha Rao , "Harman Kalra" Subject: Re: [PATCH v3] common/cnxk: allow enabling IOVA field in mbuf Message-ID: References: <20241025095040.2275978-1-sthotton@marvell.com> <20241025115122.2378308-1-sthotton@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241025115122.2378308-1-sthotton@marvell.com> X-ClientProxiedBy: WA1P291CA0002.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:19::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB6788:EE_ X-MS-Office365-Filtering-Correlation-Id: 787839f7-df81-43c7-294f-08dcf4f21164 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ui5A6VJgO0mDDfyIcHvgaZ2McVb3knLQAubE0zL2EKhAYHY5dBijm9dYf1V+?= =?us-ascii?Q?I3/BmWgqbnNy92g4oN7yE4eOqJeuM/DKlKKBZ4wDtUPgF5wRk1Wqe3ddN1uF?= =?us-ascii?Q?gZWlOkGVFyf2QiXiP/ThvHXR05Ib/0z6O0DHYP7NyMOr8hBTI/CEp/AzPHdw?= =?us-ascii?Q?qcpWTnlDl6lBj2qu6JanPujiPTO3oLp/ce9XLNOvqOsikTsytQ/itrs3BXOr?= =?us-ascii?Q?ptEPUY9Tli5L6kzHo6R3CsDJhn9eLN2jAhMcUzcz+dpXUffOi1tq72WeLjVd?= =?us-ascii?Q?pqmYAriEHLl3kxiNBRz+4eXTeCuJANw9IJHVkzDUyib7lvGrmoorK/UDsd7e?= =?us-ascii?Q?xPt+P9JFObYmkFHWO03sA/ax3D9UhyJ4iPHEnBpx4bAHDQIFVGCUU3lvfEFy?= =?us-ascii?Q?+Qeshw1wnakPfvWumE3RgD287wjSzpjBwHAl1WIkNpgvUxD4bqZoMnrUuvXl?= =?us-ascii?Q?3hIvBpI7LA9VwO4N3O5ziRrdygMw+5i/4sg/OQTEO0lWksKzUQzJLVu/MENt?= =?us-ascii?Q?tj4KeHDhVFPygSk+W7ou1MNVsg0HoCakCFz0MX/agSrQlghidWFBcbPfRO3O?= =?us-ascii?Q?bIppm2XK6him6zV52/Z/rFTzv3cCD8QvOur1dx/eOCxSBwg3A449mwyumHEI?= =?us-ascii?Q?KquVcoMEVVjddHb6VufYfiQw89o7sgVH1HqVXwiTffnnXbvr6FmBnLCwWJzA?= =?us-ascii?Q?YOe2cLq/myM8QCD5ZKxI/HdChWoTBszNSNfByZ0B9UIAjax9oEOlxzlHMAlQ?= =?us-ascii?Q?Wf9Yts6nuXf6hZLerx5q/ml0sk5L9R+NK6NC4Fr2e6n8bf446Pk8DzEfnCnI?= =?us-ascii?Q?B4N7OnjJS0RQa7JmBq2mCYP5rzsQS4+HElv3CS7dUjRFQepZYO3zuB0x//ax?= =?us-ascii?Q?Y1v0c1Yx29vtVJ8hiK4JlWjtQeHAIBQGiG7f3J2GJNf+OzRPz2OxXuP7dsyv?= =?us-ascii?Q?hRU1kHt4R2Hh3R1yxF5QQkQpblHrG+/vkTIJZ/aFrVdc5ab3/+pFYf3z6n/U?= =?us-ascii?Q?CyN9OD/r5zxjnKWUdWru++bNQ1MFxM6vG780RT/4BSIZJhTxRc+JB9uTZesh?= =?us-ascii?Q?730wKr4aXMmW/YuLerykbhM34YsC+UEBzu90nMlxfKK4ymlA38caxG+hMS0I?= =?us-ascii?Q?WyhVVzNNDIO7ekZ6Y3JrAP54OEzbm+TEyV1HlmFFaguCa0aiUnNCKnAxI9pb?= =?us-ascii?Q?BJQ3NCHR8ahmuiOtk0JwCCaSUHiVODzPgK91+nZvFxohXM3hZjPwvUBNaJaC?= =?us-ascii?Q?uhYV+RYGEiqgVdwdQKKs?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2T9vFjWETpbHWEIWBAsJzay4MLQQuuv29InjF0FR5TG/eTtDxUAqCpIt+Y5g?= =?us-ascii?Q?ty9FnmuTXX2RiOcoT9pDf3+NH9yoHKXN2T95EknVYNUJjCJtM9lw1ph8w4mF?= =?us-ascii?Q?9+ySV3qOeTUpwiF92S/aMNBWRVpt0e4CmedJzmH221/8nPFpbQWEt11LjjqJ?= =?us-ascii?Q?H3/kkcXs86If2HnmVvfY4k76qISfu3SbAaMbnwKAl8dmd68Y3eIQFjwMjS4a?= =?us-ascii?Q?HyDAhq+90gxyFX7IAkyhMs+a/r6Zp5ibKgzHj6j+gGnIpbZDMLfzSGapAYuU?= =?us-ascii?Q?n3BXZC626MUYS3UEHIXVsKFSnprV24NKf+c7cS+0ezYdMaVGV2prnF9+JbRl?= =?us-ascii?Q?qlez9OWjx5tGlb3rYgikQ8dDuq/7UbFTwPKge0fxAlk8R6jue44HgiNkrYtr?= =?us-ascii?Q?Q3YiQmvfjqDkJA+tzDAklElHA0g14x91bqv11zr6ju2S/h00sqBPSwjgZlel?= =?us-ascii?Q?B/yp3lOculFIO3qp4ImWIls3AP3Ckn0NLdz+LEBt43+KK3fQupyZQ6TumSpe?= =?us-ascii?Q?ywnDAqDyOLuCH04eSOuiJt5DwfTeScYgjU8dLfXQqbRvwU2qBWaJWeczLu7z?= =?us-ascii?Q?e4OLkrQqYNMDzff8vNhS1Rn0oAH+ZXe2RiJnXrSfREjzwo33+1WLDlt3sA++?= =?us-ascii?Q?0HwyMRG0pqAz06QFJpDvWQxV2Sa1X06rpy2VJaKk4hFm4faoHXGvLD7eNYQ/?= =?us-ascii?Q?sPRAOEE/tfFom4AOXApyGe6yNrbi24kwJkpjev2mqXrCAYAC4uy1f3GSjW/o?= =?us-ascii?Q?4OqCXy+NN3Sh4gxKr3SPavddTcaqeEYNak42jpn54j31BqIYywLfd4olJ83p?= =?us-ascii?Q?mXas4OXCGmsogWma3/Deb5pPfFuECPjqCBM8Yoh/hulvqBn7d4mEr22pSAfI?= =?us-ascii?Q?LeJMVu9nPJO2TxMxE+a9EOgXA7rbtlOdshPH8MKv/Ln/GVtiW0n2MPORjS6V?= =?us-ascii?Q?BPSW+ViFmDXC++Y3WkWf8xKaA+RlkC2whzQzil9Op9D34qYFWpk5252rATE6?= =?us-ascii?Q?exEVVGeyacSGp5EuccQR4aszDEaLU2I+Hy90oArRlb4G4zUvznKHaWzf5aKw?= =?us-ascii?Q?0UbjbrAbWZ49fYAm8EdhqTknzzcoPAQxrSww4cGeIdqmV2NWMbwfvzBFPjxu?= =?us-ascii?Q?s0kscUdbNIIWpgkTXFtZFVnp3f2fWhRSwAZ5NMa8cXgBva12YRmiH3SxrdYh?= =?us-ascii?Q?4U2QhBaNvaie/QmhNAAsCzrQPACp1uma7QkhMNCOc2W248Tp4lwWn3NtTmxn?= =?us-ascii?Q?eRPZOX65Re/Ra24mABTTm+6fWyVzAoJxGxY+5Jsjeig6nYatNJGeTT6NIRyA?= =?us-ascii?Q?Jt4kEfuBATyxs87WErOi3Xw8SSU2GKb9yjIQJLiSHV9aSXBAcZ0D7W4zXNPA?= =?us-ascii?Q?n3hMwpmBQkDR6TPEXPuiiwUqXOg+5shgEcP2ybGmAadEXUVx8iA5ZnaXEnI0?= =?us-ascii?Q?aUK5otNtq2VD9UTjOkeDBu/B/v15OpNB4pTFULY5WsMQfR8Ej4KRMoW80Q0S?= =?us-ascii?Q?NWQtIfnGKuYrfocakeMmX2xBwYrr5Ct68NqAGzYPX+sUaAVCR68CQAsaEnD+?= =?us-ascii?Q?m+HBIHg/F0TX1h+VSCBlhDnpjb6JN7H9dswEutts0DLdoamfdK4Zd9V/k+9k?= =?us-ascii?Q?wQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 787839f7-df81-43c7-294f-08dcf4f21164 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 12:39:29.3303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +XWanDAFBd0Fi4nB3dTVH/p1mT/VI+ldcuWayY9VSwbVYHdojn9dj/0yymcQfnLyTX+inGHFq4YxgUDwF/4X1lign3yn1MPjiomPXlLF0y0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6788 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 05:21:22PM +0530, Shijith Thotton wrote: > The value of RTE_IOVA_IN_MBUF has always been disabled on CNXK > platforms, as IOVA in the mbuf is unnecessary. This update changes that > behavior to respect the value set by the user. A warning message will be > printed if the build is configured to enable IOVA on the CNXK platform. > > Signed-off-by: Shijith Thotton > --- > v3: > - Updated documentation. > > v2: > - Don't override the default value of RTE_IOVA_IN_MBUF in CNXK platform. > - Print a warning message if IOVA in mbuf is enabled on CNXK platform. > > config/arm/meson.build | 8 ++------ > doc/guides/platform/cnxk.rst | 13 +++++++------ > drivers/common/cnxk/meson.build | 7 +++++++ > 3 files changed, 16 insertions(+), 12 deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 55be7c8711..20f7f6508c 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -459,10 +459,7 @@ soc_cn9k = { > 'description': 'Marvell OCTEON 9', > 'implementer': '0x43', > 'part_number': '0xb2', > - 'numa': false, > - 'flags': [ > - ['RTE_IOVA_IN_MBUF', 0] > - ] > + 'numa': false > } > > soc_cn10k = { > @@ -471,8 +468,7 @@ soc_cn10k = { > 'flags': [ > ['RTE_MAX_LCORE', 24], > ['RTE_MAX_NUMA_NODES', 1], > - ['RTE_MEMPOOL_ALIGN', 128], > - ['RTE_IOVA_IN_MBUF', 0] > + ['RTE_MEMPOOL_ALIGN', 128] FYI, meson is ok with trailing commas [1], so you don't need to modify this line at all, just leave the comma at the end. /Bruce [1] https://mesonbuild.com/Style-guide.html#trailing-commas