Re: [PATCH] net/i40e/base: fix invalid log format characters

[Bruce Richardson <bruce.richardson@intel.com>]

On Fri, Oct 25, 2024 at 03:21:02PM +0200, David Marchand wrote:
> On Fri, Oct 25, 2024 at 2:28 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > With commit cb593a832630 ("net/i40e/base: reduce size of time
> > variables"), the time_left value is 32-bits rather than 64-bits.
> > However the printf-style format strings were never updated in the logs,
> > so were left at PRIu64. Change them to PRIu32, fixing the build when
> > additional format warnings were enabled.
> >
> > Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> I'll wait for the CI then apply it directly in main.
> 
> 
> Btw, I tested this patch after removing following options:
> 
> $ git diff
> diff --git a/drivers/net/i40e/base/meson.build
> b/drivers/net/i40e/base/meson.build
> index d94108629b..ffe264a934 100644
> --- a/drivers/net/i40e/base/meson.build
> +++ b/drivers/net/i40e/base/meson.build
> @@ -12,8 +12,6 @@ sources = [
>  ]
> 
>  error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
> -        '-Wno-format', '-Wno-format-security',
> -        '-Wno-format-nonliteral',
>          '-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
>          '-Wno-unused-parameter',
>  ]
> 
> and it builds fine on my f39.
> 
And also on Ubuntu in my tests. I'll push a patch removing those error
flags when this patch is merged (and next-net-intel rebased).

/Bruce