From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] net/i40e/base: fix invalid log format characters
Date: Fri, 25 Oct 2024 15:51:39 +0100 [thread overview]
Message-ID: <Zxuwe6pz9EEY4Qc9@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8z_JySEb4KyZ0pWk+8Gh1JHH-d+h1UtHsODdvaG79hW2g@mail.gmail.com>
On Fri, Oct 25, 2024 at 03:21:02PM +0200, David Marchand wrote:
> On Fri, Oct 25, 2024 at 2:28 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > With commit cb593a832630 ("net/i40e/base: reduce size of time
> > variables"), the time_left value is 32-bits rather than 64-bits.
> > However the printf-style format strings were never updated in the logs,
> > so were left at PRIu64. Change them to PRIu32, fixing the build when
> > additional format warnings were enabled.
> >
> > Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> I'll wait for the CI then apply it directly in main.
>
>
> Btw, I tested this patch after removing following options:
>
> $ git diff
> diff --git a/drivers/net/i40e/base/meson.build
> b/drivers/net/i40e/base/meson.build
> index d94108629b..ffe264a934 100644
> --- a/drivers/net/i40e/base/meson.build
> +++ b/drivers/net/i40e/base/meson.build
> @@ -12,8 +12,6 @@ sources = [
> ]
>
> error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
> - '-Wno-format', '-Wno-format-security',
> - '-Wno-format-nonliteral',
> '-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
> '-Wno-unused-parameter',
> ]
>
> and it builds fine on my f39.
>
And also on Ubuntu in my tests. I'll push a patch removing those error
flags when this patch is merged (and next-net-intel rebased).
/Bruce
prev parent reply other threads:[~2024-10-25 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 12:27 Bruce Richardson
2024-10-25 13:21 ` David Marchand
2024-10-25 14:51 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxuwe6pz9EEY4Qc9@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).