From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 082DC45BB8; Fri, 25 Oct 2024 16:51:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED06D4026B; Fri, 25 Oct 2024 16:51:54 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 71C234021F for ; Fri, 25 Oct 2024 16:51:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729867914; x=1761403914; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=FIvIqSlcxOHuA2P3Kaeh+2iP1I4n8b8YNPy3SVyiDso=; b=lhony5LxCFHcVtWlJgrtXL14hsCvxeJGRiLJxdK0FMxKYxrtx2oymsRJ Jp/Xh+Uk+s61hQZBQQYxryzVl7uM39DdVhl8fVHnjLU46iiNKuU9S4nXC yLMqgrN3MtVF6aTWfKkLZnXBs+VHEST6GN3kEoVFLyz2hluVgNxP3QGA/ tXZJW1oPsmCHZNOX6X9nOEwzWFPGm2R7+K+xGe7y5XmAfNRW4fKdf6V89 qVBvBoX1CIF/F/HnhIgbNH2kZM8fLgsgLVPoFYu+ANYWWq1RhSD36mx0Q 7oQtT9jH5I1l4F7s6y2PGlWp83ZpwVpzSPs4wbvGEXSIsGQnp+jI8PzG+ g==; X-CSE-ConnectionGUID: IfoQCsJRQTC3YaDQ84MK8A== X-CSE-MsgGUID: sa+Aa1dHS4SpGLz4tN9zuw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29403825" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29403825" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2024 07:51:53 -0700 X-CSE-ConnectionGUID: 4i9oGqWFSKqORR+fCiHmeg== X-CSE-MsgGUID: iQz50Ot8Tsqtve1DCw2G3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,232,1725346800"; d="scan'208";a="81044012" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2024 07:51:52 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Oct 2024 07:51:52 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 25 Oct 2024 07:51:52 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 25 Oct 2024 07:51:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J0wtnGfVW4w2a8upOlZRh3us+2ERWuionRgbKqcH21HY7VwCbTa+9Cwx2kt/M+8pvMNmUnhB6jieShbFR25sypmdnk5AMDVyoeQeiqkHuX4QoopNB00ke2K0zlCnUERuz5w2G5VrftEq+SLzmzoTY0IzYR7Lfp7aua5jVZQG4IGAfkwCRBOidiGcKTJKa+t02QtINUOORZ4CsH98hNcAV9xCsos1JFMOQko2lgILmZHLRB6sr342ho5aEW220nANqjl38yHW8qinczXOft3PuP+6TktHl48wEtssAdMpwbM/MmCqbtix1K9fBPpjuAWnlJLNss4n/v1ctGT1DvuVPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OuhSPK1zQWYCdNCP73tP3265WZ+OJpYFMzDFr9KAkD4=; b=xwdv29Up/0ry2fVGoEvrpaoE49Px8L24t9T1gY2R6sbqOon03pvKQiDMhE54he1+t3KLsxx5wz5nGw352Q5dXOeRildakQSYhFX9QDECy9CsJ3sJARmujU4kyd2RYeZibAyvUyEMtS9h2r+o+zYz94zgJOtL+Ypms8zE+slzFF2rEZiueScV3c+jSODGxGkfxTPr6ba0D5XUUZg9XoiFVfsd+vEqNeVnu9pensLo3zzefVwENkj96yiD6civdl+vsUDGr1vMC491BHU+pfX81DxTgWrVSCK+wZ09kAzyX6PM5SVfF3fXafpshtWXPg9T452y2gEUHSoD5J7V6ow1JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB7150.namprd11.prod.outlook.com (2603:10b6:303:213::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.18; Fri, 25 Oct 2024 14:51:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 25 Oct 2024 14:51:45 +0000 Date: Fri, 25 Oct 2024 15:51:39 +0100 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH] net/i40e/base: fix invalid log format characters Message-ID: References: <20241025122746.1775593-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MI1P293CA0007.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:2::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB7150:EE_ X-MS-Office365-Filtering-Correlation-Id: 6de56ae0-f97c-4596-16a2-08dcf5048b88 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YisxUlg3T014MXNxTjhZVDg1VHh5Sk9vQ3RWMlpkK2p5dFA2Q0xEK3J4MXMv?= =?utf-8?B?Z0FmZXlvZWZwaXFxN2p6S1BoT0dBK2txdWI4ZHorYjRSdXJZT0g2V2N2WnVn?= =?utf-8?B?eWpwVmhtVFFQZVpUWDNDUTlwU0p0Y1NZRnFWTHFEam9SaFdIUWJXU0FsWjM4?= =?utf-8?B?blVqOWpCNUIrZmRhQnFGaXZPeVczeHJHdDRld3pjUmtJY1BtaFUrZnNvU3dP?= =?utf-8?B?Qm5zV09zaCtMNFVQcjJXMHprd1BpL1c5UjBnQkJMN3NkYzZqTXdLMzc2T0lS?= =?utf-8?B?T3Vzdjd0U2NnS3ViWTFzQ2dBSDd0K2x3WktWRTlVam9LdUhXcmRMZjA3RnRu?= =?utf-8?B?UVVEUjMzNG8xV3d3ZGlVMW1ua1ltb1J4MTI2aUloV3BjQXp6bUNtOWQwWDM0?= =?utf-8?B?ZmJtRDJBMTFMUksyaUJuc0Z3M1J1M3ZPYmswUmg0L2I0SUliOGJWS0xQMTZM?= =?utf-8?B?YnNud044c0YrVmJVZ2dZZjRsVE54ZC9xUkxnZUg3TWgvY0VLRkZoUFZCTlhq?= =?utf-8?B?QnJTa1ZnVzNDS3BBZ0dpbnBKOHBWMjFleExIa0hENXJXWEpvSHp6MmlJRjhD?= =?utf-8?B?Mm9wYzhkSEUyN29rTWpleFV2N3dnZFpIU3RBSFcvZjQrS3ZtZWk2eUZuT2pu?= =?utf-8?B?dkJkVjMxSEhSMTBqR2VuYXhweU14M3YwUUdjMFp4cDJYS2tSaUdYcUN2a3pX?= =?utf-8?B?bWxDYnRyU3ZURENENTNSSkdhbjNEUUx1aGZTVzQ5aURySHlFRW5OcmxDRnpK?= =?utf-8?B?b3QyV1hTYTZMT1g4M0NsL2tGaE1ob210NUVzdDVEeW43dTFHMHhaYjR1RHo1?= =?utf-8?B?ajhVS3N5TnZIV3VOSkF5MWw4VkNNMXE0R2RhTXQzTTIzWUlncEJRTGo5ZW5s?= =?utf-8?B?YjdMNlB6dXJqRGxqT0tlWGtGRWtkZytyMlJWc2FaaWlYajAxM2FnOVduRHFS?= =?utf-8?B?Tk40QU10V0s2eS9hWFltSEU1dUdlOGNCNUxXSjBXQTN6ZVp1aUpkM1JiblhJ?= =?utf-8?B?bmE3N3ZnUWlDZGg2T0NDTm1FYlJxclMwL0J0SXRjWmlBckpMajRwUTdvSTZU?= =?utf-8?B?NTF0ZlNjQTZKczUyU0ZYRWszSVJoRmpaUUp1NnpzTml1ZGVKcjBsSyt0V0V5?= =?utf-8?B?MitYWWRiOUY3U252S3RnRW81cnh6MVBGVS85UDhhbDVGYlBhOHhYVzNNY0Fm?= =?utf-8?B?ZEpqM3BCeHVDZkxBR29tVzJZQUVMNjNVcmZKZ0gwUDBCYTZPMkdLNmhNRVBU?= =?utf-8?B?OUdkQ2ZqdUk3enpGUEI2QjJ5dlQvUHJWT01USEk3aWVWSnB0aDcvWk0xck1a?= =?utf-8?B?d0tIVXAyUy8zQTVMaytaM0xFb1BMcWhaV1lsQTR1UEk1ZVJlb21vZDlFc3lw?= =?utf-8?B?aDJMREl5K0N0elpUSUlFRnhlNmdXT1FXeklYV2V0SG43SXRvbkZ4ZGZZNXZr?= =?utf-8?B?ejkwaFUyVDJpY1VQZm52VEpvUFRFVnRwL2VZNHJtVXZXdCs1NCtxVm1RREgv?= =?utf-8?B?RFVJem5teEZ1azRDRnk0U0FDQ0VwK2xKM0p6RDhVSjlJZmoyY2tsaCtsMDVs?= =?utf-8?B?U2h6aURGT3JuUFNlSjMzZ0Z1MjI5QkNsUFduS2tWZnNpdzNlTHFSa21ZeGRv?= =?utf-8?B?YWFsTFo2SFg1SVFDbGprbjQ4RGp2bWM0VEl6Q1BvRFpzV29kN3RYbzRwR240?= =?utf-8?B?NlptRDZCNldQZmRkdnRWaTN2djdpbXFvZEVUcnR3WXVCV1hNNXRnTDhBZXlq?= =?utf-8?Q?JIZUDQZoCO4hHIbA8ARGls9MR5B7l9tN0MtEHP+?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXJQTGpFREIvdXI1M2JCSktuL0hWMXYra2llakd5eVRZNEIxOWRWMGw3cmVv?= =?utf-8?B?OGFYVzVGK2JZQ1pNVWUrWWVvNXRiY1ZTV3RoM3NGOFMwZkFEZ1FyU0VFbEY3?= =?utf-8?B?WkRKV3pIQUpmeUNDM0tuYUVFMGFoRHJ1RHdTTTRwRXo5ejF3V1lHWjU0OGtL?= =?utf-8?B?ZFV4cDlUOG9aYkVUT2FmbWlGNjNwdFVQemcxdHI2MGhIVC8wRm5wRjZUeHJB?= =?utf-8?B?dDVUbGNPek1IMDZkM2FQbm5QNzVna0JOTlEydkNLV2dSR1c1Zjd5SnZRdjZo?= =?utf-8?B?NFdHdzVGMnlGWFpnMncweXZTREtYNFdrL1d1dVRRK2ZNTTh0NkI4Q0VvSjVP?= =?utf-8?B?dG41MVY3dytCWjRodjMyM1Nydkx4c29mVjNkV1A5VmwzSVgwNjVGRmljR1ho?= =?utf-8?B?WnRBQnQ3RU5vdVdFL1UwOUpnTCtodGNINytOeGYyR3dFc29WM2k2M1Z4TE5G?= =?utf-8?B?QUp5NElzTkgwVjVvTlJ3MlkrdVVkZkNSc0hPbDd4ZE5SUW9wV0V5Y2pZSkRx?= =?utf-8?B?dW5JYWpxUDErc1NMM3ZCNlgwUTdqYjBwei9pQ2VOd3JoOEYyUnU3ZjVMUVJG?= =?utf-8?B?V2pGdUw5a3ZBR212T3BCSlRUNE1yVEVVQTZHL2tHM05qb3YvQ2sxNzgyN1Fa?= =?utf-8?B?dzhOQjFDY04wNm5uVzdlOUtvOHFMaWNmRkNZOFBreExCeUI0bzF0ZzJHdEdO?= =?utf-8?B?NHZ6ZzVnRzAvaURNdFJ3c3lIZDIraUJwNkRZMXo5TE15eXlLUkthY3psRW5n?= =?utf-8?B?d0h3UHMwcG1QeXl5K0tKUzJOTXFOODR1U095WnRMQnZkMFV2VG9SRjRqbU5I?= =?utf-8?B?RUViMzFzb2xOaTUvRzdxTjJpeURLVmxOR3NSdm5reWZzZG44Y2ZoRGNaaFhS?= =?utf-8?B?eGZDMFIyY3J6SURGZ1hkNDdUbjd1ZU4yZ2Y3c2QrRE1vWWpYVlBmR3NnRGFK?= =?utf-8?B?Y0hoVFkyZnhxeFlGZGdNK2NDRERmTG82Z2RKblhkK2k3M3BLdXFSQmhKUkkz?= =?utf-8?B?NVhqNEVJUlVjbWZiS1djN0luUWF0eXptV01Rc21COXZHU05kRXZQYVdRVHVG?= =?utf-8?B?d0VscnpWcWN3cTlJQUg0QVFjYXdNZm9mTXlBZnUyeVR6MmFlOXpMTEUydm5I?= =?utf-8?B?aFNyaTJlM1lmQUoyem1qSFp4NzlwbEZoNjJVczZ6WTZnbnZyUUZjYjhudnB1?= =?utf-8?B?QjFlVklWNjRlVVZYY2lPY3FndWdJOWtTTXYwbGdMNWxEM25PSUpRN2trQUNI?= =?utf-8?B?ZnZRUG9zbDduTnF1Z2JBaGRCU2w4WkxnaGZGcytFNndJWFYxVEtrck9MRCs4?= =?utf-8?B?Y0tQZnVYb2xTZnRYdWU3cjZvTmlPVjEvVGs4Y2VFTFhqaUdpRTFoNDI0eGZs?= =?utf-8?B?NERad3hLWnJqWVFMNGZZRUNva0thaS95bTYrc2JOYVdhSlBjQmZVVmljT0V4?= =?utf-8?B?MTZIUXdEbEhQWG1qcXExdUJaVXZNRFMrbUVzMnd3bms1K2tzVllZNUsyWGVL?= =?utf-8?B?UUgvUWJYMnA5MzdPMnZ0T1dpSlRydlBLZ2c1WlRRVXVLQ21PZHZEWGpWRTJS?= =?utf-8?B?ckFTaGlmcHpxR09xdElyWkdnd2lKdFFDcjBuMS9vSkt0aEtJVVF6VFlIWDZH?= =?utf-8?B?eEFvSTgvdTBVdHJEd1YwQVVTSm9PcjByNEVwZytybVFjcVJDbFJKMVU2Nk1Z?= =?utf-8?B?U1V5eDhsMjM1emY5bXlmWnYzQ1hja2VlWkpFS0taeDBTMTNZRFJZR21uWWlC?= =?utf-8?B?Y2pzNkdPY0NKdHF2cGl1TWZ3aFQ3LzcxMzdvQlRJVlpEMHhqRFpsQ0dJNENB?= =?utf-8?B?RnYvMk5PZjZJSVBqV2pBSFVIZ0ZoYlpCSUZSRm1nem9vM3hQTXMwYjJqTlZI?= =?utf-8?B?elNodFVwQjNMQ3p0aE9XYXlpeldhUXNDbGdPU1NwT1NrNHVkb1E3K1Y5MjlU?= =?utf-8?B?NSs2VXlOZnBBcnJuMTZ5Rk5ycU9rdytHNnZoUjQySnlSZ0hpME5tOEtYcFRu?= =?utf-8?B?dmoyOHE4UUJjMUdHSkpCNWZveVBoTDBFdWJ0UW14VkJ0OE95Q1d2MzJLZEJv?= =?utf-8?B?Szd2ZGNzTCtvMzAvQys1MGZTWEFvcmEvc0E5TWxkN0ZxcG4rOWl0a09hbnFp?= =?utf-8?B?NEwxcVptbXVBQVFralNTZWtRQXFYZ0c0NjhoRmFncjFkRGNQSCtxZ0QraXBj?= =?utf-8?B?cHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6de56ae0-f97c-4596-16a2-08dcf5048b88 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 14:51:45.1989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eUpz0lSMX/XdGytKNQWOXVVw8iwbRUw+TRIMrvXKcmAeVRVeHLfQYFSkLljvQfv9JV3n7O94MWTCmZv8sLsfTyeol0RqIzam3KLYvzyFTDY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7150 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 03:21:02PM +0200, David Marchand wrote: > On Fri, Oct 25, 2024 at 2:28 PM Bruce Richardson > wrote: > > > > With commit cb593a832630 ("net/i40e/base: reduce size of time > > variables"), the time_left value is 32-bits rather than 64-bits. > > However the printf-style format strings were never updated in the logs, > > so were left at PRIu64. Change them to PRIu32, fixing the build when > > additional format warnings were enabled. > > > > Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables") > > > > Signed-off-by: Bruce Richardson > > Reviewed-by: David Marchand > I'll wait for the CI then apply it directly in main. > > > Btw, I tested this patch after removing following options: > > $ git diff > diff --git a/drivers/net/i40e/base/meson.build > b/drivers/net/i40e/base/meson.build > index d94108629b..ffe264a934 100644 > --- a/drivers/net/i40e/base/meson.build > +++ b/drivers/net/i40e/base/meson.build > @@ -12,8 +12,6 @@ sources = [ > ] > > error_cflags = ['-Wno-sign-compare', '-Wno-unused-value', > - '-Wno-format', '-Wno-format-security', > - '-Wno-format-nonliteral', > '-Wno-strict-aliasing', '-Wno-unused-but-set-variable', > '-Wno-unused-parameter', > ] > > and it builds fine on my f39. > And also on Ubuntu in my tests. I'll push a patch removing those error flags when this patch is merged (and next-net-intel rebased). /Bruce