From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 291D345BCB; Fri, 25 Oct 2024 18:51:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A166B40659; Fri, 25 Oct 2024 18:51:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 5449D4021F for ; Fri, 25 Oct 2024 18:51:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729875098; x=1761411098; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/1+oH39PFDOOrv/G8lyc9GhzbmGbMbx6wmr3KjUdKsI=; b=KAl75NA+XpqJR5FcYGXUPd+VY14bD93dCkHmFrnpWO0G8XJ/Kwy0eNKT 69q81ZZxmSuKM+D2EfCIYuykFjYVqIfGKg2kg32x819any46yA16LWXYr 67KM9AbN2ylGB4zbw0BlhGp+vnWcgpAYpjEJuQxh4KAiPoXrtOnEYmS64 T8JYvwtY8HHoR8Icx3uz+WaoVRxUMc9GDixHP16BWq8tJBN6T4R+XIfCt vTADFL6LhejN02Y4z5CztagD5pP9Vz/vWk183nRhCajoyWeKAMC8dSn/R +IHEc4Bci3rzaHXxeU4o9C1PthwwIIvSnx7Yxa/HPLC3R/D5GgVvZMbNZ Q==; X-CSE-ConnectionGUID: J+W0nF4TQj2cL0HXF55gwQ== X-CSE-MsgGUID: HIJOru+/T3iSJ2NZpno19w== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29327368" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29327368" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2024 09:51:36 -0700 X-CSE-ConnectionGUID: nYGmJh3ARv6f3y7qmjEaPg== X-CSE-MsgGUID: GyuF/c1RS+SCJNk8PqXpng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,232,1725346800"; d="scan'208";a="80879755" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2024 09:51:36 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Oct 2024 09:51:35 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 25 Oct 2024 09:51:35 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 25 Oct 2024 09:51:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y6QCxranRAV1qVRUOF/ftn7jpsZ1QYc53/UOKc3x41awBHbj6Dm/rtxeATGfXR4h30RL/thsEyuUSzIqtwMiZB/w5G8cPW2NOM7r9s3XQw8vj8sPLrZer40V+9mbZ/KWldQ3GnQ7pBVyEkEKTG4QzIXfWxDwVoRfwEZ82xfXwmWj7WIDzJQjUs7KsadBoVD++CwQNGy7PcrvbsUyXkoZQKSjGAbUq6TYDn0A6HHzx4EFjR2+pKXhr8y02lIZlZv1iJz2X3507BQA1ve5TvERFmH+zgV8Dxgav8T2F7gNnqzCpd75MYqykdl4/SuliSYrcx6lZFAQGJ8TnpDFj8v1ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EpQDPLwKXxVH9yzSlNmcmIWLOcP7xzadwpAJ71ApSxg=; b=Y1QR4m6cNbjmIbIQTyVE34caMarISq4YdggbUXHj0WTWowsvz4gQjQNo3ULCqwIgJITGNyr6yWhMVOWop8sVpWlfpeoER2+zN5sEgjjAl8yW+0j+SbvEUbuO1+MmLmnxjNfPNVYmwh+qNxHHZSNumWr9E3kG02qFmi0IZqYAb5oz/7926LV6Mwco1W7qYDAPA2dTkj2wSgZQksYjkybORsC9edHfJmMlecQzX+Hb3u4wxC8C/suUZRBadyxHiGd35xjzo+o1KUPXryyoQbUfNYkJekUxp0OqYTx5KX7W7rfKY9RM8S3pLQ7ZMYoItCmcdH4l6uvbSg7bHPchSIPy4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 16:51:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 25 Oct 2024 16:51:31 +0000 Date: Fri, 25 Oct 2024 17:51:25 +0100 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH 0/6] Reduce scope address-of-packed-member warning Message-ID: References: <20241017142214.1669370-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: ZR0P278CA0105.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB4930:EE_ X-MS-Office365-Filtering-Correlation-Id: e5b17d71-a54e-4dfd-639b-08dcf51546c8 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VTZHcUtuRTRjQ0hWRGl5UmFJaTl4Z1hBY3J0TEE0aGNDVklpeDNpWnZxV3dj?= =?utf-8?B?YTZWQytCNFFheFk2SG5HdmhndnZpSU1lbXVDeW1JTEpnVldiQXRUV1RMUmVx?= =?utf-8?B?TmtEQlpOMWlsb0pBYmRKaHpHSVpYWTNDc1VSZGUrUnlaaEh2RSsyeWFMRGIx?= =?utf-8?B?eWEvc0ZuSUtnZEo1U2ttQzFLM1I2cFVIdzVrY043MzlSbVI2d05ZZ2lUWC9F?= =?utf-8?B?SEp4YU1PL3pIL1ZJTUtBYXhtZzlxWHE5SmtzZWgzZnoyZTdHUXgzQnFCOEZt?= =?utf-8?B?MEFmajFrb2xkeTZ0U2thb0ZtdEFZQk5FWW9wUG43UDVINTBPckoyeGV6bm8y?= =?utf-8?B?SnVjR3ZkWk9sKzlVMDFOMDRhZTVPNm9pMnlaenJLd21VeTJpWlk3RjIvQzFP?= =?utf-8?B?OGFqa29DSVVXbnNmYS9FRWlyL2JZL1E5TkRnWXdwK202akRBTHo5ekorUjJB?= =?utf-8?B?Y1FaSG4zVlNwdTlRYU1sM2ROT1lucXJzcTNUYW0vTUN1RVpySU9zN0FCaklm?= =?utf-8?B?OWVjUFpEQnhmK3hXYVVSZTAvNGlqWW1US2RZRXdKUlRDVmVVcHFsOUxyWTVm?= =?utf-8?B?N1VFNFpEVndualUwaW1WZVBDZ0JaM29mQkhpR3l4Y3doc1ErR0Z2ajBKMzBo?= =?utf-8?B?MGpoN1Y4V0pvSVZqZ0lLcUhtdGFpTkNBOUhRYm5nSDRXSW90SXJEaWtoSXRK?= =?utf-8?B?dmFYc2srZ2p1dlNIYUZXREk3WU9VdXVTZ1o5YzhVNGZCWGt3aGI2L2ZmWFht?= =?utf-8?B?aW5TTUo0M1FzNExzY2xYMlg1a2NxV1gvN2FKUEt2bzVYZTdvcEI1VTVjWDJ1?= =?utf-8?B?a0tSQUZIU1h5YkJORjU2d0FSdCsrdzZjY1hjRkxIeVFKZG9lcjFtWXg4OGty?= =?utf-8?B?RDFmTEJRRlNkK0p1ZFlCaFYwdzQ0MjFSTWZFMWdBbldPOGQzYkExcXdrTHh0?= =?utf-8?B?THpJbXNZekV2ZEdsZEZGQytqTkhaazdWTnlNWmJxczIxMXIzZU1uM0VPZHZh?= =?utf-8?B?WUZsRDRKSkViZW9tK0xId2pTR2xkejFKQ3Q3ZWYxRGZqWUgweVJZU3pWYXpE?= =?utf-8?B?eUthbGtTdk90WmN3MWdrNEhmUjgzQVlpMXRmMGpQNlkxbk9GVFRZWVdHTmYr?= =?utf-8?B?N2w0YXdFYmZHSzJSUmM3OXZkeDZlbGV4aG5pT3l2YjYraVBGemVXclZoMGtP?= =?utf-8?B?RDRtUVY1TkIxeEQyS21aaVNpa0ZOdXZmZDE2ZlhkMlFXc1VKdXFMZzIwSnB0?= =?utf-8?B?Q0t5ekloRnpBYll1Vmp0L0loSC9oTDZ3dEFPNXFxeXJBQTBoUTVnbEV2c1ZN?= =?utf-8?B?TmxnMmd1eC9BbjMzNjVxVHJDV2JHWGV3UGI5QzZ0TUVuTHIxSkRhVkRnalV0?= =?utf-8?B?KzhGN091aGh2QW15Y2dYYzhYRUF6aERudHZzYzdwYjdyVHJ1b1MxdGRCMEhh?= =?utf-8?B?THNhMGRsb0VDYXJPaDdaRGFYbkRCRHNNOFMvOEFPaHlNcnYvb1htdGU0RHo5?= =?utf-8?B?U1gwZUk1dHZSUk5DNitROGZaeGtxcDB5QWk2dk54YkJsUE5IZzJaOTJEZzNr?= =?utf-8?B?N0VaSVlQNzZtNVlaRjRkMDdhWVk5ZkR1R3RSKysrZUR0N2Zud0VXZXNwQ2xi?= =?utf-8?B?aXNveXZLckRJdTQ0MlBDWE0yRE5xTU11TmtPM0I3UnArc0hIaUZZamxmNk9R?= =?utf-8?B?OVBNZCt0YU95NG9GdVVlN3BQU3pGbFdyMnpEUUpOdlU4U0Q0UmZDWWxjRGJE?= =?utf-8?Q?1AxaaOIHUwu0eNmRBtpdUU6kzigy8GL1YuG+QfL?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGpHblZWcXNxSzBNaUZ1VEZhTkJWS00wZnJhZEkwMVdXK2Q4b1R6Wk5nUXRy?= =?utf-8?B?WUhUVUhCRTZ4NXQ0cTZJa0ZNanlxVzkyMzRHRWhKQmUzN2VuY1lZZGErTXBD?= =?utf-8?B?eHpGRXp6TVVoM21RMWdsdHpqakVoYXRtY2E0Z2o0UzgyTGxlODhIMmM3RlpN?= =?utf-8?B?ZDBYYTU0L2NRUVhFODNIQlptaFp5TDdYdTBVblByZlVYa2tFdlRGa3dDK2Vo?= =?utf-8?B?MlhXaFI1bG1ZZ21RaS9IWFdQQmFqYm9WMlRMUldCbW5OaDIybU55N2dHd01o?= =?utf-8?B?djJBZ3hkc3I3QzJyekxZQURmRHRGT2c5ZFJYWUt4ZE44V0QzNGhMMHVTWnRl?= =?utf-8?B?UUhTblN1NVZNeVBqSzltRjdsSE9IMTRrR3lXQnlpYUFsaDFMTHZPeHlQKzIy?= =?utf-8?B?cFBmeklFS0Fyd2NXa3luenlnS3cwMGEvWFhKQmpSRm9XMTdqWWsvYU13RjVl?= =?utf-8?B?aEZFZFFqWHl4aSt2L013YnhpNWw0blZmSnYwcHh0V0d4VmE5aklxSUhMNjA0?= =?utf-8?B?UUJRSVlpSnhwZUY4VnNITU5pYjlLZGpTWVdQMGtTQmZIZDB1T2JnSDFxT0Z2?= =?utf-8?B?N2NGM3hCZkk4bVF6Z0l6ZXl3MTNPTXBUaHpNM1RnaUxrUUhGdTJoWERDWjNu?= =?utf-8?B?NUNwd09IQWRsMS9NL2poUE9RNXFRWmovVFN1bEVpMndTV2VCWmR3VDQ4bW0z?= =?utf-8?B?N294aUVJbGxIcE9MMlZHL01DS2I5TkVJaERqcFgyeDVDMkY1bStEWkJIcWJW?= =?utf-8?B?cUdGMVhUeVo3eTJHUm90MWRBUW1ZaU1HWTRIQnAyR0t4V0p1KzZLaUdxRWdZ?= =?utf-8?B?SWhwNWY2OWdUTkMyRUwxdWNDNmx2SHJBb0dZczBBOHpOM2V4RGRPTStNai9y?= =?utf-8?B?T2oyRHFrRGpaUUkyNTVUcUhYNHZWMUczTW55bEQzc2MvNTlQVm9CTnJvRUdH?= =?utf-8?B?S2hzakdRZ1VRNFhIdzlWTjYwQndNK1BSV055ZXpTZ3BpOGFMTE9Rak9waFJh?= =?utf-8?B?MlczTkMrWTN2MFU3RzBYald2cnpFZVgzeVhVRXYzVHlTQWxzVEhnYTVyYUxl?= =?utf-8?B?ekZreVhOQTVCTVl1dXdweWlodkJnTy9QTnVHRkNGdW9jaCtYSkNGSW5EUFdF?= =?utf-8?B?Vm03eVU3VVRDd3ZXeXZteWpzUS9tZ24rUDROV2lDYmJjU1FOalJvbGlyU0ky?= =?utf-8?B?Y25rTzAyNU5EcEJQSzhaRVRYN0xrOEFDVnZUc1NYWDl1WGkvQUw0YXl2UGZz?= =?utf-8?B?dHExZDRseFZaYlh1aG5OeGptaHp6YnBaL0liY3lkL1ltbWpla2FMRlFNWEU2?= =?utf-8?B?b0htczRMMHNqMUQzLzVpR21SWVl5S3gxcENnSUFpNU5MaUVyQlNITEg1MnpR?= =?utf-8?B?OFhnT1l2RkR0YWVITGNnNmlIOXlpL3gySW9GYkd4UXZoeU41OW5KTDJsQkNU?= =?utf-8?B?aXBTYklaalRTTzNWdmRwUHVVb2xkVlJYNzg2K0JTdHVUcWdSenJTMGEyQlZ5?= =?utf-8?B?UnRPdXBkWXVWNWRrVlBQQXp4enRUSWNNNHNEcXZOWGxJY3FtNlpFY3F3eCtE?= =?utf-8?B?UHQ3TXhNZ2dFMTZaQ3pLZCtLOVBySUFpNjBZdWxxRzBJc0tQQjhNNndSM1NH?= =?utf-8?B?UzdBREFkRXhrVFc0UnRTQ1VubXl4WGtTckNHRTFPUld2aWV0a015YzdYQ2li?= =?utf-8?B?ZnNza3JCWnowcTR5SkZhdVFaRXg4OUFTNTFZUG1jbHFpNHlKcVViaTZUaFhp?= =?utf-8?B?ME1zUUdlMHJPblFUOU5xYVNubk81ajZJWlNLYjZDVFRwUDl3NU9NY2xTaGVw?= =?utf-8?B?dVJETWhRaytnTnNoR1RRaHNKMzhnZTdqempmY082ekZvS3plbDBpeitmd0NN?= =?utf-8?B?R25zMHVNcEs3OXltaHg3MTlQUkhJc25walB2eGJTZjdhZE1nVWpWZEIxd0I2?= =?utf-8?B?T0ZTNkxBUCs3VE9QdGhkREllM09pT2w4a0dPOXZQT1JRTS9vd3A3QzRIelF0?= =?utf-8?B?RVVjb0xCeHpPbHg5S1JZR1p5T3ljMzQ4U3pFS1NGaFNqTHdPaE56dm04aHBo?= =?utf-8?B?WVlHcnZieUE5QTJYN3Q3ZmRuSDZNNCtyd2dvSHMyN0JqbVFpODNnbm56NGVm?= =?utf-8?B?RlVmNVZKak5yd0Z3OWJ5YWRGQXZNMkhvZnNQSldmbzFnREhqMGh2ckxYVTdY?= =?utf-8?B?TFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e5b17d71-a54e-4dfd-639b-08dcf51546c8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 16:51:31.3060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7I6geyY9QChPMlvoNslRbOHOxtsFWOrYqNjN8TLKp9w0WRIkEzov5QpoNJgfNiU9Kw/0KOUJB/KJtZ63TLUMWAqzT1jDoYdJguM5RQuBQl4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4930 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 04:55:08PM +0200, David Marchand wrote: > On Fri, Oct 25, 2024 at 3:24 PM David Marchand > wrote: > > > > On Thu, Oct 17, 2024 at 4:22 PM Bruce Richardson > > wrote: > > > > > > The warning for address-of-packed-member was being disabled globally in > > > DPDK. While for drivers which need to access hardware-defined > > > data-structures the use of packed may make sense, for normal libs and > > > applications the use of packed data should be generally avoided. > > > > > > This patchset initially applies some fixes for cases where we are > > > unnecessarily causing the warning to trigger. Thereafter the 6th patch > > > removes the global enabling of the warning and replaces it with more > > > selective disabling for drivers and for a couple of other components > > > which have not yet been fixed. > > > > > > Bruce Richardson (6): > > > ip_frag: remove use of unaligned variable > > > efd: remove unnecessary packed attributes > > > bus/ifpga: remove packed attribute > > > pipeline: remove packed attribute > > > net: add smaller IPv4 cksum function for simple cases > > > build: limit scope of packed member warning disabling > > > > > > app/test-eventdev/test_pipeline_common.c | 25 +----------- > > > app/test-pmd/icmpecho.c | 23 +---------- > > > app/test-pmd/txonly.c | 22 +---------- > > > app/test/packet_burst_generator.c | 49 +----------------------- > > > app/test/test_reassembly_perf.c | 29 +------------- > > > config/meson.build | 1 - > > > drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- > > > drivers/meson.build | 9 +++-- > > > examples/ipsec-secgw/meson.build | 6 +++ > > > lib/efd/rte_efd.c | 4 +- > > > lib/ip_frag/rte_ipv4_reassembly.c | 4 +- > > > lib/net/rte_ip.h | 33 ++++++++++++++++ > > > lib/pipeline/rte_table_action.c | 2 +- > > > lib/vhost/meson.build | 5 ++- > > > 14 files changed, 60 insertions(+), 154 deletions(-) > > > > Recheck-request: rebase=main,iol-unit-amd64-testing,iol-unit-arm64-testing > > Unfortunately, there is a small conflict and the CI can't retest this series. > Bruce, can you send a v2 please? > Done. V2 is rebased and also includes the checksum calc adjustment reported by Morten. /Bruce