From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B9D145CB1; Fri, 8 Nov 2024 09:46:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B011402D8; Fri, 8 Nov 2024 09:46:09 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 9E300402C8 for ; Fri, 8 Nov 2024 09:46:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731055568; x=1762591568; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/kbo1BMUKNs2rXZYHMxs+TrZKvFIRqo8z3xCZpDyitA=; b=DI+hWed4z2W4mFYk7jRNo/0gb6VDo19I6v4Mu8kV5iHcLujTwAyqkqnG 9a47G9Kldi0TaXpCuurxUVMIKRSPe+q7ttva/yUTEDMpmKn0oOS9185Yq Yjov4sKURDvYr1L/oEhJjoZuAKaidbnScmHj6VCs6uvGGdGyU6zZxYUUk jLZDVd3ReyW9LY+Kr3NgjYS6iDOEMluFVgb5Ac2Gn6tMiaYIS0sKNeZ4+ 69kRjhugH/+PEw1QBi5Kbg6EDsEi+9NkAzyR7N5zChriDSUBuIkqpxcAm XiHT1Co15AUTfoQ5EBg6csnuCQQ0ciCBRozl8K1lVowgQm2zJGJwz2rOg A==; X-CSE-ConnectionGUID: gx2jHF18QQq5Uc6B8ifeXw== X-CSE-MsgGUID: YwL8TKk6Q3ecQhL1MzJUsg== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="34623467" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="34623467" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2024 00:46:07 -0800 X-CSE-ConnectionGUID: YR28K8/hTaGQ8qVznHCyfA== X-CSE-MsgGUID: bvHD0SbuSoiNwLHxVwh5Eg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="90277353" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Nov 2024 00:46:05 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 8 Nov 2024 00:46:04 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 8 Nov 2024 00:46:04 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 8 Nov 2024 00:46:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M1sNEOE0VYg01v0I+wapUP7YJhhxhs4X65gdrx+1jfr12evgJtBTZhucLnZTD595hiIc3XcBTuq2PnEBLWgLonhnnPR7TeYK8XafaVfpFpzJ9z6IjlucE2EYY+c5+HpquP/Mf30g0ZIOjcxYFFktyESvsjs1DEVIZ7Vf45KsoBfIcNLpfUFrb2p1hJNUPOlb9QQFHTy5pHfwhjAwQOrHDSnxeiKixic5ZHDRtx5Wcyfd7yYVhEXNZKYODsnK5a3oYR5NlkuhAY25uA9nwrlD840+AxcokkACBzhx4Yy1AsZAeNAZB2dKIK1Jj7H4cILZl6u1z6CZhlwdVvdqoNA6ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HYtEpy21GdgQ1N1wQbHzey/cHt8hek63VNx/UKQN/Nw=; b=kZIjou2xvxHigMC4srUTaOhdqbL1ypg0WHULHaVWvt8w/Y4LtBiXKwI3iZpdXZNwXdn0UkFEFVagckjYw+psc0wgKZFNrLeIuIxsx7aEzuqfELfz7bnz4m6XPpQ0ErQu4novS0atzeT7AzPTGCuEvF5Vwo0yGtrJClpsTG/TrowpWXlyFIaAXqj26i3B+xnVYZelLSrNu42TXfKZ2AbRmLG0geAA1pWttJpimmrPfnaxi6+CP0KGhiI/2xI+BuUdaPtsL8OTrYrtrYyVMiCs4lgrrthgKdi3vES++BpqT5EXcJL1egtJauuBnuDrDdafuNxBwsuw4PHoV/GFMEpeQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4568.namprd11.prod.outlook.com (2603:10b6:208:266::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.21; Fri, 8 Nov 2024 08:46:02 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 8 Nov 2024 08:46:02 +0000 Date: Fri, 8 Nov 2024 08:45:57 +0000 From: Bruce Richardson To: Andre Muezerie CC: , Tyler Retzlaff Subject: Re: [PATCH v5 15/20] net/i40e: remove use of VLAs for Windows built code Message-ID: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1731026691-1529-1-git-send-email-andremue@linux.microsoft.com> <1731026691-1529-16-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1731026691-1529-16-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: DB8PR09CA0007.eurprd09.prod.outlook.com (2603:10a6:10:a0::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4568:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ea72967-cf60-48f0-cf97-08dcffd1c634 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?osl3xEuQqOLgESY3dbwkhQU8xAznNYcdAIQ6rErxNnzFlc/i5ldQ5pflJQ2/?= =?us-ascii?Q?0u6pAbmZCFbuIzI6Hk6CQvlaQ0nf0CLJ2rSW9jQivkEuLTqMRHitdYW+9Smi?= =?us-ascii?Q?h9iqlM1FcXMHmLs77DYzhIQ9rcr0XNfV2xIBfEsi9qICnYDb6MJ279DuA9LK?= =?us-ascii?Q?xqeCv4FtGFy7NzMhA5OK3OzkV2UY5+y2U8XtsSaLTW5Ph+P9R5Zi5PzGF6dl?= =?us-ascii?Q?7v5w1lpUG5F4ZwQxABiHxy/htKB38CdWFKqE5UtmUCMxt7d2Y88dksGc24dV?= =?us-ascii?Q?MNmNhNPBRlDF143jckP8QAMADRl2Vw1e4ztfyqXUWr6nyyyHvE7XspM9zs5J?= =?us-ascii?Q?C3SBMgfVeL0ZhQytbJsFDLXBhU0rhBmFSAT4tBhce6hcocsStE4uRMfClYDM?= =?us-ascii?Q?K5SJoMWIjPDZT33FmdJD9jgF7ovZbRCzSYZfeiDAT7smu6aBE1aTGwBSHxkU?= =?us-ascii?Q?3NMRGlBxih+OeOS+b7FpJm3pCuEd2YDFQTgB6HxDS+cWuw2RRNY/J+/cCr4Q?= =?us-ascii?Q?MDKd5kdve82ebKKY41opG5kqptv7fhnH9goMg4FUhRSGXzIWuDtnaUB5sWx+?= =?us-ascii?Q?QoJVeBPpYQrRM8DbKDR5aSxau93Bp+9cd7rqqQShAFJCEuYjowpzyH3DL78d?= =?us-ascii?Q?BbCYYIEfqEGSroEKm/wMXAH843Dp40vzbe7vPs+VZbs5symAibhD03MFEWGF?= =?us-ascii?Q?//9D5Y261hGssS++kawSe8DRvcGxiBjQa3qKVmVF8PQd/RWbLeNITJ/FZqXy?= =?us-ascii?Q?OLeg+UVWLHsJ0KvXRLpAu2M9yOP8Ka/48vtl+vaFuCG6PRU2coG5GphjquzO?= =?us-ascii?Q?Zdv5eKsp1EGdcL2APjis7H/3y4smOlT84/pxRcYfTI3yJkEijrbDfp1TYjy0?= =?us-ascii?Q?6FcVUasQKKaaon+cJpntG6ku6THPCih/vzOoqOuv7BTAfOEEsruyQ6ryaz0k?= =?us-ascii?Q?CbS330H0GMqS+hqyxglMF7lDpVZS7PVhAwnz5ZKXwRc8bhbWs4NxEkh/3pcb?= =?us-ascii?Q?TCZobyqgS9LKhvWuOnI3ZS2IHQAK1RMsnwTgo20tWG/TUqvOrc7vEo00Hzna?= =?us-ascii?Q?dEdizVj7kcM+FnlD6o/wgDilkQoF40A0qYZbLKfpVck6o2LDQwXOmWo6UUm6?= =?us-ascii?Q?f+8NLjS4i+JgeZ9vijMqG0CLuaK25EDOkgNUgSBATsmQM0Mdd373896D0u8f?= =?us-ascii?Q?RYzHm0ex2jQQ6oox4fn0i1HAdTaHafiEuQsh9HtimcRs1J00knbPhE17zbPy?= =?us-ascii?Q?2RnxAQpGrpObWDmHcTsJGL1HeX0uXNVWmhLtfBRZ43SRWaENVu333IAYRwgX?= =?us-ascii?Q?fr9CcF8EndiS9tSX840/o16x?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FrEPsvLRXE8EQE0FFFaakDRrGfIjL2POykaPFIOEpPd1XO9rDMonixy7k9Ju?= =?us-ascii?Q?wp2YRwr0QfG6aaSODCjFiPbGsICdsWLfa6TLJjg/mR3wnoHYBxn608pvcig2?= =?us-ascii?Q?Y3EKYztCS/jg+kcKg8+6eY5As5gOR1mqbf5lNyUQJQY9ZoMOON/WHrsABu23?= =?us-ascii?Q?piXCkw4YCBDzWJtLftuxw0iQDFSaEpwHsonBeHh5w+iOTmxWyP0qUPmW/hqq?= =?us-ascii?Q?N+JcC/T9TSAkn9I/FQcCsv2eJkbcF5rEkn/+xoJwax6+jQJuFCNEonf2PpUo?= =?us-ascii?Q?k9PewXYdY8eE6K3lmzSom9xdvDer7NNzMTBaC0813ExALDlff0xMjbzk76ir?= =?us-ascii?Q?95Cb78rhMccrMtSTefwqoDTThJEdiwfpZip6rc9Tv1IJcvJoM/Z0OCkJMl5e?= =?us-ascii?Q?+yKjDiLqUSkrCURe9gg+mXQA9MXWG5FZ/dSsp0QoT4N9KJ/qxdssU32JNwFv?= =?us-ascii?Q?ftx6fowJMcb3hz4rmazELddG9fHBDMqLvjq1mQJdwVj607UZ1m/LETJwxvZs?= =?us-ascii?Q?Hgy0GWylGFiY2SrvERz2/PtzhOzNsV+nrHskiAtg9nTy9OJWkP37Vh6zhPqD?= =?us-ascii?Q?9IZWfnO706pq6tr5JLnRV5jZfEmsJgmDS7vhoZVk1qstnpqk1FW5pHNjVzHn?= =?us-ascii?Q?Jv3vSQjXXNpIDXk1A8e5fN74Aa+RJ8BPWpXbzhcmHcgFY3vUaBQJw68amSOZ?= =?us-ascii?Q?7umB8wZUDm1ZqQgvHQaKu2GY7QXha7SPj+wvctOkDwpRc45vqeGvJ6ZUSCsH?= =?us-ascii?Q?cQF50Eiq5JI7lAWB0Q5WF6tJl/qaG1nyS0R05O9M9QB4kPCF+jhbXUrBfviX?= =?us-ascii?Q?vQcLPuJmA03LYlH4Tk7nLMP/IzWW941NX1Vnn6XJFZazGHQhfOOv7HZ4EtHK?= =?us-ascii?Q?V9p+AzBodCgDAXMYxD2/XLLtY/6CFRbV2pT71pkugUbkZzRRGBJnvLsF/vtI?= =?us-ascii?Q?XITjQbWbuxEjjIV/HKE8lvxUI35PANhiJWHsTWMteD3ZTGer4Daih5RGVjhv?= =?us-ascii?Q?FdQgcWhY5KSqaotRasCdWYSsFeBdds+diQ/9pJutISImLaiZBq++bJEoeYsS?= =?us-ascii?Q?cPlq0sRvfD9VUJpl7emfd5gB6x0Ef6HniCpJvSx3g8tqjGBrCSdLhikzlLnp?= =?us-ascii?Q?U1x0DnF9tf/0NkSJsKMnMUaaDGvwgaXmTsjanWX+RTaG+34PfMmb8L67MbNB?= =?us-ascii?Q?dTnrd7PTQy6aPwPm655vrCdMiivwc5sXwCLHGr/t+iNmJMU67RwYEOiphf7q?= =?us-ascii?Q?Uw6oJhgMU3dZe9kndm0WA4A7DlODHyFhs9JkKgVpNPKg43ID1wLpit83n9Ch?= =?us-ascii?Q?dCQHSkolhOIaT3tmB86hKYNtf2gqbkUnSQQjMzyJETNacTRSKcQq0+IGyM0I?= =?us-ascii?Q?m3U/owX8OzY55NzwNhGEpISmvbl5DJUij8I9Awe7hZiacxSTlZG+q+7M1Am5?= =?us-ascii?Q?uJFlyLqdwo6FnbKUv6wG1ztJI1j4qRrEFEhPuIGJ38uBQM4liJGVzAth5eHI?= =?us-ascii?Q?nFQvd1Wh9XSCdDdIndDoGIIRvSQu6r5c2DE4QqfuI5BNbX7SNd714lH8VAGS?= =?us-ascii?Q?fp1jAH+xnzmHW9xe+1o35M98Ot5ddW0q5Z3z3G2XFaX4GjoJN1TZsKgqxVEx?= =?us-ascii?Q?AA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4ea72967-cf60-48f0-cf97-08dcffd1c634 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2024 08:46:02.0527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mVXbQMfgHG/QhCeR3DSPUyODL3nDiESHODpfFWDJyOcT2iclJrgINSbMvGc4e71evutIRN5eIkhH8ARlGk4y3hu/KAPnyGgLFYG12DiN7Ig= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4568 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 07, 2024 at 04:44:46PM -0800, Andre Muezerie wrote: > From: Tyler Retzlaff > > MSVC does not support VLAs, replace VLAs with standard C arrays > or alloca(). alloca() is available for all toolchain/platform > combinations officially supported by DPDK. > > Signed-off-by: Tyler Retzlaff Reviewed-by: Bruce Richardson > --- > drivers/net/i40e/i40e_testpmd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/i40e/i40e_testpmd.c b/drivers/net/i40e/i40e_testpmd.c > index b6ef5d6e42..21f596297b 100644 > --- a/drivers/net/i40e/i40e_testpmd.c > +++ b/drivers/net/i40e/i40e_testpmd.c > @@ -2168,8 +2168,7 @@ cmd_ptype_mapping_get_parsed(void *parsed_result, > { > struct cmd_ptype_mapping_get_result *res = parsed_result; > int ret = -ENOTSUP; > - int max_ptype_num = 256; > - struct rte_pmd_i40e_ptype_mapping mapping[max_ptype_num]; > + struct rte_pmd_i40e_ptype_mapping mapping[256]; > uint16_t count; > int i; > > @@ -2178,7 +2177,7 @@ cmd_ptype_mapping_get_parsed(void *parsed_result, > > ret = rte_pmd_i40e_ptype_mapping_get(res->port_id, > mapping, > - max_ptype_num, > + RTE_DIM(mapping), > &count, > res->valid_only); > switch (ret) { > -- > 2.34.1 >