From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3650445CB1; Fri, 8 Nov 2024 09:47:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 556A8402D8; Fri, 8 Nov 2024 09:47:21 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id 71CD9402C8 for ; Fri, 8 Nov 2024 09:47:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731055639; x=1762591639; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=FQ+zSsljBCHxE87t+DuO28bnm2cWq0SbowsH9xP5K8w=; b=GFlZANp1o+2qXUmHIFTSkQn+enWiyhskLQ2AHklGKo730cPifriSqp4c 7p/6YR2Egi9M/ebmkkJreJ0J+bh5i/a47jrXfuMY6vjBzjwfd8IEEP3bc KQ5ptx+fSmBW/xwlBsW9ElHdRy/BPaIpwauS+LsWGUC66KGOwQNvmUIML XKC6ZemWYMXAQ1TYTmI0xfm2ZVec+8M+0SplzXOpldBjpqGFB/cd3+/Ar xAjQ2wLtPlBKH3mk3pTLOyo4M5N4cQrzh8bVYC7JGNhG2taTWjj85mdzH 8R2fsXE+dRcREvaYzDw68bI/2b9OHhhKdeGa6oOKZnGBNz+0Leli7fxOS w==; X-CSE-ConnectionGUID: JNo0jUv1TMWFiZa4XJGi3g== X-CSE-MsgGUID: iNVgP7sMR5WS8zNuqWm5pQ== X-IronPort-AV: E=McAfee;i="6700,10204,11249"; a="18557841" X-IronPort-AV: E=Sophos;i="6.12,137,1728975600"; d="scan'208";a="18557841" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2024 00:47:18 -0800 X-CSE-ConnectionGUID: llmNBxHmRrKLTXMN2X2gyA== X-CSE-MsgGUID: hLhcj5dcTPaqF9p5BKnXvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,137,1728975600"; d="scan'208";a="89994033" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Nov 2024 00:47:18 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 8 Nov 2024 00:47:17 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 8 Nov 2024 00:47:17 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 8 Nov 2024 00:47:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j85WtTUvTv0z7W/fuMN50/Z2xNSU10TMmn9qDidkCtXV71AoQLx6mxCoRI/tsdsTcZ/n/fcNLQNfwb6GV2CDnuGoBVveB8geJB0zFWrBYeALkGXOMYeXBbbphY+xs7lKIWhJTaoXvOs5t+hWhMz195iouyTugSmM5u14vPGvda2AZsYc42wFcGBnN601QH0PAxPqdz5BP0dGmnDaTl8bzQTN/Wdc7cDJ3SGa56M/wGoRu/jg8MMvcWtvokR7pTnpsOpvSie8JVzYbKV0bmk0GOur6kb5a0ObU88ArV1masQ21vrToLzFNgLFIvzyncoMpA3F71X5fCpOB3cF/TN8SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=APh810h+C5kpM2lbKYHZyAcAUyjP0TGKmsgZIYxylSA=; b=j56urC6lwZEQccLlu03fflAO8SqSNFkmTDFsijKvkYYU26blLG+scO3hMiuRnd2XkdKVFn5YBxiX9+AFNlVRkeXBW3qti+1HLBhtJT1enSKKIXTESCAAMVIKt9tGvngcTD3VzpE5obb49XiwJeaXmjCrZ8cQ6ycsQcsv9JAuajjeEZnKLK1WeEMLWjioEVSFkkzEekX7OZ0rZWviJw/isS2pIf1wUsyxjNQHu08oAITeY15hndiphJPWOZAB6xlBZwivjY4HDocGh+9/wN5n3F62RJRYD4+mCa7bDLeS+F0Cv14clOzNf0+vhz9uO8y1NaWl10pMhbm1SmKjUPpLdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4568.namprd11.prod.outlook.com (2603:10b6:208:266::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.21; Fri, 8 Nov 2024 08:47:10 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 8 Nov 2024 08:47:10 +0000 Date: Fri, 8 Nov 2024 08:47:06 +0000 From: Bruce Richardson To: Andre Muezerie CC: , Tyler Retzlaff Subject: Re: [PATCH v5 14/20] common/idpf: remove use of VLAs for Windows built code Message-ID: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1731026691-1529-1-git-send-email-andremue@linux.microsoft.com> <1731026691-1529-15-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1731026691-1529-15-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: DU6P191CA0022.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4568:EE_ X-MS-Office365-Filtering-Correlation-Id: d0d5c04a-94cb-47e6-436c-08dcffd1ef41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?cM11jH5ToYBfsrH0TL062P0myVRXBMyN1V4xWxjwJvKWOCTkwdRD8oAp/Sju?= =?us-ascii?Q?twz1BL02Z62/4YtTxHYNW8r2nUXUQfiPr0HBHnJPrQrsQKE3HK7D/yfs9AJ7?= =?us-ascii?Q?7nd7O1kAOKS23Og2IX6+pIH/f9PLtPM1riBro3YC2mz6gtDZwWkakioqGJFJ?= =?us-ascii?Q?5ijj8QboId4boQxvxM2/cpfSCPCpMHPBlnDH7rqwQhkskAaThCUFoi5Rdhpq?= =?us-ascii?Q?E2Jbnax/h59eccTVANXF1anYxMgOo3DzgvrngvUgKTUJXI27MH05BL5+VHz1?= =?us-ascii?Q?rCXR2K2yKtYjZTVbpJ3joDNXaW3/1ez1JlL8iFM+c6nR4mlI/jUI0fmZeFTr?= =?us-ascii?Q?NY/i5BhPu3WyXlEwSEfxL9Gy0G8+4fBdcUcZJZIu2MwI4YZTmBeM7JdDRsSm?= =?us-ascii?Q?ek1llNSNWjp6Yq7bp3MfQgI/YI8p77QCBio0bLdpKiam9KOaWMLqAEtXYZWO?= =?us-ascii?Q?NHzPPEytOdaLSjTsV0sSSB4w3ftoTMg+1PyTuyB2S1wV/2kU0xAG8ZfqDhBf?= =?us-ascii?Q?PVtswETYPM0yjs1ncaTEke2f4ZpedPPE+YxADjO0zaFWWglwpWjOI6354Mm5?= =?us-ascii?Q?kQ+32RfndZffDH5/lmrjrDaYEYub0XCOVTMDIjmQwddPiAtuSFRJKgYDuk8j?= =?us-ascii?Q?ZMaYsW+KP93VH4bve/VumI+2INc6uVZhYZA6pgyrYGwnVuDUAEesLzINu9Pg?= =?us-ascii?Q?o4PnhgTvWj2ADFikc5r12IKXk8l4AKjw7zQwbxNhSg4HM9+bTvKJvPMIkydA?= =?us-ascii?Q?RLQjYlabj0F/m8IRjjDxc/Vq64wkbVRMUf8IBVgmvbLVMxPCEQNL9vRJljFO?= =?us-ascii?Q?bYqt4S6ZtPbXbXbIOiitKYv/KaaM5R/5G1AIFTIa9sQwJHe7/xY1p0ChGXJc?= =?us-ascii?Q?EUEIU5kGzePlQ2Ou7rXpFOqD6+Qz72E8+hhVD4+WraTkOAQlF85XthCofEYm?= =?us-ascii?Q?aV5OGdhwR6byfSkh9Idj+HwMD1pAxEnryOs2oCLvwo25gLFLBIlzR/czQ6ji?= =?us-ascii?Q?qmt6pVdp3waATQaYXUoxD7Uf2X0tw4SY0WHTebOSW3RzyTTV2+lT9gNik/qM?= =?us-ascii?Q?86vAHOAvoI6T4eG3Iv+pPQ9HHjLiYEta4zT2bcxr0sNpAwskyMre4ACbMs1x?= =?us-ascii?Q?1o8a983L+iErVZft0BA1knIIKawzgayUCcjB3u61gr5KBiNNxOz2SoaNpIrj?= =?us-ascii?Q?Z8reFphyT0m8NgcPJ9wS1v4Gei9X/pAKqwGLBbZ9vYmksB4PzxmUc2ttdtBQ?= =?us-ascii?Q?hWp51lfXAXUuyQ9Sngxzt3mOLnzXmxHloVeCY+OdrOFYOprw3FcryVIs4AH0?= =?us-ascii?Q?RAtvmljsAaLPnlsLSssY41UH?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ntfNuNVfU8lud2POfH8xPZ75XTw7pMR8164GdMkk1mbnd29CZaHbhjj4Vu6A?= =?us-ascii?Q?JdDBqVMKMSsKws4WQi7KQauZoHtT0jcDBedjYlBq4J2MWvjtuf+yQgZwsm2H?= =?us-ascii?Q?lxfWbwi0WPhd3WQW6b7P6qMwhm4G4B2UGfqvk6n3dJCidkXAeGvYg5zAWqvS?= =?us-ascii?Q?8ukBdqRXuBA8GPT/zztd+qJKB2JJfC483tHeBr8sDCiSfVFS+5/LNmBdKs3C?= =?us-ascii?Q?CvNIEoDwlTd6NX3ZUqSc6gO7zYxKVkwTf8xI1MiI8peC8TrvxhKreNNTqxE4?= =?us-ascii?Q?QLc1gCtnDte9oFN2tT+U0QUL3hov6D3mtH7YDQQaW5t66GHSayQHwBWpcMtJ?= =?us-ascii?Q?HxqQuUMHtUm+EDm92ruyc4xSJLNrMKOUaOCOsvsRApOiADdlJM8PxglWhcue?= =?us-ascii?Q?34E80zOfR/NwjsuDhfPae71Tb2KCVhBXQ0wX1PHVwyqtYQfhCmXBDROz4tVc?= =?us-ascii?Q?9ANZ0/5o8B+hrvuuzCxmGloND0NVatG5i8BdluIllcGQh6vZET5kSBmA/GBE?= =?us-ascii?Q?Zd+1KiiyczeXbqbCzffj1PpPgV1xxBEKN5UBhCLS0IZtFtORv2J8z3pSBA8j?= =?us-ascii?Q?4MhbnD6GOU4caVR7jtLhmu4VyGyky+YoEfsv2RiAM/zKjOvmO1Ujx7N8ySw+?= =?us-ascii?Q?MCf8gvXvUwnrlQJ45c7qTEtnttIt21ESyY34fQ4HwDtvGgXLshetmow8e+R5?= =?us-ascii?Q?hDiIwOBj9Ki1ZDREiCmu5LoTQbcUDlI1iJCgfVaP4DVwtDs5wGYde1emjnXE?= =?us-ascii?Q?vNVb1SmuKSgVBoWcsxEzi460klDFgCmfmBPhcl+beQDO/mmtyFLhJ7Hbwwe6?= =?us-ascii?Q?eaSPgI1swWtcMAR9w3XJ5gauCK6uldsCKGjUC/G7BLzgglia0tpBG7KNV3d/?= =?us-ascii?Q?ldlIvC8g/GBIPI9AaflZ/jDjmUPv9ulFjylX/IGmahZGMlhEqyOC+xt/Pf4j?= =?us-ascii?Q?DfTQ9ftwivhYkFGyThH3059yEdmgVq0sCZ9wHR2ywi9zSPgozCyGMYyByAXQ?= =?us-ascii?Q?EsGpBcEVwWibOSWX2jZtN4iM0bHfNfHu1OZBllU8fGaikd9ciBgyTEGCJxeG?= =?us-ascii?Q?FLbU5sPqOYOZSdHzhriHKQevTQxQ4h0RzZtWGZIdqABgwXTBigq4nf5cuTHv?= =?us-ascii?Q?DT6KqIMdd6y3ugWlP1OPbtHRmmMULjPLnrKtWhJOqXJchQv9IX9Y97hMokc/?= =?us-ascii?Q?fqz3PinnIPj/eiFYw1YfNCsfvhxIwtg9VYMVfb0b5FaxvVIeaOsjIpjWQgmj?= =?us-ascii?Q?xJLbFrnSW/9gdMwvD/7QNWkuQ1TLF8ewFVPRnhYr8EgyxHKOBg4yKtNIXowL?= =?us-ascii?Q?i3BINz5DlD0PQZKSaBF8791NWuuILno7EiujMz4unXtN9AxLUqlohLFelYEZ?= =?us-ascii?Q?MeM5sQ34Gu7OIQcxdFl+ZXn0CA9s/6zbd39+TxiKiA8VuDtjVnX24WWk935K?= =?us-ascii?Q?Rpm/lc7fR2wicqcczn5AL4TvD4FCpzGbGLtMJgX1xPafHgn/Q4xTjA4VqunY?= =?us-ascii?Q?UCrB3krHnBQyzFD2RGb6KdvdStEyb7zrfBNyoKiwDRjyLfzbr+KjF1e/jznk?= =?us-ascii?Q?sOkejN9UbGHhyp3Z7bpOgFndsX9VAxeMQ4ubM8w4O9ROCKE3JxuXX9Dfeb4c?= =?us-ascii?Q?PA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0d5c04a-94cb-47e6-436c-08dcffd1ef41 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2024 08:47:10.8063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zFio/sYUlemakEwVhmkztfLJaqp1EnpxxemNgDLZxgVPsYTrjFWuopqDqQwbdaplc8Bcw3wJ4Lmdpb/UmGbUfDzkH7VuIZhCtUMMC8FdDOs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4568 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 07, 2024 at 04:44:45PM -0800, Andre Muezerie wrote: > From: Tyler Retzlaff > > MSVC does not support VLAs, replace VLAs with standard C arrays > or alloca(). alloca() is available for all toolchain/platform > combinations officially supported by DPDK. > > Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson