Re: [PATCH v1] net/macb: add new driver

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Oct 30, 2024 at 09:53:29AM +0000, liwencheng wrote:
> add Phytium NIC MACB ethdev PMD driver.
> 
> Signed-off-by: liwencheng <liwencheng@phytium.com.cn>
> ---
>  drivers/net/macb/base/generic_phy.c   |  276 +++++
>  drivers/net/macb/base/generic_phy.h   |  198 ++++
>  drivers/net/macb/base/macb_common.c   |  667 +++++++++++
>  drivers/net/macb/base/macb_common.h   |  253 +++++
>  drivers/net/macb/base/macb_errno.h    |   54 +
>  drivers/net/macb/base/macb_hw.h       | 1138 +++++++++++++++++++
>  drivers/net/macb/base/macb_type.h     |   23 +
>  drivers/net/macb/base/macb_uio.c      |  354 ++++++
>  drivers/net/macb/base/macb_uio.h      |   50 +
>  drivers/net/macb/base/meson.build     |   26 +
>  drivers/net/macb/macb_ethdev.c        | 1972 +++++++++++++++++++++++++++++++++
>  drivers/net/macb/macb_ethdev.h        |   92 ++
>  drivers/net/macb/macb_log.h           |   19 +
>  drivers/net/macb/macb_rxtx.c          | 1386 +++++++++++++++++++++++
>  drivers/net/macb/macb_rxtx.h          |  325 ++++++
>  drivers/net/macb/macb_rxtx_vec_neon.c |  677 +++++++++++
>  drivers/net/macb/meson.build          |   18 +
>  drivers/net/meson.build               |    1 +
>  usertools/dpdk-devbind.py             |   95 +-
>  19 files changed, 7622 insertions(+), 2 deletions(-)

Hi,

thanks for the contribution. However, in order to aid reviewing and merging
of new drivers, the policy in DPDK is that the driver be split into logically
distinct patches, rather than a single massive patch. For contributing
guidelines see [1], and especially see the section on new drivers [2], and
the subsection within that on patch splitting [3].

Thanks,
/Bruce

[1] https://doc.dpdk.org/guides/contributing/index.html
[2] https://doc.dpdk.org/guides/contributing/new_driver.html
[3] https://doc.dpdk.org/guides/contributing/new_driver.html#splitting-into-patches