From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FA0D45C13; Wed, 30 Oct 2024 11:14:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3792443380; Wed, 30 Oct 2024 11:14:28 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 8D29E40263 for ; Wed, 30 Oct 2024 11:14:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730283266; x=1761819266; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=J5LgmSV0jIIaukhIfZcFmZJz5AeKNS4tJw2KuUCNyTE=; b=W5weQshk0cP99iH4ZW/kskACjwYrrfho/8/mjzOIV/5WG08yHBUPt25o sfJI5Ho6fSkRTRBCFMqfQyEkFaCbvPErbXMqN/yOxqjcMtaqD5WikoFE6 w7ZBSm2S8MI9WIvrOv4go/eKQQRbBK+9TXumGUCAo2xHhglMXx2Dgvxn5 fXcJEXhG77RAXOuOpfg+Tv/zvgcYMq9Grte6GLQ3TfysEjeNXaaqQQEVh lKShOKldGhAB6VkPvk7Oq5F9574/JUP5XVNBU6r3yEEElGddPKIxLP8Z1 A35OfE0KiFJ5na3m9r1jxJNnh/4EU8PvEmcKlQO2wlYjtJbn/EJVL6Mmc Q==; X-CSE-ConnectionGUID: r5RaQ1C4QfieiP9hRosL5A== X-CSE-MsgGUID: 03CnhUG7Qbue9HgFKIZ5cQ== X-IronPort-AV: E=McAfee;i="6700,10204,11240"; a="41340939" X-IronPort-AV: E=Sophos;i="6.11,244,1725346800"; d="scan'208";a="41340939" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2024 03:14:25 -0700 X-CSE-ConnectionGUID: 5NqGDrGAQY+NIfG9L0WZLA== X-CSE-MsgGUID: U34RYP+8TnauaUNtD/UNWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="87044659" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Oct 2024 03:14:26 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 30 Oct 2024 03:14:25 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 30 Oct 2024 03:14:25 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 30 Oct 2024 03:14:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KSrqPVVIg7Kt7xw+v3+7AVFAJMujlk30fbY4Ixiq5VXF+h0FkqcKPk1Y6FwItVthlYybLjq0TJPvfBjU5GBKE4F4nx351O7nGxjd9GL3S6rT8qURUynrlbnjrVKMxw31UShP6QUCZCnsb7OCJrUWp7l+tGHK6S+jofUVo9BpoKmTJOTx+/1ORxD+tQFbVVT92hTlxyzMoP2TL037Yv6F+EZD8pXIj1oYmg7J3uhWwIFLUuNvPAIpS2MRlgeAqjnJ4fYeiOhaqh6iNL6gUgxvopCq3DhPe7p282rBXQaBs4GmmDUmMlbWLp36dFwo+gu7nnrn3ap4kunmYgGxrAoqpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BGzHkJ0gkRLKjTbaOpeizCpC47eqQ/jzqYnsu6nqiHY=; b=uIA1Ht0e4olCednCLemiIvRYvJI9L+YvuCqVcOL86uCTIbxrQoNsqwOzCHFfTpMmlNqfdUCpyHyqQ4NQvv1Y1Y8Cmt2sj3XrAgRPhYlAQMhpp1/OF6JXYv13TBPU+6kjcojV1etuHhzkK1e2XeE6F3LZ7f96AyhthwJCy6JiI2UlYRQtuRbbBLscQQWUjoqWT1RDxMPb5xNwftiAzRkj8QjcQRNJ5LEFTNcDzaAfFSbzV+Sfxfu85D0whRPpyOLSz+6oyaimm0aEEtW9j/WQE/jagMVrMWk04SIrdJ29uCFoxEKAJDzr/jf66soFhvzHO23WJZXw/P4g5EJkIu7m1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7559.namprd11.prod.outlook.com (2603:10b6:8:146::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.32; Wed, 30 Oct 2024 10:14:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Wed, 30 Oct 2024 10:14:19 +0000 Date: Wed, 30 Oct 2024 10:14:13 +0000 From: Bruce Richardson To: liwencheng CC: Subject: Re: [PATCH v1] net/macb: add new driver Message-ID: References: <1730282009-562817-1-git-send-email-liwencheng@phytium.com.cn> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1730282009-562817-1-git-send-email-liwencheng@phytium.com.cn> X-ClientProxiedBy: WA1P291CA0015.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:19::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7559:EE_ X-MS-Office365-Filtering-Correlation-Id: f75e2ce2-8c6f-4b89-d47f-08dcf8cb9da7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?eo/STsCm5D6Zf+yWhMFD8SBGemzn4fOLcZQtrVMiL30lI1B4ZJ91HhzspN9W?= =?us-ascii?Q?JIRljBgj3W2La5x4NSkvxn+n0JiO7JObpMhR4lB+Trqg0knHMFsLLbHs3oom?= =?us-ascii?Q?UuxVt/+F5N7lianog9ALhOkASdMgp9EXajpEyVmRnGCrXrPuhPTxEdj+1IEg?= =?us-ascii?Q?lGyrFOVuNXZUFgA6+LtZ8vr1hGF+SGPNWod02mopy6DePH1BtGTRfjwRyJf8?= =?us-ascii?Q?VqiVWtlzqqBJ5X/4jb1ChU200z6h1UTDL5LyDT/Xdsga3Z4cxrAosFoLfW51?= =?us-ascii?Q?dWV4ZQfpzNDwbzgvg3rC7OBOTc6Z/Yz2dQNXOelohtmsS+5Opnyx9OUaKFSt?= =?us-ascii?Q?3QxCoC7qWgyJxtrreUi9KjBhLN0rBoJnNh6mLF+o7eZeyXJO6PUknwNdfI3G?= =?us-ascii?Q?6ZzeZaaD+Ww/VhvL4J/aoeEpsVWWMimnKAqX1V9tvqV3JfIm5IASBtQ15Rvd?= =?us-ascii?Q?8E8lLzK0/24XXGQHcM/j9Ya5d9YRrwe27ynkjQ8WbbzsFhkyIWD7FrxZ9Xz1?= =?us-ascii?Q?M7fNPx1i4tNycr0q0RswmB3FDnxpqUI9b/nQ7+ngREGhEtYifDeElLaIa7vK?= =?us-ascii?Q?LBwLHvK9aHMdkYsuQvI4xaPu4Be6p03F3jULmFhxstlnlGgTEM959ecfBhV6?= =?us-ascii?Q?/cydnHs42wai6TxK/DYSgcJciD3QBZcVQrkHBW0vUEwcA+aTmFKrhziyQ7cV?= =?us-ascii?Q?w66eWQgQDxxR/fVwO0/xdx8k7X9UA+I78XfC4lnCyzLHaWGDptzb+EHiJTcd?= =?us-ascii?Q?2rOtuAUwoE4DTI/GzgOz/caY9zF4DAb6h701QE/kgZTI836mcRSpjA/dEIs+?= =?us-ascii?Q?kLHlMeFAc0BOiyEGa+3MNQMisC+BMS8S4IEHRFg0qxiNKkgiDXfg0+AlkPzx?= =?us-ascii?Q?GjegRmmBf5xlwYIDN9xQXEaHfVcY0MmuydlLQEFUGTuB617NlzccUvvF42xF?= =?us-ascii?Q?teg15W5mENwNfHLwGjkl32jLLhZPRaFT5jZSI+n050xq7qQEBNcuy+z+hGHE?= =?us-ascii?Q?AAXapbNldEn/mRUBQexvc7DLAxpyO+D0xX7+Q5ITicLhjJzV+EbydRO4inOE?= =?us-ascii?Q?e+e6MMqaHkK1/Egg1KnsHB7k6q7cAlbQmqJ/skJOL+P9iRdR68oCXyFaUz+b?= =?us-ascii?Q?plUkqWSrQJMGaDP/DGEjH8RvXhAkjuLUGFAqRMNCFuXJolLW8bgFVAguLUdJ?= =?us-ascii?Q?ddfTVJFN1yOERRiZ8X76iPVXVW4Yew5Hxmn7nEV8yI21BX2yX9ICBGifXqki?= =?us-ascii?Q?LT2Z/4JIhYz9znEVSfeh3h+pOYCKMySJvEKj3Rs9iA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UPltBPDtgY0LQG1alnu3HhdAm6MnQFRIAbJkO0p784ahQb9s1GSS/de1x2nu?= =?us-ascii?Q?Ed+6Q4GPAq5i9O2r/pR0JTDZS2A2Inz3pn3DbrNacpmZcE/XP1r7H37A1L3w?= =?us-ascii?Q?JljeqYyDNSZJRYisJbGV0wc3x7bP9jqltfukne4li63uLU1z0QJLsz5gY1cH?= =?us-ascii?Q?Eh6bWTdJL58LVOR4CgVPaKf2qjFxN6pcsw7zCu/DH+7Ovo4aJuSYSqX/KLSx?= =?us-ascii?Q?D8B4zM5bwIiEDQWkIZS7TDZ0Jnr8LRSnfvKatuOZxN6vtB4G+O3Sg4X+3eWA?= =?us-ascii?Q?9aY1h+Qj1ulpBmKLk8hd95EJwT2zmFYn9IiTiZHS4ZATrzVoH2lHtXMhHAki?= =?us-ascii?Q?j+ZZXflXnxyI58XV6BT56Gue4w3wNWBjjeKMXodkk53CjCN7J6vc9iEMtbMA?= =?us-ascii?Q?L65sFoCq99Re8oq6enBp+NYaCYF1CAMI3qayqlZWvix0zP5vWp+L9I+TjeV4?= =?us-ascii?Q?Vfo1r9N5idaPGuI7o0drQlmt8HZrv87TkKnKzK7a96MHyp0mvs3o5+/HCpX0?= =?us-ascii?Q?cK8PdzRyhQq31fZmwhZxjlY5gNreQkMvBmw0ahcy9t68Pt1AmGa5Q3rfnLe4?= =?us-ascii?Q?21VV0mwqAik3hmvjUxqiF7qePFstA7g3ksLtddKUaAhOqpaspeKzqoECjYpD?= =?us-ascii?Q?ldQfUxkMfs6ZW34Mugf3cJszWa7Ew029hiMhsvP5GgDDTpHb20WfBeLtCqos?= =?us-ascii?Q?n4NUOoiLJPESHT5a9gv87ae8DBFn2XSwZX+L1swwXDuD5BlMYw7+fkmlm65R?= =?us-ascii?Q?uIFhO0o/mAtq6pyIJHID0mkaxMbs0MM8ctTg6CDn92yDfe2+hLHipiYxJSEL?= =?us-ascii?Q?us5XG+2ucNbeNmG0HXAyY45M9K7gQfk2L1cJ3Wgp3P/ro4tWvt2HFCdwtRIp?= =?us-ascii?Q?z+nlCpM9UJG2Ve88wF+0XQtFdbEW9GkYfo1K/dR2gTV/nh5aZStLU9dia8zE?= =?us-ascii?Q?7/GB1pFZ35UKmUHRJsSOKl6TKmUafgcMDgPKSTLC+UsCXpK+NlV4NNvOkkit?= =?us-ascii?Q?Ortj77QK2qsS/IiPXGf2b5H+eFNA5OpfyPuDW6dlVpX7GQpYAhkQdjQpRBZb?= =?us-ascii?Q?rgC8aA9Fwavdbjur+xzj2DdV70cRrn4CStNPWAdUreKuljYPvhPI1I0t2MDr?= =?us-ascii?Q?Ycveli7HhkX6cx8TCjXo0iRh57b+tk2+me3KPNAsrmRhpXbuTG2761hMudCk?= =?us-ascii?Q?ROYCOJ5Kl9w59zYWhIR9eKX9flPAxCREK1E4BiAvrXef9FViAlAWkvZdSD2U?= =?us-ascii?Q?PcXlXX+RUG/hQ3AuK2H/1zdRr3SxIlS0m1XKTT4I280VA49sZI+ZuYJy7vtL?= =?us-ascii?Q?W1VadMSx6XpiNXYaBlo+xu/nsNU+3J7cDAkta8ef6/d3rH9iFyplM05Z+Z4X?= =?us-ascii?Q?0Ix1sy9PWlsDK4sP/WEvv4RWp+g8jaPV1cbwh9eWYjzHwKm5MPcyBlzVa+kW?= =?us-ascii?Q?LqbNfwp20CNyIF0AauVRLY7NJ+yMIoYO2W21N3IIho4PleC/hE1iazeOGbBr?= =?us-ascii?Q?NiUPxFIECXJcNy2YARi1hudaWJEqdW8Z07ozLa1tuZ2uwy42sjolOIiMXEj/?= =?us-ascii?Q?LcAYw3TMTlV/U6dK8nJ1wltWH+TRXiE/F45GalkBqeHNZhmwca352vq0U+Vo?= =?us-ascii?Q?CA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f75e2ce2-8c6f-4b89-d47f-08dcf8cb9da7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2024 10:14:18.9461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BWjnBx34JOzRLHLNze7Pb0uv672NVKDQux2K+Ztfs2PSandy75ssOIVElqF1L1ucAaUc7ur35Cc/thwSXpe3WJUrvtnoNSI/L+hxuXB86gE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7559 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 30, 2024 at 09:53:29AM +0000, liwencheng wrote: > add Phytium NIC MACB ethdev PMD driver. > > Signed-off-by: liwencheng > --- > drivers/net/macb/base/generic_phy.c | 276 +++++ > drivers/net/macb/base/generic_phy.h | 198 ++++ > drivers/net/macb/base/macb_common.c | 667 +++++++++++ > drivers/net/macb/base/macb_common.h | 253 +++++ > drivers/net/macb/base/macb_errno.h | 54 + > drivers/net/macb/base/macb_hw.h | 1138 +++++++++++++++++++ > drivers/net/macb/base/macb_type.h | 23 + > drivers/net/macb/base/macb_uio.c | 354 ++++++ > drivers/net/macb/base/macb_uio.h | 50 + > drivers/net/macb/base/meson.build | 26 + > drivers/net/macb/macb_ethdev.c | 1972 +++++++++++++++++++++++++++++++++ > drivers/net/macb/macb_ethdev.h | 92 ++ > drivers/net/macb/macb_log.h | 19 + > drivers/net/macb/macb_rxtx.c | 1386 +++++++++++++++++++++++ > drivers/net/macb/macb_rxtx.h | 325 ++++++ > drivers/net/macb/macb_rxtx_vec_neon.c | 677 +++++++++++ > drivers/net/macb/meson.build | 18 + > drivers/net/meson.build | 1 + > usertools/dpdk-devbind.py | 95 +- > 19 files changed, 7622 insertions(+), 2 deletions(-) Hi, thanks for the contribution. However, in order to aid reviewing and merging of new drivers, the policy in DPDK is that the driver be split into logically distinct patches, rather than a single massive patch. For contributing guidelines see [1], and especially see the section on new drivers [2], and the subsection within that on patch splitting [3]. Thanks, /Bruce [1] https://doc.dpdk.org/guides/contributing/index.html [2] https://doc.dpdk.org/guides/contributing/new_driver.html [3] https://doc.dpdk.org/guides/contributing/new_driver.html#splitting-into-patches