From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2E9645C14; Wed, 30 Oct 2024 13:28:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A318A4331C; Wed, 30 Oct 2024 13:28:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id EAD6B402EE for ; Wed, 30 Oct 2024 13:28:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730291309; x=1761827309; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=h5lcfCY/r7iHTKKDQ/LGoB798ITveBXmFNV60XqSaWA=; b=OVG3ZbE8nbCRKVxq/2c4vLfkabGpzHUoD0t73lDuBgIOhRQoWicsHwCu 530apPWwi5CIQ9KEOuDXJQBIR/jf7LuowIAQ0QuRWdpQRiQfPu9VNSS7Z OxGQ52G970AyBtG6oIi9wPUyGlhA9wjeFSh4uQCyX5/j8rP/MVpmaiuhJ epOaSnG6D2Y1khLeOHBPJ6/4HF5uJ4v3vuZQAnGFMTtJe4sdUnpJeCJde gjV1XyaMyZug0O5PjVYyGS6SsHSCuYnuWJzh6QTYFRJ4QCZIQzy81oHD4 O6DfM3DzSukgcNs39RFuXLahX6p50MCy6YNlKuYkB4xbb9DPc6Z3eB8dl Q==; X-CSE-ConnectionGUID: vG4xxdTGTbaD2TiUnWQAHQ== X-CSE-MsgGUID: 5v461Y/ZS/iGcSBMZVFITA== X-IronPort-AV: E=McAfee;i="6700,10204,11241"; a="55393008" X-IronPort-AV: E=Sophos;i="6.11,245,1725346800"; d="scan'208";a="55393008" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2024 05:28:28 -0700 X-CSE-ConnectionGUID: QHNPpcdzSg6axMyuZDokTw== X-CSE-MsgGUID: G16HUXNQSNWK0WgCa1nDNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,245,1725346800"; d="scan'208";a="82473595" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Oct 2024 05:28:28 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 30 Oct 2024 05:28:26 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 30 Oct 2024 05:28:26 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 30 Oct 2024 05:28:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FSagb1LIImynp47RvxLL1a4lEcVYxK5sGdi8d5uaw4YA96wj1qfKOYRjJNK5d3qA1gpRAQ52FD4XTgHOrxEAdA9CXZ9MmWYv2GfRLeqJdZxv8ST07vjlXKnw/7SAi7cGI7gBOLF6kYUH81OXfpLJexEhanj8ZbNBJK4l8shf7qZYPR9CzW/7N11EzTwXBruvQG26ZR5x6TK6CskSTmEJsH+1bJHiHrgy3nddxWaMMIPgNhxr++heekwIZSSbJsDu0TpEG2Z/It3eY7buG/7swE/ddGW8enS+goS5hEN3PhEmPec5g61d4mfjDOEUuzvgCCWunh4La08vtoeG15vA3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IbJhEmgiQZ26Dpo1S6cJSvj529LJ5wHhQp6XVH9Y7Ow=; b=hEoWS47SClNzO46l9w0e/kv/s3sVlvPgFEwASrcu1tbaOMLo1RAoiULPrnE9FPQJwO1jpjB3zFhuEO5YFCT2O21WWzeOjx4k2j0hPVuva9W9mRb2BhXm2dlQdtFLJGM1dW8EXsgt3XBA/fMEOvt6/Zi8R4rzpfq1S5nEvUVzTMnKx2xzlnDEDPF9TjSJMap897LQiETiTWdVVXeypr89eBn9/y0JOWO1YtKhRmoXPnlU3/08aoZW/VFezO7QTwXbe+FLrL3hYbyn14WY+KLTnE8ofb9BgnIW02abZsVth0kLh1+IFF1xM0xacEsDbs5c6AF50eVs1yQMAQDatZnSIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB8470.namprd11.prod.outlook.com (2603:10b6:a03:56f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.27; Wed, 30 Oct 2024 12:28:22 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Wed, 30 Oct 2024 12:28:22 +0000 Date: Wed, 30 Oct 2024 12:28:16 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: David Marchand , , "Stephen Hemminger" , Jerin Jacob , Aman Singh , Konstantin Ananyev Subject: Re: [PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases Message-ID: References: <20241017142214.1669370-1-bruce.richardson@intel.com> <20241025165020.1856733-1-bruce.richardson@intel.com> <20241025165020.1856733-6-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F84E@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F84E@smartserver.smartshare.dk> X-ClientProxiedBy: WA1P291CA0020.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:19::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB8470:EE_ X-MS-Office365-Filtering-Correlation-Id: 65ed2ee5-7ee8-4a1a-1143-08dcf8de57e2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OTZWeTdXaWhkcE5wQkwyL3ptbEhURDFZL1BKNk9yL29aUWI0Q2FaeHY1ZlZL?= =?utf-8?B?dG1vVXdVNUlZZ3NSdDRMOWVwdktoQ0VuR1VZYWtERGhlU3R5V2hRcSsrcWN0?= =?utf-8?B?elhEMzlrWVUyN0x4eDdUZ3RuYks0MHZObDdocXBleXY3REE2VU1ZUVBySjVv?= =?utf-8?B?ZWhNOGo3OUlXbDd2SEt6MzdnRlFLN0pOWlUwVUU0NGRGdThUdjE3QXRNV1l5?= =?utf-8?B?S2xXd0VmcytuVHpqRENjcGl3TVdyWUlxYzdSenNXU0FBdHdXY0p0K1JaazYr?= =?utf-8?B?eWVISjVHK3NwbGFGeGhEQWlJNTRZWGFHdXhOZ3dMTG5NUTVVVSt5TTMvdlBB?= =?utf-8?B?MWlCVlUrUElucjNyeDhIeis3ZGJ1RTVhbktFVUlTbVd4SW9JNmtNQUdFNjFm?= =?utf-8?B?YlhlSlBqSDdEeGlZU1NaQnRoU0NCbC9VNGw5UGRlNTdickFleFRhUGpTNXo4?= =?utf-8?B?RFIycHRrRVN2QWgyS0tqZzJUQXg1SFJzcG1VdGhHT3p3Y09ySW1JazFCU0Fu?= =?utf-8?B?LzlOK3R3dGRuTm8rR0EwcXlFODFDeW1MWEN2UUYzTVRTVDhZbTJHMHRKcDZU?= =?utf-8?B?S3VoQU5kOXpTWXhNUkNZK1Irek5RN2lnT2Z1cGE2YmhKdzdjS3MxV1dzbzE3?= =?utf-8?B?ZS9FaXFXOS9QMXE0RGN1Rmh3SlpBdGczNm1PNTNDclJyQXdIejh2UWwydnZz?= =?utf-8?B?Nm02eHVrV0FjUnljd3NleCtRcUd3RlVXaGkrWVp2azJUaW1nNnpHWGxaSE40?= =?utf-8?B?ZkFRR1NNWUxlVVhMWG5nNFFiYlk5bGlpd2dNdWh3bCtDVkM5aXppcyttVG1y?= =?utf-8?B?d0hvR0tOWmIySmVwenB4bmdyV21JSm5ZbUtTY0MwaUpxeHJDL1NWOHVrTU9Y?= =?utf-8?B?ZjBoU0pBRG04bmgzcUdRWGhMOEFFRHl0Q0NzR01qbFZBK1FkNU5tNGc3OHIx?= =?utf-8?B?R2xOV2ZVd1BwY2QxM2dEZ1JoT1RrYi85dnZrSXhKU09tRlNnem5mVzhmZHZU?= =?utf-8?B?TENHeWttcTZseUNTbzR4ZnE0NjgrNkZOTWZiYUovRERFRmM2Y0pQcVZpTXh6?= =?utf-8?B?Tjlyd25iK05IaVZVOEI5T1VkSmVGR3BmdGpSdmJGTzhySjltWUpweERVaWlh?= =?utf-8?B?YzFUNFdIdmNleHhuNnovZFJKY0RnSHdnUlFxVWJoY0ZrOU5hVjhVakt6NXFq?= =?utf-8?B?Z3dzS3RIdFBSUFVkWmlzTU5qUnVKbEN2SFg1WG96V2NMQi9WeXM0WDl2a0RP?= =?utf-8?B?VU5vaTFWa0l1U1Y4blhSdGJMMGYvbnREZXhDbytWMXMvT0JoQ3VjVGN1c093?= =?utf-8?B?Zms2RTRIczJsanJwaS80VytnaG9UVTNQZ0Z4QzBmbm5LRmNjdm0zN3RaTVhq?= =?utf-8?B?S3l5ZnBKM051SXpHcmFuK0NzQjV3cEkvMllJMVd2Mk5ZS0YvR2FJMHpPZFZz?= =?utf-8?B?dVFmQm45Y2hyWUNhWEp2T2tIMnVMQnowYkhqTGhqZ1JMMXpCZFkrMis1QXBQ?= =?utf-8?B?eW9DNVFIY3ZwamY5YUQvNUJKcTFkenMzM2lqeEZuL2FYbWFQZHBrdW5VYWR0?= =?utf-8?B?U0lNSnNEZjBLcEFzYlI1c1B5dXBoTmc5UWdCSEllMjJ3dFhJNzgxRVIyR2Zm?= =?utf-8?B?Z2haRVBXZkxCVzg4Ylp5QlhJVDdkbTJqd0k5M2Izc3JQVmZlN2xBUWM0VENR?= =?utf-8?Q?XCsJUX3Fqw1JEXO66ZyE?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0ZnYktCUW9BY01SekVKdFJyRGUzZ3R2WnlMZk9HSmN5d3k0ODhWb2pQQktI?= =?utf-8?B?SmswSGF2VHVqWEVVNVdrcS8veFBkTTQ0OElEUTlIVnBkK1FzR2p0MW9HNkV6?= =?utf-8?B?WXQxVDk4czkwMCs1aXI1U09hcUZzOTl5akl1b0FJSUdJYVdGb2d0MENXSmFY?= =?utf-8?B?QUU3L1d5MHpIR1BmeXIzd3dRZGNlc2hmZGsraGovVENYV1YxTW9XMDhVVFor?= =?utf-8?B?Q3ZoakJudTZHYjlLZjJOQ2lnZHlHeFdtNTFxNHhDbUwwVFBJTzgxOW1SUHli?= =?utf-8?B?aDlnWWo0cEd6bUZEMndJUW1rMlRiaW1sblZhTHIzYVJ2bUdNS3F6UjAzRW84?= =?utf-8?B?bEFCeHoxMnlqZmd4UWRmVi91MW9raE9JdUN2Y2o4clIvT3NGK3ZEY0IvUTcr?= =?utf-8?B?bGlkSTRQbDNRVDFkajRUdk5ITmNFVWxIN2k3akl2ZW5UWHNWY2hVd3VPeDNz?= =?utf-8?B?VVp6MWh2S2t2UVhJcksvWWo4V0lTbEpkeUN4MGpEVmJmQVp5Sjc4b0Q1TkZo?= =?utf-8?B?ZHhUM1FLbDVGNWprdk4yS0hKMHlwM1ZlSmgrdlMrVzMva0ZqanE2cU94aU1D?= =?utf-8?B?TnN6TUI5NUVVR3QyVXJQdit5cnpkeHNIS3pEdVZMbTJBOHkvSVBhb3dvQTB4?= =?utf-8?B?Qlcrb1lkajdmWkQrMS8zZjRvaGdNVmV5ZldIMUJMMjZoZkI3MGRXNHVocEl1?= =?utf-8?B?emN1VXBmbEJYZzhIcVBCdHBCM1pnZzJVaG9icTZ0aHRBbVdaVWN5TStYbVpI?= =?utf-8?B?SFVrUUtUZURTQ1Ewb29rTDVNemZLZEo5ZTNZdDJta055dWtMRmR0K3ZHWkEv?= =?utf-8?B?UnFyZjZsZWNQYmRvZkMycGYzZnN6a2lQZ0U5Rm1IK2J0bTJBR21XY29CNXJF?= =?utf-8?B?N2xkb25yQXN6aGtlUjlhaUNiRnpDSVV5Y2hMYmxtTm5nTkRrS1hidUlNMkdZ?= =?utf-8?B?d1FYRUdxN3RKZE8zOVFUaktUcWZsWk5HbXRDL1B6OFZLckUzYTdBaldUSHVn?= =?utf-8?B?WUV0ZE1wT1hVKzgyNXdjTWt1UXZxQ2F3Qy9TU2d6NUUrQ1RHTzM2Si9yLzhu?= =?utf-8?B?aUh3cmU5Snh2V1pGN0ZFVVcvVE1iaWZiUVhiVzZ0RmFnY01VL0dWQWdBVzVC?= =?utf-8?B?MUNJRTdXam1LN21raTZEWCtxSTZSb1B1WnhOS05pN3VJVDJFYTFGUmNZR3VM?= =?utf-8?B?OEFBZCtnYWtyTmJibVB1MzVBSnBkNGxTNjVxOGkyYVRlT2Y3amowRTBrSGsv?= =?utf-8?B?NHlIM1I0b2YzM0U0WXIyRTUya2pFTGxqTCtCaGdaSXBiSlN5NkkrQjlqVTYz?= =?utf-8?B?NXpkUTlvUHJ2R3BTMnkrVnRCdzBTSTloOGh3N0JSNE1ybXMrM2JvamRKZWJo?= =?utf-8?B?b0s4d0tBL1ZTUHJGcll4M3VwakpBSlYzV3E4Q0I0ZUFGNlplTS9RTUVYN1FJ?= =?utf-8?B?L1cyWmlXT1plbnNxNFB3MVZIZDZkd2o2WWZJbGh3NEw0TzdPRFRkcVg1Y2xi?= =?utf-8?B?ZVlCYklnRm5Udnd4QkRFOVcwUCs4WGY1blBSWkJRZWR0bFVSSFhLaUhXc0c3?= =?utf-8?B?S2h5akZoSXV0QWlLSWROTDFnM3A1dzFWMVRHQ1hBYWdNQjZwcHFqQ1VHV0Fq?= =?utf-8?B?OE5GRUNKKzlocTBhZnJzL2p2N2RrRGlickE4RWZHK2F0UWRlajhpV01kRjFz?= =?utf-8?B?bnUvMXNvQmNWUW52KzhjdVVZWnF0cmVVZ1RaYWxyVDFxQ0pOd1kwamYvMCs3?= =?utf-8?B?UTBuSW1FcW1icTZxSmR1L2hhOGY0V0ZCMERHWVd0bWVDU2J1VWxTZHZvcW1N?= =?utf-8?B?aWErUHJYOGE0Z0xDTStwYTR0QThsdmM0cXZlWUcxU1pOUDFLNThJbDVZM2ky?= =?utf-8?B?R3I5Y2IrbTV1R1ZXV0JtaTdrV29TMTgzWWJMWm90QUtXVDdKMGJuR2pTbXZX?= =?utf-8?B?QTJsWXpVTXVMbU1Ob0syVVdCbFFYeVQ0SzRIbk12dFMvbk1aRWRwQmNxcmwr?= =?utf-8?B?c2lNTnVxQTRjTmcxNXE3VmZBSFhrY2FhcDY4NDhvcjF2SCtpSU84OEVpRkxN?= =?utf-8?B?ZnpISjVsNCtBemhnU0lVSkVnT1ZlcXVyZ2tlelB6RXVpeUxmeWlqbjRiOHRQ?= =?utf-8?B?UkRHSzNxK0RQN01BN3dOREljZmxicmpzTTZlb2VtZFVwdTN5RWlVV0ZnQlpJ?= =?utf-8?B?M2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 65ed2ee5-7ee8-4a1a-1143-08dcf8de57e2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2024 12:28:22.3861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wfG9z62IhwjgPQFSgzf60KigT/OH6SLmQpQ2vOc1turAQpUYBDHBjNxUSutLBf3VVhr93CcBntDtuuaZTdcFu4VSgPPcm828hiGplTTQKho= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8470 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 30, 2024 at 12:32:30PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Wednesday, 30 October 2024 12.28 > > > > On Wed, Oct 30, 2024 at 12:21:00PM +0100, David Marchand wrote: > > > Hello Bruce, > > > > > > On Fri, Oct 25, 2024 at 6:51 PM Bruce Richardson > > > wrote: > > > > > > > > There are multiple instances in the DPDK app folder where we set up > > an > > > > IP header and then compute the checksum field by direct addition of > > > > nine uint16_t values in the header (20 bytes less the cksum field). > > > > The existing rte_ip.h checksum function is more general than > > necessary > > > > here and requires that the checksum field is already set to zero - > > > > rather than having it skipped. > > > > > > > > Fix the code duplication present in the apps by creating a new > > > > rte_ipv4_cksum_simple function - taking the code from the existing > > > > testpmd icmpecho.c file - and using that in app/test, testpmd and > > > > testeventdev. > > > > > > > > Within that new function, we can adjust slightly how the > > typecasting to > > > > uint16_t is done, and thereby ensure that the app can all be > > compiled > > > > without -Wno-address-of-packed-member compiler flag. > > > > > > > > Signed-off-by: Bruce Richardson > > > > Acked-by: Stephen Hemminger > > > > Acked-by: Morten Brørup > > > > > > This added function triggers a build error with OVS because of - > > Wcast-align: > > > https://github.com/david- > > marchand/ovs/actions/runs/11401635820/job/32273090691#step:12:514 > > > > > > libtool: compile: env REAL_CC=gcc "CHECK=sparse -Wsparse-error -I > > > ./include/sparse -I ./include -m64 -I /usr/local/include -I > > > /usr/include/x86_64-linux-gnu " cgcc -target=x86_64 > > > -target=host_os_specs -D__MMX__=1 -D__MMX_WITH_SSE__=1 > > > -D__SSE2_MATH__=1 -D__SSE_MATH__=1 -D__SSE__=1 -D__SSE2__=1 > > > -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib > > > -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith > > > -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter > > > -Wbad-function-cast -Wcast-align -Wstrict-prototypes > > > -Wold-style-definition -Wmissing-prototypes > > > -Wmissing-field-initializers -fno-strict-aliasing -Wswitch-bool > > > -Wlogical-not-parentheses -Wsizeof-array-argument -Wbool-compare > > > -Wshift-negative-value -Wduplicated-cond -Wshadow > > > -Wmultistatement-macros -Wcast-align=strict -mssse3 > > > -I/home/runner/work/ovs/ovs/dpdk-dir/include -include rte_config.h > > > -mrtm -Werror -D_FILE_OFFSET_BITS=64 -g -O2 -MT lib/ofp-protocol.lo > > > -MD -MP -MF lib/.deps/ofp-protocol.Tpo -c lib/ofp-protocol.c -o > > > lib/ofp-protocol.o > > > In file included from /home/runner/work/ovs/ovs/dpdk- > > dir/include/rte_ip.h:9, > > > from /home/runner/work/ovs/ovs/dpdk-dir/include/rte_flow.h:25, > > > from lib/netdev-dpdk.h:30, > > > from lib/dp-packet.h:30, > > > from lib/ofp-print.c:34: > > > /home/runner/work/ovs/ovs/dpdk-dir/include/rte_ip4.h: In function > > > ‘rte_ipv4_cksum_simple’: > > > /home/runner/work/ovs/ovs/dpdk-dir/include/rte_ip4.h:191:17: error: > > > cast increases required alignment of target type [-Werror=cast-align] > > > 191 | v16_h = (const unaligned_uint16_t *)&ipv4_hdr->version_ihl; > > > | ^ > > Ok, I'll see if I can rework it to avoid issues. > > Would be easier if IP(v4/v6) headers were 2-byte aligned, like the Ethernet header. > Just saying. ;-) > I agree. Would adding that alignment constraint cause us any issues, does anyone know? /Bruce