DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 0/6] reduce number of warnings being disabled
@ 2024-10-30 17:38 Bruce Richardson
  2024-10-30 17:38 ` [PATCH 1/6] net/i40e/base: remove warning disable flags Bruce Richardson
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Bruce Richardson @ 2024-10-30 17:38 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

for historical reasons, many drivers had extra warnings disabled,
especially in their base code directory. Many, but not all, of these
warning disabling flags are unnecessary so remove as many as we can.

Bruce Richardson (6):
  net/i40e/base: remove warning disable flags
  net/ice/base: remove warning disable flag
  net/e1000/base: remove warning disable flags
  net/iavf: remove warning disable flag
  net/fm10k/base: remove warning disable flags
  common/idpf/base: remove warning disable flags

 drivers/common/idpf/base/meson.build | 13 ++++++++-----
 drivers/net/e1000/base/meson.build   |  7 ++++---
 drivers/net/fm10k/base/meson.build   |  6 +++---
 drivers/net/i40e/base/meson.build    |  9 +++++----
 drivers/net/iavf/meson.build         |  2 --
 drivers/net/ice/base/meson.build     |  1 -
 6 files changed, 20 insertions(+), 18 deletions(-)

--
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/6] net/i40e/base: remove warning disable flags
  2024-10-30 17:38 [PATCH 0/6] reduce number of warnings being disabled Bruce Richardson
@ 2024-10-30 17:38 ` Bruce Richardson
  2024-10-30 17:38 ` [PATCH 2/6] net/ice/base: remove warning disable flag Bruce Richardson
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Bruce Richardson @ 2024-10-30 17:38 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson, David Marchand

The i40e base code driver has a number of unnecessary warning disabling
flags. We can remove three flags warning about variable format errors.
In the process, simplify the list to one flag per line.

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/i40e/base/meson.build | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build
index d94108629b..a0912b1788 100644
--- a/drivers/net/i40e/base/meson.build
+++ b/drivers/net/i40e/base/meson.build
@@ -11,10 +11,11 @@ sources = [
         'i40e_nvm.c',
 ]
 
-error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
-        '-Wno-format', '-Wno-format-security',
-        '-Wno-format-nonliteral',
-        '-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
+error_cflags = [
+        '-Wno-sign-compare',
+        '-Wno-unused-value',
+        '-Wno-strict-aliasing',
+        '-Wno-unused-but-set-variable',
         '-Wno-unused-parameter',
 ]
 c_args = cflags
-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/6] net/ice/base: remove warning disable flag
  2024-10-30 17:38 [PATCH 0/6] reduce number of warnings being disabled Bruce Richardson
  2024-10-30 17:38 ` [PATCH 1/6] net/i40e/base: remove warning disable flags Bruce Richardson
@ 2024-10-30 17:38 ` Bruce Richardson
  2024-10-30 17:38 ` [PATCH 3/6] net/e1000/base: remove warning disable flags Bruce Richardson
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Bruce Richardson @ 2024-10-30 17:38 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

The -Wno-unused-value flag is not needed for building the base code, so
remove that flag from the list of warnings to disable.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/ice/base/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
index 38ddde9e8c..addb922ac9 100644
--- a/drivers/net/ice/base/meson.build
+++ b/drivers/net/ice/base/meson.build
@@ -32,7 +32,6 @@ sources = [
 ]
 
 error_cflags = [
-        '-Wno-unused-value',
         '-Wno-unused-but-set-variable',
         '-Wno-unused-variable',
         '-Wno-unused-parameter',
-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 3/6] net/e1000/base: remove warning disable flags
  2024-10-30 17:38 [PATCH 0/6] reduce number of warnings being disabled Bruce Richardson
  2024-10-30 17:38 ` [PATCH 1/6] net/i40e/base: remove warning disable flags Bruce Richardson
  2024-10-30 17:38 ` [PATCH 2/6] net/ice/base: remove warning disable flag Bruce Richardson
@ 2024-10-30 17:38 ` Bruce Richardson
  2024-10-30 17:38 ` [PATCH 4/6] net/iavf: remove warning disable flag Bruce Richardson
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Bruce Richardson @ 2024-10-30 17:38 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

Not all the flags for disabling warnings on the base code are needed, so
remove the unnecessary ones.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/e1000/base/meson.build | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/e1000/base/meson.build b/drivers/net/e1000/base/meson.build
index 528a33f958..158badce43 100644
--- a/drivers/net/e1000/base/meson.build
+++ b/drivers/net/e1000/base/meson.build
@@ -22,9 +22,10 @@ sources = [
         'e1000_vf.c',
 ]
 
-error_cflags = ['-Wno-uninitialized', '-Wno-unused-parameter',
-    '-Wno-unused-variable', '-Wno-misleading-indentation',
-    '-Wno-implicit-fallthrough']
+error_cflags = [
+    '-Wno-unused-parameter',
+    '-Wno-implicit-fallthrough'
+]
 c_args = cflags
 foreach flag: error_cflags
     if cc.has_argument(flag)
-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 4/6] net/iavf: remove warning disable flag
  2024-10-30 17:38 [PATCH 0/6] reduce number of warnings being disabled Bruce Richardson
                   ` (2 preceding siblings ...)
  2024-10-30 17:38 ` [PATCH 3/6] net/e1000/base: remove warning disable flags Bruce Richardson
@ 2024-10-30 17:38 ` Bruce Richardson
  2024-10-30 17:38 ` [PATCH 5/6] net/fm10k/base: remove warning disable flags Bruce Richardson
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Bruce Richardson @ 2024-10-30 17:38 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

The no-strict-aliasing flag is not needed for the iavf build so remove
it.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/iavf/meson.build | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build
index 27d104cc12..b48bb83438 100644
--- a/drivers/net/iavf/meson.build
+++ b/drivers/net/iavf/meson.build
@@ -5,8 +5,6 @@ if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0
     subdir_done()
 endif
 
-cflags += ['-Wno-strict-aliasing']
-
 includes += include_directories('../../common/iavf')
 
 testpmd_sources = files('iavf_testpmd.c')
-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 5/6] net/fm10k/base: remove warning disable flags
  2024-10-30 17:38 [PATCH 0/6] reduce number of warnings being disabled Bruce Richardson
                   ` (3 preceding siblings ...)
  2024-10-30 17:38 ` [PATCH 4/6] net/iavf: remove warning disable flag Bruce Richardson
@ 2024-10-30 17:38 ` Bruce Richardson
  2024-10-30 17:38 ` [PATCH 6/6] common/idpf/base: " Bruce Richardson
  2024-10-30 18:17 ` [PATCH 0/6] reduce number of warnings being disabled Konstantin Ananyev
  6 siblings, 0 replies; 9+ messages in thread
From: Bruce Richardson @ 2024-10-30 17:38 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

Not all the warning disable flags on the base code are necessary, so
reduce the list to only those needed.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/fm10k/base/meson.build | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build
index bd19df27f7..666733b25a 100644
--- a/drivers/net/fm10k/base/meson.build
+++ b/drivers/net/fm10k/base/meson.build
@@ -10,9 +10,9 @@ sources = [
         'fm10k_vf.c',
 ]
 
-error_cflags = ['-Wno-unused-parameter', '-Wno-unused-value',
-    '-Wno-strict-aliasing', '-Wno-format-extra-args',
-    '-Wno-unused-variable',
+error_cflags = [
+    '-Wno-unused-parameter',
+    '-Wno-unused-value',
     '-Wno-implicit-fallthrough'
 ]
 c_args = cflags
-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 6/6] common/idpf/base: remove warning disable flags
  2024-10-30 17:38 [PATCH 0/6] reduce number of warnings being disabled Bruce Richardson
                   ` (4 preceding siblings ...)
  2024-10-30 17:38 ` [PATCH 5/6] net/fm10k/base: remove warning disable flags Bruce Richardson
@ 2024-10-30 17:38 ` Bruce Richardson
  2024-10-30 18:17 ` [PATCH 0/6] reduce number of warnings being disabled Konstantin Ananyev
  6 siblings, 0 replies; 9+ messages in thread
From: Bruce Richardson @ 2024-10-30 17:38 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

Remove unnecessary warning disable flags, and for the remaining flag
implement a compiler-check for it before adding it to the cflags.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/common/idpf/base/meson.build | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/common/idpf/base/meson.build b/drivers/common/idpf/base/meson.build
index 649c44d0ae..7056352a67 100644
--- a/drivers/common/idpf/base/meson.build
+++ b/drivers/common/idpf/base/meson.build
@@ -6,8 +6,11 @@ sources += files(
         'idpf_controlq_setup.c',
 )
 
-cflags += ['-Wno-unused-value']
-cflags += ['-Wno-unused-variable']
-cflags += ['-Wno-unused-parameter']
-cflags += ['-Wno-implicit-fallthrough']
-cflags += ['-Wno-strict-aliasing']
+error_cflags = [
+        '-Wno-unused-variable'
+]
+foreach flag: error_cflags
+    if cc.has_argument(flag)
+        cflags += flag
+    endif
+endforeach
-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 0/6] reduce number of warnings being disabled
  2024-10-30 17:38 [PATCH 0/6] reduce number of warnings being disabled Bruce Richardson
                   ` (5 preceding siblings ...)
  2024-10-30 17:38 ` [PATCH 6/6] common/idpf/base: " Bruce Richardson
@ 2024-10-30 18:17 ` Konstantin Ananyev
  2024-10-31 13:26   ` Bruce Richardson
  6 siblings, 1 reply; 9+ messages in thread
From: Konstantin Ananyev @ 2024-10-30 18:17 UTC (permalink / raw)
  To: Bruce Richardson, dev



> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Wednesday, October 30, 2024 5:38 PM
> To: dev@dpdk.org
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Subject: [PATCH 0/6] reduce number of warnings being disabled
> 
> for historical reasons, many drivers had extra warnings disabled,
> especially in their base code directory. Many, but not all, of these
> warning disabling flags are unnecessary so remove as many as we can.
> 
> Bruce Richardson (6):
>   net/i40e/base: remove warning disable flags
>   net/ice/base: remove warning disable flag
>   net/e1000/base: remove warning disable flags
>   net/iavf: remove warning disable flag
>   net/fm10k/base: remove warning disable flags
>   common/idpf/base: remove warning disable flags
> 
>  drivers/common/idpf/base/meson.build | 13 ++++++++-----
>  drivers/net/e1000/base/meson.build   |  7 ++++---
>  drivers/net/fm10k/base/meson.build   |  6 +++---
>  drivers/net/i40e/base/meson.build    |  9 +++++----
>  drivers/net/iavf/meson.build         |  2 --
>  drivers/net/ice/base/meson.build     |  1 -
>  6 files changed, 20 insertions(+), 18 deletions(-)
> 
> --

Series-Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>

> 2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/6] reduce number of warnings being disabled
  2024-10-30 18:17 ` [PATCH 0/6] reduce number of warnings being disabled Konstantin Ananyev
@ 2024-10-31 13:26   ` Bruce Richardson
  0 siblings, 0 replies; 9+ messages in thread
From: Bruce Richardson @ 2024-10-31 13:26 UTC (permalink / raw)
  To: Konstantin Ananyev; +Cc: dev

On Wed, Oct 30, 2024 at 06:17:12PM +0000, Konstantin Ananyev wrote:
> 
> 
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Wednesday, October 30, 2024 5:38 PM
> > To: dev@dpdk.org
> > Cc: Bruce Richardson <bruce.richardson@intel.com>
> > Subject: [PATCH 0/6] reduce number of warnings being disabled
> > 
> > for historical reasons, many drivers had extra warnings disabled,
> > especially in their base code directory. Many, but not all, of these
> > warning disabling flags are unnecessary so remove as many as we can.
> > 
> > Bruce Richardson (6):
> >   net/i40e/base: remove warning disable flags
> >   net/ice/base: remove warning disable flag
> >   net/e1000/base: remove warning disable flags
> >   net/iavf: remove warning disable flag
> >   net/fm10k/base: remove warning disable flags
> >   common/idpf/base: remove warning disable flags
> > 
> >  drivers/common/idpf/base/meson.build | 13 ++++++++-----
> >  drivers/net/e1000/base/meson.build   |  7 ++++---
> >  drivers/net/fm10k/base/meson.build   |  6 +++---
> >  drivers/net/i40e/base/meson.build    |  9 +++++----
> >  drivers/net/iavf/meson.build         |  2 --
> >  drivers/net/ice/base/meson.build     |  1 -
> >  6 files changed, 20 insertions(+), 18 deletions(-)
> > 
> > --
> 
> Series-Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
>
Series applied to dpdk-next-net-intel.

@Konstantin: FYI, when running checks on the patches, I get warnings that the
address you used to ack the patches is not your main email address in
.mailmap. Not sure if you want to update your primary email in that file?

/Bruce

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-10-31 13:26 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-30 17:38 [PATCH 0/6] reduce number of warnings being disabled Bruce Richardson
2024-10-30 17:38 ` [PATCH 1/6] net/i40e/base: remove warning disable flags Bruce Richardson
2024-10-30 17:38 ` [PATCH 2/6] net/ice/base: remove warning disable flag Bruce Richardson
2024-10-30 17:38 ` [PATCH 3/6] net/e1000/base: remove warning disable flags Bruce Richardson
2024-10-30 17:38 ` [PATCH 4/6] net/iavf: remove warning disable flag Bruce Richardson
2024-10-30 17:38 ` [PATCH 5/6] net/fm10k/base: remove warning disable flags Bruce Richardson
2024-10-30 17:38 ` [PATCH 6/6] common/idpf/base: " Bruce Richardson
2024-10-30 18:17 ` [PATCH 0/6] reduce number of warnings being disabled Konstantin Ananyev
2024-10-31 13:26   ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).