From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7865E45C4B; Fri, 1 Nov 2024 15:30:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23DBD4027C; Fri, 1 Nov 2024 15:30:13 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 2EA804003C for ; Fri, 1 Nov 2024 15:30:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730471411; x=1762007411; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=DKE9kJOmeummIxSq98Xz11OTnfA6P6g1E70RqmIzzo4=; b=QD3WGonKzDJVAKWXzdUr24wiWJYJBd6MEIMB4+Ozi5XpmEUP6uhJIVIP vPGDlCu3t9TH7uk068y+XzPf74MtFEDcP1S0pTkPkSdaGwgbhCpyyxpV+ sAubk23I1EDEXLUu99bdHI9JgFfxdf7wWwcwgKfX0tuajedtSPVU7QA4J Qc47DqBShKAgZM1+gTrDplNacDoII2Lz2dC7g9cJjBO5BZZKS/+yrD/FO KXIH0bD3XUqpfiunz/VKrtsBrWI/kkXWWFu0uPsOfEjeAu061kGIAQRZb GeRiiYRYvWXkASv9Z4jhluYq6wdB5TT5dD6fm+LucfvfCU+++8wPsKgtN g==; X-CSE-ConnectionGUID: SEaFvjAARFahcde4MDxOjA== X-CSE-MsgGUID: Z5gqPcNJS4SDfeg+OT/g7g== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="30093633" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="30093633" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2024 07:30:10 -0700 X-CSE-ConnectionGUID: zvYXlRTHRwej0LSguqYIew== X-CSE-MsgGUID: +LFFlJSASpyLnfNeJCBE2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,250,1725346800"; d="scan'208";a="82663087" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Nov 2024 07:30:10 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 1 Nov 2024 07:30:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 1 Nov 2024 07:30:09 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 1 Nov 2024 07:30:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NV+H62kMRA7TeBUEtEL7qiKu/KE4+vWw6jG+4f4EsfHfWoaNFPezlayuyXEg2uPZrqSWwDwAG+j/hbjz/AwDi2Vt30L4Iia03XitDvJyoOFrCipQLW1pSP3iUkDSMxAVWynOHux8Xf+/ouxtikwROTmgbo90YjaCyVO9fWIUqS4eu0QsuBCns70kr2ISWr0zDISC1OaJzPaS9tpbDXEl/WIciCkTLAliC8jv/5T60D9zq54iqnxc0VzeVlt6iTSZCQNCRHBuHFLUblZal6rZLpXB7O0riIFL76XxLhAgmdxn4dBNGCWU7nIk08+G1wN0BptBjfc771a6wYqAgrwasw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ctxH1oOiCthRyLXwypofnLHpio+JogChPliBumebMzQ=; b=aR5PoqR42u8LNMYHWMT02E2SHu2gH2HKU1kT1+2vwlil2TOfHkup14Hd7IoSjvGodYdZy27f1Uk6XrGnWD30Iun5Ua+ruMILczh/avT9XoF2dwV2oB0uSW0NnEXX9t/pQRVEZiXfKaBxJS0Lu0ppkcZyAYwkLPVmjftbzwotqM3pJXUEvEMESgybBg1fhhY+SB7ZyrofynyOwTgSs6eOz5UIWGnHFUCNa/HVLS0ZaAbvgw0qVTITH/xR71VpqM3+MJ64dXX3gY6EjIwVcgHLQDnBfUNdVrdbbOnUxlJ7sN3mcDdzyZl7Rbi6qU1DFsjmc3nPkAf2rEYs4mmx2iufTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB5888.namprd11.prod.outlook.com (2603:10b6:510:137::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.18; Fri, 1 Nov 2024 14:30:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 1 Nov 2024 14:30:05 +0000 Date: Fri, 1 Nov 2024 14:30:00 +0000 From: Bruce Richardson To: Martin Weiser CC: Subject: Re: [PATCH v2] igc: fix invalid length and corrupted multi-segment mbufs Message-ID: References: <00f78eba-8eff-4c67-8ecf-3bef5f25b9f6@allegro-packets.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <00f78eba-8eff-4c67-8ecf-3bef5f25b9f6@allegro-packets.com> X-ClientProxiedBy: MI2P293CA0007.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:45::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB5888:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d141d18-da5f-41e2-7eca-08dcfa81add8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YBcoxt3G7ehqeFfbGwBHz3zyU3uAhq2nNtU++UkD8LZTAuG/rIXY9KIA1A6W?= =?us-ascii?Q?vGN1sJiE403e6zjGqzMZz6BqVA2t0l1CwQRkODR3JgSym9upxJRQ4aL/07bc?= =?us-ascii?Q?Pas6LztqxmEsbCNQ1HnjMjN++o1eQ06eR8OE20Z0w0DC63SKoYpeOevI8lhG?= =?us-ascii?Q?ijHOVh2l7dwupGCWuH8L9pLGkaJl5N6PyF3fws4Fatl738rUF+JD5gZFnTrW?= =?us-ascii?Q?EuEz+5WDVajw6nQ0HEhcNG4Lx7k4IkMydvLC79Z8QigmzqDynsAwDpur2HSV?= =?us-ascii?Q?QtP0ygARduo/xgmN4Jjqu42mcq/nHqpnV3lcGgHVEaEekwN9my19Vm6xR9wn?= =?us-ascii?Q?o6+PbOWq70ioX6VfavjhdShP8akZj2c8L7cetMtknZ5J7fXCDUxUtFCrCco8?= =?us-ascii?Q?2zAk1Yv6HSG0Y3AwXngrut7TDOAyGLMytKNVLdAk3tTHwScZ6xt9jlBe5ri4?= =?us-ascii?Q?MpuMbs6bTUcfWr0y7lz/eJA3YQHBRySTvcYc5QX7HIQN2Vuv0pfqWrFxTFSd?= =?us-ascii?Q?bybYKfLsEZiManuwZtHM6cUX5Enu23YdDXaCEqUUT3wVDAROhTSm0bFWPHxC?= =?us-ascii?Q?+H/CzJ+FsBhTrzAjeJ4buSLU71IwonJcLrq4UAaPsqJg+ooIxqe2oeE5Soqb?= =?us-ascii?Q?xXc60wASq2jZrzrhJ/3PGn/nSBjMDN/VEO5TaaCVj04SVui7Ejqh7xbfYkgW?= =?us-ascii?Q?uS+cYkOm6KksxumGJc4ZWLIDKKJHTf+gOUaFaZUjwXllHAWgBj5MgbpLWqeC?= =?us-ascii?Q?nzFy76+d9GOYm8DBWJ28JQKs7JqpFE5DPw7lRBOPsXFSzZtsxvLiNAFtI328?= =?us-ascii?Q?UOzbOUaAkQgelbhumuXTfhBFAgLk8zzFCU1smFkzz2hyYbuzt1REwadOrjoS?= =?us-ascii?Q?FV/pS0i2jbSRj6kqf2I4xCZJ0wJjdOab6zeNT1E0popnnDqBU7/83EJqc4eu?= =?us-ascii?Q?uOY1yoUKTV8i3R6PR9azUUux1HfUwdXkFNPymRFIRsyHWzqTT7y8bzlowGcu?= =?us-ascii?Q?hpVYqK6d7NWnuCB9QC4WD1khmer2fsMxu4s4KRB7kk6Nh+gWG5ZEOOKsLGgU?= =?us-ascii?Q?HnL4dvvcWctNMSU1kV1o5E4qb17+FjEwxcV0dMsX93fZh0XYAYBVArDO3l/y?= =?us-ascii?Q?gRaYGNul6wcumH0AqDRhLm+RdUNPdg2U3lAqI1lbpwjGK4ggHcI12XhLILIV?= =?us-ascii?Q?OeUpnbcgsd95wr7GM7RYOx7e1L4qwlNkN9yozpYucKEk6gQ+Ns7pKKnW/Fjr?= =?us-ascii?Q?FUZSpyhkwEPSYNrVQ3oXK2T0BCZs72LacGNGppQHHGRKar6Gpkp+wKuI17mi?= =?us-ascii?Q?fKa8yXt2Xae7kmUgyQ7G7b1c?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aKQ478JTFKRRcfXJlI9qDpz9ZlWM54B7NQS0bx7HDQC95M47PUzvb7cS0T2H?= =?us-ascii?Q?ylVmAJ0ZbMCIx45O4F0qV0jYX6zFRwy+/H5Pmd4YnPyOysGuIHxJHhKVuMcq?= =?us-ascii?Q?OkfsRM5puMVEi4UelkF9UQmcsMqe1vTnoFrylptzQHXyXn9buD6MxYLgSzi5?= =?us-ascii?Q?hOLvd0v1tCKbqpidcr58yeTT8x2j7MAjgIP5pqS9AZoBkPa+///g6Fy5r+Vo?= =?us-ascii?Q?vFTwnNuTvw3A1HWzicve0j8x7PPz91P54LJnNHXT8AwP6MkK9OsYXA27CBKJ?= =?us-ascii?Q?AtdZfetUFxryS2eorioejhBbmjRZKSO3h7k7NlCbcb+dSsifOIocXGdfufX/?= =?us-ascii?Q?ZivoJGf35VrWYo2o2yicWRbOa0/VJu9P+DcU+E2SUz7/j2W2rXphwme4ZPeS?= =?us-ascii?Q?C8h+rw5t8kI2Eb05BdE9/gjSo/Gz9BVbEIrsJWTmIrPZ2M8dsZROQhxpEYIr?= =?us-ascii?Q?7j2WNMv5+2ykdfgMgkSwTyAoNyCJCpsXo3n3QpVj46bKQxzEsmW66T6b6DhE?= =?us-ascii?Q?vR0ZgNeWeORcOsvQcLwDS1s79GO9Tp9ajIeJ/I4340RXntgtmUEv0gjcxv4+?= =?us-ascii?Q?SgsmrKtstHnJ4q0OAQ5UQBmfOeqvLsygOkRrueqf407IQFTKu8nqLlru1K2f?= =?us-ascii?Q?UtwzLC4EOAgPRu77xApcVOZhQvY7CU/x1jkCI96uvc2v5E5Q4eWiQLpAa1k1?= =?us-ascii?Q?aeLlDeTQcvQ4FmGJtLqYDCp4Xe5NXVz2mmy65ODJMfauydpXSkTWqgUb2uFK?= =?us-ascii?Q?zodxFSbYkvP3tuf+jQMTyrphpWCD+Ngn1hhUuht0VG0pHbUUAoQ9us1JJOOQ?= =?us-ascii?Q?2XiWvBdEfonPYODuR6Xzn9OTBmD+QsWSiJSy3MShVXDk8ES9H6rgTE560cQY?= =?us-ascii?Q?rE3ObLEk5Am3lvRni1m1QCwig4KZAXc/jh5bj2/twAqZKb71g39Q44tyE2Vs?= =?us-ascii?Q?JNdcAQ5oCJyfilmR6RRssu8GsmkWdMCyq5x4EdCyHBOtykrMobyrMd2Vw27u?= =?us-ascii?Q?pQzUcW/DNkzcJIPRQqk6JsGqBpENjNoil3gn68SGaXbBPjnCTKgfzW+cZTiB?= =?us-ascii?Q?L0sqxklX7ON64ZXvMVgqH3TwtKZOhSY0CjyH9GEs9YsM3VJPKCXWKrEAN6tp?= =?us-ascii?Q?jetiKe9/aThV1RqXCXjGqxXaxdZp43hC99GpmDKY1gy6oGmmxjTgkFhHSsYi?= =?us-ascii?Q?27svZYzrnvwC/7E/6QvSkhicz3gDt1jk6ooXpK42nzadMFf8xN87X6qwujOL?= =?us-ascii?Q?9o9R/uGBppXtIAlee8XjFSUQxhUrenhASe3JCcbdK4QuZXyfG4xNooLzzmKt?= =?us-ascii?Q?eUnAvBE7TTSddNcW1vkvQ9jA2Q2xziySpzGr6Hc3sw9NxZG8iK8lsQiWfoJA?= =?us-ascii?Q?7ygTGIqf1CyJPcSPVgC4MERFJOlHKK/71JutBq3g2znlP/Q1soojOoh2OMY/?= =?us-ascii?Q?c+gfgO/mRysHmDkP2YgEKJSmM2ourcuizDJaGdrjPx5pcpIkBrpxDiZwCfnr?= =?us-ascii?Q?noARjlUM1bnvH71JIcASEOOhNRFgrVpiF4AdbNCTA0TGoZ84R+f8csE5qLeA?= =?us-ascii?Q?vi+fFGl6oYDOHqMg06DeTQXoHI2VmUeyTEBQVz6bazzmaRUwu39PvnxR1Rwi?= =?us-ascii?Q?Kg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9d141d18-da5f-41e2-7eca-08dcfa81add8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2024 14:30:05.6184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yypzgk+0qM6RYxq3qj3K4oJ1ipvmPDHY4v3EQtlRa9Y8xXo/f8PbhS9p2kjYR1rLVWQtCQVESigdQBtT86bUmUH64CFeP3Tc7I8omsaoL+0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5888 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 01, 2024 at 02:57:26PM +0100, Martin Weiser wrote: > > The issue only appeared with hardware-timestamping enabled > (RTE_ETH_RX_OFFLOAD_TIMESTAMP). > > The length of the prepended hardware timestamp was not subtracted from > the data length so that received packets were 16 bytes longer than > expected. > > In scatter-gather mode only the first mbuf has a timestamp but the > data offset of the follow-up mbufs was not adjusted accordingly. > This caused 16 bytes of packet data to be missing between > the segments. > Fixes: 4f6fbbf6f17d ("net/igc: support IEEE 1588 PTP") > Signed-off-by: Martin Weiser > --- Acked-by: Bruce Richardson