From: Bruce Richardson <bruce.richardson@intel.com>
To: Martin Weiser <martin.weiser@allegro-packets.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2] igc: fix invalid length and corrupted multi-segment mbufs
Date: Fri, 1 Nov 2024 14:43:38 +0000 [thread overview]
Message-ID: <ZyTpGs8kGhEL0HUr@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <ZyTl6FtX_Ym3Ta26@bricha3-mobl1.ger.corp.intel.com>
On Fri, Nov 01, 2024 at 02:30:00PM +0000, Bruce Richardson wrote:
> On Fri, Nov 01, 2024 at 02:57:26PM +0100, Martin Weiser wrote:
> >
> > The issue only appeared with hardware-timestamping enabled
> > (RTE_ETH_RX_OFFLOAD_TIMESTAMP).
> >
> > The length of the prepended hardware timestamp was not subtracted from
> > the data length so that received packets were 16 bytes longer than
> > expected.
> >
> > In scatter-gather mode only the first mbuf has a timestamp but the
> > data offset of the follow-up mbufs was not adjusted accordingly.
> > This caused 16 bytes of packet data to be missing between
> > the segments.
> >
>
> Fixes: 4f6fbbf6f17d ("net/igc: support IEEE 1588 PTP")
>
>
> > Signed-off-by: Martin Weiser <martin.weiser@allegro-packets.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2024-11-01 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 13:57 Martin Weiser
2024-11-01 14:30 ` Bruce Richardson
2024-11-01 14:43 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyTpGs8kGhEL0HUr@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=martin.weiser@allegro-packets.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).