From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BE0D45C4B; Fri, 1 Nov 2024 15:43:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9569A4027C; Fri, 1 Nov 2024 15:43:54 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 13BDA4003C for ; Fri, 1 Nov 2024 15:43:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730472233; x=1762008233; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=FKKZ9KtwrgVJc/TQSo2qOJK4LHFIJYM4u6UGyLUl1Ig=; b=UOw4Ys+DjXiVt7zesr7AGHwTgEumg3+YXp6UL8wNRkMnqrAsYHo55un1 ZfM8Fh6nF/FeGsB987uJ84CH5OWsGENqa7Roj1EISM65Ukgsdu0v9PStn EvxAYXaI2XbGO1ZyTzTxrZpxfpqPFSX3Gszc74hJ+RFm+juhZ8EdLw1TG YXlgIRMhN8s4u4WsogC0O1fdl0530/7OZh5+PCj1d6cxhfjoOLYJMp9ZX Rx32EElwmkOyCVvHF55HQL8WnZSC9Rm3CuyTQyjWw6Nyli2bY5RFg8HC5 1lsV6PA0AnbtshnK2Yz2S2t53F8c+67tXwqeLVSM0oEMR1yRLlgSehTGr g==; X-CSE-ConnectionGUID: mWFxA0L3RpK7mBiPMxNx+A== X-CSE-MsgGUID: dJMKEOYKSFiAplShmj5Ygg== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="30004007" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="30004007" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2024 07:43:52 -0700 X-CSE-ConnectionGUID: BJRjAZ8cT/iUy9tnPrmirA== X-CSE-MsgGUID: sSo3IzugQBixX74wbmrXVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,250,1725346800"; d="scan'208";a="82511299" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Nov 2024 07:43:51 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 1 Nov 2024 07:43:51 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 1 Nov 2024 07:43:51 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 1 Nov 2024 07:43:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nhbKYQfTcHn4ky325wSK82zi2pFtPSMGoRfa/oGnTpq1l4abMYjuRrcTqc0xLw8tFsedlckOM97TZelfILDyaP70zXsVntpYY6vU9vSXl0mgEDOmPWkuqRtBw6O0fjtzxXwrPkr5Bd4Ob/LXYsOpTd8IKJhj3U0wvc+t1QN5Gqi2v3xmsJRSAlZkVLf3DNT0bVZ1k6rBLDkQcArVFrJ/fFrxe4ABoM1agL3rwIK1qz+eyimw+y3Wa4UrYRIa2mW4kzlzPI0GBOLo2ea7PAKkSxYz7amd2LMhHviikRCjgSXGL5DMzU4X6ogHodqwwRpyKHz1tXc8JO2RXERgR9wh3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KqcZXruODs9iy4yNsEqJri+r2zEW+zfj0sRNdUUkdME=; b=lloxu1CVVsva16E0KXENDVINxm3sasbxr/a7Lg1JrjWOj7jGJ2dmqdgPHXif7Zix7ujOCEK76hrP9r2p1map1AAJ+Hxsn1uy++YoJIgBc1uaBevvoAgulu4Q/Xj6df7Q0VD3qTp93PB/AElzZzt6xVD16e8cGnnrdnIrw3+pQFynDvLy6dXcGwwjoag3XGXNyP0A1Q20hpgsDx5z6U0mBCaKOpbWE/vrT60D7QSlw+HqMm0b+HNkUwe74xGKP/0WhIDtQEMUVD7LZiPf+RPAe+0jUXER1h7nQunWTkgX3NGHykGifxhOWkDbPfNt0T/NdXQf0yRa8fuN9oKNv/6mCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH0PR11MB5251.namprd11.prod.outlook.com (2603:10b6:610:e2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.28; Fri, 1 Nov 2024 14:43:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 1 Nov 2024 14:43:43 +0000 Date: Fri, 1 Nov 2024 14:43:38 +0000 From: Bruce Richardson To: Martin Weiser CC: Subject: Re: [PATCH v2] igc: fix invalid length and corrupted multi-segment mbufs Message-ID: References: <00f78eba-8eff-4c67-8ecf-3bef5f25b9f6@allegro-packets.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MI1P293CA0005.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:2::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH0PR11MB5251:EE_ X-MS-Office365-Filtering-Correlation-Id: c5a1769f-a001-4f34-127b-08dcfa83954f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zbafMYR909F8ohscJNEkzoQn++NELhgknAcsgcXmMI6JCArCaVikNHrYyG8n?= =?us-ascii?Q?xufMEo38xFBy51OTlOah4JMCnTjGY8MnW98d0lmKv06A/tC8B65+jjGC2nVg?= =?us-ascii?Q?zxAxhkYOz6qxZtAY4LFtrY9mwJzIoePlLd0DfDRbeYXwNtUU31q3u/xiTiO5?= =?us-ascii?Q?CcAOq90VBT7UKVQlfJ0F8wNghW6kpuSyScLGpRDdWr3muGSUk5BvvPen/42O?= =?us-ascii?Q?Wsw0hnWd5bFp14R8Tpx3C5BMC1ZMeidOfCO+w2ub40yZ7yA7PQN9MwVm0M+F?= =?us-ascii?Q?v4QrMMdU712Ho2xv6oNpHrKbFcB7N0FZhtECwFaip0TQ1e2uK8qH2k8AJTp7?= =?us-ascii?Q?n81rvTDmMxzhUczsKCnzdzj0V4WcHd7GXg4y8MWWdi0wQ9diN18Re41eUI/O?= =?us-ascii?Q?IdLhPCsgF+8GjpuRjJITSQJQCz2GPRYGXX1RAOhJM7roPvFN+21eVoaRaEnh?= =?us-ascii?Q?DmU7w02hy4/iwQLhBWY/jpZKRHkRXkYsANwGHg0EH1DJErP4j9pE7zHSg30N?= =?us-ascii?Q?x3PbTFJtzyBMfF8HS3XPUHpQLarI0Jq9sk1CKNIAMs/p5OOlL3emcJmuG8Cn?= =?us-ascii?Q?Zs95b/zLMT2pqayZWtj9LGYx/xBpTHfNRrU0qhr0TVtq4ss/5jW7zjWvHtQw?= =?us-ascii?Q?kzmAwVS4VszGsOA9ksojgjGLbukkLQwZBce/GJqjD8dlV9Rj0kBYm7yHJugJ?= =?us-ascii?Q?4nR/Gi+A/vakWGKQtjFFxIxzT1WmtfQyeTWPTgIjNyCVmgLzl/EI3oVKKNXM?= =?us-ascii?Q?YI9D8jp0SPEXAuk07lQTpESd+CfItojrIXPLCtgNncs0vN/3QBYydClPDVCm?= =?us-ascii?Q?Q1t7pV0ijo1swi0CTMt8Z5y64R4dNUSsse7SGmk2y9LlVGNhtDKyGmvzAJQ5?= =?us-ascii?Q?JGQVy2cgHqo9fmnoA41qT2udnNhUwBkT8jHsJhvg2dgM5RZpHSagRS7NkFia?= =?us-ascii?Q?xnUfpjeP0OSheZWR3p7XfDXQITqlEncPkL6DW8cYyLywaIPzNvWdHn08kFJ1?= =?us-ascii?Q?h1Nr4r0df/pRCdz6O3ArghQhA4OhsXVKiqN7Pa/35numyUwPFJCai1yMif96?= =?us-ascii?Q?4KTzPDPe4cfwdOeB/LFnnZs5hsPydaFikEr8QSVCOU3Jnmu6VfckPtzTMbRl?= =?us-ascii?Q?98zePvwMixmGsX6nMyT67z2nyyefrfC2xC1ziAbPaVWDxu3HVCvhmSgf1JKh?= =?us-ascii?Q?Tu6RBzhIc/Wfx8nVPhxwuTla107tfSkc26jPxWzB5bE1Grkyp1GzdfFhWL/b?= =?us-ascii?Q?uJcAecvxxFUKxzUUfaGjhie5mNksKI0AiydLrUHHDW5eADWVzxPICySJbclE?= =?us-ascii?Q?ocb/apP9RPMKSrOQMaEqoHLX?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZCCFGhhPWXh2RGi/tlicsHy3sFGlEBH+wfpRbL3kuBT+ZgTUlVpQkJBAJgZg?= =?us-ascii?Q?f+dhWuzIaG4AK8mXLh0UGvEj5OC4G3x30C+U6GQIthCV2y3/Dnj+yiJ2J09u?= =?us-ascii?Q?xKSONxyilH+qsuD+r8ajX+VE9PniO3xKjOYy6hyyau94fnYToDbvDHMxKyd4?= =?us-ascii?Q?mrePG7nBxYcxG6j/01GKc5J0oapsm7uf5822r8tgs/GeH/APqeaMPE00N17N?= =?us-ascii?Q?cepVecuLqcHbME9MiQEQDC89LZMjgO9V2Qag77l+yttkMMMK14XtSetgLZH9?= =?us-ascii?Q?uLoEoX/J0ImUoVtevQToc2nDm4sP1uXUVk+2hbEvpHEf1vEmG6VDZ8M3ENio?= =?us-ascii?Q?geKEAHWro6ckgw50/FrVB5rEIocfVYpkCUFmlapRH1Zm2MecshiTkaGZfylN?= =?us-ascii?Q?8OP15EEUDmw6ylAYyLWNAR9iLAPWTvkK1KjUnaQc4UPoWHeuDUzxNP59Gnnt?= =?us-ascii?Q?2d2fgwIqmOQ4fnv+tGXrWvRSEPuqHmRvn4CZlFI8b79E+HlwHijYmgoPcKYj?= =?us-ascii?Q?dVXBzyNJdaUwIlKMeQQ+EDRhHpO+ppxSlMT6SHR+F7exmFc5d0dspkNPCTCE?= =?us-ascii?Q?MaqztxLVs/DXtGrnZcLtKpRiRVJ8tbVwWicyee9dT6UBxTWfFmdyLmWgRkmi?= =?us-ascii?Q?uFAV6NYp7yQuZCBZ9HP0DLUpvbogO0xNIN8H/JrcYmhheOzUPLEYot7Rk1JI?= =?us-ascii?Q?G18N+DzI8+AWWiB9SZUKT12lMM6XTeEdslYUprs2TF35+z0ZXgKjju4IM511?= =?us-ascii?Q?CJlgE87lqmiMrjm5GutXCMW0Kkhv/Nq//5OKE4iz6ia+OXb6sgJL36EO0gbd?= =?us-ascii?Q?W63VldM37RR69gPd3RoggoVhwSYLJrNzhM2IDPxjHOlVAS7giRrt9MNlPHEt?= =?us-ascii?Q?rLjOOmYemvV7+86itzUMF+y9OQoz1kzQCOKXGgKm1+/1QABVAkuA2zHZlQwf?= =?us-ascii?Q?HEUP7c2jJMN+1jlu7ZyuI/SxrK7GFOuLvArAbfLSk/DzoLb5DuNw14HHeajl?= =?us-ascii?Q?A75J8npoc7KrlUrSrw0EepPMehn4wtEljGHeExQWJ03vzO/WPRu1MlkjH0xQ?= =?us-ascii?Q?lVgJlrxx0vur+U7SPa55PVYiPgbGI3MMXOawvJ9jK3HDRkVj8YTPhjRN4yc2?= =?us-ascii?Q?DSCqR5VbmqidKGuxgnfmPFB5ZZmU4iKe3eB5scm2/wrzknUwg7jmBLUqGpYH?= =?us-ascii?Q?P5pk36hWVY/+XFl66GB+Hs4dNjJxFYm7hJ1PaP1rQQbC9W6EU6JyBlfoAyVC?= =?us-ascii?Q?prVAzIt9bD+nk28D7YOXlqzTYwBKpLRdcvshSkvPdlWTMLCJFHlI3jlGTLb8?= =?us-ascii?Q?+B4iXrTMaaITHt3ELWcGBRZJgV1ix2brKLgkCQvr6X0DT69WGDuT4TReWCFH?= =?us-ascii?Q?9eSSvHqJr+iU2uKJK/N3Gojl81bsFJuiJ2kYwjk2s7miZr9Xcm0rD/unPBLY?= =?us-ascii?Q?GC7DJx3UfskTJU389fp7s5CRvKluICu04374ISMRD/X60LrR/gYoBroRplc5?= =?us-ascii?Q?hMyMY/mfbUMW8v9hwFLLEg5GepZaewgkgSvDYND8wBA38Y629O4vYPJ3GJv2?= =?us-ascii?Q?KX+B8PPNtDQBCRz/VJNhMFVVovfeoG9+T9Tvnuw2w1zW3wkeOizNGaM1oAjn?= =?us-ascii?Q?RA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c5a1769f-a001-4f34-127b-08dcfa83954f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2024 14:43:43.4262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8CzKCJ5aCzIALg/SZhibSgDwzfQ4SfRTd3S+n2t3f+mGUIRMW74pNQNjWVPoUn8XsaKwU3NEUEVn+h7uyyFNM2OnvF4GNTVIVS0q+x3S6a0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5251 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 01, 2024 at 02:30:00PM +0000, Bruce Richardson wrote: > On Fri, Nov 01, 2024 at 02:57:26PM +0100, Martin Weiser wrote: > > > > The issue only appeared with hardware-timestamping enabled > > (RTE_ETH_RX_OFFLOAD_TIMESTAMP). > > > > The length of the prepended hardware timestamp was not subtracted from > > the data length so that received packets were 16 bytes longer than > > expected. > > > > In scatter-gather mode only the first mbuf has a timestamp but the > > data offset of the follow-up mbufs was not adjusted accordingly. > > This caused 16 bytes of packet data to be missing between > > the segments. > > > > Fixes: 4f6fbbf6f17d ("net/igc: support IEEE 1588 PTP") > > > > Signed-off-by: Martin Weiser > > --- > Acked-by: Bruce Richardson Applied to dpdk-next-net-intel. Thanks, /Bruce