From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3607E45C94; Wed, 6 Nov 2024 12:36:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0722E402C3; Wed, 6 Nov 2024 12:36:28 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 7AAB340265; Wed, 6 Nov 2024 12:36:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730892986; x=1762428986; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=n1mP1h04kszjzP9re6HZwO4smt7Zfc5oFrVwl2zJzU0=; b=CH8J20DDsxELxhAHqPsXg3zudRzikznsgGLXUc82EcGvoqsxLEDyMUXj MjD96XXZmfdo4a6YbD8nv1rQKPLcP5rAei5z8qPVskAqkoSgB77u7ufXc zSSzglZFsla8rPZK0VAIjrBgFBACzQkQw3bWohx3U6XtE59JsMTN5qe+Y Py1lcH2IawDIXUAzy35kuf/1fxoF/hrJYul5nd4pmqPAQ0OMcBcQQ99Tr mEzb1Xy5KJYq7H8EwZlsG0ZQX2sIyigLY6oUhDmjK0GbAHZZS9jozk+1w WRvm/q+C/zKWFMcy2xktw20gkUD9YqQ2TArj6pggMO2bZ+cjTAlT1JnTj w==; X-CSE-ConnectionGUID: 9CxkuylqS8yXArRXGjFV4Q== X-CSE-MsgGUID: fyUd3oOjTx+IzGI7/eGrZw== X-IronPort-AV: E=McAfee;i="6700,10204,11247"; a="30799747" X-IronPort-AV: E=Sophos;i="6.11,262,1725346800"; d="scan'208";a="30799747" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2024 03:36:24 -0800 X-CSE-ConnectionGUID: pi/s1g5gTdWs8NbAmjXZpw== X-CSE-MsgGUID: J9btzaVdQeCUU0o2w3pbPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,262,1725346800"; d="scan'208";a="88458620" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Nov 2024 03:36:22 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 6 Nov 2024 03:36:22 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 6 Nov 2024 03:36:22 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 6 Nov 2024 03:36:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mBBfbN01awBUOB4K+Iu4hJzytOADX6qbeQxtuRWP1XjvWP4r2pFYfkBbEtXrybMwMW2PRPCg/Ht4hK8t2V/juJDgltWN36Piuouanin4NwcrVSXfSd1u5a5/P5wYJqjYKZXAiCpye/Qk60e3jx8j6SxOGMpOs3waZEyi7cJ//5Pu0oEH4LOOeQTrHFu5Z4N2j26XRLFUZPWmedAv1LRDk2q1V714xBeKM5kbDuaJPQfI9OmpFQByb2XDQeUJSNu40cUPCsLmbtO4rA+wUqdCXVKiErsf1xyqpEKK9GNaZnGnbwEyVWB6PJh1kLedzsOynu/vfbKimzMrLB9p1mXupA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9S6YV+eFvtEgMtHsPnGDcdLOaBP8S6pfaJtWZ3wg6xk=; b=scfzu0eSco48uKb59DrYQo8MuSerou06aLsLSNKXIB+8tzo8aAxv+YR5C8S1C8Nd6Bxh/auBP3NGgfMttPqggtug8EVol7KvJb+GRM0r7kUHLzxo6gOGMERzmKQMS7lcUMbcx5PH5/zFBvnoZDiI/CRCHzncG45vjVS4Kt9KFgE515Lapg/7hrYRDYANaMNcnr4308U1d3w+vUuLsvn8I18MufJfZivE0tFPorYhgSS6FfEaOmvwLfTzoLia7c8bjn8zkYt25ger9U3jEdUdcJLXy0stQNVx1kQmGcjB91w59zPzm19Wek50HZ7TlifIoqzqPaIIvcbWjkYGqQFTgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB5287.namprd11.prod.outlook.com (2603:10b6:208:31b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.31; Wed, 6 Nov 2024 11:36:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Wed, 6 Nov 2024 11:36:19 +0000 Date: Wed, 6 Nov 2024 11:36:14 +0000 From: Bruce Richardson To: Soumyadeep Hore CC: , , , Subject: Re: [PATCH v5] net/ice: fix incorrect reading of PHY timestamp Message-ID: References: <20241105101419.888975-1-soumyadeep.hore@intel.com> <20241106082229.892805-1-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB6PR0301CA0088.eurprd03.prod.outlook.com (2603:10a6:6:30::35) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB5287:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e9f7229-79a0-43f3-a558-08dcfe573b93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KkcriHM1NKZd32CRJNC/TzFOaM/71Ct9omKQRH9WNDB/EDssoLFz9jmjhfQg?= =?us-ascii?Q?ooPFA/2C+c02sikvYu/u5orbRgeVB5VHUuHMq2JVcQ3RkJoghYn1e1TjtdUY?= =?us-ascii?Q?Q1sMPzFemRgm9z162YeXiWj50pjuZGaCIs2q9ldqD5G4FfG+ywKKcMrJB9xH?= =?us-ascii?Q?1ctaHMTqOLQLrWiAlKy/YU9X+NK9nImgz4vkWxS1jt9Vkoi7UyC8kJw/8Jpu?= =?us-ascii?Q?rQIgPOewIn5Oi3VKVCynTzDZYNyhVSskzUBSr1frZyh1/8TDBLv9ZI2pm870?= =?us-ascii?Q?+rEh2CWJvJrJF2PG3bU1zRZkYZ/P4ArklK+5upsFJzmwnI+TyM7od/BhKSIK?= =?us-ascii?Q?mHU/PuNKtRPUc2c8cAqCAfSKo1yMMO7BloimDqiUft+RWr+dcGgpmoYp40Sv?= =?us-ascii?Q?9DbU0aCDTFzy/GHhqbwQFJ988mLTLJn3/Au5QScnB2wayzKyMuLiXzmhEH4u?= =?us-ascii?Q?/ME8FkypmjAsZFFqCWmVcBbVRLnFdt7xgP4i7H3+AaqVeZoF4Vu9tywWC6kG?= =?us-ascii?Q?otuu2xoqOX7wptgK7/lnT937cCRsDLCum/PxlbKRKMd/s1XVBDXI9B8rYozX?= =?us-ascii?Q?i/+rt130gssXtqJ1KxjCa/3w5ZZQaQfx0plgyIcUFTCghkKzdac1NjD6s5XS?= =?us-ascii?Q?nOKUWoQXEkvon10XkTOHQ7M6EYEghRYwTcJcTaxTIHMTtZBrIXVEqCQ7b+ND?= =?us-ascii?Q?1egRzI2SrY04wtqb6vRAN7v+QlJvAiDa18Qh8wsfo6kOHyHkn8odPJl+RAPK?= =?us-ascii?Q?U1TtCd/+RQEFE1NbMYX1LVezOUa9t/vioaopIkZa9CI7XeQaYUDOQ4X+b/52?= =?us-ascii?Q?oSbukHKIrb+4OIHI92ic2i6bicfBE0GIzlqJErZfiUoWocj64eDstPilHcjT?= =?us-ascii?Q?57BdLXvpdBiI6h/3siwCFpBVCF3KIjc2xnEAjsLAnLMm2eJZaRlOhgr9hurL?= =?us-ascii?Q?I2M61DQ9g2Xep1/mO64IeZL7Ybu/nlXzWu/0p2rTOhmFbtl4sVx3KgSjkC3B?= =?us-ascii?Q?LavOr8jemRokTAmBaMeYd1yFcpgmYhDoycSrHLPlu8Auy4oRB954uuVKbuJ+?= =?us-ascii?Q?hz/z0t3VW1aF6+FnAwn7HVenWMYFzFFWURRRotvgQ0KwZcaorLl0dZFVOCQJ?= =?us-ascii?Q?syFt7s+UpKzAYmbvLHk+zPmWWpDSdUb7T0wc+n2MuXJPOPk7rM/GmKUqmgHC?= =?us-ascii?Q?Cp4Zm4PI2YXgc7JCA9bER4TwHVEg1rM1GHzczudbTuHYbYoIxI2kLIZ0cDRS?= =?us-ascii?Q?uyilHTg6jm0BkxQebptfWl+1vFeXT64TBGkmJrTDC/tsEZ/xDXKWCKN9Ac25?= =?us-ascii?Q?6sK0JV9I+CwkiFlxy4SjtYYA?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l5+fmokyc/5hW+s6kGLfo9tE+Hf97PSJHxUsEh4wi2P+qxnKZBVDJM89u3LZ?= =?us-ascii?Q?ZpBGeB8Az9bhtjfgpVYEnB9vT9VhQNvMy2KZcd1APQo+WRd4iEm5q9ofUkHl?= =?us-ascii?Q?QQifcVR1TJUujvi6HwzudNTe/DUZ+nkJkxb5GUrI4JzHiAA2bMMsN7YEZGl1?= =?us-ascii?Q?h+QMw8V6ncLtzlAsZs9iHxyCR3+H2M2T5GOLIPrLDg1M03HCaHwjK7zpl8gB?= =?us-ascii?Q?AswG7lEEwL/hsjYfeYRr6hqvatpv0LUIfur3T3YSxa2ApwEWvEVgKUVB+maH?= =?us-ascii?Q?pUBaOvEjwPrd5BWhuCOfMp06JhAjXzsE6SKrSQBJ4Wk7I2lnqYt95St1uc3X?= =?us-ascii?Q?qhPzjqGIZy8z4AyrYkkTH7nQLvcGAffla6nyN3afZnYVRZOnbgOD4lwIBJcD?= =?us-ascii?Q?XHBGPa6RgKAZ9XYShOftdS7Q0l5ZOG5+GDEZh/Fixf7BOZ5pigWbptQraT4n?= =?us-ascii?Q?klwFaJqH84Ljfmr6XGCdRWIuiuMA7eAMRfsS5RoJDeLwUDJEDnv1leb2bGIl?= =?us-ascii?Q?bbvxNeWYmDVzHhZPL1C1AW7YfiUQvIH3nd/sJhvkY9p6AxvgjrIhuX8pRV7V?= =?us-ascii?Q?T3pNgBvCA5Cq9NiTfZlpSepWgI9BhObmGJHdOHkGYnRpDOYksk5mlJ6flVfR?= =?us-ascii?Q?j6ylrhLKgKPL0c7LdlUQEVIHo90v2iev5GGqcTo+Bg1wYtWNSCEtqzwDetVd?= =?us-ascii?Q?6B8JpNpgXBHmiEa8Efdtr/SQ4Ibr1KwVqY/WG072xe+RDMrEk/Y+N9Yur67p?= =?us-ascii?Q?R5UxDc/28hBVUR7pMsCyh7k9wSD/QhS1ploST6wwVIrm2UksEGbz0nICP4lo?= =?us-ascii?Q?lw3ZfO9gjQP643JaampJaVfDEncwnQmsqgTFGM1BEZTQufz1/aaE1S+0k8jx?= =?us-ascii?Q?7WDekRteFmHpfphDvhSF4znuLN6Nq7HXjexKRkWKLV6YS5OaBnY1Igekwq/W?= =?us-ascii?Q?h3GIRjQx0MP2OAvbuTcPvOkT2JISK8VBg+70zLcPgiEYUtu535sYoWCoYPl9?= =?us-ascii?Q?+H0C/ZU00bSHYx2993v5n4lP9z3ybruk/K/dFWvQ5XLdm7n/WPASohBytO+D?= =?us-ascii?Q?E1UV+8H2MtT89WPxuiRneicAsMIC9ddgNN89TBt3c5GdgB2CDK2NDdkRKsEM?= =?us-ascii?Q?Sq2/BCks4b2UU/ss7zK6hL+IeNTqq9DR/QDV9vujkMiwveibjFlTWJOX9sjM?= =?us-ascii?Q?Vlrc4BN2Va0K96uqV6g3JT88/ezZ/TmvOu866W88onzelS51suw9T6GQFxGp?= =?us-ascii?Q?/EjDMx5VcVRJ1c6PoJKJRmmJuUCeSb66dT8ngyblg/YUs/GyjmS6qla5qd0c?= =?us-ascii?Q?uAZbAZkBVwzBJKDNTdFEqLZGgqwWcSIuIbc8OPVTT0FJoZIqlVKW7q6HGmVu?= =?us-ascii?Q?yox+UmtRyQXUIdBBkpPWS0aozq/TzdlMSj7TNjPZgTRdqtKRzfsXAcqZgvtv?= =?us-ascii?Q?kSP3fnSQlh+ZB9jrUsRJDE/lCENVyun2HipcU0fTUHgZxdoLNF5he50Tbvd6?= =?us-ascii?Q?rjMllJseBVJSsrYV6IpVvwWtFCn9RcP+XKmuSoBlGJqVtrTiPPyJ7ZrBGFeg?= =?us-ascii?Q?gVPjTqXW+TOEYjZid/MkHuYEAjI3pGVfki+n2UhGzLLmsgDMWfGzgFDkWh9d?= =?us-ascii?Q?7w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8e9f7229-79a0-43f3-a558-08dcfe573b93 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2024 11:36:19.6398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pGpFfJP6SdmkOhP4+8wHZsC+EiW9+ZNol/RlCwhh0xOE9iVCOfp229PmJX7Wo25YnIBsYcOk/+ggz3F0E0KA88lviE4mV1bBqcASfqVbncw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5287 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 06, 2024 at 10:59:47AM +0000, Bruce Richardson wrote: > On Wed, Nov 06, 2024 at 08:22:29AM +0000, Soumyadeep Hore wrote: > > In ICE PMD, previously the ready bitmap checking before reading > > PHY timestamp was not present. This caused incorrect Tx > > timestamping. > > > > The ready bitmap checking is enabled and PHY timestamp is read once > > the ready bitmap gives positive value. > > > > Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830") > > Cc: stable@dpdk.org > > > > Signed-off-by: Soumyadeep Hore > > Reviewed-by: Bruce Richardson > Applied to dpdk-next-net-intel. Thanks, /Bruce