From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D87645D4F; Wed, 20 Nov 2024 09:54:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 046B742EF6; Wed, 20 Nov 2024 09:54:02 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 4D1CC42E5C for ; Wed, 20 Nov 2024 09:54:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732092840; x=1763628840; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Uy/RA3ozwZSWx0U5wziHbPst10GmYM0B2FB2uFsff0s=; b=HjcfYCNN7IJFJh6SKTlsqlfxihLshUpTBNnSkWyLZiSl05RMbq9ktJmh 2gwEItDCYbhU9trCpAW1Wa0hhV0XtL6foAfcvmKx4s7UBNqiDaex95WGA HfOB6p7bQNPqe5mOKWCMdKbQ0+nwZ2L8h4U4l22y+sHjfAkzSrth/yinx PlMOVwmvz8Xzrim7ENgLNc/Bd1sJnUPBVFeDmRUQYVy59o2Zjh6V2C4iF R7A7sLWIxdDq4OZTJmmkfbOTSQ2JJp81W5sXf1254ZeTVva8k/X+e6pHh lkhUjVfIIPpUuJ+A5TF1/hOogFHYFxV+1MWcPAYMnxqT1S1rBzeJdokxU Q==; X-CSE-ConnectionGUID: Z4zl2o5CTbqmLL88A33cUg== X-CSE-MsgGUID: wUiML0D5Q5qelpsACBI9pw== X-IronPort-AV: E=McAfee;i="6700,10204,11261"; a="57539323" X-IronPort-AV: E=Sophos;i="6.12,169,1728975600"; d="scan'208";a="57539323" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2024 00:53:59 -0800 X-CSE-ConnectionGUID: 3cs5ViIyQp6pePIrbxd6tQ== X-CSE-MsgGUID: M1jUwLTgTTKtoaMzQE9XVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,169,1728975600"; d="scan'208";a="89796308" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Nov 2024 00:54:00 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 20 Nov 2024 00:53:58 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 20 Nov 2024 00:53:58 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 20 Nov 2024 00:53:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i1gzd44N3tB5cz9S4RV9MS/rsh6N3/v4fZ14/m9j1vjXKUwgyV+fv46zeclUHiX+utiKR39r0d/a1xNru/ww79CHKJtCeneJPUvRn2iL/oBvbtSjBTlHOj5uDVXGvBS6liLtSzGJbyRXNNzuaIXjwapdeYsLL4SgIcS4cZWn8nwmgZ2XVXAmDscP3IHMBkyXHF3fTAfBWKh3B9VSsy5vCRPlKdiXO99/ljKFkC8gnk693M2rWTj+fLMILWu3ohGXy81N5C910bKNiKWhtpxLvOIXv2FntOMA1cCEmLH/1/qBNhj5A85PD0H0npITXoJTA5GrV/z3+4yOybTzVZK6Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5QWa/AU89o18KXJ/kqjO7Pj3ihmd09v0kXUvv0lLe8A=; b=Az0TEQesFRFoPSwKMVHn1mGAvbZf1QE48stDMKdv2J/no7uQIlSrtoG0ZIadeqfunCro91YWQq3Rb/oPcKeOD49ksfUnNfTmkVPmUteA9FbEP3NBelGWUoe1E7alRDCCuGxVs61DBRMY9a1TIeL3ASdGA26NCuX7SnPuGQb9HEmT/W6STPprLp3wwI+XFd7A2ltMenqA2cCLVDFxVptqSEevviEmyrFKdvKYY/QuapeH1tEDbXvbePOTBrwhAV5CbXVGx+vTBcVggp5mgb7TK4U4Hau43lPr9xez+IcFWO9EOR9l1Y4suhP4LZb+EUxa2BYdJYe68zdKbhTl2NakDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ1PR11MB6204.namprd11.prod.outlook.com (2603:10b6:a03:459::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.24; Wed, 20 Nov 2024 08:53:56 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Wed, 20 Nov 2024 08:53:56 +0000 Date: Wed, 20 Nov 2024 08:53:50 +0000 From: Bruce Richardson To: Andre Muezerie CC: , Konstantin Ananyev Subject: Re: [PATCH v9 04/21] ethdev: remove use of VLAs for Windows built code Message-ID: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1732067686-5938-1-git-send-email-andremue@linux.microsoft.com> <1732067686-5938-5-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1732067686-5938-5-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: WA2P291CA0018.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ1PR11MB6204:EE_ X-MS-Office365-Filtering-Correlation-Id: 6fd40350-7abf-4bcb-f99c-08dd0940ddc4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QVF3VlZianFzZ211bmxhYTBITktXSzh6TUNtVlk4cTJNUHlaUDg1TDVTbTdN?= =?utf-8?B?Y2tBZEQ3Ynp3Z3ZKeThrbW14Y3c1Ly95c0JhTXFoNmk4NU1pSGg0M2IzZkto?= =?utf-8?B?Z1lxMHpzWVNrMEtqNlRHNFhzZnFMeFRBejc2Tk9wY3loMHEwK1IyWjhJb3ZR?= =?utf-8?B?bU0yN1dFanlHbWFhSUtzVkxQeCs4R1FaalNEL0VGOWVkNFVBSXpqcTlMZ3h1?= =?utf-8?B?MW9uREExSUdVL3JONVBXNDZVZ1Z0TUZoRTBKVU5oRVJ2ZEV1TmgyL0RMaGVk?= =?utf-8?B?RmJaK28rZkFNeHd0SDhOUzR5S1BVVFU0L01nSEJnUWlOVXN6M0VZYUhBcldm?= =?utf-8?B?RUFmeEZPR0xBd3F1Ky9QK0piN2t3RHJoMUpWcVREK1VHRkFUVVdqU2NEa2Vn?= =?utf-8?B?a2NpNXJjcExPa2NMTWg1NFdVZzR6U1Bra1NoeU1JOUthMXhjSE84R1llZzRO?= =?utf-8?B?S0w5K3N4U21BamFON3pCN3VZQUFWNnZpcHp4dlRnWit1U1ptRm9hdnhHNUlF?= =?utf-8?B?a1EvSVppb3FIK1UvTEtjSW41bHAwaDBYNjcwUXY4Q0tJS1lrdXNXeXhLWmRi?= =?utf-8?B?bG9WV28rV0NMSmpoVnhkTlFIdzJjMndML3p0cXhPUnNINGE4YXJSTk9QT09z?= =?utf-8?B?UmxmSmFYK2hlTnhhWm1zL21DUnZKbG1wTjlOSlNVZ01aeWNTRFJHUlVxaUdD?= =?utf-8?B?cTBMVnlTUDczWkI1SzBiZXNXdVgzUENhaXJBQUE1REV2ckprRUpFWFFncGpR?= =?utf-8?B?VzBXWG5TUE1oN3BiN3EvWHlXUVM5akJSdnJlenF1N3prRVZIeFZ2dE95RFVO?= =?utf-8?B?V2oyU3Z0TzhVaDI1cUNSTzh3L0R5U05CODRkVkZKOWNZSTdiRWVVZVh1ZGhB?= =?utf-8?B?b2k0c3czOVc3cWdXK3pSTy9ZYjgwWHJjeU5BTjFnb1NuWTNJanFMRGc0ZVh1?= =?utf-8?B?cjZDbk5UdlE0UFN2RWtBbDg4ODZVTUxkRDZ4ZTB4bGZPMGp1K2pOYlR5T2Q3?= =?utf-8?B?KzlBakxMajdRWmU0SWlML2JOVDBRSHlKVHp5UWtpczFHV1QwcnZheFduazFB?= =?utf-8?B?K0w1QTN4UUZKeHpCUVd4L0JiYUd0WVJROWI1dXlkMTdmUHplSlM4aWNHNHR5?= =?utf-8?B?QTVmSytITkFBTEhRY0ZBUkZ4djVQM0hwYXF0Mjhrc2RkMmdGSVBoUnY1VSsv?= =?utf-8?B?N1dNUmNaVmtORzJKRVFyQ290YTBYNWc0SU5VSVFVU0FTMGx5dFBJMU9hSkRW?= =?utf-8?B?UytvOXVoS3NKUUdNeVpBZXZBZVZXeEdSTHR0NzFhd1ZBaEtQSUFHY2NCNENt?= =?utf-8?B?UlZLYWZ3TEpHY2JvZ0RxYVV0U2lXYWxrUE4vWTdMeXV5RzdnTTdUUE9XOHVP?= =?utf-8?B?Q3dXMGVJU0tpa0RkRFFBbk5UZjExWWIxRFc4YUFDUEtBaFR0RnJSMUJmOGxG?= =?utf-8?B?ZzlNQkx4SUZSUURQVERPQ0RoV2lkTUpHKzMzaFY0WGhuanBTMEdnSjVOS0RZ?= =?utf-8?B?R3RPMCtHYmJ3a0NNNU9VN3hDTjZRbnNxV2V6T213Nlh3b3kyVDRqZC9hR29y?= =?utf-8?B?UjNSMnJQM2I1WE4wMy85YmlqeFZlMTE5YitaaFZFU2hEZnlqZ1dzdGhnUUtW?= =?utf-8?B?S3NzZVVuQ0tjU3MzZk95QXNieWlENVdEZ0hQTEJYNGpnK3podHljWTdoS2ZV?= =?utf-8?B?TTRFVHVxN1ZYTlVUZVJqSTVRbzQrSlZXRUJrTnZlUTJUa3k2ejIyMEVKb1lr?= =?utf-8?Q?XxtX0a+XQki9zgEJJJD7j6oCZbwuGMA5EKefqAy?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2lEWS81MmswS0NMQko5SXRac0tsMkh0dTk4RHVTQUl5TzEvV3NnT3Z6SWlv?= =?utf-8?B?NERVbmdaMEN0YU5GY2ZyWTBQWWpvaUozLzJjeHU4WVVUK2hmeXFpVmNoeEZ4?= =?utf-8?B?Y1dlUDVEbWF0dXUwSkxpekZpdm4zWTk3V29TR3NRQ3lEMmtobmo5UHoxbE01?= =?utf-8?B?Yk8zL1NyUHRLNEttQyt3WlpiOXNsYmhJNGJsckJvcmJ4aElVRTltQlRLeTFv?= =?utf-8?B?UW9rcDljZ3FlSHN1VzNNcUcvSC9CNERpRmtSNk1rOXM5YU9UMmFDai9WZ1RE?= =?utf-8?B?bXhKY09rQjlZWlJhZzBLclJLZ2U3T0hKMFZCcHVHSVlibFlvajdhRFVRbFpL?= =?utf-8?B?VG9nckR1QzlrT2R1azNYK3Jsdko4cGRCSUNKL015cVRRSU4zRTVoZEZNdzBF?= =?utf-8?B?T201N2owWmxkdjJ1WDV2dzhUcmNrYVV3djRsY21seVIzZllXS2E4RkxWK05F?= =?utf-8?B?S1luaDRadmxnR3JSOS92aTBPSGRJdTFlRlFPZ2xRY2VZcmV0WnU0R3U5RWZx?= =?utf-8?B?MG0vZm1KZmY4Q0tZcTM5WXdKcm5FY2Rtb0Q2RjJYbWVwaVA4eDV2UkliMjBH?= =?utf-8?B?VS9oK1F6VDdlYjhSbFVSVkZQSDUzQ1B3K01rV3NXTnFKK29vcFVwWE11Q1NW?= =?utf-8?B?a3BIdzE3eWJnaVF4NzVIV0kyTisrblFFc3hGcEUwL2ljNms2TCtPVFBETHVY?= =?utf-8?B?RWVXeUhGdDJCbXlJc2hCT1NXdURQRVAwOHlPWnVhczhpN0Y1UEdMZlZLdEpm?= =?utf-8?B?aGdicjFZNmJEaml1bzRmSEoyR1ZtK2NuVXUzQjVzWVpITjRQUzJidC9PcDVr?= =?utf-8?B?SVZVZDVHL20xOU02eU5TUmY3Qk1wdVYxbjRPRmlUN09Yak1RQkpKN1Bld2s2?= =?utf-8?B?N0toMnFkQ1JndmVBRVMzSVFpNDB1OXBQRy8rQ29lMmFJNWdmY1g3bCtwM2NM?= =?utf-8?B?cEZ5WDRLdEd0czk3Y2VTbGRINEhodDdZbkwwNkRZU0pLSDlmVUkyVWpJeUZX?= =?utf-8?B?VzBGWnJOS2ZtRWljdVpYdEF3VnN0dStjVzJHempoajhLK0lHdDZ1OUtNMU90?= =?utf-8?B?bnNhTGR6ZGc0OElzZk8vRnZybFdQM2g5aW1XeUhvOU1HODVnOC81WDhIZVZs?= =?utf-8?B?N090R1FsenlxdWdWWWtEY0Y0bE13TUwxbnY5RXU2Wk03S1EzSzJYZWowbFBW?= =?utf-8?B?dnZZb0UzbDdsYm5ENkIzSUdnTzdLbzZMVVRRenYvZ3psNU5tUGpIM1JnaHhl?= =?utf-8?B?TkFWWi9MSjFSU0thc1dkeml4ek9ST2k1dXJ5TGJaU2lHTWgyb1l1bUYzOHA5?= =?utf-8?B?WTNBY0FZK3l6UXNuQTkxN2lKSm9tSGhvSTRvc2pqSWNmelFFMHVrOHpOS2Jj?= =?utf-8?B?clI2d3JERjRMRWsrS3pGNndOcUhFWHArSTBVbDNjTENOU1c0ZGREd3B5dnpF?= =?utf-8?B?Y3luYzBqYWtDaWJxaDhSNDRTSzB1ZmtSSk11SmZDcGsrTmhCbUd6dktoTFQ5?= =?utf-8?B?ZURzdFEzbmNQQXBQL0l0TzN6ejdReXBGZktybTkxVEdxQ1FaWjB5dEpTNmpG?= =?utf-8?B?cEY1NmZ4cXRLSEVHRXZiT0xEdzk0K1BVMzQyY05UM04rNDlwdGxLcG5semtM?= =?utf-8?B?NWZZK0xYM0R3dXJMOXF6bUFnc01hQU1GS2NoNGszclVhNWxoQnJBMXNuZjFM?= =?utf-8?B?R1o1aTlOMEF2cVZaSGlJeXAvZmpyK2UwQTF5VndEZVFHeUQ3blkrZzdzTDl6?= =?utf-8?B?OFFmVUk3WkM4UTJRTGN4aGxXOWRWbXVIaVFpZkdlemhGSG5wM1lRNmI1RWRU?= =?utf-8?B?bzVKNzdPY2ZkNUswemRvRUNrK1llZ2hvc2lWZTlZN0czZGpMYWtwTEw1c29y?= =?utf-8?B?SkxUSkNrM3ZjK2Y1QTYrZlFvcnV4b2JnQ0V2VExVUDU5OXg5SjVQQ0UvMVJo?= =?utf-8?B?SmVpVWZ3RTUxOVpOdkFPWVBKMkFmSTN4aEtKTThsdHByWlBzM2hxM0tWMXho?= =?utf-8?B?RmZPM0FIcDhTU0NTMlNmM2NGdW5LUXZ6Rlczcy95YTBqeGVxbVhSU3RSUUZD?= =?utf-8?B?UXVhd0o0c3VNRGRaK2xMbHFzS0lGcVY4NTZ0YndTUXFvNUR3VlRkbnZZcWkw?= =?utf-8?B?Y3hDTVZKV2Yxamc5V2hpbzF1L0VDRkgxY2VpYnNQSkxjSGJsNHhzYjZ3MGd1?= =?utf-8?B?OFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6fd40350-7abf-4bcb-f99c-08dd0940ddc4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2024 08:53:56.0788 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uBjIHS2mjkVvGer+YXY/4V2SJSboIBE8g5A1xxIVZsJ+Y4mRL9YD4DQ91DW3jhPJKgJ77VysJ66ThcyTA1qieiyOAArd12NUY+juXxMYZi4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6204 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 19, 2024 at 05:54:29PM -0800, Andre Muezerie wrote: > From: Konstantin Ananyev > > 1) ./lib/ethdev/rte_ethdev.c:3244:16 > : warning: ISO C90 forbids variable length array ‘xstats_names’ > 2) ./lib/ethdev/rte_ethdev.c:3345:17 > : warning: ISO C90 forbids variable length array ‘ids_copy’ > 3) ./lib/ethdev/rte_ethdev.c:3538:16 > : warning: ISO C90 forbids variable length array ‘xstats’ > 4) ./lib/ethdev/rte_ethdev.c:3554:17 > : warning: ISO C90 forbids variable length array ‘ids_copy’ > > For 1) and 3) - just replaced VLA with arrays allocated from heap. > As I understand xstats extraction belongs to control-path, so extra > calloc/free is hopefully acceptable. > Also ethdev xstats already doing that within > rte_eth_xstats_get_id_by_name(). > For 2) and 4) changed the code to use fixed size array and call > appropriate devops function several times, if needed. > > Signed-off-by: Konstantin Ananyev > --- Acked-by: Bruce Richardson