From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81CB145D4F; Wed, 20 Nov 2024 09:57:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76CBC42ED7; Wed, 20 Nov 2024 09:57:02 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id D118540E36 for ; Wed, 20 Nov 2024 09:57:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732093021; x=1763629021; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=iNS1dG/Fm332GCP1w6dgqAr7YvdPGczOHlgfnKuPZx8=; b=TQ32J8sT3ulGER0LvNmUyeXIGkne6hLMMqJKakSy9hdit4oLSBugryPL mSX1LLdnaiieo3Sdf3LIAmxKKMfnNhvaUJ+KUNO2JlOka2rzEZWlSsYhP E8A63nCg16w+d3dc/DHCLWb+rdosLO3ZbvUAaTQA7sgxcmwjUAzU1Oujk 5uXOylLH5sAmET3v1pX7xM+6VrgQ59x325rpBPEjK2B/3QLtHuV/ebHdm 9/yteAOLnJ11ip6I9Pyt57FA5EvIlHHzgtKmDNrcqaHt8Z5urstLiMoto FiHotqRX3UHcE/ilD9pzYBBwXMjiFjcAMK39zugzIKNzn0EE4SVJjL1KW w==; X-CSE-ConnectionGUID: SGn9cxfhTJGGjH41IRDbfw== X-CSE-MsgGUID: 8e8Zb3rqQ2aIpA6ZX27/9g== X-IronPort-AV: E=McAfee;i="6700,10204,11261"; a="32250654" X-IronPort-AV: E=Sophos;i="6.12,169,1728975600"; d="scan'208";a="32250654" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2024 00:57:00 -0800 X-CSE-ConnectionGUID: YaFSgmDwTXKuC682r+ONpw== X-CSE-MsgGUID: ZmMp6Ym4SQmYFR4uwvqZcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,169,1728975600"; d="scan'208";a="120784523" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Nov 2024 00:56:59 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 20 Nov 2024 00:56:59 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 20 Nov 2024 00:56:59 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 20 Nov 2024 00:56:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xH73nHZiPaRZHFVEjRWK1ouv2xvZOChOwdFbnUZ3HhY/QvCYfvS1Droe1SRkvmXp+mmu3mjUF5++oQeQl+k2INnhrkx5McrdYbDLDROrY+TR2dr7KqkcViacZuBb7E3+CmlcocvNSac/EP85VoFhyMExcuEJKEVfmwy9VUeOFWF6P3AkXn0hTPz46Po3J2Qi1MFbsokgcOBo13z0fg+Stgp468UJAO8SATI7SgKGZxsYpL34FFNovUZutLT7T2iTreOo+jLts9d+YUZQs1KW6j3NmTRAy7GmBlEDb1bA6TWxclSMn87irCgvsy/G4LqVPOOihhO3seW+mOeznWSivg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jtAJ48GbDandcoxNdcNcPPgizi78hi0Xs5m6RHiP/CA=; b=lDn93cqM7RDj4omTMuXvI2khPHUW3n0oe8qWaGYuLDkJw0IEa8oyRB/s437ghHrqa/XMvnDJcqeYIpuaeKZGU7HcoBj5+N+uINzwwuPDHPtAj6NyXSID4RzB9PVrJM4kT3Y23JK51pz8yMI1D6DGjvM0ctBhH3vs0puqIdxGNuqXrV7Dfe14zfaufmJkKwuzLxGkGN2JwYaDTdLyaD0k1wTTaG4z3rhQUPOHU764fLn4d6CIO2iWEjqLugS0hsP6O2Igqa/EWzdEZwqP8MJiMoWfK4b274lJTxQPfjl0PaPlbu9I0Ff8gDYWTZ4is6KG/T66TqHtbClFs/WWMXVuXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ1PR11MB6204.namprd11.prod.outlook.com (2603:10b6:a03:459::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.24; Wed, 20 Nov 2024 08:56:56 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Wed, 20 Nov 2024 08:56:56 +0000 Date: Wed, 20 Nov 2024 08:56:50 +0000 From: Bruce Richardson To: Andre Muezerie CC: , Konstantin Ananyev Subject: Re: [PATCH v9 05/21] hash: remove use of VLAs for Windows built code Message-ID: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1732067686-5938-1-git-send-email-andremue@linux.microsoft.com> <1732067686-5938-6-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1732067686-5938-6-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: WA1P291CA0003.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:19::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ1PR11MB6204:EE_ X-MS-Office365-Filtering-Correlation-Id: d01011e5-2d65-4365-2d8f-08dd09414941 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NGpsaUlYQk5BNEdicklmS0tZbEd3Z0Zzenl2Rm9ZSFIvOVV6VXpkQ3dkN0xF?= =?utf-8?B?WGRkSjBDY3B4OXNZaTloVlBVV1JqZGpuR2RqM0sxV1V6elY1SVI1bUdrWndF?= =?utf-8?B?eXFBR0wrOGJZWjlkSXYyeGpsUDd4YWdLbzlUNndldWdvdkI1dCtUK2lhdHJG?= =?utf-8?B?R3B1NUF6S0tlQkk2cGttRndjaFpQNnptTFcrc0EzUTQvQnVqTlB0Q2QwWkl2?= =?utf-8?B?ZDF4R1lZTWkyMHdqbFMveXF1Zks4cmE0aG83SlM4SlpTdGlmYld1ZDd2U2F3?= =?utf-8?B?TGpqd0ZBSit6M3hjT0xnZnhuMk5PcCt2WC9VM3FrMllQSlJ4SXhmVC9ud1p0?= =?utf-8?B?RFpmanhkN2hJaXpXekRScCtscDRKR3RKR1RudXpnNnNUMDZqU1lrL0lsdWh0?= =?utf-8?B?R1F0ZTdnVXhYdm5PdURSQ0dMaGVlTjBxTHgzczVuT3dzQWtDSWp5ak04WVBJ?= =?utf-8?B?RjE0NkFxSW5Pak5QUDhMWm5NWXluL2ZxcHg5OTJKejJlNStMWTJLQ1pBRHJj?= =?utf-8?B?ZktFS1M0ZmR0TDFIV3BNdExiUUhxVXZyZHNGZHZNWSs2MFFmMC8vM3RBQVFS?= =?utf-8?B?WjlnRHgzTjQrNno2aEZDaktBS1BqcjlDcmdiWnVtenpFd3lxOVp3dkJFcDFV?= =?utf-8?B?bXBUTTcxVTZlU3ZqdWVPYW9kMmlCaUF2Tnp0R2NreTNubzVIeUJSOWJMc0Y2?= =?utf-8?B?dHJDMXA1eGFCMzk4bzJGdEdDM2VMcVk0ZGVDUXBmQkZHRDFrNmFmZ1E3U0po?= =?utf-8?B?VS9ETko5ekwxQVJRVWhVSEw5TFlubzRMaU1vMUM1ZHIvQkhLZm9YY1JJc1FL?= =?utf-8?B?RlZFSXFtbzFJeVYxY1BKWVk5QlFLS3ovRnVEMXlwS05GczR6ZGF2Zk1xZ1pV?= =?utf-8?B?aG9OdlRxNUNFdTVOY2ZYWGZmTVVZMWxwK1YxakhpQUV4Y0V5MTVEa3JKcEFC?= =?utf-8?B?KzZnSThjakFVVS80ZldISGxUL2dna0ZnZXFzRHNYUjhEM1J0QlJqWHJXRnJo?= =?utf-8?B?N2VjNnpKa0dtNmVIaUdpelBhRHUzcGIwakVZNzZ3a2NIZFV5czJya25VdmZm?= =?utf-8?B?UlZCV0Q2ck96SW4rOHNuUFlvYlhQKy9XcTNsc243WkNmTzBlVldadldrTVRM?= =?utf-8?B?MlEvYmJScXJYQ25MeHo3YmZzdDRCZEdqaXUzSzNrWTFsK2pxakxJbEluVzZP?= =?utf-8?B?bDZPODlzUlA3SnFZcHY2czlCSVVPcVozcTZpVkR6RHZraDJLNzJxSkJCK3Z5?= =?utf-8?B?a2NDdUttRHZXYTZHNUVYLyt5MGtFQldCTFhKS3l0TXhsalFNZGVQUXgrZkV3?= =?utf-8?B?Z0R5QmxWVzZQaGNxYmhQeUVzZkJQdE1UL0phaUlsTjkrWkxZaFMrNVUyUzZk?= =?utf-8?B?MTBuTG93azM0YW15akI1SE1jYjMzeCtUZk41T29WeXZuVDVzK25hSTJPSXlH?= =?utf-8?B?bGgrWTZ6TGJ2ekpmUjFiN1hYWlNRS1hJdHZQK3lYUzZEUHU3Szc2MmdIRjZh?= =?utf-8?B?eVY0R2ZOUWpPS0dUM0l2VDV1eHI5NlZ6QzU3Z05Sb3lZN3RmamYydUx4bXZj?= =?utf-8?B?NlZBTVlZNDBTZXlCY00xWjRDcHduNWhSa1dsaUlEeW1sVW1YQVYzQXBkbGFN?= =?utf-8?B?em9kNHZySWFZZExoU1hrK01laXJ5NGdkWnAwT3I5TkgrZ0IxQzExM3UzaHpK?= =?utf-8?B?aEVlYjVRMldsSGN1dWZLbU9zNkNWMktqTGtrQmZrS0VCOEFiVUtmcE1HZ2NP?= =?utf-8?Q?TyGYy3HxOjMneRLt8dJiTB97Q0jX/A1jch/ZEeF?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckdwN0dKaDhaMGtQdUFaWTdIZW00WE9SZTVHZTFNVmtESkg2RERxak1RdEY0?= =?utf-8?B?MWpIeGsvd3B0RkJXY2w1aDhZaS9hTU40WmNDOVF5T3l4NzJCQW1tOGZiYWI1?= =?utf-8?B?S05QMzhxWG1oRFArVzEvNnpqREZOTkRSUm1JaC9GemF0R0VHMEZ0dVg1eUFF?= =?utf-8?B?RVdlUzRFWEtuQW9mRzkzZGlKTG5ScGMyMUE4ZGFRYTBMMjl2aWJCa2lNalJy?= =?utf-8?B?MmhXbUxiSWdKMUh6L1RocGp4bExMb1dPN25ONEJoc2ZXZ0pTZmJvcy82Mzc0?= =?utf-8?B?Mkxta1NvZ09nc2tnNmI4T1VOU05TRnNxZjBMUGdQLzhSUHRXWStVa1h1a1po?= =?utf-8?B?dXBScjdnL0w3aEJWMVlrdXBod2x6aHl1aHZsdGIrUXZHZHg1eEd0dE1WUWxN?= =?utf-8?B?NSsrMjR4b1o4NGQ5bEx2UDB4ZEVkMEVvVmFEUnBMbjFtdjdhWCsvbitHWDBG?= =?utf-8?B?REVwVW92aEROcEp5d1daZVZBQVFTOWZsRFhJUExPdWROajNRSjRwUWo1eWpp?= =?utf-8?B?ZW5pY285MnkzMlVOU2x1b0p1U3JOdWVsZTZIeFFqcDBVNUxSV0hGbnVYbHA3?= =?utf-8?B?em8rTlB3aWVBS2xCWGNEckkrbmQ3dG4yczY1QlNZRjNCN2txZ2ZtSWx1R01Y?= =?utf-8?B?cVF1QjViK2wySktPdzhpR0VFZUw0aEk5Rm5wY05sRVNPWTVaaWNVc1FTY1Zt?= =?utf-8?B?ejFyNEdHMjFsZEc1cENIT0xtMVJxTjhKTHg3Z2tJSVZCY2FqRmtuR0RWY3g0?= =?utf-8?B?SHJZRTlYQnRGblVPT092aklldGx4VUJyc3NEZW84QmlXb0lyemxmeEhldjlD?= =?utf-8?B?ZzZxREgwZExlQTFZcFhGNXcvZUh6NGVIWWtvNmpPWldaaERsQWg4NGZxQWdD?= =?utf-8?B?UW5GWStKVURacWZrTG1ISmFETjExTC9hdUpmK0sxKzJhbzVGRFBJNmlBVkJL?= =?utf-8?B?czN2NWJUdElXR05nK0NkSXVaM3Ayc1JvWHJBUys2KzRuZGN3TlJyUWl0M3Yr?= =?utf-8?B?MFVkbWN0TVFUZWgyeUNQYkg5NTY4YnZmdDU1OHpjWEV5MmNWY1EzSTBsNzJR?= =?utf-8?B?V2Z0ZUJqZkpGbmhINm1XTnFIU0NlaXJoaWtoaWZ4d0ZqQWFidU5IU2M2Qy8y?= =?utf-8?B?OUxyQVRqRHNpY0QzUGhOMUI4MEFTZUdHcG1JcXhrUjl5SFd2WmJQc0xZZDV5?= =?utf-8?B?OWdlWFljblN5eit0SU42QVZ1aWdWT3ZoOEtoZFRLc053bGpZNmwzVmxEWkxR?= =?utf-8?B?cmtCbUxGQm44dG9LM2VGNi9CNVZ0L25QWUE5NThaTjFKc29vaGVjaHlsNE1F?= =?utf-8?B?MWhBcjhuWHZIdzJVNDkxTDNhdHA4SXRsZXpNVUwvNEdIa3RXd3lSVjNnejJV?= =?utf-8?B?R2tLQTRkUW1wT0Z6aFQ3bytPQjZrRW52QjY0cmhwazg4SWR3Si9VZ2hxZFRT?= =?utf-8?B?RG84L2RRNlZoajhMRW5wa1VubmJJVEhEdEFQSi9VU3pDMGdTK0s0anNVN01X?= =?utf-8?B?UUZCWjNBeWJWZFlMc3MrMzV1MTRHQ1AxWmZtZkhaZ01rRUVEMWJXQ0tnbEVT?= =?utf-8?B?b1o1ZUN2OEJsZkRiNzhmK1AybVpVZzRhejJrZDNHdjJmcXkwSWVWMm9qcFVy?= =?utf-8?B?OFhxQXJyQlpjQm8yQzZsVkh5MDl3YjlnSFBVdHFkQ1l1QkUybERFbkZtZzh3?= =?utf-8?B?dHVsZzM3enJkWkhIZFN6RUtQeEJTSTltdytwRjRpY200THhpbU15MklOWXQz?= =?utf-8?B?RXNMRFBKQVJwYml0T0lnVmZXNW44Q3kvMUVtWEc0cS9aSGlFVUd0bisvalgr?= =?utf-8?B?SU43dDNSVjVZb2xsNU1BTFp3c04yaFBPeHB5WWRRck43NmxTRStaU1pjZFVu?= =?utf-8?B?NVdaYk9Wdi9yN2srOUIyK200TVVGZlNLeEJiTHVmeEZYVFZack5ZNVhYb3pX?= =?utf-8?B?UmFrSTc5ZFhjVjNTNW81MDZhdWx0OUxsT2pXTmIrVmlkbWhlTHpOUmhtdVNH?= =?utf-8?B?Tlc2d0p1WXc4UXk4YmxkTllrN054WjRYUTZjNU5iWk84cHZ3SUdPZVh4RXAr?= =?utf-8?B?UlNVWjZBWHlPYlRVSXhkdHdaQld3bk81RVYwQm5LR0c1bWtDem1xaWdJUUFP?= =?utf-8?B?THBWK3g0RHVJSkdlYnhaR3YrVDVubnhVd21JUk54ZDdmS1Z1OHRGOC9LQ0NS?= =?utf-8?B?R3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: d01011e5-2d65-4365-2d8f-08dd09414941 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2024 08:56:56.3778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vGg4LLDm/AOnEjXYII3tynhLFNR5HTSbWIZM85ksdzxeHAD5UZFbhcn/9rfSMJJbIhiyviIsRYSSwOma9Xj0abt7fzO9KUPOr5P0Id1lHpI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6204 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 19, 2024 at 05:54:30PM -0800, Andre Muezerie wrote: > From: Konstantin Ananyev > > 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 > : warning: ISO C90 forbids variable length array ‘positions’ > 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 > : warning: ISO C90 forbids variable length array ‘positions’ > > Both rte_hash_lookup_bulk_data() and > rte_hash_lookup_with_hash_bulk_data() expect > @num_keys <= RTE_HASH_LOOKUP_BULK_MAX. > So, for both cases it should be safe to replace VLA with fixed size > array. > > Signed-off-by: Konstantin Ananyev Reviewed-by: Bruce Richardson