From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8289145D50; Wed, 20 Nov 2024 10:00:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 746FA42ED7; Wed, 20 Nov 2024 10:00:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id B259240E36 for ; Wed, 20 Nov 2024 10:00:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732093228; x=1763629228; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=TMifW+D0ANqkbg+mIHI8PITxbKpoKAoeOXdaHapLbbc=; b=WX12whERqiKi3Gwz3sjGW+GJYmVjChyRlnyjtuHvwQhXzqYd4z4cK9Gw iEcq3bBFgPDk0/OXtNMQTszlc7p/GGnWSzyyOj0duGvN7bgFHOEn3/KA2 13YE5yLeFXzJlbeMEIqBcJBEMC6MLmjVLX4NHUVef+lNjS1otY7hVU38c d5mEhe5GFdoEx+a/l7ZtHg7Vfo+mclW+e1yMD6sTp0Lxj349k7X9CUnP2 hwapsaICgOdh1PBoY8Vrp2lZyT25BQuLrtlxVDKHA4M9XYP7aToAQPLZM 0v9TY8pg00ynqmKke4P8Q9yEK3GE1gdpd1owyI0cV3ZO/Eyn66VEp8LuF Q==; X-CSE-ConnectionGUID: aS3ON/w+SAGfLTOAAEYuag== X-CSE-MsgGUID: 68FqKvvQR5Wa8ryb6KEWfQ== X-IronPort-AV: E=McAfee;i="6700,10204,11261"; a="32251014" X-IronPort-AV: E=Sophos;i="6.12,169,1728975600"; d="scan'208";a="32251014" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2024 01:00:27 -0800 X-CSE-ConnectionGUID: sD45KXFZQCqf1BIm/KePyA== X-CSE-MsgGUID: PfrFK5a+THCBoqcW5nPj9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,169,1728975600"; d="scan'208";a="120785913" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Nov 2024 01:00:26 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 20 Nov 2024 01:00:26 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 20 Nov 2024 01:00:26 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 20 Nov 2024 01:00:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZVMOn9otEZgNdK6aMxB+ebvBI7fdP4iKsmIIHrl/EGgT/XQ1x3L9WH3Uj61Hg0oJD9U9Qjy9nhMWNYGuTaOXZJedC69lU74vunpKiSbQ57T+M5E8YT96Y5fG8OEfr5IJ9516HCE2F2KB1p/kUuZAbp2m0FXRDEuyTjSG8CK3XdvzEN2N4YLQRVe8kRLzVGIaM0GTekr4wLQAd7acuFcsDHwYBnIzGWrbnMVZz27NrzwcEIH9Z07lCgiNBdF1kcLcrMqP5KQBomoT7Zei5+cffSJVuIg9EL9tRkvhj43OA5mJe8yHE44TziWu6tZWhOgWQrH5ilEvF9ks8SNL04QdAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZVoW0ggL8tBt7jNmGLWmYr2fAFTgwTnXIBO0MNl/JZ0=; b=HzszZKBx/YwEOCsUB8bAXtzUGHBFX12sfTkZnM8hbQsIOLLXNWROhUXwaU6GS/ImXPuGx3udS6VD8Np/X5PMDhkaThjx83P1VzqzGkEPh6Ji3QVz/R2Jq4YKl6vCYCR/3yovzn20f5S9vqAcdNkQOVEsItMFubv6lAe7C3ZxweEUjUKgR1b4noXyfZbp8jDO9V2gg0g7cfsiuW93M3N+93BGJeJiug2tuFdLsinntS854x1pdoxfiUO07u2Y//Kf8IUPpC2pgmKdh6uFoQ5cXl2aoaiuFPSp6wdW0t3zkLjjxmuvv+MGnoaLTRpnVYw2yc1YO6YDgf0epWOjK1Eerw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ1PR11MB6204.namprd11.prod.outlook.com (2603:10b6:a03:459::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.24; Wed, 20 Nov 2024 09:00:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Wed, 20 Nov 2024 09:00:23 +0000 Date: Wed, 20 Nov 2024 09:00:18 +0000 From: Bruce Richardson To: Andre Muezerie CC: , Konstantin Ananyev Subject: Re: [PATCH v10 05/21] hash: remove use of VLAs for Windows built code Message-ID: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1732072401-15962-1-git-send-email-andremue@linux.microsoft.com> <1732072401-15962-6-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1732072401-15962-6-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: MI1P293CA0014.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:2::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ1PR11MB6204:EE_ X-MS-Office365-Filtering-Correlation-Id: a0e3abd6-6494-4af1-7989-08dd0941c4b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZmlZUll5enRmVFMxTFZsK1FCc3RQZ3VCd3VsSGhWSWFmWDNWaXR5VHRzODhJ?= =?utf-8?B?Vm5aaWNFWHVRd2VFMlRoVThKOEpRN3A2N3lpYzVkSU9saEJWa1lxWE9CeGNt?= =?utf-8?B?RTk4eWhqRFJlYjJBS3k2dUtNRWQ1L05jTkxUNVJoRzBlaWpoMjYzcE5zaktH?= =?utf-8?B?c29xSEtKdDMxa2lvS0ZOdVpSa0I3WXdvZDcyUytHNko3SWZrVFpwZ3hGVXB5?= =?utf-8?B?bDl5bkRKeTV1YmNGdVFuQlRDeVdCQUNLU0NLbWpYZ01TaEJHYTAyQXZEWmcw?= =?utf-8?B?aTlrWURmUnFQR3ZibW14QkFzMzJTalM5VS9WMXExVlYwdDhlNWk5VzZQMFNu?= =?utf-8?B?Y2IyRDdBNWVINGU4OEc2bDBKYmErKytxM3VnazdScnhORU5JNTJMeWVoTmpa?= =?utf-8?B?dGtlSnVnQlZsZWtmRmFHWnNEWEVOajRVdEI0S1AyRWVCaWpuMnlEeWJHdWp1?= =?utf-8?B?cWlieEJmM05ydkppUEdxbGxiWC92K2FLNm10d0VWUUFhc0NyUmozdXJIUWxI?= =?utf-8?B?WjFXeHpEV1k1QUYvanhZRE9hTFJjS3B2VklXQjl2YndGMG1sNFl5eUl5V000?= =?utf-8?B?NVNPdEgyZWZYNmJBMTZRKy9iRXVFN2x2dSs5bEg5bzE5MmY2UzVyWTZUSmRp?= =?utf-8?B?dnB5WTQ3b2hTL1pOaGxhSzBDNkZBOFhYZE1KN0cwbGJKbFlMdHRoZjRCM1FV?= =?utf-8?B?cGZicmlqRkpzTWE3Y3dFQVdiODVaaWVtU0FyNkMrc3BLZ3J0bFlvUHovcEtp?= =?utf-8?B?SStBZXFMdFFHbnVYZWt4eWtuTDNBK0JzVFh4VDF0NEs0dWtiMklwbDJGblFv?= =?utf-8?B?U2lSQ3k5RmUwR1JjWWtXNXAxK1dCUEZqQkQwUFRqUTkxT1lCNjRzNFNLSzNB?= =?utf-8?B?RUZDenRQQitmb0EyNk11Zlh5OWhyR3FpVFZmRHRNVi9Fc2NVSlFXcnBIZTBk?= =?utf-8?B?RVAzbGpoaHRseStnbmdnNkdKcDBNTkU0eWlUKzRaNDJPeUhoZjQ5eWpVV0Z5?= =?utf-8?B?cU9oUWJlVkZCb3dxekttMy9PeDZmSjhYRE1JdFNLOVZvbDl1MmN2TVpVQm5G?= =?utf-8?B?RUIyL2thT2s3TU9rOEtVTTJLR1kxR0VrSTZlMEdQVkNuODRqUWszR2tTUUtv?= =?utf-8?B?K3Z4UWxwVGx2V0czVmwydGRBeXphNGcxOXRvajNibFhBZWJtNUxSTUJIMlRQ?= =?utf-8?B?Z0xjcWk4TjBOclpndnpXSWp3NjRxWDVrMWJUNlhmVlR3SXA0Z0tpQkdCYjAz?= =?utf-8?B?ZTd0em5rNG9rQitxWUxVTURHcHhpRFo1ZFM2bkRTdXIwdTZQTGVaak9DNEwx?= =?utf-8?B?V1NwbXI1djlkbEhnamF0bE9MSGZKa24rUmlGd0FJK0FvM09yejZtV3FZSy8z?= =?utf-8?B?ODZuSGdaSnJyREpaMHpTemhyMW5ya2xRaE1jZGJBU281SjFRdDJaQkhuVzA1?= =?utf-8?B?TUFRbEZDVmIwT080NTlHM0NJd2t6YUJVQU1OYmluMUdPYmhzRDQ4VWoyYzB4?= =?utf-8?B?MGdBd29MZ1FLUEZlYXRKcjNKRm55MzN4UGdIdHdrZHpobmFWR24ralZKaTlP?= =?utf-8?B?M2luMTBXZ2xQYVVvL1o3U2JpL3RBSmpIMVNmRGU5d3RJcGs4bVMxTjFuM0VC?= =?utf-8?B?b0hneFNsa0s3dnNWeXhMWGZnMnJCZ21LVTNPS25Ndjl0ZVd5b0lUUjlGeGhB?= =?utf-8?B?cm52TGQ4MzBXQzB0ekNDcmJYZDlBeTVnVy9XRXpTYVRhVHFaUzVPN1lWVVpQ?= =?utf-8?Q?Iv8OQUXBiayLUHcoab7OqpTXOONagiWaykWSZST?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFlWRjJzSGtnQ1hka2pHdkNVeCtRTVBwQTU3Y05wYXJoSSswYkVJS01JcE40?= =?utf-8?B?cGxndHM4VUladUFZVUtEUGpZWisxbU1zS3BGT3ltei8xb2x4UXVCL2tNU1ow?= =?utf-8?B?YjlWT1JRQkVkaWlJM3pxSnZRRXM1WFBOVWlDZkJtdFV4enZpc2ZOU2l2aXJQ?= =?utf-8?B?Znh2TWdmcmx5SE9PMDBsK3lrUjFHNHZ0LzNDSFRkOURIVTE5NlZYTFpaeXFS?= =?utf-8?B?U2lmaGw3WXA2ZzhUN012VDNjM2FwUlFWUk1weG5CY0Nic0RWbWhKMk9kN1B4?= =?utf-8?B?WGE1SFdqSTRUNmJvaFg1VnlXbzR5VGlBRkFiTWk1eEtueDlNUXVCNDJZMkNw?= =?utf-8?B?c2xyWUJyVWdWcXhFaXM2WUdVMmNVNWNINUo1Vys3WmhOaitQN215V05jd2oz?= =?utf-8?B?cTFYL3prVTBod29kZ3RhZDliWFFiU2h5b3gways2RWp3RXJraWZKTzZNRGNk?= =?utf-8?B?eTAwZ3hFYzQ2VWgySFh3RVE5L1dPb2VSck1FSkh1OG4wZSthM2J5bThCQ21H?= =?utf-8?B?QXJUUjM0TThveFRiMVhZenp3R240VXRGdWp1YlpwVnFCMHVad1VsZ2pWYTZQ?= =?utf-8?B?S0lQdzN4ZExIUU1aNmFRK3ZVTitMMnl1N2xTNUZ3Rmc3TVF5OTBjUnRaSE15?= =?utf-8?B?RkoxMm52dUZmM1AwK2dIT290WW9KUDcveEZadVo0KzhYeXJ4eHlyYzJ4Q1hR?= =?utf-8?B?RXNrY3N1eW81WVdBbWJrdGYzYkxXTWNnQ1hkcGlCM2xGZURtczBUUEJESVRL?= =?utf-8?B?ODZFb3FUZTJoaXQ4VG9XYjlLUTdaVlc3aVNUWGUzYkl6VXRjdDBtZ3RlZ3lt?= =?utf-8?B?TGg1Tk1qQ3FFUm44S1dTb0ErbXVLWFdBMlh4a1MraDR4NUI4UU9vVkdyR2dj?= =?utf-8?B?VmZSUXE4S3lOa0FhQ0IxSm1zOHJveXFnMUFOVDJxdGVURHFGSHV6OFR4T0VP?= =?utf-8?B?cDBrSkJneGZvZ3NlT1pKbXlPL0ttd3NtNU5GRklzM21CSzg2bUFIdGFzYUlB?= =?utf-8?B?ZHJTMUdtUzJHeFVnaEhhT3QrMmg2Sldsa0lYclFaSzAzMEc1QjBWbkFnbFBs?= =?utf-8?B?LzhzVTRBSjVYYzJPTlpYdGhSUUxIWFRzVFg1Mkhrd2lGUzMzTE5lVWw3QThS?= =?utf-8?B?Z3B2RlQ4Y2Zvd2ROd1ZpUHlTT2svQmVwUVNLMHN1NXRSRVRBeWdrSU5uUjZW?= =?utf-8?B?bXliT1BKTFNacjd6bXJDZEF0b21lVEJYZkE4Zjh6ZndZYmk3ekNwQU5kZVNP?= =?utf-8?B?VUgrNnpBMTYrWU9KdXlVajRlM1hobmZiYTE4VmhUVDl2WGdqSzRRS0FnZUZk?= =?utf-8?B?SmZEMkJzS2laWUtIczB0c1BnRFhsU21tbzVZM09sVk8vVDd0MVBOdDRQbkhr?= =?utf-8?B?Vm4rajdvV25DTzBIM1RwQmRMeW54OWRRb25KbUFNa2tFM0FzTFVsTkNEU24w?= =?utf-8?B?TWtuckZtZWg3YWJYb2ZnUVl2NnNLWFV4SldOdzBza0NZSUxjUmFyc3l3TWtU?= =?utf-8?B?U1Q1VHVFbStvQzhTc3hOaUZQbXlKcnF1TGxkYWx5SDlQWERmVVJ4VG9zYklk?= =?utf-8?B?ZTMvcnpRK01tNDB4dmk3SG5rdWx0bHl4WkhGeWdRMTgvMnljV1dXUXpNYXE5?= =?utf-8?B?dmNZWEs3Q01QK1Btd3J4WXlkL081a1JBcWxKWXhIei9CR0E4b3FxOHFzbXJu?= =?utf-8?B?bWJ3c0paeEk3RTR2elpadDBLa011WWkwdzBSWElrbVB2NUthUE94OFVmendJ?= =?utf-8?B?dys0NXgyTklmMHhUSDRkazVuanRldWN1QnQ4TE16SEpZUmFpU3ZlNlYrdFo2?= =?utf-8?B?QU1aTzFtbFk4RnlnbzJjZUpKbWFOOFd3ZlFvSGdNOHY2LzkvUTR0ZSt5ZVpH?= =?utf-8?B?SWFXK0hZQmNrZkpWMml0UkNqS2JuemdiZkxJaHgvSTlvQitHMEFHSmluQ0Nx?= =?utf-8?B?WVNxdHdFQUQwSHFFeXJ0VjFRRWQ5T3l2VWJ5eExoU2tlc1Fodm5XK0pwZnNH?= =?utf-8?B?a1d2UkZRd1V1UFhZMzlxZ2lsTzBIWDY0SXo3VWYxVlh4a1Q1K0UzTklKeVVy?= =?utf-8?B?SkhQT3ZKVmtDS2dxNk5XeU4yM1JDTklLckVJNDhUOFp2R1g1UHlVU1NnSHlt?= =?utf-8?B?bnE0NldJd1lIaVE4R2ZNSUxxR1d1NW44Z25GblphckZacElBMGgvWWtkNFp6?= =?utf-8?B?eEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a0e3abd6-6494-4af1-7989-08dd0941c4b6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2024 09:00:23.5429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LmkP0gAf20IlVJpDeHgPBmO/ZN6GADJbwRwU6lBFKoB0dfNd3CqOC+jrjlT197gXLbii9+dis1ADo5bqBMuNL9LsVc/SUh9UqGWpgAuouXc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6204 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 19, 2024 at 07:13:05PM -0800, Andre Muezerie wrote: > From: Konstantin Ananyev > > 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 > : warning: ISO C90 forbids variable length array ‘positions’ > 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 > : warning: ISO C90 forbids variable length array ‘positions’ > > Both rte_hash_lookup_bulk_data() and > rte_hash_lookup_with_hash_bulk_data() expect > @num_keys <= RTE_HASH_LOOKUP_BULK_MAX. > So, for both cases it should be safe to replace VLA with fixed size > array. > > Signed-off-by: Konstantin Ananyev > --- Resending tag from v9 Reviewed-by: Bruce Richardson