From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B91EB45D01; Thu, 14 Nov 2024 09:56:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A83D642D76; Thu, 14 Nov 2024 09:56:18 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 942DB42D6A for ; Thu, 14 Nov 2024 09:56:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731574577; x=1763110577; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=98lqbBJN9jWgUzldR1G7Yk9cQvDgCE3q8wmFB3U206c=; b=GAYdKjB40gmcOvWWWb4YictpGfoATBT71i65Simz/UdkVnfottpBKdN0 /L3EYituCHBOVDKbjEqKNnGHjttDe5ahT4Vep6mn0Wk1nKavyOao1UOV7 SpbUa1jYvfKdol16ndG/NOZA4mYO7QP70dX7XhnF7p5AB0AO5a1Tg1mTZ DrwOhhMn/6VAJEzcLvITvlo+Ner8jEKXSEDjSE4K7OPgSwEbcyHzJt3Rq zmu5KwMZOH9Ak3d24CzRtrj0cvJC/onFsEhmu2/+HaD7MVp3yrk6RgP8U 4hy/4XsEy4fZaWYJnhXgQghGYKSbbzxxGcCqRiZ5364kfsOCjmSODn21h A==; X-CSE-ConnectionGUID: ZEhBesgBSS+wIrqHUm/MPg== X-CSE-MsgGUID: Tpbm5sk5Qui/fC0+nrtSRw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="31283055" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="31283055" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2024 00:56:16 -0800 X-CSE-ConnectionGUID: VFfm0EyfR8W0MPzKEtWtpQ== X-CSE-MsgGUID: v0/tnUb0RauUMx57khHQpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,153,1728975600"; d="scan'208";a="93085125" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Nov 2024 00:56:16 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 14 Nov 2024 00:56:15 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 14 Nov 2024 00:56:15 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 14 Nov 2024 00:56:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pGDPhFPHpw2xXTDbmTS9dW04HxDFP7n5OvIxZK7MmVVJKHp+r65ScyRsRHtl15/0FVKIW0gEgHLkdYPrjrMq4qpCmFx7vJPGV0na+exMSQZ5qg3Gfm5uGGkHtRCvbfyOznQ7t4BIiI1/IlQ0BY1pgKzzENK20fKZ5UJlTbGACqR/8iaqLrM6msK7T0Hs5zi4tGKcYAbnOuJsL19lDSTTx6s1uWDBba17W10FNA4s18yqu9jPL2wOSJ5zi8U8r6DP7sB5FW/8HslMlcjwH8hLSlwt9ItIF2xdNPOMkxenMnEtEATdNfDL66UC/ibxkr2fBMakZJGZ98toW54wsAFzyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CuCa0wqpseK+R5ygcBMDpq3U66UMZB+EmJr1a8HoDm8=; b=ZcCpJu6s/RAuP/IvmO46IHuiKY9YN9e8N9XYg2kzfTcrToTug6+ksx7S0X1mYk6f9aez8A4vNd4MGKzOJfxJzgwth4w1PEV6psFlXDOXY/mRjgr34nB7/+EgxwDrnsNqsVfexbMaZ+ji93wOUT7sOUQrOjLGwEJt6+mSDVP1PV/o9ZyUuKz6bQakgqKld5EtNxLfLkwsCUrPWi8e+Aur98AMq19SebHaL0PyxooHapxHc7hBkLKrts6lo6qhC0O0eMINhzpliD3vFd7d3g7Z79bnVhvcMvLTRnw7cS0cBcO2MkVbOwx3QhdP6tjducTzioDnHiTXQSmyv2SzbBBr4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5230.namprd11.prod.outlook.com (2603:10b6:5:39a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.18; Thu, 14 Nov 2024 08:56:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Thu, 14 Nov 2024 08:56:13 +0000 Date: Thu, 14 Nov 2024 08:56:07 +0000 From: Bruce Richardson To: Stephen Hemminger CC: Subject: Re: [RFC 0/5] Fix memset usage Message-ID: References: <20241113185720.28706-1-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241113185720.28706-1-stephen@networkplumber.org> X-ClientProxiedBy: WA2P291CA0026.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5230:EE_ X-MS-Office365-Filtering-Correlation-Id: a332a81f-48e6-4d3f-2258-08dd048a3112 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wbZY8AZeE1OVgBW5TauDLGI/uNW4nzD3arU4Swxh5WYEln3omBAj4x39H2NY?= =?us-ascii?Q?sDWQtNRTc1RfLJvXCdTpAQTirZmr1jJpILmldBJy80bKvOadt+GExOMsy9Z5?= =?us-ascii?Q?T5t4Sz2Mb95DFdCcU2zpZo8NhYMzhuiJvTtcsjg/QWYPvZNHr1CfKiDD7JXH?= =?us-ascii?Q?skrd22sMyd4GddWD2Y6lZbOBFFHm6niUQMHBv2+IRAe6GPngGtbn+kvSVdoX?= =?us-ascii?Q?MSFNTUJkR7PmvXy28/1WWXZEXrQso4IPUs+JoZoHVfnT2baDjxs1OA2BUaO+?= =?us-ascii?Q?zZzsDZz7ob+QSygtDY4vzgP4qlNmI7F14UwO08lYbEJ6Hn7PTrwwcLlnKfcw?= =?us-ascii?Q?ALsSZbwCakuc1tLHX5Idx8qAEGU3lylRxdoanx4L9fnc6pvlW01PS+uH8u0A?= =?us-ascii?Q?L9jG2grTcBpupOAo/M30J+qTADsjpAyazbC27p0ECE/Uo0dclwrQO383uK0O?= =?us-ascii?Q?VObi1oTG2UWg+6xBLFZAvZFQKukb648Th53p3MxyYXgOhZ4ntF5cNhLcHZWM?= =?us-ascii?Q?AK1Nf2CebL3eYQYXNTOPo/lYVJ81FSggIX1riS4xbk99OOcOc5cX0EFN5Mzf?= =?us-ascii?Q?QuEcAoiu6cJ4vC8qtKJUs6CKfd94tHzNirZQCeD7xVC2f+UI7xaGDXdbYA/w?= =?us-ascii?Q?+SYDj3YO6VPrghVC9qf3kNfJz4nfBMJ47d1OFJzVl7hq3bsl8PTbldCBzZle?= =?us-ascii?Q?LD0rwo2PJ+1rbZCjNgHdt983i5WO5C/0hX8QFReT4rVdq52BNEHTIGICyFWW?= =?us-ascii?Q?I03b0WhvIAxAlNmI6iWzfYImzYeQq4KjXtiV2CQrVTSc3rhFi2oKOo/LJgUh?= =?us-ascii?Q?Mp52KHwvOfwYaMkbrSk2b+nq7miBB7XVdgEG61vxVviBP48puOwfP35jJXjk?= =?us-ascii?Q?BqKqgdOj06bDfAQzQWDlMIXOAwI6A803Zq3MTiThhfSlgGXSvDfYaoZgOjhW?= =?us-ascii?Q?Y28yj7Coxa8H6+8uwlazpkofo62gnZXhllnur1gU0Yt9rvUABJ1/BL9FDr09?= =?us-ascii?Q?KO8C3opBiHAZ4xOpW6Xgvsdh4nY2vl3VTMq58rSi8WuKpxSNuB/uaTT2gSjt?= =?us-ascii?Q?VRt1hiSmN/kw8sF7S2/JdMMFWS0ZE35vmRrYSy66rRzUjhS5/id1J1EBCXud?= =?us-ascii?Q?h8hncfH/BLzQWD2L4/Xq3W4PP4pgG9pig4xwXo/GY/Ng0EkACpYPs8Ag7N9g?= =?us-ascii?Q?xkhemm0cPM9dMZ+D7AHvP85krdtXzFMj309Kj1ASj3NXmCr5/YcatzzOLBva?= =?us-ascii?Q?GJw960p+nfkEE44rwMIR?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yR1IlXGmY1BXC9xT/fi6S4/rJ3gXNRYYZkoUFWTGT6EWn80tn70eZ247efeS?= =?us-ascii?Q?8G883k5U5UI/haJrXZK0WN9Ycr669KaBjH0Ygpbw2AyoZC1aRISLnkX7ZR8Z?= =?us-ascii?Q?VilIIwSCQ5hnc9ztf4Nci3rO30TYKa9oyToaxgxbFKCuRCoDLAF4/69qO2t9?= =?us-ascii?Q?TxaNG8RS9JGT8zTznubxYWmucnEU9AFwfgvZerTvHg6M4E6dLXwbhJ+GbI6W?= =?us-ascii?Q?VHy2NQyYk9zeg4FIdiZOxUDS63Kti8V10dU9eZRwrdQj3i3nEnyHjKliAyxt?= =?us-ascii?Q?vAWr5yCGC9+z7bGMhNCOa3OTV4hwz8Il11GPa/CdJ7cww5hAoOB5a3nyR+KR?= =?us-ascii?Q?VrNwhQy9E6QlrpqTsF8WstboD4BHMAT9V4lZpRM8Bhdt2J0OMv8isfKXuBEL?= =?us-ascii?Q?g/A75t6EUmzNIa/uAKuOy+WNNRlMu6JxoZDx13tVHpokyhSTJHIVidsoSUCX?= =?us-ascii?Q?vIWKnDs/PrZpH9Nx906VbxhEuszptaDx/7/lCLfAZOls8xic3RXfReO7yjUH?= =?us-ascii?Q?tAKfHsrqb7kiokdeSMQUnXdmXVkW7WC12Mc3KVgJjFiCqQoHr3CFlTNap1NO?= =?us-ascii?Q?Qa7PHZLcD0AkuEt1kh1XfHVKbjU/a+2AlZc6Z/odE14fs0RSZ6sNiGWbvgyN?= =?us-ascii?Q?r67eWTOqbE/Qw+MGf+TAe8O0vdaD0LhVH+uv7XShdHB1rDR2jDHaWGq5LRtL?= =?us-ascii?Q?h90JdguS76owLCvKywQ2p/0jVmwNHm5cvKxbT+PCT5XkInygH+cFJQ+LriFf?= =?us-ascii?Q?p/3o5P2oq33A/x2cBk89TDPoeqAmDQgpRkuKCkw6pU6WXRpgsH2ru69Sh+DU?= =?us-ascii?Q?or0lcMf/k41LUrOI9NaNBCIZE2b7J8tCsAhhaN+QE1SaJIwLYR9wbQrb0LYj?= =?us-ascii?Q?DJJTn5gx3VZl0j5nQTeiUDnERuleDLWw6xKW8gmNauIMcO3xb6L18JxpSJUe?= =?us-ascii?Q?rCO86OJetKX4r0/JVkmfrsDR0Rc2O+9jB+r8f/ReBEweeXJndjLe47tWy0qY?= =?us-ascii?Q?qiGgRUFdITF9kN1E6kwcCxDx5wu9eHZb+M4Vlmi4MbqOvfVVwPIoXlyL55kW?= =?us-ascii?Q?atqQiJ/v5rltljesrmtGem4bQKVSNRDAu2e9qGdgg+/fq1Y1vup5ViTbhcLR?= =?us-ascii?Q?xbOFuTSPcAQrtEaVCoanoHdxQs5a4plpGNjdEJKx2i5U01JSGBDOROaoD/xx?= =?us-ascii?Q?TSBWcX0p5MXgoB4GMkdom01YuSmcM/BE20PFnWMhRPhFv+SGQ7zUdUTYNCVi?= =?us-ascii?Q?6+zVqOhk21jjqBT5X40ZKDWvgOXMTzNhW/HF1rMV8v35bZKK1qG6YpzLw64y?= =?us-ascii?Q?FVwBERXupPNeCscHafPNFJkxDJw/hxw16oJ6pncI0hSbg3KjFQxsRSOKcDOR?= =?us-ascii?Q?Iqps47QmXS6qMm8kjCl1i4B40zSWKL/scfMBNpdXHpmkhcjY/VarP7kEXywD?= =?us-ascii?Q?xS+0k3Ipm8oKGtETDpEXILRJSl3XYqIf1lTRtSrdn3zHZghyZPm+Hst8T95D?= =?us-ascii?Q?qUZ/JAvG3wcRE0RMfx5eNBveeNHK6MJ7IYelKTxM+ReQtvZQgwiEALnmwAD+?= =?us-ascii?Q?k4bPOiZaGC32kj0G9v4cP7oRmGtlEaGGRxN9jLQLq82DTogg2m7ybjxS20VJ?= =?us-ascii?Q?3Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a332a81f-48e6-4d3f-2258-08dd048a3112 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 08:56:13.3000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IF0T+zzioDkdWVR2Y2SruQeNU7koSq7SN7MpsC0JBZIG0eHeVq78deiC951G28DEKBIzanKS1UfubQcGih8b+QGYJ23D5wl79jtDyD+MRHg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5230 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 13, 2024 at 10:55:59AM -0800, Stephen Hemminger wrote: > Bruce mentioned recent security scan of DPDK > https://pvs-studio.com/en/blog/posts/cpp/1183/ > > There are some low hanging fruit things that can be easily addressed. > > Stephen Hemminger (5): > crypto/qat: fix memset of SHA3 state > crypto/qat: use secure memset > bus/uacce: remove memset before free > compress/octeontx: remove memset before rte_free > test: remove unneeded memset > These fixes look fine to me. Thanks. Series-acked-by: Bruce Richardson