From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BC2A45D0F; Fri, 15 Nov 2024 10:01:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71B28402B5; Fri, 15 Nov 2024 10:01:45 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id C2CE640278; Fri, 15 Nov 2024 10:01:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731661304; x=1763197304; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=5V+OZNq6kCpcgFnxuxx50CLIh46RJoKfMH4End80oxQ=; b=Ip097x3S/33o9+muaUxvevGujGkuFp7y+6h0FnaTuELP1oX4W2pLe+ce n9Zpw2XcPdlhSprM+bLVPb6qrGrMj4oRNktDhWpgzlEVQ01CRbccNrROX 8PK/8wxaaZQQDOIorgVWBM18uPH0rdXdasDjBuTHplKHpntTqCHicveYp UDtOYjpjJtU5S2SADJbB0F6AGnVDix/M+9RdqQtDRXxhP/u3LmBmj4Sqx FCx3vXdiFXA6wwbMvB1OqeMGhp7Kem2d24JFHhiEtzQUugLMBG/QaDh4R 8EiVZsVqYOrCf3lduckjcjvJbwlONC26CYjgB4GlfxLeImBhjyD1u9Mw9 A==; X-CSE-ConnectionGUID: ark62NKQQzCXDxNHusXp/g== X-CSE-MsgGUID: YHYJGm/fTKa+InFLOKllAQ== X-IronPort-AV: E=McAfee;i="6700,10204,11256"; a="42741528" X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="42741528" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 01:01:42 -0800 X-CSE-ConnectionGUID: aYMvOdX+SxWRXanqjiOolg== X-CSE-MsgGUID: xK0SL9+nSbqi2by7E3JOGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="88381351" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2024 01:01:42 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 15 Nov 2024 01:01:42 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 15 Nov 2024 01:01:42 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 15 Nov 2024 01:01:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pEEly9QGhZZM2YxOrHNUOl3f178E97m7lXUfYAnH5UPlyvsVV9/QZ1MP7Jf2NW287IJHziSgNCJV81jQEQoRnVRgSRy9J06KWK+G1fQoSvhXzEWnyv4wwt1u1yEPBlNi68CVsd7wW6Xp7TndknTpdV6EhK/9zogTKnVrhuAGK5g+ys0LUETnbHCG5d4kEqtQpAArACejXtpiB6W/GLcZhDulToPqT591whaDRCxdlW6N4tIsAOZzSo8NedBKaLa9bX+M6+Jbfq8VCIEfySYMB6B7BfxVg9CdG1n2Fjl8OOeoM2J/msY3i0YkVAheyqxFrCekKEHiBGL9JoR25clO1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/qtAbn2y5AvtGzD6u4KVbKEK4Sv8ZsW5HTxtgkUEAs=; b=kOUzK5be11NIqjfPIk31ar7q32oCsqTErBYXvZJmXqt6X+gM6b24aXp4JUr6Z29AVleYmKl27uTEm4piwPq4FuizWDwAHaCbgg0MW5bt6SCwEDI0Oy55ymo8bztP1SaVa+cVeaJIyIJ76NrdUnuShn+1rNxbU0bvehdhPta8RbhGHpL5eQfnOPCvkhHMYq1tFITBVbvube16Vm88DGF7KZUukxXLl+xNCiOVxODV1cnflhS2aMW/pFwiugQRtQMoC6iOgdXltb6cTt4j8ZqvGQCZaUa1jsZjgsj4YBfjsCR8GyeRXb2FNgf6tRqQ2JSn36NmD54+wC/OVirNjgWPSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8479.namprd11.prod.outlook.com (2603:10b6:510:30c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.19; Fri, 15 Nov 2024 09:01:29 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 15 Nov 2024 09:01:28 +0000 Date: Fri, 15 Nov 2024 09:01:23 +0000 From: Bruce Richardson To: Stephen Hemminger CC: , , , "Chas Williams" , "Min Hu (Connor)" , "Pablo de Lara" Subject: Re: [PATCH v2 01/10] app/test: do not duplicated loop variable Message-ID: References: <20241114001403.147609-1-stephen@networkplumber.org> <20241114192603.41145-1-stephen@networkplumber.org> <20241114192603.41145-2-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241114192603.41145-2-stephen@networkplumber.org> X-ClientProxiedBy: BE1P281CA0425.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:83::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8479:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bb46eec-f0e7-4f9a-57a3-08dd0554178b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zUk5IuD04JAbD99HSF//69GBoT3IT+QfV8KOnYySW2cjpCkkDqm0iAdGFLtG?= =?us-ascii?Q?igv9zU0m9ODBpjNNPAfM0UMbdTbCOIDLSBKimJXEJjmTaBAdIisgQMfTBbAb?= =?us-ascii?Q?NVtAeofLsASQg5pGQyLcFr2Ec6dPLJ4rObpxiK9QFZeO0CHafnNDrS7xmpzI?= =?us-ascii?Q?b0cUHV6Btu+ZSsIE18v8B4iZa9HXOKH/BqKn6nvaAJrqEGEE0adiyCorgG/A?= =?us-ascii?Q?1XS4QvbhK5q/fUx9YYGVBAdkb8ep1QdtHsQ3Mk2Eag0bk8m6oUPRMREbb5jq?= =?us-ascii?Q?X4i0cRDek5UzJfLoWEaIKneNfWYck4lfDewSPzNQ4zt1Jw0gU2adOOZZ84Hx?= =?us-ascii?Q?jVnVC5XLJnhm06WkfCsfRFHaV6iHRZ/IsLcAAohxbA0Hkd8FKL1gt1FCATnT?= =?us-ascii?Q?pi3WikSxFS48Zt5BUYL72IyD3yIKSckG/obBBHU5cwjoLfVd6W2DZun7419z?= =?us-ascii?Q?I7brgVmj4KWcj/V+tpgZK/rD5f/uH1nfbgkabSc+ew1Ih2uRO89a2tNQnJtr?= =?us-ascii?Q?Bk5WQqmDM+/hiDwB5cc30Et0l5tH9n++6b1R2E2PFltbPTxmkTZhYESeovmz?= =?us-ascii?Q?jkVMJcxukpb+IzpITvnNqRakmI3lHhgmGQiS8q0aNpOlGedSWKHRo2/JvbHd?= =?us-ascii?Q?8rgYdTaL05xN4hmNVMwSr1pM8MYblkE5zCo7Lt6DxPPMIbUWLJvn8VAxOIBI?= =?us-ascii?Q?6uAzmtl685CvgyKeA2WTK+AOfk/QDFfvg9eGqnQvMmt8nRf1rZslpyJtNuw2?= =?us-ascii?Q?lWJyErWTG3heqHz5UpnbB5u5tZCs3TfH8ttZKfV20nlu97+sn95woZQEPUPe?= =?us-ascii?Q?e3pT7fpk3+ooQKWACm4FI93dc+8XbdYZg3AvWDFhPjxFbfcOF+C4B1PiFAxL?= =?us-ascii?Q?M5HmMatFkfaPraZ+Bi1QmcDC5LXyDP3tL/Kd5zFaodrDtgDra5aH4+PtiU22?= =?us-ascii?Q?DxYqKQpXYKw4onFTBpJKQw/5Ik6GQmDx3/I5iP71PDTs/T9u7vGf3dYioTbL?= =?us-ascii?Q?5nsWnS5joMtxXqAWcZCmhgbLe4FYNdoEWajWv8ZZfMb1jHIQ+oIsF27M1+kI?= =?us-ascii?Q?ODO2FOzzoRo3Ah8zRziZzEXplVAxu+CaEirBtUqd+RSfW/bqWWIA5gnAD3+8?= =?us-ascii?Q?TJMBxdcY3JUq+wBkUpT7zdYp41fAfxO12AUjSE8Xim3ZCDYMu0evwflI86Xh?= =?us-ascii?Q?B9H5SHraswkmbFLJzyg10oZXawb7oQAI1ZMXYaDRIH6AYk70YjI5ulbNqXOc?= =?us-ascii?Q?VLt95VRm25sh2nn2XBwY?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Rbm8KT+2T+ZpxQGrZ3g4I3sKDp8Vd+hAHDpFODWu7ek3OcRBWs2xXfczs6r?= =?us-ascii?Q?zNqTKbariJ9gOeSCvEVyfglfgUflXnWekUueg3NzM7U1LNPSLECIKHgJ9gsc?= =?us-ascii?Q?f2RfrMyQXi3b4Hk4266jofG32LUWTUd2oiE4+hmsUz/dSvdT8kjAYdnifFP2?= =?us-ascii?Q?8DD+MbMWAP6hepfOnRcO03aqi07LdrM7fxz5IL3bkp38ujNWikofAgFyOo6e?= =?us-ascii?Q?iiPEbm1jY/oaPikg7o8/moKtI9s/XvUA304aNbONBh9MzuLJTHuflryt/vyc?= =?us-ascii?Q?YzYF8Vxam9/lu70tyxe9+jQOd9y7WATRTf4Qp5SBDI08Ex+KD20qNHStcuvy?= =?us-ascii?Q?ISiqkqgmFwfKv6xEOMpWIcgyVJV3IjV08EE12rX6sdcjpZkdEqVw1qJ8lx3+?= =?us-ascii?Q?Pk1M84xhqm/H2BmggaJIT7tmWUgoKfmbjpYZIzM0Fvi1aQdWKl6HYtrk2xWx?= =?us-ascii?Q?Fw/LxMKpt4oOvbkXs1nAIHWYqW6vSnHAONdiv1ixwkEQleWRzni8hnM34ZQl?= =?us-ascii?Q?Zt6g9yiVD2p5j0Zn+WfFVZEpr4wSyL/DJuMnZsRx4jGqibZv3YguThtSZCX6?= =?us-ascii?Q?HyPRE+8zpNyvko7vTZyrbFjnSvpxRiflStNMq081cipGqGEB1MsAcioZulcz?= =?us-ascii?Q?Uvn/S1gIhtwh+Mr83apgRl+wsHMNAaJjzATZDswdQk8eT3Qh9YEzmlxqCAjG?= =?us-ascii?Q?NduNuQ9mejQJN4H2KI8vUcTTHlxL9vlnk4zjs7n03l/asDXqqyKQuFb9i1yV?= =?us-ascii?Q?aWQLmqaIUYA2jvk7x+jbkJij+yuQWW+utkLZDRprZ525KpJh/RNiH3BtsgVu?= =?us-ascii?Q?6oILojABNwh6sUdKttqAaxW44w6CysYnRDF1xJNSPUXV5SHB6TGmXEHemgQp?= =?us-ascii?Q?k0P5OcbKpTpPScpGXc7Cv44J5rdD0VX/lVst619/Iy26k6/0PAXI3UsqV+HY?= =?us-ascii?Q?Y9mpu60iva1eeDUVZdqelQyF8o6zFVWFPqnM8iXeNhHOAI5rSXvRWN9+2ciP?= =?us-ascii?Q?rSdsZ8QXM1lGV8vz9PZLXpjoe3W+7UfWWdYVNEmXUxInCkalV9Xja7O3xbe+?= =?us-ascii?Q?mElYht8mxbOt6Ub62svcKNl5DYTCHJv2laEqvny3o6KQWtIRYF3AhV8HFvHT?= =?us-ascii?Q?nURbV9ObwQGb3N7zJTShgywRplS8x3CeOLJo1BxioQJJBmMUgD4HXZfzDuwT?= =?us-ascii?Q?sJ22DnZTbmqlS64VjtuvplLRKHNLz+7fWQHMKiljmFB/xm95oDhjJ6HbyppE?= =?us-ascii?Q?qztWyfzbmVQfhv4bGW0X69XIZfMUFnG972BQYcdD6Ll0J734HzY/sfYxYhtv?= =?us-ascii?Q?JnrxVZbV34ejHLUP/YY2DpgrqoM2qriBQsTUFcWvgQWZpviqV9CVbitGQHMa?= =?us-ascii?Q?PjmUPr8WPlnw7N9b6rjqYgX72/FPQE8oDam8W74BsLDDgpeBhpFFvP+tVXMD?= =?us-ascii?Q?jdpp4f06ovWba1ee+7KZCMGW9cJj2R3rzFR/CvbH5wENgth+KnEMRpuXwOtF?= =?us-ascii?Q?rGZaYtZ7sd1TvqfaHdAZ70l14jhf4ehZKepYIlAF6M+RCf1U7zt9xDLZaz7T?= =?us-ascii?Q?Q/Ok0qtRSQdOErWBJsorrEnCT5BimmiVk82IgIPrJFrqLgmyK+UBfieWxFTl?= =?us-ascii?Q?gA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb46eec-f0e7-4f9a-57a3-08dd0554178b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2024 09:01:28.8026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5OvCUK2xjtTwLWGGXCEbM8VDmW66Q1mwnNLepeKYjUbosob0X19/QDbCHvnV8lkXyLpnfyVSmZX3wgCZc673bCtLw9+bvLuQZsH7cfaRR64= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 14, 2024 at 11:24:59AM -0800, Stephen Hemminger wrote: > Do not use same variable for outer and inner loop in bonding test. > Since the loop is just freeing the resulting burst use bulk free. > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: 92073ef961ee ("bond: unit tests") > Cc: declan.doherty@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson