From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85C0B45D0F; Fri, 15 Nov 2024 10:06:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76E1242F95; Fri, 15 Nov 2024 10:06:26 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id B525A40278; Fri, 15 Nov 2024 10:06:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731661586; x=1763197586; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=5zcPwF2DeafrrE33HwSaBGvyoQ1oVlSybnFAHtwB0PU=; b=NOBX6IEw3oOQz54bRdhkfgVanLXGgjJ5bvlqqHzpXa2yjqOidLJJU/OC OKSNLJrDHFlGPLePsStLZEaASM0YamrKydpdTmu+HKQB9OsBSltqUGFnl 1kEOet14EH6uUDMPYknMSHHfts18uFHocP4uFCWQAls8ad0cDcLnp80BM KYFwIWNwNape5rSoCzFR3D65hTafCPHav6MCwLSUvOhsO6WGFcl2XOKZ8 iQYGtsKwHYFW3uIx0LAqB2p/EYV0gQujo/uPutiM687M3A0inrWs77dhf NoNQ1L+Wi2NVS+SM66enyXrcPFMEnlCFMGEQ+Q15YalKTWervQTowuhzP A==; X-CSE-ConnectionGUID: Medmdy4EQoeTrN+af3B5JA== X-CSE-MsgGUID: CCcLqsmPTde6hZbn+8MIWw== X-IronPort-AV: E=McAfee;i="6700,10204,11256"; a="31611979" X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="31611979" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 01:06:24 -0800 X-CSE-ConnectionGUID: HIvCcyhpSGiwqMdDh7UsEg== X-CSE-MsgGUID: AfwzKChRTPyuYr167X7nnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="88496998" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2024 01:06:23 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 15 Nov 2024 01:06:23 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 15 Nov 2024 01:06:23 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 15 Nov 2024 01:06:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vVEAjdO6vNC2FiNEYOHcBwMiqbN1k9n2bZ/1+W2WeJMREQxaT/7JYLKZAeRqIJvRzHTOMhVxhwgaydssumNzfhREfGkn98arCv9ofCUQhOCskwzulAhiFGUdSC6JdRzYKsjYQPiQ8DNzbyiCqNSN/gWYs431SzMoHrXltk1Ua9bcezsgt/fmmGf4t4dYagqwRyyXmxq/Xm3s2LEr2H1Oh/QZHryMf9Fu9IsdI0EGxRgiYyR+cc1OrNpQyjezPTdCZZ4B90V8QoE5DDGtsoY/3n2RPIBdwYCIvTtPzVurIMNnYQ/6v/TdZSKLhoCSCGRAhU8Odko+a4N18tsoQkYnMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKJKDVqR3448wmZrZcuaxHfDv2KZ+/gyQo27DULy4AM=; b=dGspQN/v4KQFA11H332IUir0MfbAQ07oyhQvLQq9nDxJwnWM64ACuixBlwZKMMT7gy4VkJu1PdCiE44+fgTN19yG0+zui6hWcA7ydQimFpeCZJkxt6N5ctpctOI9VQtWQGAo2Bm9U4CGqexHHUArReZEd9BT5SL8nvJbYIaFL7NzhqIzibVTUz4hnq1dQUrvl+V8oSlySxZc/S9Ptkr6+B2G9Ia/Fobsc22iZtnsreccXCXzT4pECK+vfsW58JqbEmpMIxAnyJR3IbpUCKdn341AIyvb2d5VACm7gu8NoT+kKSE6qGW4A86XIGWIaSFVOMB3C8jKSnflYH3Bu0ALnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8479.namprd11.prod.outlook.com (2603:10b6:510:30c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.19; Fri, 15 Nov 2024 09:06:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 15 Nov 2024 09:06:08 +0000 Date: Fri, 15 Nov 2024 09:06:03 +0000 From: Bruce Richardson To: Stephen Hemminger CC: , , Tyler Retzlaff Subject: Re: [PATCH v2 06/10] app/test: fix operator precedence bug Message-ID: References: <20241114001403.147609-1-stephen@networkplumber.org> <20241114192603.41145-1-stephen@networkplumber.org> <20241114192603.41145-7-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241114192603.41145-7-stephen@networkplumber.org> X-ClientProxiedBy: ZRAP278CA0007.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8479:EE_ X-MS-Office365-Filtering-Correlation-Id: cf3fccc9-9bf7-4295-4fdc-08dd0554be6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GcZi7/uz7ESWjes7i3FscaZtjLjOvyRdqNGPZ1d5InFZJghPDXf8K0DpK007?= =?us-ascii?Q?b6hQhPkyMsi2fOadcOWoLhvS0f3/JytxYvawDUM5+Qq2KDKxawZrWrhZy86c?= =?us-ascii?Q?X5NFYLvjFtvEyqlWITqhSRn2DQpI1/LRWENKbCjUVG8uI0ZRXF6pBcpa0uhq?= =?us-ascii?Q?OQu0nQsfwf1ZknsyYMbUIx9e6mzjo5r3wItD9Ycei2SB52716xrWTyxolzmN?= =?us-ascii?Q?OmffpjCDQ7AWaGUnr5/6JLJf1abrSoDyVP2aTxPChioPhMpVRWtQWUBiehKk?= =?us-ascii?Q?vcnqONy26gB0yu9OELOg0M3efcMknnQuYd5hHtvWkr3vAD4cPg7Gtnn0maKd?= =?us-ascii?Q?n/hFWa7A8XYXAeMYfk64NFK5cH3oIgtmzWQiP+CuCB+ak3Q7UQH2h1nhAHh2?= =?us-ascii?Q?QuUPVnfdj0BTCfnoMoa8ZgsmmNwVLsNYOA6d/iCfqRXbO9sSIbYWtkHOJLpV?= =?us-ascii?Q?dKzdjV0ECDHdhjksVIc36zcAykeUroRwIIBaVeLv9vFG7DTn4HXhOgDOhs49?= =?us-ascii?Q?yrCgv++0WgEjNPorZFZd7ZLnb7wNjoAnNjTc5beji1jfKzGfHS0XkLRyMjLY?= =?us-ascii?Q?fQGQhaUxvABW+rvfg4PvSfzIOaTcXIF9MFwZIiKRyhi/If6/G2xPfQhHMY+p?= =?us-ascii?Q?m6mPE5tbQt/vQjJ47AoIYsc8LLvz11jQz3iCEP/o6MzTTG4nrh+wmc8WzR/3?= =?us-ascii?Q?yNCdMQv8AApoCvJPemMowXJeyC7F+ByKzMSPSzzgvCnX/oOTkX0G18/dlWKy?= =?us-ascii?Q?zAE+B9EhGNk3BI+CzmhwAQ66uw68nEOFntURrBbbNvOaEyL5VzU2kyzSTDap?= =?us-ascii?Q?HIC+I9qFjAG1weC2NkWtbggWYikPU6XujwybbFAUniRcb1w02a/+vc2jtSyh?= =?us-ascii?Q?0/RHJkPqepNnEHOLNPDNGq9+I/kxgMMLqyf1kyIPpFTDyGa42mPv8LbyrSVR?= =?us-ascii?Q?t7WL70Vv6XLIMWt7Z93AXPFTxlnBoZ+jKG8ClwYvEFs62A1tO+eUNlvhbqQ4?= =?us-ascii?Q?mfO9GpCggCRUbpT/3liWAacalDeJ9fN5tLDGSv1EWe+w2MjOuJa0UrfXtT74?= =?us-ascii?Q?q0t+IIi9K8uO7RvDBqGeWRDUt2338hCSUC4RtNiOm1N/O1ll/bVViiEAgk4w?= =?us-ascii?Q?pblRCBH/wo6DYcAD/NQgx5IGrCy8iIAdwNYjmWqJn8d7faa1lNHsBs7ixK5/?= =?us-ascii?Q?+KKmpFSYBCbAdKM3vr4u0Xja40C9boHiWptsYjHUltKmUlPctI6I0q+vdbk3?= =?us-ascii?Q?sMDhxY3GTqk3ZkAzq3nJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Cz7hNBSPqzSl8yaun/AvBrHOGWPVGgSHO5IKm5MRBVNTRy135NHYf5D3tZyG?= =?us-ascii?Q?wihhC0RQVcp+8iTZxGBarxxk3ZMwrTVNfpXFTEejb9ytEq7vxVkerJ8R5COW?= =?us-ascii?Q?C6iY4H/uTrTMz1450OvAe58fPoZQ0RueXkMCRGE3uWumjRIpBnej264mZ4Y5?= =?us-ascii?Q?JWKs7GPvDSr/sIO6esr/fcHMSoXAIDBOn+3/RUP8GByj8wHHIarwUkLt2T38?= =?us-ascii?Q?TZKWXKIZnn8/GZ980RtyG+T4w/kvqPGpiMtthPAHioPywf8RPnqtuwQhfViH?= =?us-ascii?Q?73JSA3DPLarJ2lCR4ADO6Fa76pNz8fNOImvVYX2YrN92MxUW2hcM5M95A3K3?= =?us-ascii?Q?srs/ZInDTEIS+7Ug65QZQbRgase5dQOQfb/vq0TNmu0MpmCWay4NawtH3vyK?= =?us-ascii?Q?uDgdUylfWEs3tVz4APk3yGI3mGyFOMfM0+FBVCmDX/CSsPW8nNc4PIefRF8B?= =?us-ascii?Q?bFvJVRzx7/XUs9nfofj4pSR0GJTYyjjWHcuypzcgbjgJ+/5M7aq+0ruVijyC?= =?us-ascii?Q?j4IZJEDNGZS6JeLQX6n//Rrm4WtvV73tO/j9Q/HpvxoQjknnaCjqIOc5i4kL?= =?us-ascii?Q?eUzNoZHLufLIzrt0Z54hVy0ivvLvAX/NG4hvQo/8RKX2WoP/UMKVdZwJ2wl3?= =?us-ascii?Q?yh/gF7VsJKVdAZ9dG3mUnshJ5AunGtlL+HKykc1CD2+yXNAz6zR6j2WUQZ4J?= =?us-ascii?Q?hH7jMoD+vAZ82+d7QNsQ3f/5cB6QzjiIxJfStwurilUSjuoKrCZBAQXiXjAY?= =?us-ascii?Q?34wxfBz8sc93AibZcv4JPpDyAai+a2KCFfGI/seBIgCV3V+gp8DL7ksT1pUd?= =?us-ascii?Q?s56hesBhCzUhkuxRwIAjwvHrzXOZAJ8a+tLPSRZjGz62x7M4NU4pVnILPL2N?= =?us-ascii?Q?fpKDxsd2tHhxn0y8NUWr9lJ04pFadRnCoU9m61AyEijWGZ6j9Pnh79/UkKSQ?= =?us-ascii?Q?O+QLlKpnCx8CR/spZUG/BOrCyAJ4rB5F637X7n4RDWolyRKscWjtNYksetg9?= =?us-ascii?Q?s1mee0IYO+GVOfu1OfSEYNQS5eenZVENFsN2BbQas066RoALI5UQdXI8wEEw?= =?us-ascii?Q?vEWjue6dcoiZ9yyIyzKF7Rr6goJQaWWujbhL20v8iNnT6+haeUajBsmubbm5?= =?us-ascii?Q?JlLeEXPTaxSRsDlmYUQebADXL5l9Ivt8MZ3Siem8Hu3INETSmSgundw/KsRr?= =?us-ascii?Q?PDfu5stnDnajDUnG3UZEOKYnq05W/R5+GWxLYwWtzy1RVRpkDRcIr47NU2Z2?= =?us-ascii?Q?CJTOamNfTb5lip1AstqF4widfsriBuO7H4kZIZv5P3woFORh7fFM+eLWeTQk?= =?us-ascii?Q?Zvlj5QagkrvFTWaYv4PGM5eUpDG25du6scCXiypObOhbrVoO41GMRJ8TaA3x?= =?us-ascii?Q?MfRPyGt0N4PoABvys/zjrcMGUulMfjsamxzc9HEmejCFgprL7PyiTsCmbDtV?= =?us-ascii?Q?a87gzRBYGMRcrkpl7DFoJIJr20LjhFtskhARy+z6RI45JH1nOmYMgL1NvL5x?= =?us-ascii?Q?UkO5wTHYSoTnBSsYbJ9nAjwX4AF3QiRMCLDXxFMPxg1T7oOULTLkLa1cZMJz?= =?us-ascii?Q?ScWznN1m+6ztFv626jdYyp2mX86jH7Im4TDazfoXuKROhMXdutUXYW9DnCuN?= =?us-ascii?Q?hA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cf3fccc9-9bf7-4295-4fdc-08dd0554be6f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2024 09:06:08.7811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8XfEtc5+LAQiHYiMTypJOJ2hwkVc7rit+Lj8rnVnW1nLr+97dET1Ctj+3NrhohXUPr6eI0Eyc5dUpO+6MLgFO75RyY/ZB3+AI9+5QhJ10tU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 14, 2024 at 11:25:04AM -0800, Stephen Hemminger wrote: > The test loop was much shorter than desired because when > MAX_NUM is defined with out paren's the divide operator / > takes precedence over shift. > > But when MAX_NUM is fixed, some tests take too long > and have to modified to avoid running over full N^2 > space of 1<<20. > > Note: this is a very old bug, goes back to 2013. > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: 1fb8b07ee511 ("app: add some tests") > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson