From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F017E45D0F; Fri, 15 Nov 2024 10:03:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9CC6402B5; Fri, 15 Nov 2024 10:03:08 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id A179C40278; Fri, 15 Nov 2024 10:03:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731661388; x=1763197388; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mW3d0Ho/v5bnrxgTrmUbNqEB/mwrqE1JP/yYGvqKHB8=; b=ioUgRsJTVmspRuhECj3Fz7wjN95+eJjPJoNkHcenLMysXztBcGkrlg84 ECO/4N1s1Aac5y1YGJTjvoubHA6eVLXlwARvlg7cPDCRLwl0ShNCEWOKe QFZoyyg/9fL2+WivZUHVTOwimNhfdbJq2v0NSjOdj8YDP7arPSXWJoPBw N5pF/BBHOMv5mziihcNpPQ0MwdkNNtPM8+ccsikuZQ0oQm92bRjR154pr dXiqBUoRC+SS/30ReifFFDasQTypm3Z1QhJ6PTjm9j8b9q9ymUIvcpsJV IX8aNyyMBvVhW/N5g6AQ4xtzZ7TQS14l+EeyJzoioSHnPCbZ0LtEEGHUE w==; X-CSE-ConnectionGUID: xjPz0+k3QxO6yiBspDc5EA== X-CSE-MsgGUID: OYXNKR3nRFKDK5DsnRJARA== X-IronPort-AV: E=McAfee;i="6700,10204,11256"; a="31796117" X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="31796117" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 01:02:49 -0800 X-CSE-ConnectionGUID: C87xJmjCSxSsA1uKg/Zh9g== X-CSE-MsgGUID: PyVUo9BnRFG0tuzWzT7V+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="126031788" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2024 01:02:49 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 15 Nov 2024 01:02:48 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 15 Nov 2024 01:02:48 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 15 Nov 2024 01:02:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c56L6Gn1EEVOH9yoHC3KuieGKVOd5GCM9wCeRI7k9DqwZJOXFsGBr7SmS04Q+kh4AwokROG0C1tOXbODUCOeUXm76dz2JfejXlu5TXTRss1kQwFNlGNvfN340DOhy8kltKIET+93t3haUNCuAMhcK5s7bI3gLxrHkoEZFvb1mwEpxSRtyviBJpMZl8Fnua51JOJKQT8udi1aHRT200U5wNqwyUa4iNzUmVEzAiPGJcMZNoQ1xexf0bt3/LuA0P0bzC2ojJI6/ibTsdXcURpXzPF7LdRMNzhOP2vd9ppYblhXfDiC1CPrStIBCUOyCeeyO7XS9gwE3ZlHH7/O2QD3iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=inhi74lGsjxrYtXVRqToe3nXMzVW2WRmiNlgZ+76DKM=; b=Llb3AzUlQo8U9aO9ygjKKy4iiSC2e8P3aPS9pIGZXdAwV2rvEuWaf3Me5iPzveadeEQkAU1Nx7ITU53HJ8uHT/ETyuZCMYCadx6n8jBQyHEgWNAetWAEts+gyUEF47MBC3O0zKmW4M4s77SKZsns+Fd/PaaeqAwi8RDQ79yyN8WkVj0OM3sQdbapTQtGDf0jGtKKvLG23v0vxzmdmSo25OYyQHVH8aVdci3VDHDT0lDI1ZALB7Y0k/N3WHiikilyJfSn36UlE3hiCzKewYj7M9sMio+YYbqMJ7x9jNdN8zqWIMHd8wAg9tXmwey0Xz6FxFE2jUMC7imHgxDUoy4xEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8479.namprd11.prod.outlook.com (2603:10b6:510:30c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.19; Fri, 15 Nov 2024 09:02:42 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 15 Nov 2024 09:02:42 +0000 Date: Fri, 15 Nov 2024 09:02:36 +0000 From: Bruce Richardson To: Stephen Hemminger CC: , , , Akhil Goyal , Anoob Joseph Subject: Re: [PATCH v2 03/10] app/test: fix paren typo Message-ID: References: <20241114001403.147609-1-stephen@networkplumber.org> <20241114192603.41145-1-stephen@networkplumber.org> <20241114192603.41145-4-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241114192603.41145-4-stephen@networkplumber.org> X-ClientProxiedBy: BE1P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:67::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8479:EE_ X-MS-Office365-Filtering-Correlation-Id: ff8f3ebe-f439-483d-b4ef-08dd0554437b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8+pp6RFj3ElwcVt5EwyMisysiaAKMrHmxJ6lJH3Cy7IJ/HedqtLwR6HQSuvQ?= =?us-ascii?Q?rjtJtWDnR2mi5YC6MBvzm/GllzVlSTj0oKzPIOIF/rwdU72ElJxo3nE7SlYK?= =?us-ascii?Q?PZh0jUB6shiTM0DyLhkzB0K04I2HbHRguDrJoRtBXN4eBDOsUV9bAQTCspKs?= =?us-ascii?Q?qlVvVfT0ebTjiKPjCDIWPwOPP4BRM9pVyqEHsn4AufhsiYSPpz7QjPj79ACd?= =?us-ascii?Q?IF5rhxAtijbFerHrnzxhfTmdPbyEYdriRIF/KIs81zAcplBBMF/W2+K9uLrP?= =?us-ascii?Q?vYpGFdYnAs1FYD8VhibuDYy5WEKBZxTr0vS938ZDW3LDnnwNyorJkDYW9Ier?= =?us-ascii?Q?kV9a/P2pK4DSMyiKGL8WKTNuAfvQiPt0AhxdK7TQy4RP+qEhHeDlcSMC/mRI?= =?us-ascii?Q?m8BHpKs/SCXH+lzyQ+3PI73bld0Fjbri/7klbzvT/jtmcFzs0rMLe3kuNisn?= =?us-ascii?Q?2OCP7ZGNCyBHyGJs+A/V+4Us4Ftj5Xcoep6Qsu6G7MeYEEx34gmJgf1ZBMF2?= =?us-ascii?Q?Kh1c5ASs1H2yyAuhLU7F+iTy8TaCntsuRYUL1HNErTeune1gZA+KBh7rN3Rd?= =?us-ascii?Q?Cv3CNnUzgTiaYs8y+N2cnk/iR5WhDac8SfhQ5Cg5PlTX06xeVvkc5lTohZub?= =?us-ascii?Q?D4rkStr79Vfqe1zinHAC1ojZMrLY1y4tORLFSArE5uhS8OoSVlCvjBQW4TlN?= =?us-ascii?Q?H3bG0H6AdtNBMlcu2cRfTr34GCdapGW/EIrxyaB/3WxEFoUS//d6CKDsXt/F?= =?us-ascii?Q?q+G52OK/6BsE25UcwWer+JOHFoYNezcuvv7i/XJ8gtxEuaFrfqQrhIUPFmIg?= =?us-ascii?Q?jIX1xVe21dXeGRTO0p4WkmnXKt2gxPV98rvUxCqKQKb+NT0+FHB4dMjNZ+6l?= =?us-ascii?Q?PXpPcbDxjTR8triS9b+mL113KOEx1A4E3hjx6TU/+6iY4oooXNzDbggg+pVr?= =?us-ascii?Q?QV4s7PEbSujT7jztGOKRlzFxIHkECsf7Md9rJ3H+yB8BIXUfLeJRsasxF053?= =?us-ascii?Q?dJpUxveeH1ko40OPRbJerUciAjTJDzv+VhNHvZYU0xFZiSEqkLKOuyILGdP+?= =?us-ascii?Q?7vZhkCLxwF2mYvpl7hpzL1dBwpVBWf6t+1Iq8xLkF0ZZsaG9LV8Zp5nDjHYK?= =?us-ascii?Q?OIOzfhJKxic1dUiOIlLAaMX/3KUrq0qXdl/29yhDcLNBQmFw5EGLUCl14De0?= =?us-ascii?Q?6F7zgh54i/W1HtwzBoAof9NQehQkleY9Y3RmLdCUnVPOYtfq/q4KKXwCLikZ?= =?us-ascii?Q?KTxiI1i/NgFwMneKfqwv?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aDJze3pWYMT2vxVgFI8WZanPvgi8Icmok2BGoC4CYYOIEeVcKG8/kohOAB/H?= =?us-ascii?Q?Q6MyOFSs6c1tvwUp+v39wm+mTPe0IIUBd1fXpkkBZ1AigjdA8s+59VFn9fos?= =?us-ascii?Q?vAGYhiooMiwhGer0r5CV5/74kf4Zw1+fzWwo4ND2/aBLSH4AwONQM/epI/eB?= =?us-ascii?Q?zqUGCSwY+J7dtwHOtmBdeoLUV86H5mzeA0t3SLil4m20vR1C9JDrUxPY/4SJ?= =?us-ascii?Q?RVqY6g/TqVVjNbIpvmPtYk/TQ7MFRT+WgqT2E5oXX6w1hMwUIY3StjzhZfnf?= =?us-ascii?Q?k7ejoO7Xa7gqQlmGCkfA5S4261bybYWu/k6K5DvY0i/AgejE0EQwMM0JWhrI?= =?us-ascii?Q?uyTXcggCvYJZbrlg3aWZ9rI9YSDympI1zHZW6XWybCYYuzH8tB0x+dUxSEnA?= =?us-ascii?Q?PW3iPpCKeSSKtPyZBg+Y8DQ7y89beWyozPdZjw1XU7qiAySborMj2Hn9AIFn?= =?us-ascii?Q?ml+aANbzuXjHjDBZL56gAp/IN7h8xIWAJYCnC28esSIxWgrDvwf/GBI6T8lx?= =?us-ascii?Q?PVvtNG4E1HM+EjkUuK4SaNQoBAkD3ggZSqAymgNxi6MOKfLZwcH26T/1wB2V?= =?us-ascii?Q?UhLrSI5ZY/P1I5YvR5Q3NF3MfZKJ7PldEaWiWxANTvA4F/vEDCtPfRys5kIn?= =?us-ascii?Q?9ONW3Oa3oxhIm00Q+c+448nnNuCANxPSyeusIc8AFa72WXiEbX6F+LMTz5ln?= =?us-ascii?Q?o0609Le11RfuUDpmriwDV+a6rUH80lyX+f4xoosqct/qzphrxwSO13KY+S1O?= =?us-ascii?Q?p1rjFuCwr8Qg0T1KV54LDW9QN6EqDutqan1HrpNODWTCzsCZlgO9qaEs4knl?= =?us-ascii?Q?vTEQP8+EkqpJpIzuUiOc3Qvgccd4aJTQWK5SRMF3rBiWBY7Hk62qfppDh/oN?= =?us-ascii?Q?NHbPngoT83v9GYOWkyhFNyXJ2z8euULG/vCvhYm2DhCTwLRZkxZGPq+MC/8x?= =?us-ascii?Q?fki6UGKmxJvYShDdEaYECJ5daX7xQNfK8A5j+vYdMPxkfR2Gzq1kufeJTYFT?= =?us-ascii?Q?2Jl4vB7o7to2n636AaiIzwTdWbg9m20UZhvdSMQ/MBvaDGavvMjSDDF8lC46?= =?us-ascii?Q?sXV7zf4tZZbNTQYKvJyx2fRvoJG2+OoM+YVhmXHAOUU0rC3tIOaJ4RB1FMF8?= =?us-ascii?Q?no8UKr6kSkHKJVunQYhSNmsO2pXXAUykqJAJLCx+XEPYl1nA/S56NKIyJ+ol?= =?us-ascii?Q?piGwbI1HIX6NABA9+2EVpMxlQPhRxjQkVdp1ENh8hCF0c0LlnaPniNY9GnIk?= =?us-ascii?Q?xxV5UeYDX78odYNgNay6HRKkfCXBogMf+O1+AupAqE9owNt6f2cUL34uLPhF?= =?us-ascii?Q?WiMkIzSBSe0XEdiF7JF55ozt0pRy/bSeyXgqihaAS2iBWBSFYpr8Fec/iNYZ?= =?us-ascii?Q?tLhR7IpbJURL/eiaRqequRIarzgo7ADGDCSqIWC62++dAv356TKUx4aUVTY9?= =?us-ascii?Q?2tiCy2Ga6FNzDptVK7yrN5RLpP4znrqcwl7GeNpn13ngRw0IB7r3KiOXEHIJ?= =?us-ascii?Q?IIcyYhDIY5h87V3mBwCpbBPiyikcCE/tJK78uQnhwGd+8txXXdFiwRtoCAmr?= =?us-ascii?Q?5Az+mWB0pCHGWIy7rrrJiGXHwyXGXEdAq4TqGY/ZmCWQFSEHZ/LSm5ukWCUv?= =?us-ascii?Q?PA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ff8f3ebe-f439-483d-b4ef-08dd0554437b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2024 09:02:42.4871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FhYAYEyFLWBf3PYGekOsmTdmy+z/at7UhjXjYw3svfHC4NvItVF2/PUsQc/taHbg42R8J/880oHNoTwAPJXpJbHeb981SO+I9XVpghXs/ZQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 14, 2024 at 11:25:01AM -0800, Stephen Hemminger wrote: > The parenthesis were in the wrong place so that comparison > took precedence over assignment in handling IPv6 extension > headers. Break up the loop condition to avoid the problem. > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: 15ccc647526e ("test/security: test inline reassembly with multi-segment") > Cc: ndabilpuram@marvell.com > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson