From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05E6245D0F; Fri, 15 Nov 2024 10:04:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4E2342F87; Fri, 15 Nov 2024 10:03:59 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id DAD8F402B5 for ; Fri, 15 Nov 2024 10:03:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731661439; x=1763197439; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=qANM3Skusy8dWyP05kEOEzM3I1tHcQSFmzsAyDiCj7Y=; b=XdXL3DJISGnzRTo57cV+cVeRlqEyNqwEsRTwJQU4lyDLyVvquMbTKzg2 LV1Pc3Q5RHY4qfZAZThSqZe5SbSF/KwtCSoodNTAmbM1OCBnMSVF+wNuB B/V09vSdVW52cy450I+ez+yYyuIHnBPCwtVB29kHTEgrUb18vXEAyv0JG ZmTo+gXyvohGv8p1D8eXp+kk3piR6qAUSKseWmgJ2QbMVVx76Pvhn0W6u K5oUVkWH9mpVCfRKBmFgl0dCykWIFG15VYoTdREhM5q4Djdbhclo25oRk F27VhV/Wde8u3s23iI5/I2bzwygq3GsDCzFgsoRC69O1WKehvmFLtr14H A==; X-CSE-ConnectionGUID: 51bTVaMeSaGEJieI2zs67Q== X-CSE-MsgGUID: 2wcEIdUcRNeOe7fVtXBFQg== X-IronPort-AV: E=McAfee;i="6700,10204,11256"; a="35350828" X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="35350828" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 01:03:58 -0800 X-CSE-ConnectionGUID: IlM+7ZlPSNacPRYSwsv8Og== X-CSE-MsgGUID: a5xzrSKET2qPJVcajzBRlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="93456045" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2024 01:03:58 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 15 Nov 2024 01:03:57 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 15 Nov 2024 01:03:57 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 15 Nov 2024 01:03:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W7g37t64LFzODk3xwQsB0FwkdJa5f0m3C50A667X+qUEvG+lbxSvxMAg0IMUZqncOjY1Q6Ed31bsRA3Ncce4JcJQ2VEXmNpS+zKMaxkn8u+uqgkJNMEvx1+Nzgv5XU6XW98g4sTJtjeGVEATpySj2Yw8ifq7MO/ToOSweJ6AEakaDlU98dbfrUHcsD+jAojXr4P9LVUorqZXaYFzrMMn0ha8aqCH1K3FuWdRPJkctcZbu7LvZ7JCOrfNzmUCejOWuuED0nxO6G6gLhlDR1m9dDSx6xaLBUgtoZjV5a0ACQLTo/ZmATI74/t5dHoP1lMBJjWVZqe7o7gGOfuWcCudUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5FF7iphgiOfNBfd1tQvc6bov7ItnxMG8pJ59xPKatB4=; b=DfX4ML6Pj9m02hp1kuHyet5z7/jX0Jz9m0/Cvh/+dZro2OuNYmW3KrA/7H/vRbIPgGK+cxdnuW0KZ1GW67N+Xuzk5r3bDvTtthntiWkPNUhfDL9jLF5uvUC9jtANTKFf749xAD1AYKXL8JWM0J+yenVgEyt14lkXdbk9CF5gS/KBEgqF3Eww67r/8QuAFSk9NLrKi8KE86HKuyYItQoyozZ5Isv0qT1YNbzJR2tUcFs22ehJ3x15neF4IlxnfMRw+TCOujjryr5t15GzApt1ibgi7ZBL2E7peU8Bd9tjwgqNM5/dp1svTYp8Cg4IwMJDPda+dLqEYhmWiTPdkBawzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8479.namprd11.prod.outlook.com (2603:10b6:510:30c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.19; Fri, 15 Nov 2024 09:03:47 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 15 Nov 2024 09:03:47 +0000 Date: Fri, 15 Nov 2024 09:03:41 +0000 From: Bruce Richardson To: Stephen Hemminger CC: , , Abhinandan Gujjar Subject: Re: [PATCH v2 04/10] app/test: avoid duplicate initialization Message-ID: References: <20241114001403.147609-1-stephen@networkplumber.org> <20241114192603.41145-1-stephen@networkplumber.org> <20241114192603.41145-5-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241114192603.41145-5-stephen@networkplumber.org> X-ClientProxiedBy: BE1P281CA0299.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:8a::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8479:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f67dfa1-a4dd-4e97-a569-08dd05546a1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DGjJuXJl+6icGWkzwy9JPG9eeQJbezD+KxyzZM0/YgCIdJ145HF6BCANyP9J?= =?us-ascii?Q?byX/XJOW7EqJDhVaTMNrO5EAVlrIcb50V8AyxcUFz6edS7rK6tvoUXuQnnME?= =?us-ascii?Q?nQHcqP7iqSbAIND+7PJBBb9W8aj7TMrtq+8b5BtBoY+gZVQk29rU2pkzm7fR?= =?us-ascii?Q?UF3PdIgcGleklLzXmRGKARkh5ochlULMzow6e4W0br9CQkPZmcr61t5Da53v?= =?us-ascii?Q?AWDN3KUnkbQhmo5CKZvEgONQirulIyGXN9G9WD3hnhWxnWtoq/7lr5QU8lIf?= =?us-ascii?Q?cPezicGa7cK8lBSg1S327NGJETqdOYt0xxz1/tzYeb7PIjJ5rtET5SpvmImi?= =?us-ascii?Q?nM5zvsLmtWMHNzQEDqkDnQsG93tkGA3go/pcXnsEiffCXzwviDH/Dfa7LoFO?= =?us-ascii?Q?uPYmbmvjd4H/s+X0dIkwRmp+EOpedRoyk4xE/0Nd76c/pVW+6rAkoMBpQvWq?= =?us-ascii?Q?mnw2JHN5oMqvjGdCIQ4jheW+khTs16vztgJK/fT3MGOKVMQpU4HxO4ThCxwY?= =?us-ascii?Q?i1LGWDRCkW15MLR6/S7Fe3f3ro8vqQ4hFI6TDAmgAHzhA5lcSQ5lmdF81H2g?= =?us-ascii?Q?MvixZyOPq2K9P+I5DpNp7LVuTZQQuLaC68q1+tWhwLc7OWVIFZ0oWJydp9mS?= =?us-ascii?Q?bCorbThur6mFwPZ4QTPwnt2maCs61z+vpzhNW71yv0yUzdBUll5/YJUoZYMI?= =?us-ascii?Q?FZj1dCbJB0vG7ncbY1CBNKVSkKOzgj1RceGiN8ghyBJPjjuIwESA2cztrq8E?= =?us-ascii?Q?dJ/QhHf5OZOiFsH766i73MfNOvTfGMkwafW6oMnwcjbq5WguUJoW8B0i82Nw?= =?us-ascii?Q?OsvGaf9zfWjjnIdVtulI5gVnp1tZ9WnQEb3jxe/ENqqcHKqXplofYdKymaLO?= =?us-ascii?Q?lMopChliprw04+bXXpSX6C31xDr4t55aOrJTT+SiPHi054b9AJcE5gKE6VsE?= =?us-ascii?Q?zccEutOHcZIQX91xSGkXPhUggVhqHLZ2FnaICdV+J2YVlDoOW8pJhK58Xieu?= =?us-ascii?Q?6qD6cBf66cat1rcJ/jCv6dOkNxgZYGzuzWKbz4zQPp7vxUmzhT51uTMw/2rh?= =?us-ascii?Q?m3Mh0g3Hu4dcQb1lXev4WHCYcqa0WGCnqswUby3OJujxVJAniamH1p9/jeEZ?= =?us-ascii?Q?rQLzxSMtO8ThM1MgRinqgUzZHN/t1iaU6peAJS6hWe2nL6g1tOy5jvw5U6c8?= =?us-ascii?Q?lFZK4gmkF1bgSE07fHr9hO7EJNP9Ekd8lnfC2FH4Bhh5Br1g6WybhddH5jmp?= =?us-ascii?Q?FG5E+8Np0jIhj1lzeuvU?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IUDsb+q5ZnA3/1OFeN/UTuN3vZnU5zuz7IU4p0+q1us5Sdp3+PFr8cTcNsOD?= =?us-ascii?Q?Ytp1l7EcryVd+b7g5p965j68BIdngW/hHWGNuPXg8Fa+vj3l+zPm2EAW4po3?= =?us-ascii?Q?HQUzfuVwQaTvv3okg19PIFxeXNWaGmubfA0uYeFuSsFZsPMlZPbLdBMyDpnU?= =?us-ascii?Q?JS8b+PPetzk3sVd0Vl9gk7R5u3qNrsle3J8ODZJE0lpXR6aGFlYpq/TFLPM2?= =?us-ascii?Q?ZwcEKyQEJy+3WLwEF+J78rhhTWbQoYesfldWeat8LuzuzgNJdz4SoxQob8Uv?= =?us-ascii?Q?VvRv/H4c78bjonHkkfPWnYCB2+Kf7V43R82RzstcmCLrXBhxPt0MJMwGxqD2?= =?us-ascii?Q?s/QlXhfgxH9g7lXDkUbpRuXqR1iGsuKCB36FpaputxgRuP/0Z2PbjD2axL+4?= =?us-ascii?Q?Ev+t5UogG8dJx9QzsBeuIOFqQYwCMU/E+rzdbGPgff+YJm1vvbatH7MO4iCC?= =?us-ascii?Q?SqPnoeC/Z7LgjYauAGTuXfgDXCDWITZnTyLOVnO8LOPOMZm1C6csaz9F9qlU?= =?us-ascii?Q?7P5m7L9Ow01dSdb6UWqW50wakBJU5gxNu9cQSi1ZP4GQxlehnbURzsP4ab7R?= =?us-ascii?Q?APsafUN+UCCQnJnvT3hfhsO6PEdgMb8sebVMtTwGvjIPvnN8glS2hbOyOSNA?= =?us-ascii?Q?5gICkqXwPzS6r44Snz2ODgzl2EdmOj5iGXP0Re0phV1tx9hmMTkSZnq/L8U4?= =?us-ascii?Q?Pgyl9xH7c63TIN40dV/d5wiyag32nuyzXetGMk/q/Qn9SW1lsJVq+V2rLpcr?= =?us-ascii?Q?H4A/al7jlbjROdsGtSuHAGBaQnx7g+yXoehf1kSGj2MiWVIA+RjCrsJFQfw0?= =?us-ascii?Q?3sUI82hNOrEwTb372vTxwfKe66QSTKibenV+huLxjmTKR8+nKG0k33ZH/Vwi?= =?us-ascii?Q?LZJS/XLuhilzz5qtO95PXxQyfPjjY6AEaj428kjdwhxbzeWlkU9cRz83rHon?= =?us-ascii?Q?xSreOAePvfLiPJEBWnA8x9t8uPNSuBY4lHA73IJiUUr9AD8Iq9AjuGsK+zCQ?= =?us-ascii?Q?KTdtY83ssnLVSsY0bos2WI8brdrROr9G96zmqUf99uhDYlErVzTe9ZLG6W24?= =?us-ascii?Q?bo7Hrj2qgEQWa7m45Pb3DzKRDNK+2UP772mhp0qSLUrj5ITIQe9stWgMfAGo?= =?us-ascii?Q?EoUOCUvHMsIhN4Vbe4LZAcQSa8cgN78hCoJAGJQgTFrJ5ac2ZkbCcFK/6hPr?= =?us-ascii?Q?/WdC5UOeWcCBW82Eax74oxV8+8i9BNRFxRovnWpsaGidKQiYDZxIv65ZyKX2?= =?us-ascii?Q?ddA2nyUNtt2qeAAFse6pn3TmhW8dBMnoErViRr02h5MTXfSy+OwnQKupRZZY?= =?us-ascii?Q?v8KbUwwjNqVi5GVtEk/kxynPnKPyctGBOR4tMF/XvuG0q/hw0b7ZhWtPclEh?= =?us-ascii?Q?mYnkzHXsE7A58vSjgNgx9QwIzhWGrzLtms30eiHwS0p8vHv7oGRP9NzcVWj3?= =?us-ascii?Q?M6/wGnqceI97VnQ1WxkVytjdQGcI+CgGTrNhPf9Mnyu47lVxZkBjW/WMLlPO?= =?us-ascii?Q?v5Amndop1HBUmPukp8YDqFLnOF4BysbuwliVu9zI+Tad3SKvF3Fg9mMSUROf?= =?us-ascii?Q?mamcksCrRSs+tar/M+3rLoiCKKx7TDBl2hlGI+T6UUZJ3yKCYLyrHDtkt+0y?= =?us-ascii?Q?hw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9f67dfa1-a4dd-4e97-a569-08dd05546a1f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2024 09:03:47.3048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Ohq3QqSwPQxPgSWTdF+hPziXH2emECLW48kki2ftnU57tTcQQGiemi3y2I3Iz8GRYtpWWjeirXiCLjpdO3Fjo3K6VY/0KHcqQWtKaniYPs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 14, 2024 at 11:25:02AM -0800, Stephen Hemminger wrote: > The event_dev_config initialization had duplicate assignments > to the same element. Change to use structure initialization > so that compiler will catch this type of bug. > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") > Cc: jerin.jacob@caviumnetworks.com > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson